Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email )
Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> This is a synchronisation commit. It is about to sync two branches. […]
Then it sounds like this should really be fixed in osmo-msc and then copy-pasted here, or fix them in both sides at the same time. Otherwise code will end up differing in quite a lot of places for no good reason.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d
Gerrit-Change-Number: 39560
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 25 Feb 2025 09:38:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
falconia has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39604?usp=email )
Change subject: cosmetic: add .gitignore to doc/examples
......................................................................
cosmetic: add .gitignore to doc/examples
The two binaries built in doc/examples add noise to git status
output, making other work in this repository more difficult.
Change-Id: Id54e9a8c471dcfbf1588c2f69c37bf0d6feda47f
---
A doc/examples/.gitignore
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/doc/examples/.gitignore b/doc/examples/.gitignore
new file mode 100644
index 0000000..3da0af7
--- /dev/null
+++ b/doc/examples/.gitignore
@@ -0,0 +1,2 @@
+lapd-over-datagram-network
+lapd-over-datagram-user
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39604?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Id54e9a8c471dcfbf1588c2f69c37bf0d6feda47f
Gerrit-Change-Number: 39604
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email )
Change subject: drivers/dahdi: fix MAX redefine
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/dahdi-linux/+/39591/comment/4eaaa04c_6d6950b7?… :
PS1, Line 9: current linux master:
> why is this marked resolved without mentioning a specific kernel version? This is super important f […]
the commit message of this patch in version 2 mentions the version (v6.11-rc2) and even the specific commit that adds the MAX define (linux 1a251f52 ("minmax: make generic MIN() and MAX() macros available everywhere")).
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: If048523ac2c69b1251fdee758a2cd3e14f8e617c
Gerrit-Change-Number: 39591
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Feb 2025 09:19:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: osmith.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39594?usp=email )
Change subject: drivers/dahdi/Kbuild: fix 'No rule to make target'
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
> sorry, but for this patch it is not obvious where this comes from. I could do a git bisect... […]
it is a very important piece of information to all other usres of this code. Now we'll have to rewrite history and amend all those patches 😞
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39594?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I653318e158caf133bf4c81cd04da0adec14ed0d8
Gerrit-Change-Number: 39594
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Feb 2025 09:12:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>