February 2025 - gerrit-log - lists.osmocom.org

[S] Change in dahdi-linux[master]: drivers/dahdi: fix MAX redefine

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email ) Change subject: drivers/dahdi: fix MAX redefine ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/dahdi-linux/+/39591/comment/9f0ccb5f_8ae7b9b3?… : PS1, Line 9: current linux master: > Done why is this marked resolved without mentioning a specific kernel version? This is super important for other users of this repository that cherry-pick patches, whether official upstream DAHDI or debian or other distributions. -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: If048523ac2c69b1251fdee758a2cd3e14f8e617c Gerrit-Change-Number: 39591 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 09:08:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

4 months, 1 week

1
0
0 0

[S] Change in dahdi-linux[master]: drivers/dahdi: fix always true cond

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email ) Change subject: drivers/dahdi: fix always true cond ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > please mention specifically the version like x.y.z-rcXX that introduced this in the changelog. […] why is this marked resolved without mentioning a specific kernel version? This is super important for other users of this repository that cherry-pick patches, whether official upstream DAHDI or debian or other distributions. -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I33ee446a32de3bb8d9fe966a2989994bf4bbd806 Gerrit-Change-Number: 39593 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 09:08:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

4 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: cosmetic: add .gitignore to doc/examples

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39604?usp=email ) Change subject: cosmetic: add .gitignore to doc/examples ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Id54e9a8c471dcfbf1588c2f69c37bf0d6feda47f Gerrit-Change-Number: 39604 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 25 Feb 2025 09:06:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: cosmetic: add .gitignore to doc/examples

by fixeria

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39604?usp=email ) Change subject: cosmetic: add .gitignore to doc/examples ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Id54e9a8c471dcfbf1588c2f69c37bf0d6feda47f Gerrit-Change-Number: 39604 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 25 Feb 2025 09:00:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in ...pyosmocom[master]: .gitignore: add vim swap file pattern

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39601?usp=email ) Change subject: .gitignore: add vim swap file pattern ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I20780f311623e44040fa3ec4e865b57a71559524 Gerrit-Change-Number: 39601 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 08:57:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[S] Change in ...pyosmocom[master]: utils: add unrpad()

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39600?usp=email ) Change subject: utils: add unrpad() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/osmocom/utils.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/39600/comment/086504a6_d8e6… : PS1, Line 125: """unpad string on the right side -- reverse of rpad(). in which way is this different from the python standard library string.rstrip method? you can also pass stirng.rstrip the charcter[s] that shall be removed from the right end. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I48c23390926f8c9412624edb4481e7f4cd3f4b46 Gerrit-Change-Number: 39600 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 08:57:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in dahdi-linux[master]: drivers/dahdi/Kbuild: fix 'No rule to make target'

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39594?usp=email ) Change subject: drivers/dahdi/Kbuild: fix 'No rule to make target' ...................................................................... drivers/dahdi/Kbuild: fix 'No rule to make target' Add a workaround for this error with current linux master: make[4]: *** No rule to make target 'vpmadt032_loader/vpmadt032_x86_64.o', needed by 'dahdi_vpmadt032_loader.o'. Stop. Change-Id: I653318e158caf133bf4c81cd04da0adec14ed0d8 --- M drivers/dahdi/Kbuild 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/drivers/dahdi/Kbuild b/drivers/dahdi/Kbuild index c3ec58e..4d05f12 100644 --- a/drivers/dahdi/Kbuild +++ b/drivers/dahdi/Kbuild @@ -146,6 +146,12 @@ endif endif +# FIXME: This workaround should not be necessary, but for some reason the rule +# '$(obj)/%: $(src)/%_shipped' from linux.git scripts/Makefile.lib doesn't +# cover this anymore. +vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o: $(src)/vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o_shipped + $(call cmd,copy) + ############################################################################### # HPEC Support ############################################################################### -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I653318e158caf133bf4c81cd04da0adec14ed0d8 Gerrit-Change-Number: 39594 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in dahdi-linux[master]: drivers/dahdi/Kbuild: fix 'No rule to make target'

by osmith

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39594?usp=email ) Change subject: drivers/dahdi/Kbuild: fix 'No rule to make target' ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: I'll merge this so the jenkins job stops failing every day, and the gerrit verifications work again for dahdi-linux. -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I653318e158caf133bf4c81cd04da0adec14ed0d8 Gerrit-Change-Number: 39594 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 08:56:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: cosmetic: add .gitignore to doc/examples

by falconia

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39604?usp=email ) Change subject: cosmetic: add .gitignore to doc/examples ...................................................................... cosmetic: add .gitignore to doc/examples The two binaries built in doc/examples add noise to git status output, making other work in this repository more difficult. Change-Id: Id54e9a8c471dcfbf1588c2f69c37bf0d6feda47f --- A doc/examples/.gitignore 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/04/39604/1 diff --git a/doc/examples/.gitignore b/doc/examples/.gitignore new file mode 100644 index 0000000..3da0af7 --- /dev/null +++ b/doc/examples/.gitignore @@ -0,0 +1,2 @@ +lapd-over-datagram-network +lapd-over-datagram-user -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Id54e9a8c471dcfbf1588c2f69c37bf0d6feda47f Gerrit-Change-Number: 39604 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

4 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: Log RAB_STATE name instead of value

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39602?usp=email ) Change subject: Log RAB_STATE name instead of value ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39602?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I24593a1db1334052f3a79f59a521228393fc1ed7 Gerrit-Change-Number: 39602 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 08:00:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025