February 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-sgsn[master]: Assign MME GroupId/Code to remote MMEs

by daniel

Attention is currently required from: laforge, lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39294?usp=email ) Change subject: Assign MME GroupId/Code to remote MMEs ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39294?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I881aeba904fb6ca815842d36e466a2459ad81913 Gerrit-Change-Number: 39294 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 24 Feb 2025 15:35:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[M] Change in osmo-msc[master]: vlr: add PS support

by daniel

Attention is currently required from: laforge, lynxis lazus, neels. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email ) Change subject: vlr: add PS support ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 24 Feb 2025 13:16:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: eim: move es9p_Types_JSON to library

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39603?usp=email ) Change subject: eim: move es9p_Types_JSON to library ...................................................................... eim: move es9p_Types_JSON to library The TTCN3 module es9p_Types_JSON is currently only used by the eIM testsuite, but it may also be helpful in other testsuites in the future. Related: SYS#7339 Change-Id: If4be10a298e30188aebe7c9d3efbdb56d2816c7f --- M eim/gen_links.sh R library/euicc/es9p_Types_JSON.ttcn 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/39603/1 diff --git a/eim/gen_links.sh b/eim/gen_links.sh index 4bb1ea8..1996da9 100755 --- a/eim/gen_links.sh +++ b/eim/gen_links.sh @@ -35,7 +35,8 @@ FILES+="PKIX1Explicit88_Templates.ttcn PKIX1Explicit88_Types.ttcn PKIX1Implicit88_Templates.ttcn " FILES+="PKIX1Implicit88_Types.ttcn RSPDefinitions_Templates.ttcn RSPDefinitions_Types.ttcn " FILES+="SGP32Definitions_Templates.ttcn SGP32Definitions_Types.ttcn " -FILES+="PKIX1Explicit88_EncDec.cc PKIX1Implicit88_EncDec.cc RSPDefinitions_EncDec.cc SGP32Definitions_EncDec.cc" +FILES+="PKIX1Explicit88_EncDec.cc PKIX1Implicit88_EncDec.cc RSPDefinitions_EncDec.cc SGP32Definitions_EncDec.cc " +FILES+="es9p_Types_JSON.ttcn" gen_links $DIR $FILES DIR=../library diff --git a/eim/es9p_Types_JSON.ttcn b/library/euicc/es9p_Types_JSON.ttcn similarity index 100% rename from eim/es9p_Types_JSON.ttcn rename to library/euicc/es9p_Types_JSON.ttcn -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4be10a298e30188aebe7c9d3efbdb56d2816c7f Gerrit-Change-Number: 39603 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2 ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > We already spoke about this during last OsmoDevCon, and it has easy solutions: […] This is a synchronisation commit. It is about to sync two branches. I can't tell why those style issues has been merged into osmo-msc. For this commit it shouldn't matter if there are style issues, because the osmo-msc is the upstream for libvlr. So those fixes should go into osmo-msc first. You got a message, because things has been changed, a line in Makefile.am. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 23 Feb 2025 14:08:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

6 months, 2 weeks

1
0
0 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2 ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > Maybe the new gerrit version with "less mail notification" also helps here. We already spoke about this during last OsmoDevCon, and it has easy solutions: - You fix the 32 style patches before re-usmbitting N more times. - If you don't plan for these patches to be reviewed, you can: -- Mark all over them as WIP or PRIVATE, so nobody receives annoying updates -- Even better, you submit them to non-gerrit-managed branches. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 22 Feb 2025 20:27:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

6 months, 2 weeks

1
0
0 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2 ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > I don't see a good solution for it. […] Maybe the new gerrit version with "less mail notification" also helps here. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Feb 2025 14:34:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

6 months, 2 weeks

1
0
0 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2 ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > @lynxis@fe80. […] I don't see a good solution for it. So far I know, there isn't a good way to modify a single change-set without changing all commits in the same chain. If I don't push my review-branch all at once, I might overwrite reworked commits later in the chain. I also fixed problems in here, the missing include in Makefile.am, which seems to be not a problem, when you have "old" files around. It builds as long you don't treat the strncpy as errors. About this commit: It only synchronizes against a osmo-msc commit. I don't want to modify any code of the libvlr code, otherwise you can't track improvements between both branches. I consider osmo-msc as "upstream" as long libvlr isn't self-container. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Feb 2025 14:32:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: Log RAB_STATE name instead of value

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39602?usp=email ) Change subject: Log RAB_STATE name instead of value ...................................................................... Log RAB_STATE name instead of value Related: SYS#7338 Change-Id: I24593a1db1334052f3a79f59a521228393fc1ed7 --- M include/osmocom/hnbgw/context_map.h M src/osmo-hnbgw/kpi_ranap.c 2 files changed, 24 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/02/39602/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39602?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I24593a1db1334052f3a79f59a521228393fc1ed7 Gerrit-Change-Number: 39602 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: Log RAB_STATE name isntead of value

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39602?usp=email ) Change subject: Log RAB_STATE name isntead of value ...................................................................... Log RAB_STATE name isntead of value Change-Id: I24593a1db1334052f3a79f59a521228393fc1ed7 --- M include/osmocom/hnbgw/context_map.h M src/osmo-hnbgw/kpi_ranap.c 2 files changed, 24 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/02/39602/1 diff --git a/include/osmocom/hnbgw/context_map.h b/include/osmocom/hnbgw/context_map.h index 8fe478c..f9bd251 100644 --- a/include/osmocom/hnbgw/context_map.h +++ b/include/osmocom/hnbgw/context_map.h @@ -2,6 +2,7 @@ #include <stdint.h> #include <osmocom/core/linuxlist.h> +#include <osmocom/core/utils.h> #include <osmocom/hnbgw/hnbgw.h> #include <osmocom/gsm/gsm48.h> @@ -117,6 +118,10 @@ RAB_STATE_ACTIVE, RAB_STATE_REL_REQ, }; +extern const struct value_string hnbgw_rab_state_names[]; +static inline const char *hnbgw_rab_state_name(enum rab_state val) +{ return get_value_string(hnbgw_rab_state_names, val); } + struct hnbgw_context_map { /* entry in the per-CN list of mappings */ diff --git a/src/osmo-hnbgw/kpi_ranap.c b/src/osmo-hnbgw/kpi_ranap.c index d731c5f..3f2c1b3 100644 --- a/src/osmo-hnbgw/kpi_ranap.c +++ b/src/osmo-hnbgw/kpi_ranap.c @@ -28,6 +28,13 @@ #include <osmocom/hnbgw/context_map.h> #include <osmocom/hnbgw/kpi.h> +const struct value_string hnbgw_rab_state_names[] = { + { RAB_STATE_INACTIVE, "INACTIVE" }, + { RAB_STATE_ACT_REQ, "ACT_REQ" }, + { RAB_STATE_ACTIVE, "ACTIVE" }, + { RAB_STATE_REL_REQ, "REL_REQ" }, + {} +}; /*********************************************************************** * DOWNLINK messages @@ -108,7 +115,8 @@ break; default: LOG_MAP(map, DRANAP, LOGL_NOTICE, - "Unexpected RAB Activation/Modification Req for RAB in state %u\n", map->rab_state[rab_id]); + "Unexpected RAB Activation/Modification Req for RAB in state %s\n", + hnbgw_rab_state_name(map->rab_state[rab_id])); break; } @@ -154,7 +162,8 @@ break; default: LOG_MAP(map, DRANAP, LOGL_NOTICE, - "Unexpected RAB Release Req in state %u\n", map->rab_state[rab_id]); + "Unexpected RAB Release Req in state %s\n", + hnbgw_rab_state_name(map->rab_state[rab_id])); break; } /* mark that RAB as release requested */ @@ -249,7 +258,8 @@ break; default: LOG_MAP(map, DRANAP, LOGL_NOTICE, - "Unexpected RAB Activation/Modification Conf for RAB in state %u\n", map->rab_state[rab_id]); + "Unexpected RAB Activation/Modification Conf for RAB in state %s\n", + hnbgw_rab_state_name(map->rab_state[rab_id])); break; } @@ -288,7 +298,8 @@ break; default: LOG_MAP(map, DRANAP, LOGL_NOTICE, - "Unexpected RAB Release Conf for RAB in state %u\n", map->rab_state[rab_id]); + "Unexpected RAB Release Conf for RAB in state %s\n", + hnbgw_rab_state_name(map->rab_state[rab_id])); break; } /* mark that RAB as released */ @@ -336,7 +347,8 @@ break; default: LOG_MAP(map, DRANAP, LOGL_NOTICE, - "Unexpected RAB Activation/Modification Failed for RAB in state %u\n", map->rab_state[rab_id]); + "Unexpected RAB Activation/Modification Failed for RAB in state %s\n", + hnbgw_rab_state_name(map->rab_state[rab_id])); break; } @@ -382,7 +394,8 @@ break; default: LOG_MAP(map, DRANAP, LOGL_NOTICE, - "Unexpected RAB Release Failed for RAB in state %u\n", map->rab_state[rab_id]); + "Unexpected RAB Release Failed for RAB in state %s\n", + hnbgw_rab_state_name(map->rab_state[rab_id])); break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39602?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I24593a1db1334052f3a79f59a521228393fc1ed7 Gerrit-Change-Number: 39602 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-pfcp[master]: pfcp_endpoint: Increase sent_{requests,responses}_by_seq_nr hashtable...

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/39580?usp=email ) Change subject: pfcp_endpoint: Increase sent_{requests,responses}_by_seq_nr hashtable size ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/39580?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ie0bb28240b3a83a1776702f26d79a09e8f0e30f6 Gerrit-Change-Number: 39580 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Feb 2025 15:31:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025