February 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: eim: move es9p_Types_JSON to library

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39603?usp=email ) Change subject: eim: move es9p_Types_JSON to library ...................................................................... eim: move es9p_Types_JSON to library The TTCN3 module es9p_Types_JSON is currently only used by the eIM testsuite, but it may also be helpful in other testsuites in the future. Related: SYS#7339 Change-Id: If4be10a298e30188aebe7c9d3efbdb56d2816c7f --- M eim/gen_links.sh R library/euicc/es9p_Types_JSON.ttcn 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/eim/gen_links.sh b/eim/gen_links.sh index 4bb1ea8..1996da9 100755 --- a/eim/gen_links.sh +++ b/eim/gen_links.sh @@ -35,7 +35,8 @@ FILES+="PKIX1Explicit88_Templates.ttcn PKIX1Explicit88_Types.ttcn PKIX1Implicit88_Templates.ttcn " FILES+="PKIX1Implicit88_Types.ttcn RSPDefinitions_Templates.ttcn RSPDefinitions_Types.ttcn " FILES+="SGP32Definitions_Templates.ttcn SGP32Definitions_Types.ttcn " -FILES+="PKIX1Explicit88_EncDec.cc PKIX1Implicit88_EncDec.cc RSPDefinitions_EncDec.cc SGP32Definitions_EncDec.cc" +FILES+="PKIX1Explicit88_EncDec.cc PKIX1Implicit88_EncDec.cc RSPDefinitions_EncDec.cc SGP32Definitions_EncDec.cc " +FILES+="es9p_Types_JSON.ttcn" gen_links $DIR $FILES DIR=../library diff --git a/eim/es9p_Types_JSON.ttcn b/library/euicc/es9p_Types_JSON.ttcn similarity index 100% rename from eim/es9p_Types_JSON.ttcn rename to library/euicc/es9p_Types_JSON.ttcn -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4be10a298e30188aebe7c9d3efbdb56d2816c7f Gerrit-Change-Number: 39603 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

6 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: eim: move es9p_Types_JSON to library

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39603?usp=email ) Change subject: eim: move es9p_Types_JSON to library ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4be10a298e30188aebe7c9d3efbdb56d2816c7f Gerrit-Change-Number: 39603 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 07:59:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...

by laforge

Attention is currently required from: csaba.sipos, domi, fixeria, pespin. laforge has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: > @laforge@osmocom.org […] There were tons of unresolved review comments here; I usually only review code that either has no review yet, or where all the existing review is marked as done/resolved. I've now cleaned up those comments that clearly were done but had not been marked as such. We still have 6 unresolved (one of them this, so 5 remaining) that need to be cleared up one way or another. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 22 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: domi <domi(a)tomcsanyi.net> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: domi <domi(a)tomcsanyi.net> Gerrit-Comment-Date: Tue, 25 Feb 2025 07:59:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: csaba.sipos <metro4(a)freemail.hu>

6 months, 1 week

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...

by laforge

Attention is currently required from: csaba.sipos, domi, fixeria, pespin. laforge has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 22: (8 comments) Patchset: PS22: please make sure to mark review comments as done if they are addressed. Otherwise you will discourage further review. I usually only review code where other review issues are resolved already. File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/a364b58f_b871dd90?usp… : PS14, Line 1716: #define FIND_ELEM(data, data_len, ei, var) (find_element(data, data_len, ei, var, sizeof(var)) == sizeof(var)) > Let me put this back to WIP, as this must be grossly annoying. […] Done File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/90554bee_ab3c887d?usp… : PS21, Line 1828: get_object_identity_string(object_id_state[4]), > If you want I send you a printscreen that it looks perfect on my side. Done https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/b2f4015b_64f2d63c?usp… : PS21, Line 1876: get_object_identity_string(object_identity[1]), > Same as on the first one. Done https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/cf279dd0_40af37b8?usp… : PS21, Line 1884: get_object_identity_string(object_identity[1]), > Same as on the first one. Done https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/97d372e4_e9896905?usp… : PS21, Line 1898: get_object_identity_string(object_identity[1]), > wrong indentation Done https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/0a95b997_63eb4962?usp… : PS21, Line 1907: get_object_identity_string(object_identity[1]), > wrong indentation Done https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/cf6a8bef_118f89c9?usp… : PS21, Line 1916: object_identity[2], > wrong indentation Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 22 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: domi <domi(a)tomcsanyi.net> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: domi <domi(a)tomcsanyi.net> Gerrit-Comment-Date: Tue, 25 Feb 2025 07:57:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: csaba.sipos <metro4(a)freemail.hu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...

by laforge

Attention is currently required from: csaba.sipos, domi, fixeria. laforge has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 22: (1 comment) Patchset: PS21: > This hopefully final version is runtime tested against InSite and MetroSite. Both works as expected. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 22 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: domi <domi(a)tomcsanyi.net> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: domi <domi(a)tomcsanyi.net> Gerrit-Comment-Date: Tue, 25 Feb 2025 07:49:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: csaba.sipos <metro4(a)freemail.hu>

6 months, 1 week

1
0
0 0

[L] Change in osmo-msc[master]: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to...

by laforge

Attention is currently required from: lynxis lazus, neels. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email ) Change subject: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to the parent ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I27fd1048f85363797b43808d2061ce28be6da81b Gerrit-Change-Number: 38491 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 25 Feb 2025 07:46:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

[XS] Change in osmo-msc[master]: libvlr: replace strncpy with OSMO_STRLCPY_ARRAY

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/39565?usp=email ) Change subject: libvlr: replace strncpy with OSMO_STRLCPY_ARRAY ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39565?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I96a27ef42cb06dd2365f5c9902933323c7caf9a8 Gerrit-Change-Number: 39565 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 25 Feb 2025 07:45:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

[XS] Change in osmo-msc[master]: libvlr: replace strncpy with OSMO_STRLCPY_ARRAY

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/39565?usp=email ) Change subject: libvlr: replace strncpy with OSMO_STRLCPY_ARRAY ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39565?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I96a27ef42cb06dd2365f5c9902933323c7caf9a8 Gerrit-Change-Number: 39565 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 24 Feb 2025 15:46:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[L] Change in osmo-msc[master]: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to...

by daniel

Attention is currently required from: lynxis lazus, neels. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email ) Change subject: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to the parent ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I27fd1048f85363797b43808d2061ce28be6da81b Gerrit-Change-Number: 38491 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 24 Feb 2025 15:44:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...

by csaba.sipos

Attention is currently required from: domi, fixeria, laforge. csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: @laforge@osmocom.org When you have a moment, please vote so we can move on to the next one. Thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 22 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: domi <domi(a)tomcsanyi.net> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: domi <domi(a)tomcsanyi.net> Gerrit-Comment-Date: Mon, 24 Feb 2025 15:39:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025