February 2025 - gerrit-log - lists.osmocom.org

[XS] Change in docker-playground[master]: ttcn3-bts-test: do not use respawn.sh

by laforge

Attention is currently required from: laforge, osmith. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/39597?usp=email ) Change subject: ttcn3-bts-test: do not use respawn.sh ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I770a0530f90c5e03d2073bfc1c4cfd0e840379c9 Gerrit-Change-Number: 39597 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Feb 2025 12:12:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XL] Change in osmo-ggsn[master]: gtp: add support for SGSN Context Req/Resp/Ack

by laforge

Attention is currently required from: daniel, lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email ) Change subject: gtp: add support for SGSN Context Req/Resp/Ack ...................................................................... Patch Set 11: (6 comments) File gtp/gtp.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/e2e69e10_106b6071?us… : PS11, Line 899: struct Im surprised that the destination peer is not 'const'. Likeweise I'd normally expect any othe rinput data like local_ref or ie to be 'const' as the called function shouldn't modify any of these. Probably you're doing it this way as a lot / all of the existing code does it this way? https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/9712d78b_434ec111?us… : PS11, Line 1134: int gtp_decode_pdp_ctx(const uint8_t *buf, unsigned int size, struct pdp_t *pdp, uint16_t *sapi) I think the function could deserve some documentation as a comment [doxygen style or not] https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/b510fb7e_0eb96e0f?us… : PS11, Line 1273: int gtp_encode_pdp_ctx(uint8_t *buf, unsigned int size, const struct pdp_t *pdp, uint16_t sapi) I think the function could deserve some documentation as a comment [doxygen style or not] https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/3a753755_77d7eb15?us… : PS11, Line 1403: LOGP(DLGTP, LOGL_NOTICE, shouldn't we print some kind of context? Like which GSN peer (address) has sent us the message with the wrong version? https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/2acd816c_11141355?us… : PS11, Line 1410: "SGSN Context Response expected Sequence flag set. Flags %d\n", packet->flags); shouldn't we print some kind of context? Like which GSN peer (address) has sent us the message with the wrong flags? https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/4777d45d_0b8ecfc0?us… : PS11, Line 1458: "SGSN Context Request expected only on GTPCv1: %u\n", version); same here -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idb8ed0bb87200a68bb8caedd734fc070df9179c0 Gerrit-Change-Number: 38938 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 25 Feb 2025 12:11:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: ipaccess: Reset pointer before calling stream_cli func triggering cal...

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email ) Change subject: ipaccess: Reset pointer before calling stream_cli func triggering callback ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-abis/+/39607/comment/f4b28e87_ad2541eb… : PS2, Line 21: SYS > s/SYS/OS/ Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 Gerrit-Change-Number: 39607 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 11:18:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: ipaccess: Reset pointer before calling stream_cli func triggering cal...

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email ) Change subject: ipaccess: Reset pointer before calling stream_cli func triggering callback ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-abis/+/39607/comment/a7a1854b_f53f4254… : PS2, Line 21: SYS s/SYS/OS/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 Gerrit-Change-Number: 39607 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 11:18:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: ipaccess: Reset pointer before calling stream_cli func triggering cal...

by pespin

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email to look at the new patch set (#3). Change subject: ipaccess: Reset pointer before calling stream_cli func triggering callback ...................................................................... ipaccess: Reset pointer before calling stream_cli func triggering callback The osmo_stream_cli_destroy() may trigger the disconnect_cb, which we forward to the user through sign_link_down() callback. Hence, the user may call e1inp_ipa_bts_rsl_close_n() again (re-entrant, recursively) before we had time to nullify the pointer, calling osmo_stream_cli_destroy() again. Instead, make sure the pointer is reset bfore potentially calling the osmo_stream_cli_destroy() to make sure to catch this scenario. This issue was being triggered by BTS_Tests.TC_chopped_ipa_payload, which was hitting an assert due to incorrectly calling osmo_stream_cli_destroy() twice on a given stream_cli. Related: OS#6729 Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 --- M src/input/ipaccess.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/07/39607/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 Gerrit-Change-Number: 39607 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: ipaccess: Reset pointer before calling stream_cli func triggering cal...

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email to look at the new patch set (#2). Change subject: ipaccess: Reset pointer before calling stream_cli func triggering callback ...................................................................... ipaccess: Reset pointer before calling stream_cli func triggering callback The osmo_stream_cli_destroy() may trigger the disconnect_cb, which we forward to the user through sign_link_down() callback. Hence, the user may call e1inp_ipa_bts_rsl_close_n() again (re-entrant, recursively) before we had time to nullify the pointer, calling osmo_stream_cli_destroy() again. Instead, make sure the pointer is reset bfore potentially calling the osmo_stream_cli_destroy() to make sure to catch this scenario. This issue was being triggered by BTS_Tests.TC_chopped_ipa_payload, which was hitting an assert due to incorrectly calling osmo_stream_cli_destroy() twice on a given stream_cli. Related: SYS#6729 Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 --- M src/input/ipaccess.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/07/39607/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 Gerrit-Change-Number: 39607 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

4 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: ipaccess: Reset pointer before calling stream_cli func triggering cal...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email ) Change subject: ipaccess: Reset pointer before calling stream_cli func triggering callback ...................................................................... ipaccess: Reset pointer before calling stream_cli func triggering callback The osmo_stream_cli_destroy() may trigger the disconnect_cb, which we forward to the user through sign_link_down() callback. Hence, the user may call e1inp_ipa_bts_rsl_close_n() again (re-entrant, recursively) before we had time to nullify the pointer, calling osmo_stream_cli_destroy() again. Instead, make sure the pointer is reset bfore potentially calling the osmo_stream_cli_destroy() so make sure to catch this scenario. This issue was being triggered by BTS_Tests.TC_chopped_ipa_payload, which was hitting an assert due to incorrectly calling osmo_stream_cli_destroy() twice on a given stream_cli. Related: SYS#6729 Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 --- M src/input/ipaccess.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/07/39607/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 6a7d753..44ec719 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -1168,8 +1168,8 @@ cli = il->ipa_cli[1 + trx_nr]; if (cli != NULL) { - osmo_stream_cli_destroy(cli); il->ipa_cli[1 + trx_nr] = NULL; + osmo_stream_cli_destroy(cli); } return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 Gerrit-Change-Number: 39607 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmocom-bb[master]: trx_toolkit: correct Tx burst advance value

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39606?usp=email ) Change subject: trx_toolkit: correct Tx burst advance value ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39606?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I559e86a15a3a8b4ec725f9d381e7d28628ea9155 Gerrit-Change-Number: 39606 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 10:23:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmocom-bb[master]: trx_toolkit: fix typos in Transceiver API doc

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39605?usp=email ) Change subject: trx_toolkit: fix typos in Transceiver API doc ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39605?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I59c6c75bb2a76fa082d0ad110930a2982ee6728f Gerrit-Change-Number: 39605 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 10:23:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmocom-bb[master]: trx_toolkit: fix typos in Transceiver API doc

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39605?usp=email ) Change subject: trx_toolkit: fix typos in Transceiver API doc ...................................................................... trx_toolkit: fix typos in Transceiver API doc Change-Id: I59c6c75bb2a76fa082d0ad110930a2982ee6728f --- M src/target/trx_toolkit/transceiver.py 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/05/39605/1 diff --git a/src/target/trx_toolkit/transceiver.py b/src/target/trx_toolkit/transceiver.py index e6af013..672c261 100644 --- a/src/target/trx_toolkit/transceiver.py +++ b/src/target/trx_toolkit/transceiver.py @@ -126,12 +126,12 @@ by default, at the moment of writing this patch). In order to reflect that delay in a virtual environment, this - implementation, just like a normal transceiver (e.g. osmo-trx), - queues all to be transmitted (L12TRX) bursts, so hey remain in - the transmit queue until the appropriate time of transmission. + implementation, just like osmo-trx, queues all to be transmitted + (L12TRX) bursts, so that they remain in the transmit queue until + the appropriate time of transmission. The API user is supposed to call recv_data_msg() in order to obtain - a L12TRX message on the TRXD (data) inteface, so it gets queued by + a L12TRX message on the TRXD (data) interface, so it gets queued by this function. Then, to ensure the timeous transmission, the user of this implementation needs to call clck_tick() on each TDMA frame. Both functions are thread-safe (queue mutex). -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39605?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I59c6c75bb2a76fa082d0ad110930a2982ee6728f Gerrit-Change-Number: 39605 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025