February 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: Indicate error and release BSS connection when SMS transaction fails

by fixeria

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38514?usp=email ) Change subject: Indicate error and release BSS connection when SMS transaction fails ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38514?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I82da9c283205c69b19ceb4ba40ac5aa7f37d159b Gerrit-Change-Number: 38514 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 12:28:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-msc[master]: Release BSS connection when CC transaction fails

by fixeria

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38513?usp=email ) Change subject: Release BSS connection when CC transaction fails ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38513?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icb893d5c1ce4c77a29259ce66189576dcaa5a44a Gerrit-Change-Number: 38513 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 12:28:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in libosmocore[master]: gprs: define OSMO_RESERVED_RAC 0xff

by laforge

Attention is currently required from: lynxis lazus, pespin. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email ) Change subject: gprs: define OSMO_RESERVED_RAC 0xff ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gsm/protocol/gsm_04_08_gprs.h: https://gerrit.osmocom.org/c/libosmocore/+/39557/comment/ec6075cd_942db01b?… : PS1, Line 14: #define OSMO_RESERVED_RAC 0xff > Yeah ok, but I don't see how any of that makes it osmocom specific... so basically pespins point would be to mark it GSM*_RESERVED_RAC instead of OSMO_RESERVED_RAC. OTOH, I have checked both TS 23.003, TS 44.018 and TS 24.008 and couldn't find any mention of a reserved value. So if we cannot find a spec reference, I guess OSMO_ is the right way to go. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I17a2adedc2c2ab158f40d58280f5df5c6967b8ec Gerrit-Change-Number: 39557 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 25 Feb 2025 12:18:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

4 months, 1 week

1
0
0 0

[XS] Change in ...pyosmocom[master]: .gitignore: add vim swap file pattern

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39601?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: .gitignore: add vim swap file pattern ...................................................................... .gitignore: add vim swap file pattern Change-Id: I20780f311623e44040fa3ec4e865b57a71559524 --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/.gitignore b/.gitignore index 0c6adc6..5f5bdb1 100644 --- a/.gitignore +++ b/.gitignore @@ -7,3 +7,4 @@ /.cache /.local /pysim +.*.sw? -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I20780f311623e44040fa3ec4e865b57a71559524 Gerrit-Change-Number: 39601 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

4 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: bts: expect TC_data_{rtp,facch}_tchf144 to pass

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39599?usp=email ) Change subject: bts: expect TC_data_{rtp,facch}_tchf144 to pass ...................................................................... bts: expect TC_data_{rtp,facch}_tchf144 to pass Change-Id: I5dfcecc9cb6829ad208a54d7a3092a4cde327fb3 Related: OS#6167 --- M bts/expected-results.xml 1 file changed, 2 insertions(+), 12 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/bts/expected-results.xml b/bts/expected-results.xml index c10e668..ca5ad2f 100644 --- a/bts/expected-results.xml +++ b/bts/expected-results.xml @@ -183,23 +183,13 @@ <testcase classname='BTS_Tests' name='TC_speech_rtp_tchh' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_speech_osmux_tchf' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_speech_osmux_tchh' time='MASKED'/> - <testcase classname='BTS_Tests' name='TC_data_rtp_tchf144' time='MASKED'> - <failure type='fail-verdict'>Rx unexpected RSL port message: MASKED - BTS_Tests.ttcn:MASKED BTS_Tests control part - BTS_Tests.ttcn:MASKED TC_data_rtp_tchf144 testcase - </failure> - </testcase> + <testcase classname='BTS_Tests' name='TC_data_rtp_tchf144' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_rtp_tchf96' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_rtp_tchf48' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_rtp_tchh48' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_rtp_tchf24' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_rtp_tchh24' time='MASKED'/> - <testcase classname='BTS_Tests' name='TC_data_facch_tchf144' time='MASKED'> - <failure type='fail-verdict'>Rx unexpected RSL port message: MASKED - BTS_Tests.ttcn:MASKED BTS_Tests control part - BTS_Tests.ttcn:MASKED TC_data_rtp_tchf144 testcase - </failure> - </testcase> + <testcase classname='BTS_Tests' name='TC_data_facch_tchf144' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_facch_tchf96' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_facch_tchf48' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_facch_tchh48' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5dfcecc9cb6829ad208a54d7a3092a4cde327fb3 Gerrit-Change-Number: 39599 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: mgw: osmo-mgw.cfg: remove deprecated no-op params

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39598?usp=email ) Change subject: mgw: osmo-mgw.cfg: remove deprecated no-op params ...................................................................... mgw: osmo-mgw.cfg: remove deprecated no-op params This patch fixes the following warnings: % Deprecated 'sdp audio-payload number <0-255>' config no longer has any effect % Deprecated 'sdp audio-payload name NAME' config no longer has any effect % Deprecated 'loop (0|1)' config no longer has any effect % Deprecated 'allow-transcoding' config no longer has any effect % Deprecated 'loop (0|1)' config no longer has any effect % Deprecated 'allow-transcoding' config no longer has any effect Change-Id: Ie4f2b46eda2e848781b77e590ad20e80fed86257 --- M mgw/osmo-mgw.cfg 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/mgw/osmo-mgw.cfg b/mgw/osmo-mgw.cfg index 2af7dff..8f390df 100644 --- a/mgw/osmo-mgw.cfg +++ b/mgw/osmo-mgw.cfg @@ -49,14 +49,10 @@ no rtp keep-alive no rtcp-omit no rtp-patch - sdp audio-payload number 98 - sdp audio-payload name GSM sdp audio-payload send-ptime sdp audio-payload send-name conn-timeout 0 - loop 0 number endpoints 300 - allow-transcoding osmux off osmux bind-ip 127.0.0.1 osmux bind-ip-v6 ::1 @@ -64,8 +60,6 @@ sdp audio-payload send-ptime sdp audio-payload send-name no rtp keep-alive - loop 0 no rtcp-omit no rtp-patch - allow-transcoding line 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4f2b46eda2e848781b77e590ad20e80fed86257 Gerrit-Change-Number: 39598 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: bts: expect TC_data_{rtp,facch}_tchf144 to pass

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39599?usp=email ) Change subject: bts: expect TC_data_{rtp,facch}_tchf144 to pass ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5dfcecc9cb6829ad208a54d7a3092a4cde327fb3 Gerrit-Change-Number: 39599 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 12:13:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: mgw: osmo-mgw.cfg: remove deprecated no-op params

by laforge

Attention is currently required from: dexter, fixeria, neels. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39598?usp=email ) Change subject: mgw: osmo-mgw.cfg: remove deprecated no-op params ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4f2b46eda2e848781b77e590ad20e80fed86257 Gerrit-Change-Number: 39598 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 12:12:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in docker-playground[master]: ttcn3-bts-test: do not use respawn.sh

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/39597?usp=email ) Change subject: ttcn3-bts-test: do not use respawn.sh ...................................................................... ttcn3-bts-test: do not use respawn.sh Re-spawning osmo-bts is no longer necessary. For quite some time now, it has been able to attempt OML link re-establishment in a loop instead of exit()ing. Additionally, using respawn.sh makes crashes harder to detect. Whether we should restart the IUT process and continue executing the remaining test cases after a crash is debatable. However, none of the other testsuites (except ttcn3-pcu-test, which actually requires restarting osmo-pcu after each TC) use respawn.sh for that purpose. Change-Id: I770a0530f90c5e03d2073bfc1c4cfd0e840379c9 Related: OS#6728, OS#6729 --- M ttcn3-bts-test/jenkins.sh 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 40c00ac..d4b59e7 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -40,7 +40,6 @@ start_bts() { local variant variant="$1" - sleep_time_respawn="$2" echo Starting container with BTS if [ -z "$variant" ]; then echo ERROR: You have to specify a BTS variant @@ -51,11 +50,10 @@ --ulimit core=-1 \ -v $VOL_BASE_DIR/bts:/data \ -v $VOL_BASE_DIR/unix:/data/unix \ - -e "SLEEP_BEFORE_RESPAWN=$sleep_time_respawn" \ --name ${BUILD_TAG}-bts -d \ $DOCKER_ARGS \ $REPO_USER/osmo-bts-$IMAGE_SUFFIX \ - /bin/sh -c "/usr/local/bin/respawn.sh osmo-bts-$variant -c /data/osmo-bts.gen.cfg >>/data/osmo-bts.log 2>&1" + /bin/sh -c "osmo-bts-$variant -c /data/osmo-bts.gen.cfg >>/data/osmo-bts.log 2>&1" } start_fake_trx() { -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I770a0530f90c5e03d2073bfc1c4cfd0e840379c9 Gerrit-Change-Number: 39597 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in docker-playground[master]: ttcn3-bts-test: do not use respawn.sh

by laforge

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/39597?usp=email ) Change subject: ttcn3-bts-test: do not use respawn.sh ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I770a0530f90c5e03d2073bfc1c4cfd0e840379c9 Gerrit-Change-Number: 39597 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 12:12:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025