Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/39611?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: vty: Add cmd to look up route
......................................................................
vty: Add cmd to look up route
Implement a command which allows looking up a given route, similar to
linux "ip route get", which is helpful to debug routing setup.
Related: SYS#7112
Change-Id: I4dbe04862c018a1beea253de99404adb88bb7f4b
---
M src/osmo_ss7_vty.c
M tests/vty/osmo_stp_route_prio.vty
M tests/vty/osmo_stp_test.vty
3 files changed, 53 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/11/39611/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39611?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I4dbe04862c018a1beea253de99404adb88bb7f4b
Gerrit-Change-Number: 39611
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39610?usp=email )
Change subject: vty: Rename cmd to show routing table
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> please clearly state whether or not the new syntax brings our commands more in sync with Cisco ITP o […]
That's indeed a good point, I forgot to check and indeed we used "route" because it's what cisco ITP is doing. I'll instead rename the new "route lookup" command to "show cs7 0 route-lookup" and leave the existing one untouched.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39610?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ie2a01523f95275d88e04f6c76505116372524d3b
Gerrit-Change-Number: 39610
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 25 Feb 2025 14:37:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/39612?usp=email )
Change subject: pySim-shell: obey quit command in startup commands+scripts
......................................................................
pySim-shell: obey quit command in startup commands+scripts
Startup scripts are executed using the cmd2 provided onecmd_plus_hooks
method. This method can run arbitrary commands, which also includes
the command "run_scrit" that we use to execute startup scripts.
When a script executes a quit command, or when someone issues a quit
command using the --execute-command or the command argument, then
this commands is executed. However a quit command won't actually quit
the process. All it does is to change the return code of
app.onecmd_plus_hooks (see [1]). So we must evaluate the return code
and take care of the quitting ourselves.
[1] https://cmd2.readthedocs.io/en/0.9.15/api/cmd.html#cmd2.cmd2.Cmd.onecmd_plu…
Related: OS#6731
Change-Id: Ic6e9c54cdb6955d65011af3eb5a025eee5da4143
---
M pySim-shell.py
1 file changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/12/39612/1
diff --git a/pySim-shell.py b/pySim-shell.py
index 9733b22..c59e481 100755
--- a/pySim-shell.py
+++ b/pySim-shell.py
@@ -1159,14 +1159,18 @@
# Run optional commands
for c in opts.execute_command:
if not startup_errors:
- app.onecmd_plus_hooks(c)
+ stop = app.onecmd_plus_hooks(c)
+ if stop == True:
+ sys.exit(0)
else:
print("Errors during startup, refusing to execute command (%s)" % c)
# Run optional command
if opts.command:
if not startup_errors:
- app.onecmd_plus_hooks('{} {}'.format(opts.command, ' '.join(opts.command_args)))
+ stop = app.onecmd_plus_hooks('{} {}'.format(opts.command, ' '.join(opts.command_args)))
+ if stop == True:
+ sys.exit(0)
else:
print("Errors during startup, refusing to execute command (%s)" % opts.command)
@@ -1177,7 +1181,9 @@
print("Error: script file (%s) not readable!" % opts.script)
startup_errors = True
else:
- app.onecmd_plus_hooks('{} {}'.format('run_script', opts.script), add_to_history = False)
+ stop = app.onecmd_plus_hooks('{} {}'.format('run_script', opts.script), add_to_history = False)
+ if stop == True:
+ sys.exit(0)
else:
print("Errors during startup, refusing to execute script (%s)" % opts.script)
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/39612?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic6e9c54cdb6955d65011af3eb5a025eee5da4143
Gerrit-Change-Number: 39612
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: domi, fixeria, laforge, pespin.
csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )
Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes
......................................................................
Patch Set 22:
(6 comments)
Patchset:
PS14:
> @domi@tomcsanyi.net […]
Done
Patchset:
PS22:
> Just waiting for somebody else to +2 it.
Done
PS22:
> There were tons of unresolved review comments here; I usually only review code that either has no re […]
Done
File src/osmo-bsc/bts_nokia_site.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/418267a1_0ce2f5e1?usp… :
PS11, Line 1828: get_object_identity_string(object_id_state[4]), object_id_state[5], get_object_state_string(object_id_state[10]));
> Please, as mentioned, keep lines belows 120chars, otherwise it's a mess. This is far more readable: […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/bc925776_c2df549f?usp… :
PS11, Line 1859: find_element(noh->data, len_data, NOKIA_EI_OBJ_STATE, &object_state, sizeof(object_state))
> Again, all the indentation choices you are selecting here make it impossible to follow. […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/005f1da3_905fe508?usp… :
PS11, Line 1863: object_identity[1] = object_id_state[4];
> so basically object_identity[0] is left uninitialized in this code path? same for object_identity[3] […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3
Gerrit-Change-Number: 39416
Gerrit-PatchSet: 22
Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: domi <domi(a)tomcsanyi.net>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: domi <domi(a)tomcsanyi.net>
Gerrit-Comment-Date: Tue, 25 Feb 2025 13:43:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: csaba.sipos <metro4(a)freemail.hu>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39576?usp=email )
Change subject: osmo-upf-load-gen: Introduce hashtable to look up session by CP SEID
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39576?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: Icab511fa1c136c75403e7469f63d91004e75dab4
Gerrit-Change-Number: 39576
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Feb 2025 13:42:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes