February 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...

by pespin

Attention is currently required from: csaba.sipos, domi, fixeria. pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 22: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 22 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: domi <domi(a)tomcsanyi.net> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: domi <domi(a)tomcsanyi.net> Gerrit-Comment-Date: Tue, 25 Feb 2025 15:21:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in libosmo-sigtran[master]: vty: show cs7 route: display qos-class configured value

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39613?usp=email ) Change subject: vty: show cs7 route: display qos-class configured value ...................................................................... vty: show cs7 route: display qos-class configured value Change-Id: I2d2a246c7fbdf495af94ac5da14d4a93ef837f81 --- M src/osmo_ss7_vty.c 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/13/39613/1 diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index d1885ea..a15b7c6 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -518,7 +518,14 @@ llist_for_each_entry(rt, &rtbl->routes, list) { vty_out(vty, "%-22s %c %c %u %-19s %-7s %-7s %-7s%s", osmo_ss7_route_print(rt), - ' ', ' ', rt->cfg.priority, rt->cfg.linkset_name, "?", "?", "?", VTY_NEWLINE); + ' ', + '0' + rt->cfg.qos_class, + rt->cfg.priority, + rt->cfg.linkset_name, + "?", + "?", + "?", + VTY_NEWLINE); } } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39613?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2d2a246c7fbdf495af94ac5da14d4a93ef837f81 Gerrit-Change-Number: 39613 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[S] Change in pysim[master]: pySim-shell: obey quit command in startup commands+scripts

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/39612?usp=email ) Change subject: pySim-shell: obey quit command in startup commands+scripts ...................................................................... pySim-shell: obey quit command in startup commands+scripts Startup scripts are executed using the cmd2 provided onecmd_plus_hooks method. This method can run arbitrary commands, which also includes the command "run_scrit" that we use to execute startup scripts. When a script executes a quit command, or when someone issues a quit command using the --execute-command or the command argument, then this commands is executed. However a quit command won't actually quit the process. All it does is to change the return code of app.onecmd_plus_hooks (see [1]). So we must evaluate the return code and take care of the quitting ourselves. [1] https://cmd2.readthedocs.io/en/0.9.15/api/cmd.html#cmd2.cmd2.Cmd.onecmd_plu… Related: OS#6731 Change-Id: Ic6e9c54cdb6955d65011af3eb5a025eee5da4143 --- M pySim-shell.py 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim-shell.py b/pySim-shell.py index 9733b22..c59e481 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -1159,14 +1159,18 @@ # Run optional commands for c in opts.execute_command: if not startup_errors: - app.onecmd_plus_hooks(c) + stop = app.onecmd_plus_hooks(c) + if stop == True: + sys.exit(0) else: print("Errors during startup, refusing to execute command (%s)" % c) # Run optional command if opts.command: if not startup_errors: - app.onecmd_plus_hooks('{} {}'.format(opts.command, ' '.join(opts.command_args))) + stop = app.onecmd_plus_hooks('{} {}'.format(opts.command, ' '.join(opts.command_args))) + if stop == True: + sys.exit(0) else: print("Errors during startup, refusing to execute command (%s)" % opts.command) @@ -1177,7 +1181,9 @@ print("Error: script file (%s) not readable!" % opts.script) startup_errors = True else: - app.onecmd_plus_hooks('{} {}'.format('run_script', opts.script), add_to_history = False) + stop = app.onecmd_plus_hooks('{} {}'.format('run_script', opts.script), add_to_history = False) + if stop == True: + sys.exit(0) else: print("Errors during startup, refusing to execute script (%s)" % opts.script) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39612?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic6e9c54cdb6955d65011af3eb5a025eee5da4143 Gerrit-Change-Number: 39612 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

4 months, 1 week

1
0
0 0

[S] Change in pysim[master]: pySim-shell: obey quit command in startup commands+scripts

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39612?usp=email ) Change subject: pySim-shell: obey quit command in startup commands+scripts ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39612?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic6e9c54cdb6955d65011af3eb5a025eee5da4143 Gerrit-Change-Number: 39612 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 15:19:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...

by laforge

Attention is currently required from: csaba.sipos, domi, fixeria, pespin. laforge has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 22: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 22 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: domi <domi(a)tomcsanyi.net> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: domi <domi(a)tomcsanyi.net> Gerrit-Comment-Date: Tue, 25 Feb 2025 15:18:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: ipaccess: Reset pointer before calling stream_cli func triggering cal...

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email ) Change subject: ipaccess: Reset pointer before calling stream_cli func triggering callback ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 Gerrit-Change-Number: 39607 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 15:13:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmocom-bb[master]: trx_toolkit/transceiver: Spellcheck

by osmith

osmith has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39609?usp=email ) Change subject: trx_toolkit/transceiver: Spellcheck ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Thanks! -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39609?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id2a59d6db53c7f90cd21a056da8b1ac4d85e0373 Gerrit-Change-Number: 39609 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 15:12:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 1 week

1
0
0 0

[XS] Change in osmocom-bb[master]: trx_toolkit/transceiver: Spellcheck

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39609?usp=email ) Change subject: trx_toolkit/transceiver: Spellcheck ...................................................................... trx_toolkit/transceiver: Spellcheck Noticed by Jenkins: https: //gerrit.osmocom.org/c/osmocom-bb/+/39328/1/src/target/trx_toolkit/transceiver.py#134 Change-Id: Id2a59d6db53c7f90cd21a056da8b1ac4d85e0373 --- M src/target/trx_toolkit/transceiver.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/target/trx_toolkit/transceiver.py b/src/target/trx_toolkit/transceiver.py index e6af013..e3a457f 100644 --- a/src/target/trx_toolkit/transceiver.py +++ b/src/target/trx_toolkit/transceiver.py @@ -119,7 +119,7 @@ immediately. Instead, they are being scheduled prematurely. The rationale is that both transceiver and the L1 implementation - are separete processes that are not perfectly synchronized in time. + are separate processes that are not perfectly synchronized in time. Moreover, the transceiver needs some time to prepare a burst for transmission. This is why the time difference between Uplink and Downlink is actually much higher on practice (20 TDMA frame periods @@ -131,7 +131,7 @@ the transmit queue until the appropriate time of transmission. The API user is supposed to call recv_data_msg() in order to obtain - a L12TRX message on the TRXD (data) inteface, so it gets queued by + a L12TRX message on the TRXD (data) interface, so it gets queued by this function. Then, to ensure the timeous transmission, the user of this implementation needs to call clck_tick() on each TDMA frame. Both functions are thread-safe (queue mutex). @@ -288,7 +288,7 @@ "is not running => dropping..." % (self, msg.desc_hdr())) return None - # Enque the message, it will be sent later + # Enqueue the message, it will be sent later self.tx_queue_append(msg) return msg -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39609?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id2a59d6db53c7f90cd21a056da8b1ac4d85e0373 Gerrit-Change-Number: 39609 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmocom-bb[master]: trx_toolkit/transceiver: Spellcheck

by osmith

Attention is currently required from: kirr. osmith has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39609?usp=email ) Change subject: trx_toolkit/transceiver: Spellcheck ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39609?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id2a59d6db53c7f90cd21a056da8b1ac4d85e0373 Gerrit-Change-Number: 39609 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Tue, 25 Feb 2025 15:12:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[M] Change in libosmo-sigtran[master]: vty: Add cmd to look up route

by pespin

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39611?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: vty: Add cmd to look up route ...................................................................... vty: Add cmd to look up route Implement a command which allows looking up a given route, similar to linux "ip route get", which is helpful to debug routing setup. Related: SYS#7112 Change-Id: I4dbe04862c018a1beea253de99404adb88bb7f4b --- M src/osmo_ss7_vty.c M tests/vty/osmo_stp_route_prio.vty M tests/vty/osmo_stp_test.vty 3 files changed, 53 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/11/39611/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39611?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4dbe04862c018a1beea253de99404adb88bb7f4b Gerrit-Change-Number: 39611 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

4 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025