Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39608?usp=email )
Change subject: Move osmo_ss7_route_name() to osmo_ss7_route.c
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39608?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I6889a9b6c86453044a6cf6728e7e61264d594a4e
Gerrit-Change-Number: 39608
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Feb 2025 13:41:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39610?usp=email )
Change subject: vty: Rename cmd to show routing table
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
please clearly state whether or not the new syntax brings our commands more in sync with Cisco ITP or not. If they use route-table, then I'm more inclined to accept this patch. If our current command is closer to Cisco ITP, thm we should keep it as-is.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39610?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ie2a01523f95275d88e04f6c76505116372524d3b
Gerrit-Change-Number: 39610
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Feb 2025 13:32:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel, lynxis lazus, neels, pespin.
laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email )
Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2
......................................................................
Patch Set 18:
(2 comments)
File src/iu_client.c:
https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/889a4a75_d7142d45?usp… :
PS13, Line 883: if (!osmo_lai_cmp(&entry->rai.lac, lai)) {
> ehm looks like gerrit messed up the indenting. […]
Done
https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/c3fdefd2_2388594b?usp… :
PS13, Line 914: int ranap_iu_page_ps2(const char *imsi, const uint32_t *ptmsi, const struct osmo_routing_area_id *rai)
> But meanwhile while there's no discussion nor outcome from that discussion, I think we should stick […]
I agree, the consistent thing to is to have it in the C source file.
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd
Gerrit-Change-Number: 38946
Gerrit-PatchSet: 18
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 25 Feb 2025 13:30:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39610?usp=email )
Change subject: vty: Rename cmd to show routing table
......................................................................
vty: Rename cmd to show routing table
The previous cmd name was misleading since it doesn't show a route, but
a routing table.
Rename the cmd, the previous name will be used in a follow-up patch to
implement a command which allows looking up a given route, similar to
linux "ip route get".
Change-Id: Ie2a01523f95275d88e04f6c76505116372524d3b
---
M src/osmo_ss7_vty.c
M tests/vty/osmo_stp_route_prio.vty
M tests/vty/osmo_stp_test.vty
3 files changed, 9 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/10/39610/1
diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index 6b404b3..1369640 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -522,9 +522,10 @@
}
}
-DEFUN(show_cs7_route, show_cs7_route_cmd,
- "show cs7 instance <0-15> route",
- SHOW_STR CS7_STR INST_STR INST_STR "Routing Table\n")
+DEFUN(show_cs7_route_table, show_cs7_route_table_cmd,
+ "show cs7 instance <0-15> route-table [system]",
+ SHOW_STR CS7_STR INST_STR INST_STR
+ "Routing Table\n" "Routing Table Name\n")
{
int id = atoi(argv[0]);
struct osmo_ss7_instance *inst;
@@ -3102,7 +3103,7 @@
install_lib_element(L_CS7_AS_NODE, &as_pc_override_cmd);
install_lib_element(L_CS7_AS_NODE, &as_pc_patch_sccp_cmd);
- install_lib_element_ve(&show_cs7_route_cmd);
+ install_lib_element_ve(&show_cs7_route_table_cmd);
vty_init_addr();
}
diff --git a/tests/vty/osmo_stp_route_prio.vty b/tests/vty/osmo_stp_route_prio.vty
index 10833ea..73608db 100644
--- a/tests/vty/osmo_stp_route_prio.vty
+++ b/tests/vty/osmo_stp_route_prio.vty
@@ -77,7 +77,7 @@
update route 3.2.1 7.255.7 linkset as2
update route 3.2.1 7.255.7 linkset as1 priority 6
...
-OsmoSTP(config-cs7-rt)# do show cs7 instance 0 route
+OsmoSTP(config-cs7-rt)# do show cs7 instance 0 route-table system
Routing table = system
C=Cong Q=QoS P=Prio
diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty
index cb24560..4caa40a 100644
--- a/tests/vty/osmo_stp_test.vty
+++ b/tests/vty/osmo_stp_test.vty
@@ -11,7 +11,7 @@
show cs7 instance <0-15> asp-assoc-status
show cs7 instance <0-15> asp-assoc-status name ASP_NAME
show cs7 instance <0-15> as (active|all|m3ua|sua)
- show cs7 instance <0-15> route
+ show cs7 instance <0-15> route-table [system]
show cs7 instance <0-15> sccp addressbook
show cs7 instance <0-15> sccp users
show cs7 instance <0-15> sccp ssn <0-65535>
@@ -34,7 +34,7 @@
show cs7 instance <0-15> asp-assoc-status
show cs7 instance <0-15> asp-assoc-status name ASP_NAME
show cs7 instance <0-15> as (active|all|m3ua|sua)
- show cs7 instance <0-15> route
+ show cs7 instance <0-15> route-table [system]
show cs7 instance <0-15> sccp addressbook
show cs7 instance <0-15> sccp users
show cs7 instance <0-15> sccp ssn <0-65535>
@@ -77,7 +77,7 @@
asp-remaddr Application Server Process (ASP) remote addresses information
asp-assoc-status Application Server Process (ASP) SCTP association status
as Application Server (AS)
- route Routing Table
+ route-table Routing Table
sccp Signalling Connection Control Part
OsmoSTP# show cs7 instance 0 as ?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39610?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ie2a01523f95275d88e04f6c76505116372524d3b
Gerrit-Change-Number: 39610
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39328?usp=email )
Change subject: Revert "Revert "trx_toolkit/transceiver.py: implement the transmit burst queue""
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS5:
Thanks.
File src/target/trx_toolkit/transceiver.py:
https://gerrit.osmocom.org/c/osmocom-bb/+/39328/comment/b6548bc0_0b6683ff?u… :
PS1, Line 134: a L12TRX message on the TRXD (data) inteface, so it gets queued by
> I think it's not a big crime if we fix the typo here in this patch.
I did the full spellcheck over this file in https://gerrit.osmocom.org/c/osmocom-bb/+/39609 .
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39328?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I41291708effdd2c767be680fff22ffbd9a56815e
Gerrit-Change-Number: 39328
Gerrit-PatchSet: 5
Gerrit-Owner: kirr <kirr(a)nexedi.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Feb 2025 13:04:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: kirr <kirr(a)nexedi.com>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
kirr has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39609?usp=email )
Change subject: trx_toolkit/transceiver: Spellcheck
......................................................................
trx_toolkit/transceiver: Spellcheck
Noticed by Jenkins:
https: //gerrit.osmocom.org/c/osmocom-bb/+/39328/1/src/target/trx_toolkit/transceiver.py#134
Change-Id: Id2a59d6db53c7f90cd21a056da8b1ac4d85e0373
---
M src/target/trx_toolkit/transceiver.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/09/39609/1
diff --git a/src/target/trx_toolkit/transceiver.py b/src/target/trx_toolkit/transceiver.py
index e6af013..e3a457f 100644
--- a/src/target/trx_toolkit/transceiver.py
+++ b/src/target/trx_toolkit/transceiver.py
@@ -119,7 +119,7 @@
immediately. Instead, they are being scheduled prematurely.
The rationale is that both transceiver and the L1 implementation
- are separete processes that are not perfectly synchronized in time.
+ are separate processes that are not perfectly synchronized in time.
Moreover, the transceiver needs some time to prepare a burst for
transmission. This is why the time difference between Uplink and
Downlink is actually much higher on practice (20 TDMA frame periods
@@ -131,7 +131,7 @@
the transmit queue until the appropriate time of transmission.
The API user is supposed to call recv_data_msg() in order to obtain
- a L12TRX message on the TRXD (data) inteface, so it gets queued by
+ a L12TRX message on the TRXD (data) interface, so it gets queued by
this function. Then, to ensure the timeous transmission, the user
of this implementation needs to call clck_tick() on each TDMA
frame. Both functions are thread-safe (queue mutex).
@@ -288,7 +288,7 @@
"is not running => dropping..." % (self, msg.desc_hdr()))
return None
- # Enque the message, it will be sent later
+ # Enqueue the message, it will be sent later
self.tx_queue_append(msg)
return msg
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39609?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id2a59d6db53c7f90cd21a056da8b1ac4d85e0373
Gerrit-Change-Number: 39609
Gerrit-PatchSet: 1
Gerrit-Owner: kirr <kirr(a)nexedi.com>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>