February 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Create all components alive

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39487?usp=email ) Change subject: hnbgw: Create all components alive ...................................................................... hnbgw: Create all components alive This makes it easier to figure out errors due to getting rid of DTEs changing the result output of the test. Change-Id: If7ef1897adf3ef819314aa094ba78c526d77770f --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/87/39487/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 939a608..58a27fc 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -312,7 +312,7 @@ multi_conn_mode := false } - vc_MGCP := MGCP_Emulation_CT.create(id); + vc_MGCP := MGCP_Emulation_CT.create(id) alive; map(vc_MGCP:MGCP, system:MGCP_CODEC_PT); vc_MGCP.start(MGCP_Emulation.main(ops, pars, id)); } @@ -410,10 +410,10 @@ iuh_pars.remote_sctp_port := mp_hnbgw_iuh_port; iuh_pars.local_ip := mp_hnodeb_ip; iuh_pars.local_sctp_port := mp_hnodeb_port + hnb_idx; - vc_Iuh[hnb_idx] := Iuh_Emulation_CT.create(id); + vc_Iuh[hnb_idx] := Iuh_Emulation_CT.create(id) alive; connect(self:HNBAP[hnb_idx], vc_Iuh[hnb_idx]:HNBAP); - vc_RUA[hnb_idx] := RUA_Emulation_CT.create(id & "-RUA"); + vc_RUA[hnb_idx] := RUA_Emulation_CT.create(id & "-RUA") alive; connect(vc_RUA[hnb_idx]:RUA, vc_Iuh[hnb_idx]:RUA); /* Start Iuh side components */ @@ -476,7 +476,8 @@ if (ps_domain) { msc_sgsn := "sgsn"; } - f_ran_adapter_init(g_cn[cn_idx], mp_cn_cfg[cn_idx], "HNBGW_Test." & msc_sgsn & int2str(cn_nr), ranops); + f_ran_adapter_init(g_cn[cn_idx], mp_cn_cfg[cn_idx], "HNBGW_Test." & msc_sgsn & int2str(cn_nr), + ranops, create_alive := true); f_ran_adapter_start(g_cn[cn_idx]); } @@ -491,7 +492,7 @@ T_guard.start(guard_timeout); activate(as_Tguard()); - vc_mutex_disp := f_MutexDisp_start(); + vc_mutex_disp := f_MutexDisp_start(create_alive := true); f_init_statsd("VirtHNBGW", vc_STATSD, mp_local_statsd_ip, mp_local_statsd_port); f_init_vty("VirtHNBGW"); @@ -627,7 +628,7 @@ var ConnHdlr vc_conn; var charstring id := testcasename() & int2str(pars.hnb_idx); - vc_conn := ConnHdlr.create(id); + vc_conn := ConnHdlr.create(id) alive; /* Iuh RUA part */ connect(vc_conn:RUA, vc_RUA[pars.hnb_idx]:CLIENT); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39487?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If7ef1897adf3ef819314aa094ba78c526d77770f Gerrit-Change-Number: 39487 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 4 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: RAN_Adapter: Allow creating components alive

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39486?usp=email ) Change subject: RAN_Adapter: Allow creating components alive ...................................................................... RAN_Adapter: Allow creating components alive Change-Id: Ice4d93b42552f1c5d621582b1fc3a38b4e1ae837 --- M library/RAN_Adapter.ttcnpp 1 file changed, 36 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/39486/1 diff --git a/library/RAN_Adapter.ttcnpp b/library/RAN_Adapter.ttcnpp index c90ffce..173cc46 100644 --- a/library/RAN_Adapter.ttcnpp +++ b/library/RAN_Adapter.ttcnpp @@ -86,15 +86,23 @@ function f_ran_adapter_init(inout RAN_Adapter ba, in RAN_Configuration cfg, charstring id, - template RanOps ops) { + template RanOps ops, boolean create_alive := false) { init_pars(ba, cfg); ops.sccp_addr_local := ba.sccp_addr_own; ops.sccp_addr_peer := ba.sccp_addr_peer; /* create components */ - ba.vc_SCCP := SCCP_CT.create(id & "-SCCP"); + if (create_alive) { + ba.vc_SCCP := SCCP_CT.create(id & "-SCCP") alive; + } else { + ba.vc_SCCP := SCCP_CT.create(id & "-SCCP"); + } if (isvalue(ops)) { - ba.vc_RAN := RAN_Emulation_CT.create(id & "-RAN"); + if (create_alive) { + ba.vc_RAN := RAN_Emulation_CT.create(id & "-RAN") alive; + } else { + ba.vc_RAN := RAN_Emulation_CT.create(id & "-RAN"); + } } else { ba.vc_RAN := null; } @@ -106,7 +114,11 @@ } else { rctx := cfg.rctx; } - ba.vc_M3UA := M3UA_CT.create(id & "-M3UA"); + if (create_alive) { + ba.vc_M3UA := M3UA_CT.create(id & "-M3UA") alive; + } else { + ba.vc_M3UA := M3UA_CT.create(id & "-M3UA"); + } map(ba.vc_M3UA:SCTP_PORT, system:sctp); /* connect MTP3 service provider (M3UA) to lower side of SCCP */ connect(ba.vc_M3UA:MTP3_SP_PORT, ba.vc_SCCP:MTP3_SCCP_PORT); @@ -114,12 +126,20 @@ } #ifdef IPA_EMULATION_SCCP case (BSSAP_TRANSPORT_SCCPlite_SERVER) { - ba.vc_IPA := IPA_Emulation_CT.create(id & "-IPA"); + if (create_alive) { + ba.vc_IPA := IPA_Emulation_CT.create(id & "-IPA") alive; + } else { + ba.vc_IPA := IPA_Emulation_CT.create(id & "-IPA"); + } map(ba.vc_IPA:IPA_PORT, system:IPA_CODEC_PT); /* connect MTP3 service provider (IPA) to lower side of SCCP */ connect(ba.vc_IPA:MTP3_SP_PORT, ba.vc_SCCP:MTP3_SCCP_PORT); /* connect waiter to general IPA port (for ASP_IPA_Event) */ - ba.vc_WAIT := IPA_EventWaiter_CT.create(id & "-IPA-WAIT"); + if (create_alive) { + ba.vc_WAIT := IPA_EventWaiter_CT.create(id & "-IPA-WAIT") alive; + } else { + ba.vc_WAIT := IPA_EventWaiter_CT.create(id & "-IPA-WAIT"); + } connect(ba.vc_IPA:IPA_SP_PORT, ba.vc_WAIT:IPA_SP_PORT); ba.vc_WAIT.start(IPA_Emulation.waiter_main()); ba.vc_IPA.start(IPA_Emulation.main_server(cfg.sctp_addr.local_ip_addr, @@ -130,12 +150,20 @@ disconnect(ba.vc_IPA:IPA_SP_PORT, ba.vc_WAIT:IPA_SP_PORT); } case (BSSAP_TRANSPORT_SCCPlite_CLIENT) { - ba.vc_IPA := IPA_Emulation_CT.create(id & "-IPA"); + if (create_alive) { + ba.vc_IPA := IPA_Emulation_CT.create(id & "-IPA") alive; + } else { + ba.vc_IPA := IPA_Emulation_CT.create(id & "-IPA"); + } map(ba.vc_IPA:IPA_PORT, system:IPA_CODEC_PT); /* connect MTP3 service provider (IPA) to lower side of SCCP */ connect(ba.vc_IPA:MTP3_SP_PORT, ba.vc_SCCP:MTP3_SCCP_PORT); /* connect waiter to general IPA port (for ASP_IPA_Event) */ - ba.vc_WAIT := IPA_EventWaiter_CT.create(id & "-IPA-WAIT"); + if (create_alive) { + ba.vc_WAIT := IPA_EventWaiter_CT.create(id & "-IPA-WAIT") alive; + } else { + ba.vc_WAIT := IPA_EventWaiter_CT.create(id & "-IPA-WAIT"); + } connect(ba.vc_IPA:IPA_SP_PORT, ba.vc_WAIT:IPA_SP_PORT); ba.vc_WAIT.start(IPA_Emulation.waiter_main()); ba.vc_IPA.start(IPA_Emulation.main_client(cfg.sctp_addr.remote_ip_addr, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ice4d93b42552f1c5d621582b1fc3a38b4e1ae837 Gerrit-Change-Number: 39486 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 4 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: Remove unsupport test cases

by daniel

Attention is currently required from: dexter, fixeria, laforge, lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email ) Change subject: SGSN: Remove unsupport test cases ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1506324300fe3864069706d5b05860e7b44cd895 Gerrit-Change-Number: 39261 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Feb 2025 16:58:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 4 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: rework TC_sgsn_context_req_out to actual function

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email ) Change subject: SGSN_Tests: rework TC_sgsn_context_req_out to actual function ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3 Gerrit-Change-Number: 39017 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 06 Feb 2025 16:53:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

4 months, 4 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: peek_l3_ul_nas: Improve GMM Attach Req parsing checks

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39481?usp=email ) Change subject: peek_l3_ul_nas: Improve GMM Attach Req parsing checks ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic9815215d40d7bb59709dcbffa0a4673f1e0e710 Gerrit-Change-Number: 39481 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Feb 2025 16:48:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 4 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: peek_l3_ul_nas: Parse PTMSI MI from GMM RAU req

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39482?usp=email ) Change subject: peek_l3_ul_nas: Parse PTMSI MI from GMM RAU req ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I570eb31dcee94a3ebef25e15ac7cd7199ec9a79e Gerrit-Change-Number: 39482 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Feb 2025 16:47:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 4 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: peek_l3_ul_nas: Improve RAU req parsing checks

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39480?usp=email ) Change subject: peek_l3_ul_nas: Improve RAU req parsing checks ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Same code as I did in sgsn. […] In here we only want a minimal parsing, so no need to have the full parsing in here imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39480?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1a6c642e7017e159a2035869c75475d0de7fbb75 Gerrit-Change-Number: 39480 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 06 Feb 2025 16:42:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

4 months, 4 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: peek_l3_ul_nas: Improve RAU req parsing checks

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39480?usp=email ) Change subject: peek_l3_ul_nas: Improve RAU req parsing checks ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Same code as I did in sgsn. In theory we could move the code into a osmocore lib? Not sure if necessary. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39480?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1a6c642e7017e159a2035869c75475d0de7fbb75 Gerrit-Change-Number: 39480 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Feb 2025 16:41:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 4 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: peek_l3_ul_nas: Improve RAU req parsing checks

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39480?usp=email ) Change subject: peek_l3_ul_nas: Improve RAU req parsing checks ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39480?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1a6c642e7017e159a2035869c75475d0de7fbb75 Gerrit-Change-Number: 39480 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Feb 2025 16:41:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 4 weeks

1
0
0 0

[M] Change in osmo-hnbgw[master]: peek_l3_ul_nas: Split parsing logic based on PS/CS ctx

by lynxis lazus

Attention is currently required from: fixeria, laforge, neels, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39479?usp=email ) Change subject: peek_l3_ul_nas: Split parsing logic based on PS/CS ctx ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I would move the code further apart into own functions based on map->is_ps -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39479?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I198f2fd14952362c4d189663d067c7f9dae2ed05 Gerrit-Change-Number: 39479 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Feb 2025 16:40:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 4 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025