February 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: MGCP_Emulation: Make sure peer is running before Tx

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39484?usp=email ) Change subject: MGCP_Emulation: Make sure peer is running before Tx ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I'm not sure where the "peer" terminology comes from. We use "client" to refer to the individual per-mgcp-conn/endpoint components. "peer" to me sounds like something remote, i.e. the IUT -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8724870b9b967ffa49c3da03e1cdb2941f81653a Gerrit-Change-Number: 39484 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Feb 2025 09:13:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Use Misc_Helpers.f_shutdown upon rx of unexpected msg

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39483?usp=email ) Change subject: hnbgw: Use Misc_Helpers.f_shutdown upon rx of unexpected msg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7f07cff2ce93e8b11338ba4e39e1d49662323f58 Gerrit-Change-Number: 39483 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Feb 2025 09:11:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: Mutex: Allow creating component alive

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39485?usp=email ) Change subject: Mutex: Allow creating component alive ...................................................................... Patch Set 1: (1 comment) File library/Mutex.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39485/comment/63732748_c5c0… : PS1, Line 66: boolean create_alive := false > Because that would mean changing the components to alive in all other testsuites I'm not looking at […] Ok, but what downsides does this bring to other testsuites? In the past we already did switch some components to `alive` unconditionally and I don't remember seeing any problems with that. I am not against making things configurable, just trying to understand whether we need this flexibility. Maybe the S1GW testsuite would also benefit from making it `alive`? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39485?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie2980705dd0d2d8ed11a6c13349fb85e6f254748 Gerrit-Change-Number: 39485 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Feb 2025 07:24:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: RAN_Adapter: Allow creating components alive

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39486?usp=email ) Change subject: RAN_Adapter: Allow creating components alive ...................................................................... Patch Set 1: (1 comment) File library/RAN_Adapter.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39486/comment/3fc7e766_8cbe… : PS1, Line 89: boolean create_alive := false > Likewise, why not `alive` unconditionally? […] Having them not alive means also having to change all components in all testsuites using them, otherwise you end up with race condition with packets being transmitted from a component to another. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ice4d93b42552f1c5d621582b1fc3a38b4e1ae837 Gerrit-Change-Number: 39486 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Feb 2025 22:53:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: Mutex: Allow creating component alive

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39485?usp=email ) Change subject: Mutex: Allow creating component alive ...................................................................... Patch Set 1: (1 comment) File library/Mutex.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39485/comment/3b91afa4_9cbb… : PS1, Line 66: boolean create_alive := false > Why not just making it `alive` unconditionally? Because that would mean changing the components to alive in all other testsuites I'm not looking at now. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39485?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie2980705dd0d2d8ed11a6c13349fb85e6f254748 Gerrit-Change-Number: 39485 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Feb 2025 22:51:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Create all components alive

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39487?usp=email ) Change subject: hnbgw: Create all components alive ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39487?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If7ef1897adf3ef819314aa094ba78c526d77770f Gerrit-Change-Number: 39487 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Feb 2025 20:14:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: RAN_Adapter: Allow creating components alive

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39486?usp=email ) Change subject: RAN_Adapter: Allow creating components alive ...................................................................... Patch Set 1: (1 comment) File library/RAN_Adapter.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39486/comment/31fba399_6091… : PS1, Line 89: boolean create_alive := false Likewise, why not `alive` unconditionally? In which cases do we want components to be `alive` and in which not? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ice4d93b42552f1c5d621582b1fc3a38b4e1ae837 Gerrit-Change-Number: 39486 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Feb 2025 20:13:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: Mutex: Allow creating component alive

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39485?usp=email ) Change subject: Mutex: Allow creating component alive ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File library/Mutex.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39485/comment/5968c95e_f6f3… : PS1, Line 66: boolean create_alive := false Why not just making it `alive` unconditionally? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39485?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie2980705dd0d2d8ed11a6c13349fb85e6f254748 Gerrit-Change-Number: 39485 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Feb 2025 20:11:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: MGCP_Emulation: Make sure peer is running before Tx

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39484?usp=email ) Change subject: MGCP_Emulation: Make sure peer is running before Tx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8724870b9b967ffa49c3da03e1cdb2941f81653a Gerrit-Change-Number: 39484 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Feb 2025 20:09:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: peek_l3_ul_nas: Parse PTMSI MI from GMM RAU req

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39482?usp=email ) Change subject: peek_l3_ul_nas: Parse PTMSI MI from GMM RAU req ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I570eb31dcee94a3ebef25e15ac7cd7199ec9a79e Gerrit-Change-Number: 39482 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Feb 2025 20:06:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025