December 2025 - gerrit-log - lists.osmocom.org

[L] Change in ...osmo-s1gw[master]: [REST] Add MmeList, MmeAdd, MmeInfo, MmeDelete
by fixeria 05 Dec '25

05 Dec '25

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41282?usp=email ) Change subject: [REST] Add MmeList, MmeAdd, MmeInfo, MmeDelete ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41282?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iad249aed99face9e35fd19e0596cf2364ade4c77 Gerrit-Change-Number: 41282 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 19:45:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[L] Change in ...osmo-s1gw[master]: mme_registry: the MME registry (pool) implementation
by fixeria 05 Dec '25

05 Dec '25

Attention is currently required from: fixeria, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41281?usp=email ) Change subject: mme_registry: the MME registry (pool) implementation ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id5480222439bf93eca2e994b291c619dff823b01 Gerrit-Change-Number: 41281 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 19:44:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: use lists:filter/2 in sctp_send_pending/2
by fixeria 05 Dec '25

05 Dec '25

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41616?usp=email ) Change subject: sctp_proxy: use lists:filter/2 in sctp_send_pending/2 ...................................................................... Patch Set 1: (1 comment) File src/sctp_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41616/comment/26a4046b_e3a5… : PS1, Line 307: lists:reverse(Pending)), > why this reverse? Are you adding them to the tx_queue in reverse order? ie prepending messages? Yes, it's a normal practice in Erlang: you prepend items to a list and then do the reverse. Appending to a list is possible (`List ++ [Item]`), but this comes with performance penalty, because each addition requires allocating a new list. And please note that the reverse was here before this patch, I am not changing this. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41616?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic666fd77bc6d04341f3c57140dea5d4a5e616e80 Gerrit-Change-Number: 41616 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 18:17:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-abis[master]: amr_trau: add osmo_amrt_fill_with_dhf() function
by falconia 05 Dec '25

05 Dec '25

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41536?usp=email ) Change subject: amr_trau: add osmo_amrt_fill_with_dhf() function ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > I didn't realize we had to add such entries every time we add a new API - I thought it was only need […] See how I did it in PS4 - is it the right way? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41536?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie085e593d6326072295a8cedf2c2c103883f93d5 Gerrit-Change-Number: 41536 Gerrit-PatchSet: 4 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 17:50:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-abis[master]: amr_trau: add osmo_amrt_fill_with_dhf() function
by falconia 05 Dec '25

05 Dec '25

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/41536?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: amr_trau: add osmo_amrt_fill_with_dhf() function ...................................................................... amr_trau: add osmo_amrt_fill_with_dhf() function It is useful to have a function that fills struct osmo_amrt_if with constant DHF bits. In an E1 Abis MGW this function is needed in order to emit DHFs on Abis DL during initial or prolonged absence of RTP input; it can also be used in a transcoding CN MGW to emit DHFs in RTP on AoIP interface during similar conditions of no G.711 input being transcoded or TFO-handled. Depends: I1f8f8ec36cc13270a1d1fa633583107317abe894 (libosmocore) Change-Id: Ie085e593d6326072295a8cedf2c2c103883f93d5 --- M TODO-RELEASE M include/osmocom/trau/amr_trau.h M src/Makefile.am A src/trau/amr_misc.c 4 files changed, 97 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/36/41536/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41536?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie085e593d6326072295a8cedf2c2c103883f93d5 Gerrit-Change-Number: 41536 Gerrit-PatchSet: 4 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-abis[master]: amr_trau: add osmo_amrt_fill_with_dhf() function
by falconia 05 Dec '25

05 Dec '25

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41536?usp=email ) Change subject: amr_trau: add osmo_amrt_fill_with_dhf() function ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > missing entry in TODO-RELEASE: […] I didn't realize we had to add such entries every time we add a new API - I thought it was only needed to note dependencies on API additions in other libraries that happened since last release. I'll see if I can figure out the syntax for this new case (this-library API addition, rather than dependencies) and spin a revised patch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41536?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie085e593d6326072295a8cedf2c2c103883f93d5 Gerrit-Change-Number: 41536 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 17:41:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-abis[master]: amr_trau: add osmo_amrt_fill_with_dhf() function
by pespin 05 Dec '25

05 Dec '25

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41536?usp=email ) Change subject: amr_trau: add osmo_amrt_fill_with_dhf() function ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: missing entry in TODO-RELEASE: trau add osmo_amrt_fill_with_dhf() -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41536?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie085e593d6326072295a8cedf2c2c103883f93d5 Gerrit-Change-Number: 41536 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 05 Dec 2025 17:30:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ci[master]: scripts: Add libosmo-asn1-tcap to OSMO_RELEASE_REPOS
by pespin 05 Dec '25

05 Dec '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/41587?usp=email ) Change subject: scripts: Add libosmo-asn1-tcap to OSMO_RELEASE_REPOS ...................................................................... scripts: Add libosmo-asn1-tcap to OSMO_RELEASE_REPOS Change-Id: I76703ed5c648eb50574166f8459fd0bde1720902 --- M scripts/common.sh M scripts/tarballs/publish-tarballs-for-tags.sh 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/scripts/common.sh b/scripts/common.sh index fb06d70..6ef1e3c 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -10,6 +10,7 @@ OSMO_RELEASE_REPOS=" libasn1c libosmo-abis + libosmo-asn1-tcap libosmo-gprs libosmo-netif libosmo-pfcp diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh b/scripts/tarballs/publish-tarballs-for-tags.sh index 442c00f..54cd3f9 100755 --- a/scripts/tarballs/publish-tarballs-for-tags.sh +++ b/scripts/tarballs/publish-tarballs-for-tags.sh @@ -12,6 +12,7 @@ libasn1c libgtpnl libosmo-abis + libosmo-asn1-tcap libosmo-dsp libosmo-gprs libosmo-netif -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41587?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I76703ed5c648eb50574166f8459fd0bde1720902 Gerrit-Change-Number: 41587 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: Rename sctp_proxy -> enb_proxy
by pespin 05 Dec '25

05 Dec '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41623?usp=email ) Change subject: Rename sctp_proxy -> enb_proxy ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41623?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8beaea9aa98dfa1c2e6f1d1c823b033892bd00cb Gerrit-Change-Number: 41623 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 17:28:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in ...osmo-s1gw[master]: s1ap_proxy: move S1 SETUP handling to sctp_proxy
by pespin 05 Dec '25

05 Dec '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41622?usp=email ) Change subject: s1ap_proxy: move S1 SETUP handling to sctp_proxy ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41622?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I9aa67732b418bcdf3f10b2db89a41dda26ee3d4e Gerrit-Change-Number: 41622 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 17:27:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0