December 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[master]: cosmetic: stream_srv: srv_link: Document no need for OSMO_SOCK_F_NONB...
by osmith 16 Dec '25

16 Dec '25

Attention is currently required from: daniel, jolly, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41666?usp=email ) Change subject: cosmetic: stream_srv: srv_link: Document no need for OSMO_SOCK_F_NONBLOCK ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I98a6ef55a0a7289b9eeb7e8062e9afa4d87f51eb Gerrit-Change-Number: 41666 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Dec 2025 07:46:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: ts_51_011/EF.SMSP: Fix parsing of parameter_indicators
by laforge 16 Dec '25

16 Dec '25

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41674?usp=email ) Change subject: ts_51_011/EF.SMSP: Fix parsing of parameter_indicators ...................................................................... ts_51_011/EF.SMSP: Fix parsing of parameter_indicators There's a 3-bit RFU field that (unlike everything else in USIM/UICC) considers '1' to be the default. Let's make sure we get that right during encode. Change-Id: Ibe24a07f5f73d875d2077fa55471dbfc4e90da23 --- M pySim/ts_51_011.py 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/74/41674/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index cdab5de..5b397cd 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -243,7 +243,7 @@ _test_decode = [ ( '454e6574776f726b73fffffffffffffff1ffffffffffffffffffffffffffffffffffffffffffffffff0000a7', { "alpha_id": "ENetworks", "parameter_indicators": { "tp_dest_addr": False, "tp_sc_addr": True, - "tp_pid": True, "tp_dcs": True, "tp_vp": True }, + "tp_pid": True, "tp_dcs": True, "tp_vp": False }, "tp_dest_addr": { "length": 255, "ton_npi": { "ext": True, "type_of_number": "reserved_for_extension", "numbering_plan_id": "reserved_for_extension" }, "call_number": "" }, @@ -281,8 +281,13 @@ super().__init__(fid, sfid=sfid, name=name, desc=desc, rec_len=(28, None), **kwargs) ScAddr = Struct('length'/Int8ub, 'ton_npi'/TonNpi, 'call_number'/BcdAdapter(Rpad(Bytes(10)))) self._construct = Struct('alpha_id'/COptional(GsmOrUcs2Adapter(Rpad(Bytes(this._.total_len-28)))), - 'parameter_indicators'/InvertAdapter(FlagsEnum(Byte, tp_dest_addr=1, tp_sc_addr=2, - tp_pid=3, tp_dcs=4, tp_vp=5)), + 'parameter_indicators'/InvertAdapter(BitStruct( + Const(7, BitsInteger(3)), + 'tp_vp'/Flag, + 'tp_dcs'/Flag, + 'tp_pid'/Flag, + 'tp_sc_addr'/Flag, + 'tp_dest_addr'/Flag)), 'tp_dest_addr'/ScAddr, 'tp_sc_addr'/ScAddr, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibe24a07f5f73d875d2077fa55471dbfc4e90da23 Gerrit-Change-Number: 41674 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: ts_51_011: Improve testing of EF_SMSP
by laforge 16 Dec '25

16 Dec '25

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41677?usp=email ) Change subject: ts_51_011: Improve testing of EF_SMSP ...................................................................... ts_51_011: Improve testing of EF_SMSP * add another set of test data (from a real-world SIM card) * switch from test_decode to test_de_encode as our encoder now works due to previous commits. Change-Id: I8d16e195641bb59b2c26072008f88434692c0cab --- M pySim/ts_51_011.py 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/77/41677/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 5b397cd..4799151 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -239,8 +239,17 @@ # TS 51.011 Section 10.5.6 class EF_SMSP(LinFixedEF): - # FIXME: re-encode fails / missing alpha_id at start of output - _test_decode = [ + _test_de_encode = [ + ( '534d5343ffffffffffffffffffffffffe1ffffffffffffffffffffffff0891945197109099f9ffffff0000a9', + { "alpha_id": "SMSC", "parameter_indicators": { "tp_dest_addr": False, "tp_sc_addr": True, + "tp_pid": True, "tp_dcs": True, "tp_vp": True }, + "tp_dest_addr": { "length": 255, "ton_npi": { "ext": True, "type_of_number": "reserved_for_extension", + "numbering_plan_id": "reserved_for_extension" }, + "call_number": "" }, + "tp_sc_addr": { "length": 8, "ton_npi": { "ext": True, "type_of_number": "international", + "numbering_plan_id": "isdn_e164" }, + "call_number": "4915790109999f" }, + "tp_pid": b"\x00", "tp_dcs": b"\x00", "tp_vp_minutes": 4320 } ), ( '454e6574776f726b73fffffffffffffff1ffffffffffffffffffffffffffffffffffffffffffffffff0000a7', { "alpha_id": "ENetworks", "parameter_indicators": { "tp_dest_addr": False, "tp_sc_addr": True, "tp_pid": True, "tp_dcs": True, "tp_vp": False }, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8d16e195641bb59b2c26072008f88434692c0cab Gerrit-Change-Number: 41677 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: unittests/test_files: Pass to-be-encoded length to encoder functions
by laforge 16 Dec '25

16 Dec '25

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41676?usp=email ) Change subject: unittests/test_files: Pass to-be-encoded length to encoder functions ...................................................................... unittests/test_files: Pass to-be-encoded length to encoder functions Some of the encoders can only generate valid output if they are told the expected output size. This is due to variable-length fields that depend on the size of the total record (or file). Let's always pass the expected length to the encoder methods. Change-Id: I88f957e49b0c88a121a266d3582e79822fa0e214 --- M tests/unittests/test_files.py 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/76/41676/1 diff --git a/tests/unittests/test_files.py b/tests/unittests/test_files.py index ab70771..5bbbddd 100755 --- a/tests/unittests/test_files.py +++ b/tests/unittests/test_files.py @@ -96,7 +96,7 @@ inst = c() encoded, rec_num, decoded = self._parse_t(t) logging.debug("Testing encode of %s", name) - re_enc = inst.encode_record_hex(decoded, rec_num) + re_enc = inst.encode_record_hex(decoded, rec_num, len(encoded)//2) self.assertEqual(encoded.upper(), re_enc.upper()) def test_de_encode_record(self): @@ -122,7 +122,7 @@ self.assertEqual(decoded, re_dec) # re-encode the decoded data logging.debug("Testing re-encode of %s", name) - re_enc = inst.encode_record_hex(re_dec, rec_num) + re_enc = inst.encode_record_hex(re_dec, rec_num, len(encoded)//2) self.assertEqual(encoded.upper(), re_enc.upper()) if hasattr(c, '_test_no_pad') and c._test_no_pad: continue @@ -196,7 +196,7 @@ self.assertEqual(decoded, re_dec) # re-encode the decoded data logging.debug("Testing re-encode of %s", name) - re_enc = inst.encode_record_hex(re_dec) + re_enc = inst.encode_record_hex(re_dec, len(encoded)//2) self.assertEqual(encoded.upper(), re_enc.upper()) # there's no point in testing padded input, as TransRecEF have a fixed record # size and we cannot ever receive more input data than that size. @@ -256,7 +256,7 @@ encoded = t[0] decoded = t[1] logging.debug("Testing encode of %s", name) - re_enc = inst.encode_hex(decoded) + re_enc = inst.encode_hex(decoded, len(encoded)//2) self.assertEqual(encoded, re_enc) def test_de_encode_file(self): @@ -280,7 +280,7 @@ self.assertEqual(decoded, re_dec) logging.debug("Testing re-encode of %s", name) re_dec = inst.decode_hex(encoded) - re_enc = inst.encode_hex(re_dec) + re_enc = inst.encode_hex(re_dec, len(encoded)//2) self.assertEqual(encoded.upper(), re_enc.upper()) if hasattr(c, '_test_no_pad') and c._test_no_pad: continue -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41676?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88f957e49b0c88a121a266d3582e79822fa0e214 Gerrit-Change-Number: 41676 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: ts_51_011.EF_SMSP: Use integer division during encode
by laforge 16 Dec '25

16 Dec '25

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41672?usp=email ) Change subject: ts_51_011.EF_SMSP: Use integer division during encode ...................................................................... ts_51_011.EF_SMSP: Use integer division during encode Otherwise we might compute float values and fail encoding like this: > construct.core.FormatFieldError: Error in path (building) -> tp_vp_minutes > struct '>B' error during building, given value 169.0 Change-Id: I989669434c7ddee9595ee81a0822f9966907a844 --- M pySim/ts_51_011.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/72/41672/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index e46a3e0..7bd3380 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -271,7 +271,7 @@ elif obj <= 24*60: return 143 + ((obj - (12 * 60)) // 30) elif obj <= 30 * 24 * 60: - return 166 + (obj / (24 * 60)) + return 166 + (obj // (24 * 60)) elif obj <= 63 * 7 * 24 * 60: return 192 + (obj // (7 * 24 * 60)) else: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41672?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I989669434c7ddee9595ee81a0822f9966907a844 Gerrit-Change-Number: 41672 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pySim.ts_51_011.EF_SMSP: Also permit UCS2 for the alpha_id
by laforge 16 Dec '25

16 Dec '25

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41673?usp=email ) Change subject: pySim.ts_51_011.EF_SMSP: Also permit UCS2 for the alpha_id ...................................................................... pySim.ts_51_011.EF_SMSP: Also permit UCS2 for the alpha_id TS 51.011 Section 10.5.6 refers to clause 10.5.1 (EF.ADN), and the latter permits UCS2 in addition to 7-bit GSM alphabet. Change-Id: If10b3d6d8b34ece02dc0350ca9ea9c3f8fbf3c9e --- M pySim/ts_51_011.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/73/41673/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 7bd3380..cdab5de 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -280,7 +280,7 @@ def __init__(self, fid='6f42', sfid=None, name='EF.SMSP', desc='Short message service parameters', **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, rec_len=(28, None), **kwargs) ScAddr = Struct('length'/Int8ub, 'ton_npi'/TonNpi, 'call_number'/BcdAdapter(Rpad(Bytes(10)))) - self._construct = Struct('alpha_id'/COptional(GsmStringAdapter(Rpad(Bytes(this._.total_len-28)))), + self._construct = Struct('alpha_id'/COptional(GsmOrUcs2Adapter(Rpad(Bytes(this._.total_len-28)))), 'parameter_indicators'/InvertAdapter(FlagsEnum(Byte, tp_dest_addr=1, tp_sc_addr=2, tp_pid=3, tp_dcs=4, tp_vp=5)), 'tp_dest_addr'/ScAddr, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41673?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If10b3d6d8b34ece02dc0350ca9ea9c3f8fbf3c9e Gerrit-Change-Number: 41673 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: unittest/test_files.TransparentEF_Test: Actually test encoder
by laforge 16 Dec '25

16 Dec '25

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41675?usp=email ) Change subject: unittest/test_files.TransparentEF_Test: Actually test encoder ...................................................................... unittest/test_files.TransparentEF_Test: Actually test encoder In the test_encode_file() method, we should actually test the encoder, and not the decoder. I suppose this was a copy+paste mistake at some point? In the LinearFixedEF_Test.test_encoder_record we were already testing the encoder. Just TransparentEF_Test got it wrong... Change-Id: Id23305a78ab9acd2e006f2b26b72408795844d23 --- M tests/unittests/test_files.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/75/41675/1 diff --git a/tests/unittests/test_files.py b/tests/unittests/test_files.py index a3ccf06..ab70771 100755 --- a/tests/unittests/test_files.py +++ b/tests/unittests/test_files.py @@ -256,8 +256,8 @@ encoded = t[0] decoded = t[1] logging.debug("Testing encode of %s", name) - re_dec = inst.decode_hex(encoded) - self.assertEqual(decoded, re_dec) + re_enc = inst.encode_hex(decoded) + self.assertEqual(encoded, re_enc) def test_de_encode_file(self): """Test the decoder and encoder for a transparent EF. Performs first a decoder -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41675?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id23305a78ab9acd2e006f2b26b72408795844d23 Gerrit-Change-Number: 41675 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmocom-bb[master]: trx_toolkit: print milliseconds in logging
by fixeria 15 Dec '25

15 Dec '25

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41652?usp=email ) Change subject: trx_toolkit: print milliseconds in logging ...................................................................... trx_toolkit: print milliseconds in logging More preciese timestamps are helpful during debugging. Change-Id: I7c53149f4e678670392773bbcf9648997ba4ff1b Related: OS#6904 --- M src/target/trx_toolkit/app_common.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/target/trx_toolkit/app_common.py b/src/target/trx_toolkit/app_common.py index 531d8dc..75dd5a2 100644 --- a/src/target/trx_toolkit/app_common.py +++ b/src/target/trx_toolkit/app_common.py @@ -39,7 +39,7 @@ "There is NO WARRANTY, to the extent permitted by law.\n") def add_log_handler(self, lh, log_level, log_fmt, time_fmt, log_time = False): - log_fmt = "%(asctime)s " + log_fmt if log_time else log_fmt + log_fmt = "%(asctime)s.%(msecs)03d " + log_fmt if log_time else log_fmt lf = log.Formatter(log_fmt, time_fmt) ll = log.getLevelName(log_level) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7c53149f4e678670392773bbcf9648997ba4ff1b Gerrit-Change-Number: 41652 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: trx_toolkit: print milliseconds in logging
by fixeria 15 Dec '25

15 Dec '25

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41652?usp=email ) Change subject: trx_toolkit: print milliseconds in logging ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7c53149f4e678670392773bbcf9648997ba4ff1b Gerrit-Change-Number: 41652 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Dec 2025 16:54:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-netif[master]: cosmetic: stream_srv: srv_link: Document no need for OSMO_SOCK_F_NONB...
by fixeria 15 Dec '25

15 Dec '25

Attention is currently required from: daniel, jolly, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41666?usp=email ) Change subject: cosmetic: stream_srv: srv_link: Document no need for OSMO_SOCK_F_NONBLOCK ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I98a6ef55a0a7289b9eeb7e8062e9afa4d87f51eb Gerrit-Change-Number: 41666 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Dec 2025 16:54:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0