December 2025 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: pySim.esim.saip.personalization: Support Milenage customization
by fixeria 16 Dec '25

16 Dec '25

Attention is currently required from: dexter, laforge, neels. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41690?usp=email ) Change subject: pySim.esim.saip.personalization: Support Milenage customization ...................................................................... Patch Set 1: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/41690/comment/afec0fbc_e237bff5?usp=em… : PS1, Line 341: super().validate() Looks like you want to call this first, before checking length of something that may not be a `bytes`/`bytearray` object? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I397df6c0c708a8061e4adc0fde03a3f746bcb5b6 Gerrit-Change-Number: 41690 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Dec 2025 17:06:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in pysim[master]: ts_51_011.EF_SMSP: Use integer division during encode
by fixeria 16 Dec '25

16 Dec '25

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41672?usp=email ) Change subject: ts_51_011.EF_SMSP: Use integer division during encode ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41672?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I989669434c7ddee9595ee81a0822f9966907a844 Gerrit-Change-Number: 41672 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 16 Dec 2025 16:58:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-tetra[master]: Fix preventing crashes when -d missing
by pespin 16 Dec '25

16 Dec '25

Attention is currently required from: wbokslag. pespin has posted comments on this change by wbokslag. ( https://gerrit.osmocom.org/c/osmo-tetra/+/41679?usp=email ) Change subject: Fix preventing crashes when -d missing ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/41679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I6a857f62aae542b054cbb474594359da626762bb Gerrit-Change-Number: 41679 Gerrit-PatchSet: 3 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Tue, 16 Dec 2025 16:29:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: logging: change gsmtap target to use wqueue by default
by pespin 16 Dec '25

16 Dec '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email ) Change subject: logging: change gsmtap target to use wqueue by default ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > @laforge@osmocom. […] The main problem with that approach is that we then basically become constrained by whatever maximum UDP socket snfbuf size is configured in the system, plus we need to add logic to increase the sndbuf in use for that socket, etc. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d8c953a5b467ce4396d2d20ca6fa72a749723c0 Gerrit-Change-Number: 41685 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Dec 2025 16:28:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: logging: change gsmtap target to use wqueue by default
by pespin 16 Dec '25

16 Dec '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email ) Change subject: logging: change gsmtap target to use wqueue by default ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I think we can simply try to set a large UDP send buffer and ask the kernel to do any buffering by s […] @laforge@osmocom.org IIUC your proposal is to drop the iofd completelly and then apply the OSMO_SOCK_F_NONBLOCK creation flag based on "blocking-io" in VTY being present or not. I'm actually fine with the iofd approach, but if you prefer getting rid of it I guess it's fine too. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d8c953a5b467ce4396d2d20ca6fa72a749723c0 Gerrit-Change-Number: 41685 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Dec 2025 16:27:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-msc[master]: rtp_stream: drop use of codecs[] in struct mgcp_conn_peer
by falconia 16 Dec '25

16 Dec '25

falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/41678?usp=email ) Change subject: rtp_stream: drop use of codecs[] in struct mgcp_conn_peer ...................................................................... rtp_stream: drop use of codecs[] in struct mgcp_conn_peer struct mgcp_conn_peer in libosmo-mgcp-client API used to have a mandatory codecs[] array for codec specification and an optional ptmap[] array to be used only when the default payload type needs to be overridden. But now the codecs[] array is deprecated; the new way is to use ptmap[] to communicate both codecs and payload types. These .codecs[] and .codecs_len members in struct mgcp_conn_peer have been marked as deprecated (and the new way of using only ptmap[] became available as API) several release cycles ago, but osmo-msc kept filling out both arrays, leading to compilation warnings. Remove this use of deprecated API. Change-Id: I165be5c00bad3d293db2469ee4bedcbe968afcdc --- M src/libmsc/rtp_stream.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/rtp_stream.c b/src/libmsc/rtp_stream.c index eb9ba7e..14014c0 100644 --- a/src/libmsc/rtp_stream.c +++ b/src/libmsc/rtp_stream.c @@ -329,13 +329,11 @@ codec->subtype_name); continue; } - verb_info.codecs[i] = m->mgcp; verb_info.ptmap[i] = (struct ptmap){ .codec = m->mgcp, .pt = codec->payload_type, }; i++; - verb_info.codecs_len = i; verb_info.ptmap_len = i; } rtps->codecs_sent_to_mgw = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41678?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I165be5c00bad3d293db2469ee4bedcbe968afcdc Gerrit-Change-Number: 41678 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-tetra[master]: Fix preventing crashes when -d missing
by wbokslag 16 Dec '25

16 Dec '25

Attention is currently required from: pespin. wbokslag has posted comments on this change by wbokslag. ( https://gerrit.osmocom.org/c/osmo-tetra/+/41679?usp=email ) Change subject: Fix preventing crashes when -d missing ...................................................................... Patch Set 3: (1 comment) File src/lower_mac/tetra_lower_mac.c: https://gerrit.osmocom.org/c/osmo-tetra/+/41679/comment/48702c11_812e0919?u… : PS1, Line 198: if (tms->cur_burst.is_traffic && (type == TPSAP_T_SCH_F || (blk_num == BLK_2 && !tms->cur_burst.blk2_stolen)) && tms->dumpdir) { > It may also make sense to check tms->dumpdir first. Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/41679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I6a857f62aae542b054cbb474594359da626762bb Gerrit-Change-Number: 41679 Gerrit-PatchSet: 3 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Dec 2025 15:46:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-tetra[master]: Fix preventing crashes when -d missing
by wbokslag 16 Dec '25

16 Dec '25

Attention is currently required from: pespin. wbokslag has posted comments on this change by wbokslag. ( https://gerrit.osmocom.org/c/osmo-tetra/+/41679?usp=email ) Change subject: Fix preventing crashes when -d missing ...................................................................... Patch Set 3: (1 comment) File src/lower_mac/tetra_lower_mac.c: https://gerrit.osmocom.org/c/osmo-tetra/+/41679/comment/93f9fbfd_cd92ede5?u… : PS2, Line 199: tms->cur_burst.is_traffic && > wrong indentation, please align with previous line condition. Thanks for the quick review. I was a bit too fast with the second patch set, should be fixed now. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/41679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I6a857f62aae542b054cbb474594359da626762bb Gerrit-Change-Number: 41679 Gerrit-PatchSet: 3 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Dec 2025 15:45:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-tetra[master]: Added example keyfile
by wbokslag 16 Dec '25

16 Dec '25

Attention is currently required from: wbokslag. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-tetra/+/41682?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: Added example keyfile ...................................................................... Added example keyfile Added an example keyfile that people can use when trying to decrypt TEA-encrypted traffic. Note that a legitimate 80-bit key is needed. This is not a cracking tool. Change-Id: I7e13dcd10546e118e2cf9845f14121862db0cca9 --- A src/example_keyfile.txt 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/82/41682/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/41682?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I7e13dcd10546e118e2cf9845f14121862db0cca9 Gerrit-Change-Number: 41682 Gerrit-PatchSet: 3 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl>

1 0

[XS] Change in osmo-tetra[master]: Small bugfix in SYSINFO parsing
by wbokslag 16 Dec '25

16 Dec '25

Attention is currently required from: wbokslag. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-tetra/+/41680?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: Small bugfix in SYSINFO parsing ...................................................................... Small bugfix in SYSINFO parsing Small bugfix. We now increases the position in the SYSINFO read buffer when parsing hyperframe or cck number. Change-Id: Ic35f5106c096a7a3dd0d2302ad53fa00c69ab76d --- M src/tetra_mac_pdu.c 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/80/41680/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/41680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: Ic35f5106c096a7a3dd0d2302ad53fa00c69ab76d Gerrit-Change-Number: 41680 Gerrit-PatchSet: 3 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl>

1 0