Attention is currently required from: laforge.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email )
Change subject: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
> ping? Do we move initialization to the lchan activation or not? If not, we can proceed merging this
Let's merge the fix as-is, we can always improve and move things around later...
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I83f26ff06cebdfe8d4e75944f496e9678310e2a2
Gerrit-Change-Number: 39829
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 16 Dec 2025 19:51:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: laforge.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email )
Change subject: fixup: rsl: properly initialize MS/BS Power Control state
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
> ping? Do we move initialization to the lchan activation or not? If not, we can proceed merging this
The initialization was done here before this patch (and even before `75162427`), so I prefer merging this patchset as-is. We can move the initialization/cleanup of all parameters (not only the MS/BS Power Control ones) to `gsm_lchan_release()` in a separate patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I46c881d5a3959c2542610ed767e0f131d01f9f98
Gerrit-Change-Number: 39830
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 16 Dec 2025 19:50:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41694?usp=email )
Change subject: trx_toolkit: UDPLink: catch and ignore BlockingIOError
......................................................................
trx_toolkit: UDPLink: catch and ignore BlockingIOError
We should not crash when failing to send a datagram due to blocking.
Print an error, drop the data, and keep going.
Change-Id: If2248d4a670f893848c44e0fcbd2089371532207
Related: OS#6904
---
M src/target/trx_toolkit/udp_link.py
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/94/41694/1
diff --git a/src/target/trx_toolkit/udp_link.py b/src/target/trx_toolkit/udp_link.py
index 4db7283..f0a8224 100644
--- a/src/target/trx_toolkit/udp_link.py
+++ b/src/target/trx_toolkit/udp_link.py
@@ -17,6 +17,7 @@
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
+import logging as log
import socket
class UDPLink:
@@ -45,5 +46,10 @@
def sendto(self, data, remote):
if type(data) not in [bytearray, bytes]:
data = data.encode()
-
- self.sock.sendto(data, remote)
+ try:
+ self.sock.sendto(data, remote)
+ except BlockingIOError:
+ # When the message does not fit into the send buffer of the socket, send()
+ # normally blocks, unless the socket has been placed in nonblocking I/O mode.
+ # In nonblocking mode it would fail with the BlockingIOError in this case.
+ log.error('(%s) BlockingIOError: dropping Tx data', self.desc_link())
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41694?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: If2248d4a670f893848c44e0fcbd2089371532207
Gerrit-Change-Number: 41694
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: laforge.
fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41691?usp=email )
Change subject: esim.saip.data_source: Different source of data for personalization
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41691?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia6f70ff467ba58024d94742ba5cecd8141b93ad6
Gerrit-Change-Number: 41691
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 16 Dec 2025 17:13:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter, laforge, neels.
fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41690?usp=email )
Change subject: pySim.esim.saip.personalization: Support Milenage customization
......................................................................
Patch Set 1:
(2 comments)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/41690/comment/2c5a228f_bf8463e4?usp=em… :
PS1, Line 331: raise('Length of value must be 5 octets')
Raise an exception, not a string (linter).
https://gerrit.osmocom.org/c/pysim/+/41690/comment/7b8eba9e_e28ba023?usp=em… :
PS1, Line 340: raise('Length of value must be 80 octets')
Raise an exception, not a string (linter).
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41690?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I397df6c0c708a8061e4adc0fde03a3f746bcb5b6
Gerrit-Change-Number: 41690
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Dec 2025 17:07:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No