December 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bts[master]: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC
by fixeria 16 Dec '25

16 Dec '25

Attention is currently required from: laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email ) Change subject: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > ping? Do we move initialization to the lchan activation or not? If not, we can proceed merging this Let's merge the fix as-is, we can always improve and move things around later... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I83f26ff06cebdfe8d4e75944f496e9678310e2a2 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 16 Dec 2025 19:51:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-bts[master]: fixup: rsl: properly initialize MS/BS Power Control state
by fixeria 16 Dec '25

16 Dec '25

Attention is currently required from: laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email ) Change subject: fixup: rsl: properly initialize MS/BS Power Control state ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > ping? Do we move initialization to the lchan activation or not? If not, we can proceed merging this The initialization was done here before this patch (and even before `75162427`), so I prefer merging this patchset as-is. We can move the initialization/cleanup of all parameters (not only the MS/BS Power Control ones) to `gsm_lchan_release()` in a separate patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c881d5a3959c2542610ed767e0f131d01f9f98 Gerrit-Change-Number: 39830 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 16 Dec 2025 19:50:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: document the default FDMA/TDMA configuration
by fixeria 16 Dec '25

16 Dec '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41696?usp=email ) Change subject: bts: document the default FDMA/TDMA configuration ...................................................................... bts: document the default FDMA/TDMA configuration Change-Id: I988f783c1e91c916982609c0f30088b00d00674e --- M bts/BTS_Tests.default 1 file changed, 32 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/41696/1 diff --git a/bts/BTS_Tests.default b/bts/BTS_Tests.default index 9f89ed5..91fea67 100644 --- a/bts/BTS_Tests.default +++ b/bts/BTS_Tests.default @@ -31,7 +31,38 @@ Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoBTS"; PCUIF_Types.mp_pcuif_version := 12; -# Configuration for each individual transceiver +/* This is the default (non-hopping) configuration, matching osmo-bsc.cfg. + * + * == Physical channel configuration (FDMA) == + * + * +-------+------------------+------------------+------------------+------------------+ + * | # / # | TRX#0 | TRX#1 | TRX#2 | TRX#3 | + * +-------+------------------+------------------+------------------+------------------+ + * | ARFCN | 871 | 873 | 875 | 877 | + * +-------+------------------+------------------+------------------+------------------+ + * + * == Physical channel configuration (TDMA) == + * + * +-------+------------------+------------------+------------------+------------------+ + * | # / # | TRX#0 | TRX#1 | TRX#2 | TRX#3 | + * +-------+------------------+------------------+------------------+------------------+ + * | TS0 | CCCH+SDCCH4 | TCH/F | TCH/H | PDCH | + * +-------+------------------+------------------+------------------+------------------+ + * | TS1 | TCH/F | SDCCH8 | PDCH | TCH/H | + * +-------+------------------+------------------+------------------+------------------+ + * | TS2 | TCH/F | PDCH | SDCCH8 | TCH/H | + * +-------+------------------+------------------+------------------+------------------+ + * | TS3 | TCH/F_PDCH | TCH/F_TCH/H_PDCH | PDCH | SDCCH8 | + * +-------+------------------+------------------+------------------+------------------+ + * | TS4 | TCH/F_TCH/H_PDCH | TCH/F_PDCH | SDCCH8 | PDCH | + * +-------+------------------+------------------+------------------+------------------+ + * | TS5 | TCH/H | SDCCH8 | TCH/F | TCH/F | + * +-------+------------------+------------------+------------------+------------------+ + * | TS6 | SDCCH8 | PDCH | PDCH | PDCH | + * +-------+------------------+------------------+------------------+------------------+ + * | TS7 | PDCH | PDCH | PDCH | SDCCH8 | + * +-------+------------------+------------------+------------------+------------------+ + */ BTS_Tests.mp_trx_pars := { { # TRX0 arfcn := 871, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41696?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I988f783c1e91c916982609c0f30088b00d00674e Gerrit-Change-Number: 41696 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: bts: properly set BTS_Tests.mp_trx_pars for hopping cfg
by fixeria 16 Dec '25

16 Dec '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41697?usp=email ) Change subject: bts: properly set BTS_Tests.mp_trx_pars for hopping cfg ...................................................................... bts: properly set BTS_Tests.mp_trx_pars for hopping cfg The pchan assignment is *different* for the hopping and non-hopping configurations, so let's override it in the BTS_Tests_FH.cfg. Change-Id: Ib8861c3eee5157436fb213da212f22477639883f --- M bts/BTS_Tests_FH.cfg 1 file changed, 55 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/41697/1 diff --git a/bts/BTS_Tests_FH.cfg b/bts/BTS_Tests_FH.cfg index 9adb812..f012ba0 100644 --- a/bts/BTS_Tests_FH.cfg +++ b/bts/BTS_Tests_FH.cfg @@ -4,6 +4,7 @@ [LOGGING] /* The following hopping configuration corresponds to osmo-bsc-fh.confmerge. * See https://gerrit.osmocom.org/c/docker-playground/+/19160/ for more details. + * NOTE: the pchan assignment is *different* from non-hopping configuration. * * == Physical channel configuration (FDMA) == * @@ -131,3 +132,57 @@ } } } +BTS_Tests.mp_trx_pars := { + { # TRX0 + arfcn := 871, + ts := { + { config := GSM_PCHAN_CCCH_SDCCH4 }, + { config := GSM_PCHAN_TCHF }, + { config := GSM_PCHAN_TCHF }, + { config := GSM_PCHAN_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH }, + { config := GSM_PCHAN_SDCCH8 }, + { config := GSM_PCHAN_PDCH } + } + }, + { # TRX1 + arfcn := 873, + ts := { + { config := GSM_PCHAN_TCHF }, + { config := GSM_PCHAN_SDCCH8 }, + { config := GSM_PCHAN_TCHH }, + { config := GSM_PCHAN_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH }, + { config := GSM_PCHAN_PDCH }, + { config := GSM_PCHAN_PDCH } + } + }, + { # TRX2 + arfcn := 875, + ts := { + { config := GSM_PCHAN_TCHF }, + { config := GSM_PCHAN_SDCCH8 }, + { config := GSM_PCHAN_TCHF }, + { config := GSM_PCHAN_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH }, + { config := GSM_PCHAN_PDCH }, + { config := GSM_PCHAN_PDCH } + } + }, + { # TRX3 + arfcn := 877, + ts := { + { config := GSM_PCHAN_TCHF }, + { config := GSM_PCHAN_SDCCH8 }, + { config := GSM_PCHAN_TCHH }, + { config := GSM_PCHAN_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH }, + { config := GSM_PCHAN_SDCCH8 }, + { config := GSM_PCHAN_PDCH } + } + } +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41697?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8861c3eee5157436fb213da212f22477639883f Gerrit-Change-Number: 41697 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: fix pchan config in default mp_trx_pars[]
by fixeria 16 Dec '25

16 Dec '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41695?usp=email ) Change subject: bts: fix pchan config in default mp_trx_pars[] ...................................................................... bts: fix pchan config in default mp_trx_pars[] The timeslot 3 of transceiver 2 is configured to PDCH in osmo-bsc.cfg, so the pchan config must be GSM_PCHAN_PDCH, not GSM_PCHAN_TCHF. Change-Id: I7de4e2796ca91e90f9261be8355e97e60a9cc13f Fixes: 42d8bd501 ("BTS_Tests: re-organize configuration of TRX/TS params") --- M bts/BTS_Tests.default 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/41695/1 diff --git a/bts/BTS_Tests.default b/bts/BTS_Tests.default index 578aa36..9f89ed5 100644 --- a/bts/BTS_Tests.default +++ b/bts/BTS_Tests.default @@ -65,7 +65,7 @@ { config := GSM_PCHAN_TCHH }, { config := GSM_PCHAN_PDCH }, { config := GSM_PCHAN_SDCCH8 }, - { config := GSM_PCHAN_TCHF }, + { config := GSM_PCHAN_PDCH }, { config := GSM_PCHAN_SDCCH8 }, { config := GSM_PCHAN_TCHF }, { config := GSM_PCHAN_PDCH }, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41695?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7de4e2796ca91e90f9261be8355e97e60a9cc13f Gerrit-Change-Number: 41695 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: trx_toolkit: UDPLink: catch and ignore BlockingIOError
by fixeria 16 Dec '25

16 Dec '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41694?usp=email ) Change subject: trx_toolkit: UDPLink: catch and ignore BlockingIOError ...................................................................... trx_toolkit: UDPLink: catch and ignore BlockingIOError We should not crash when failing to send a datagram due to blocking. Print an error, drop the data, and keep going. Change-Id: If2248d4a670f893848c44e0fcbd2089371532207 Related: OS#6904 --- M src/target/trx_toolkit/udp_link.py 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/94/41694/1 diff --git a/src/target/trx_toolkit/udp_link.py b/src/target/trx_toolkit/udp_link.py index 4db7283..f0a8224 100644 --- a/src/target/trx_toolkit/udp_link.py +++ b/src/target/trx_toolkit/udp_link.py @@ -17,6 +17,7 @@ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. +import logging as log import socket class UDPLink: @@ -45,5 +46,10 @@ def sendto(self, data, remote): if type(data) not in [bytearray, bytes]: data = data.encode() - - self.sock.sendto(data, remote) + try: + self.sock.sendto(data, remote) + except BlockingIOError: + # When the message does not fit into the send buffer of the socket, send() + # normally blocks, unless the socket has been placed in nonblocking I/O mode. + # In nonblocking mode it would fail with the BlockingIOError in this case. + log.error('(%s) BlockingIOError: dropping Tx data', self.desc_link()) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41694?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If2248d4a670f893848c44e0fcbd2089371532207 Gerrit-Change-Number: 41694 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: trx_toolkit: UDPLink: reduce code duplication
by fixeria 16 Dec '25

16 Dec '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41693?usp=email ) Change subject: trx_toolkit: UDPLink: reduce code duplication ...................................................................... trx_toolkit: UDPLink: reduce code duplication Change-Id: I84557e2eb2e603f21e6c4d136e022ae269ced62d --- M src/target/trx_toolkit/udp_link.py 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/93/41693/1 diff --git a/src/target/trx_toolkit/udp_link.py b/src/target/trx_toolkit/udp_link.py index c3f1476..4db7283 100644 --- a/src/target/trx_toolkit/udp_link.py +++ b/src/target/trx_toolkit/udp_link.py @@ -40,10 +40,7 @@ % (bind_addr, bind_port, self.remote_addr, self.remote_port) def send(self, data): - if type(data) not in [bytearray, bytes]: - data = data.encode() - - self.sock.sendto(data, (self.remote_addr, self.remote_port)) + self.sendto(data, (self.remote_addr, self.remote_port)) def sendto(self, data, remote): if type(data) not in [bytearray, bytes]: -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41693?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I84557e2eb2e603f21e6c4d136e022ae269ced62d Gerrit-Change-Number: 41693 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: library/NGAP_Templates: PDUSessionResourceSetupRequest: Fix criticali...
by pespin 16 Dec '25

16 Dec '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41692?usp=email ) Change subject: library/NGAP_Templates: PDUSessionResourceSetupRequest: Fix criticality of SetupList IE ...................................................................... library/NGAP_Templates: PDUSessionResourceSetupRequest: Fix criticality of SetupList IE 3GPP TS 38.413 version 18.5.0 Release 18 describes id-PDUSessionResourceSetupListSUReq in PDUSessionResourceSetupRequestIEs as "reject", and open5gs si sending tu us accordinginly. Related: SYS#7073 Change-Id: I727876facc2c019b6a83335faf361a5d2e12fb10 --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/41692/1 diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index 8748d0f..1910120 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -130,7 +130,7 @@ }, { id := id_PDUSessionResourceSetupListSUReq, - criticality := ignore, + criticality := reject, value_ := { PDUSessionResourceSetupListSUReq := p_pDUSessionResourceSetupListSUReq } } } @@ -167,7 +167,7 @@ }, { id := id_PDUSessionResourceSetupListSUReq, - criticality := ignore, + criticality := reject, value_ := { PDUSessionResourceSetupListSUReq := p_pDUSessionResourceSetupListSUReq } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I727876facc2c019b6a83335faf361a5d2e12fb10 Gerrit-Change-Number: 41692 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in pysim[master]: esim.saip.data_source: Different source of data for personalization
by fixeria 16 Dec '25

16 Dec '25

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41691?usp=email ) Change subject: esim.saip.data_source: Different source of data for personalization ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia6f70ff467ba58024d94742ba5cecd8141b93ad6 Gerrit-Change-Number: 41691 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 16 Dec 2025 17:13:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim.esim.saip.personalization: Support Milenage customization
by fixeria 16 Dec '25

16 Dec '25

Attention is currently required from: dexter, laforge, neels. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41690?usp=email ) Change subject: pySim.esim.saip.personalization: Support Milenage customization ...................................................................... Patch Set 1: (2 comments) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/41690/comment/2c5a228f_bf8463e4?usp=em… : PS1, Line 331: raise('Length of value must be 5 octets') Raise an exception, not a string (linter). https://gerrit.osmocom.org/c/pysim/+/41690/comment/7b8eba9e_e28ba023?usp=em… : PS1, Line 340: raise('Length of value must be 80 octets') Raise an exception, not a string (linter). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I397df6c0c708a8061e4adc0fde03a3f746bcb5b6 Gerrit-Change-Number: 41690 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Dec 2025 17:07:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0