November 2025 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo-s1gw[master]: [REST] OpenAPI: fix regexp to permit IPv6 addr in EnbId
by fixeria 06 Nov '25

06 Nov '25

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41298?usp=email ) Change subject: [REST] OpenAPI: fix regexp to permit IPv6 addr in EnbId ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File contrib/openapi.yaml: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41298/comment/9d1a4b94_e1a0… : PS1, Line 195: pattern: '^enb-conn:[0-9a-f:.]+-[0-9]+$' > Yes, a proper/complete regexp for IPv4v6 would be huge. […] Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I112283b140a070924d59935a3bdd6fd63fc8c7ea Gerrit-Change-Number: 41298 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 07:34:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-epdg[master]: aaa_diameter_swx: Avoid answering RTR with Success if already deregis...
by osmith 06 Nov '25

06 Nov '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41303?usp=email ) Change subject: aaa_diameter_swx: Avoid answering RTR with Success if already deregistering ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I0ed13e9503ec380ce4331c662ca3eb966ccbda92 Gerrit-Change-Number: 41303 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 07:28:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Revert "epdg: add sleep to f_TC_hss_initiated_deregister_permanent_te...
by osmith 06 Nov '25

06 Nov '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41304?usp=email ) Change subject: Revert "epdg: add sleep to f_TC_hss_initiated_deregister_permanent_termination" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I900394cb02c1ff7ea85aaba6ef29a64fd84f679c Gerrit-Change-Number: 41304 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 07:17:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-epdg[master]: cosmetic: Fix typo in code documentation
by osmith 06 Nov '25

06 Nov '25

Attention is currently required from: laforge, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41301?usp=email ) Change subject: cosmetic: Fix typo in code documentation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I41da3bcc3b5f982901baa8162d7fd55f35d70485 Gerrit-Change-Number: 41301 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 06 Nov 2025 07:11:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: ipa: fix a minor memleak for unknown IPA packets
by pespin 05 Nov '25

05 Nov '25

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41306?usp=email ) Change subject: ipa: fix a minor memleak for unknown IPA packets ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41306?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idb77d3d7dc9db1076b110fb4d17c951b161e77e2 Gerrit-Change-Number: 41306 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 05 Nov 2025 17:14:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: ipa: fix a minor memleak for unknown IPA packets
by lynxis lazus 05 Nov '25

05 Nov '25

Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41306?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin Change subject: ipa: fix a minor memleak for unknown IPA packets ...................................................................... ipa: fix a minor memleak for unknown IPA packets When the IPA protocol is unknown, the msg isn't freed. Change-Id: Idb77d3d7dc9db1076b110fb4d17c951b161e77e2 --- M src/ipa.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/06/41306/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41306?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idb77d3d7dc9db1076b110fb4d17c951b161e77e2 Gerrit-Change-Number: 41306 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmo-sigtran[master]: ipa: fix a minor memleak for unknown IPA packets
by pespin 05 Nov '25

05 Nov '25

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41306?usp=email ) Change subject: ipa: fix a minor memleak for unknown IPA packets ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: FYI I find it handy when doing this kind of "inspecting ownership" to fill in the documentation of the function information explicitly staitng whether the msg ownsership is transferred to the function or kept by the caller. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41306?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idb77d3d7dc9db1076b110fb4d17c951b161e77e2 Gerrit-Change-Number: 41306 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 05 Nov 2025 16:56:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: ipa: fix a minor memleak when receiving invalid IPA CCM messages
by pespin 05 Nov '25

05 Nov '25

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41305?usp=email ) Change subject: ipa: fix a minor memleak when receiving invalid IPA CCM messages ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41305?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1b828c16350d10398810e60acbb35663f215c63f Gerrit-Change-Number: 41305 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 05 Nov 2025 16:54:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: ipa: fix a minor memleak for unknown IPA packets
by lynxis lazus 05 Nov '25

05 Nov '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41306?usp=email ) Change subject: ipa: fix a minor memleak for unknown IPA packets ...................................................................... ipa: fix a minor memleak for unknown IPA packets When the IPA protocol is unknown, the msg isn't freed. Change-Id: Ia7ab67a836ec139ef6ac3b900685335a8849c921 Change-Id: Idb77d3d7dc9db1076b110fb4d17c951b161e77e2 --- M src/ipa.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/06/41306/1 diff --git a/src/ipa.c b/src/ipa.c index 6c661a9..3b2b6da 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -355,6 +355,7 @@ break; default: rc = ss7_asp_rx_unknown(asp, hh->proto, msg); + msgb_free(msg); } return rc; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41306?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idb77d3d7dc9db1076b110fb4d17c951b161e77e2 Gerrit-Change-Number: 41306 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmo-sigtran[master]: ipa: fix a minor memleak when receiving invalid IPA CCM messages
by lynxis lazus 05 Nov '25

05 Nov '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41305?usp=email ) Change subject: ipa: fix a minor memleak when receiving invalid IPA CCM messages ...................................................................... ipa: fix a minor memleak when receiving invalid IPA CCM messages Change-Id: I1b828c16350d10398810e60acbb35663f215c63f --- M src/ipa.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/05/41305/1 diff --git a/src/ipa.c b/src/ipa.c index 8035889..6c661a9 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -122,6 +122,7 @@ static int ipa_rx_msg_ccm(struct osmo_ss7_asp *asp, struct msgb *msg) { uint8_t msg_type = msg->l2h[0]; + int rc = 0; LOGPASP(asp, DLSS7, LOGL_DEBUG, "%s:%s\n", __func__, msgb_hexdump(msg)); @@ -145,12 +146,12 @@ default: LOGPASP(asp, DLSS7, LOGL_NOTICE, "Unknown CCM Message 0x%02x: %s\n", msg_type, msgb_hexdump(msg)); - return -1; + rc = -1; } msgb_free(msg); - return 0; + return rc; } struct osmo_ss7_as *ipa_find_as_for_asp(struct osmo_ss7_asp *asp) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41305?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1b828c16350d10398810e60acbb35663f215c63f Gerrit-Change-Number: 41305 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

2025

2024

2023

2022

gerrit-log November 2025