November 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: tests/osmo_io_test (io_uring): test_segmentation: Fix infinite loop i...
by laforge 05 Nov '25

05 Nov '25

Attention is currently required from: fixeria, jolly, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41297?usp=email ) Change subject: tests/osmo_io_test (io_uring): test_segmentation: Fix infinite loop in read_cb rc=0 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41297?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I47b5fff04c601cd08ab2d46b88336247b2193808 Gerrit-Change-Number: 41297 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Nov 2025 11:01:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: tests/osmo_io_test: test_segmentation: Use osmo_iofd_close() API
by laforge 05 Nov '25

05 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41299?usp=email ) Change subject: tests/osmo_io_test: test_segmentation: Use osmo_iofd_close() API ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41299?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id910bfb4e0965700e2d378a513a9bf889b929d44 Gerrit-Change-Number: 41299 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Nov 2025 11:00:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: io_uring: Avoid extra reads if iofd becomes unregistered by user
by pespin 05 Nov '25

05 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41300?usp=email ) Change subject: io_uring: Avoid extra reads if iofd becomes unregistered by user ...................................................................... io_uring: Avoid extra reads if iofd becomes unregistered by user The user callback (read_cb, segmentation_cb, etc.) may decide to unregister the iofd instead of closing it. In this scenario, we should avoid calling the callback further until the iofd is registered again. Change-Id: I231d5a16768b730f67089090c244bcc10dc69c3a --- M src/core/osmo_io_uring.c M tests/osmo_io/osmo_io_test.c 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/00/41300/1 diff --git a/src/core/osmo_io_uring.c b/src/core/osmo_io_uring.c index 01b8063..e4a87ad 100644 --- a/src/core/osmo_io_uring.c +++ b/src/core/osmo_io_uring.c @@ -359,7 +359,7 @@ } /* Check for every iteration, because iofd might get unregistered/closed during receive function. */ - if (iofd->u.uring.read.enabled && !IOFD_FLAG_ISSET(iofd, IOFD_FLAG_CLOSED)) + if (IOFD_FLAG_ISSET(iofd, IOFD_FLAG_FD_REGISTERED) && iofd->u.uring.read.enabled) iofd_handle_recv(iofd, msg, chunk, msghdr); else msgb_free(msg); @@ -372,7 +372,7 @@ msghdr->msg[idx] = NULL; } - if (iofd->u.uring.read.enabled && !IOFD_FLAG_ISSET(iofd, IOFD_FLAG_CLOSED)) + if (IOFD_FLAG_ISSET(iofd, IOFD_FLAG_FD_REGISTERED) && iofd->u.uring.read.enabled) iofd_uring_submit_recv(iofd, msghdr->action); iofd_msghdr_free(msghdr); diff --git a/tests/osmo_io/osmo_io_test.c b/tests/osmo_io/osmo_io_test.c index 0812ea8..06491a7 100644 --- a/tests/osmo_io/osmo_io_test.c +++ b/tests/osmo_io/osmo_io_test.c @@ -280,7 +280,7 @@ } else { OSMO_ASSERT(rc == 0); file_eof_read = true; - osmo_iofd_close(iofd); + osmo_iofd_unregister(iofd); } talloc_free(msg); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41300?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I231d5a16768b730f67089090c244bcc10dc69c3a Gerrit-Change-Number: 41300 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: tests/osmo_io_test: test_segmentation: Use osmo_iofd_close() API
by pespin 05 Nov '25

05 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41299?usp=email ) Change subject: tests/osmo_io_test: test_segmentation: Use osmo_iofd_close() API ...................................................................... tests/osmo_io_test: test_segmentation: Use osmo_iofd_close() API This is saner than doing osmo_iofd_unregister() + manual close(). Change-Id: Id910bfb4e0965700e2d378a513a9bf889b929d44 --- M tests/osmo_io/osmo_io_test.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/99/41299/1 diff --git a/tests/osmo_io/osmo_io_test.c b/tests/osmo_io/osmo_io_test.c index d3e22aa..693c428 100644 --- a/tests/osmo_io/osmo_io_test.c +++ b/tests/osmo_io/osmo_io_test.c @@ -323,8 +323,7 @@ fflush(stdout); OSMO_ASSERT(file_bytes_write_compl == 12); - osmo_iofd_unregister(iofd); - close(fd[1]); + osmo_iofd_close(iofd); /* Now, re-configure iofd to only read from the pipe. * Reduce the read buffer size, to verify correct segmentation operation: */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41299?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id910bfb4e0965700e2d378a513a9bf889b929d44 Gerrit-Change-Number: 41299 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: tests/osmo_io_test (io_uring): test_segmentation: Fix infinite loop i...
by pespin 05 Nov '25

05 Nov '25

Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41297?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: tests/osmo_io_test (io_uring): test_segmentation: Fix infinite loop in read_cb rc=0 ...................................................................... tests/osmo_io_test (io_uring): test_segmentation: Fix infinite loop in read_cb rc=0 Under linux 6.17.6-arch1-1 & liburing 2.12-1, once we finish reading from the pipe (rc=0) because the write peer was closed and data has been consumed, we end up in some sort of infinite loop in the uring due to re-adding a sqe in iofd_uring_handle_recv()->iofd_uring_submit_recv() path and immediatelly consuming a cqe from the uring, without going through the poll() loop. The user is expected to close the fd once rc=0 is received anyway, which was not being done in this test. Doing so successfully unregisters the iofd and fixes the infinite loop. Fixes: 086ee51de416ae5276b4b185c055831e16c0ef85 Change-Id: I47b5fff04c601cd08ab2d46b88336247b2193808 --- M tests/osmo_io/osmo_io_test.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/97/41297/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41297?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I47b5fff04c601cd08ab2d46b88336247b2193808 Gerrit-Change-Number: 41297 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: [REST] OpenAPI: fix regexp to permit IPv6 addr in EnbId
by fixeria 05 Nov '25

05 Nov '25

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41298?usp=email ) Change subject: [REST] OpenAPI: fix regexp to permit IPv6 addr in EnbId ...................................................................... Patch Set 1: (1 comment) File contrib/openapi.yaml: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41298/comment/b14734d3_ea8a… : PS1, Line 195: pattern: '^enb-conn:[0-9a-f:.]+-[0-9]+$' > I'm not a regexp by any means, but apparently matching a n IP address is a bit more complex? […] Yes, a proper/complete regexp for IPv4v6 would be huge. But we don't really need this level of complexity here: we don't care if the address is 100% correct. We simply match the prefix and enforce basic data format (`addr-port`) for this variant of `EnbId`. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I112283b140a070924d59935a3bdd6fd63fc8c7ea Gerrit-Change-Number: 41298 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Nov 2025 09:25:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: [REST] OpenAPI: fix regexp to permit IPv6 addr in EnbId
by pespin 05 Nov '25

05 Nov '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41298?usp=email ) Change subject: [REST] OpenAPI: fix regexp to permit IPv6 addr in EnbId ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File contrib/openapi.yaml: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41298/comment/ba6903cf_b028… : PS1, Line 195: pattern: '^enb-conn:[0-9a-f:.]+-[0-9]+$' I'm not a regexp by any means, but apparently matching a n IP address is a bit more complex? https://www.ditig.com/validating-ipv4-and-ipv6-addresses-with-regexp#combin… https://regex101.com/r/tF7zQ1/1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I112283b140a070924d59935a3bdd6fd63fc8c7ea Gerrit-Change-Number: 41298 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Nov 2025 09:17:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo-release: debian_patch_apply: handle empty dir
by osmith 05 Nov '25

05 Nov '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41296?usp=email ) Change subject: osmo-release: debian_patch_apply: handle empty dir ...................................................................... osmo-release: debian_patch_apply: handle empty dir Don't fail with the following bogus error message if the debian/patches directory exists but is empty: error: can't open patch '…/git/libosmocore/debian/patches/*.patch': No such file or directory Fixes: OS#6873 Change-Id: I6656602c58fd221c8bb933890712d1392a1dfdab --- M osmo-release.sh 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/osmo-release.sh b/osmo-release.sh index 14790da..5a9584c 100755 --- a/osmo-release.sh +++ b/osmo-release.sh @@ -151,10 +151,10 @@ # Make sure that patches under debian/patches/ apply: check_debian_patch_apply() { - if [ ! -d "${GIT_TOPDIR}/debian/patches" ]; then - return - fi for patch in ${GIT_TOPDIR}/debian/patches/*.patch; do + if ! [ -e "$patch" ]; then + continue + fi git apply --check $patch if [ $? -ne 0 ]; then error "patch no longer applies! $patch" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41296?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6656602c58fd221c8bb933890712d1392a1dfdab Gerrit-Change-Number: 41296 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo-release: debian_patch_apply: handle empty dir
by pespin 05 Nov '25

05 Nov '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/41296?usp=email ) Change subject: osmo-release: debian_patch_apply: handle empty dir ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41296?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6656602c58fd221c8bb933890712d1392a1dfdab Gerrit-Change-Number: 41296 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Nov 2025 09:12:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-msc[master]: SMS UX optimisation: Deliver rx'd SMS right away
by keith 04 Nov '25

04 Nov '25

Attention is currently required from: pespin. keith has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-msc/+/28342?usp=email ) Change subject: SMS UX optimisation: Deliver rx'd SMS right away ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I'm not sure I'm fully following you tbh, because from your previous (full) comment afaict you seem […] My dear Pau, The comparison with UDP ordering is somewhat absurd. 😊 About the ordering/disordering.. have you ever really, actually, you know, as a human being, noticed that one SMS arrived (what are we talking here.. max 1 second, 2?) before another? I would imagine more likely you got some notification of SMS and by the time you looked at the SMS, you see them in order of timestamp. I'm looking at this from a humanitarian, and you're looking at it from a somewhat staunch technical POV. In the real world, one might expect that a message I just sent is more relevant than the one I sent two weeks (or months) ago. But look - I don't CARE! We can do what you suggest, for sure. The chances of running into the situation where a just sent SMS provokes the sending of an older, and only that older SMS is highly unlikely, well I outlined a remote possibility for it above, but whatever... It is very unlikely to negatively affect the human experience of it. Anyway, I'm expending energy here now that is limited, so I may or may not get around to doing...what I suggested above - RX of SMS triggers queue to THAT recipient, and that recipient only, in order, by date, id, whatever (actually number of failed retries, IIRC is the current criteria) In my real world experience of the real world problem of real world people who send real world SMS, your solution will also suffice, as I have not actually observed a situation where the situation you described occurred, because; with this patch in place, the first message was ALREADY DELIVERED, damn it. And if it wasn't, then this new message isn't going to be either. I've been running this patch for a long time now, and it works.. you know.. in the real world 😊 I thought it might be an idea to have it in for congress... but yeah.. limited motivation.. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28342?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c Gerrit-Change-Number: 28342 Gerrit-PatchSet: 4 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Nov 2025 19:20:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: keith <keith(a)rhizomatica.org>

1 0

2025

2024

2023

2022

gerrit-log November 2025