January 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: stp: set up all M3UA ports in array in steps

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39299?usp=email ) Change subject: stp: set up all M3UA ports in array in steps ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39299?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I585d9c768301bfd9ba849876923787137fc35981 Gerrit-Change-Number: 39299 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:30:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Improve failure teardown using Misc_Helpers.f_shutdown

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39298?usp=email ) Change subject: stp: Improve failure teardown using Misc_Helpers.f_shutdown ...................................................................... stp: Improve failure teardown using Misc_Helpers.f_shutdown Change-Id: I776bc32b1bdb52d7e90102c4ab6ff7b0ef7a12c6 --- M stp/STP_Tests_M3UA.ttcn 1 file changed, 18 insertions(+), 24 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 2cac7cc..52cbf7d 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -133,16 +133,14 @@ private function f_m3ua_cli_config(integer idx) return M3uaConfig { if (idx < 0 or idx >= NR_M3UA) { - setverdict(fail, "f_m3ua_cli_config(): unexpected idx"); - Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "f_m3ua_cli_config(): unexpected idx"); } return mp_m3ua_configs[idx]; } private function f_m3ua_srv_config(integer idx) return M3uaConfig { if (idx < 0 or idx >= NR_M3UA_SRV) { - setverdict(fail, "f_m3ua_srv_config(): unexpected idx"); - Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "f_m3ua_srv_config(): unexpected idx"); } return mp_m3ua_configs[M3UA_SRV(idx)]; } @@ -188,13 +186,13 @@ setverdict(pass); } [] M3UA[idx].receive(t_M3UA_RecvFrom(?)) -> value rx { - setverdict(fail, "Received unexpected M3UA[", idx, "] ", rx, - "while waiting for ", msg); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Received unexpected M3UA[", idx, "] ", rx, + "while waiting for ", msg)); } [] T.timeout { - setverdict(fail, "Timeout waiting for M3UA[", idx, "] ", msg); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Timeout waiting for M3UA[", idx, "] ", msg)); } } } @@ -237,9 +235,9 @@ var M3uaConfig m3cfg := mp_m3ua_configs[i]; if (lengthof(mp_local_m3ua_ip) == 0 or lengthof(mp_stp_m3ua_ip) == 0) { - setverdict(fail, "Empty local or remote address trying to connect SCTP socket: ", - mp_local_m3ua_ip, " / ", mp_stp_m3ua_ip); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Empty local or remote address trying to connect SCTP socket: ", + mp_local_m3ua_ip, " / ", mp_stp_m3ua_ip)); } if (lengthof(mp_local_m3ua_ip) > 1) { @@ -262,8 +260,7 @@ {sctp:=valueof(ts_SCTP(3, 0, opt_add_remote_addrs))}, opt_list); if (not ispresent(res.connId)) { - setverdict(fail, "Could not connect M3UA socket, check your configuration"); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Could not connect M3UA socket, check your configuration"); } g_m3ua_conn_id[i] := res.connId; } @@ -273,17 +270,16 @@ var Result res; if (lengthof(mp_local_m3ua_ip) == 0 or lengthof(mp_stp_m3ua_ip) == 0) { - setverdict(fail, "Empty local or remote address trying to connect TCP socket: ", - mp_local_m3ua_ip, " / ", mp_stp_m3ua_ip); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Empty local or remote address trying to connect TCP socket: ", + mp_local_m3ua_ip, " / ", mp_stp_m3ua_ip)); } res := M3UA_CodecPort_CtrlFunct.f_IPL4_connect(M3UA[i], mp_stp_m3ua_ip[0], m3cfg.remote_port, mp_local_m3ua_ip[0], m3cfg.local_port, 0, {tcp:={}}); if (not ispresent(res.connId)) { - setverdict(fail, "Could not connect M3UA socket, check your configuration"); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Could not connect M3UA socket, check your configuration"); } g_m3ua_conn_id[i] := res.connId; M3UA_CodecPort.f_set_tcp_segmentation(M3UA[i], res.connId); @@ -311,9 +307,8 @@ var M3uaConfig m3cfg := mp_m3ua_configs[i]; if (lengthof(mp_local_m3ua_ip) == 0 ) { - setverdict(fail, "Empty local address trying to bind SCTP socket: ", - mp_local_m3ua_ip); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Empty local address trying to bind SCTP socket: ", mp_local_m3ua_ip)); } if (lengthof(mp_local_m3ua_ip) > 1) { @@ -330,8 +325,7 @@ {sctp:=valueof(ts_SCTP)}, opt_list); } if (not ispresent(res.connId)) { - setverdict(fail, "Could not bind M3UA socket, check your configuration"); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Could not bind M3UA socket, check your configuration"); } if (m3cfg.use_tcp) { M3UA_CodecPort.f_set_tcp_segmentation(M3UA[i], res.connId); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I776bc32b1bdb52d7e90102c4ab6ff7b0ef7a12c6 Gerrit-Change-Number: 39298 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Improve failure teardown using Misc_Helpers.f_shutdown

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39298?usp=email ) Change subject: stp: Improve failure teardown using Misc_Helpers.f_shutdown ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I776bc32b1bdb52d7e90102c4ab6ff7b0ef7a12c6 Gerrit-Change-Number: 39298 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:30:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[M] Change in osmo-pcap[master]: server: Use osmo_stream_srv_link on tcp listen socket

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39324?usp=email ) Change subject: server: Use osmo_stream_srv_link on tcp listen socket ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I3562185f98685ea5a412273212e6dfbe55b360e2 Gerrit-Change-Number: 39324 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:26:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in osmo-pcap[master]: server: Log unable to figure out pcap vs pcapng

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39326?usp=email ) Change subject: server: Log unable to figure out pcap vs pcapng ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: one might maybe add a hexdump of the first N bytes of such a packet? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39326?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I110456f142cab88ba9d51409b66d66cf093adb9f Gerrit-Change-Number: 39326 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:26:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[M] Change in osmo-pcap[master]: server: Split buffer read from full msg handling

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39323?usp=email ) Change subject: server: Split buffer read from full msg handling ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39323?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ie7b8af0edbccc83812a44c6bfd61c98fbc3df324 Gerrit-Change-Number: 39323 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:25:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[S] Change in osmo-pcap[master]: server: Add osmo_pcap_server_free() for completeness

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39322?usp=email ) Change subject: server: Add osmo_pcap_server_free() for completeness ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39322?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I2606390fc9d9b8a2335c96688d83a038ba73f8ab Gerrit-Change-Number: 39322 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:25:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in osmo-pcap[master]: server: Move conn->file_hdr release to osmo_pcap_conn_close()

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39314?usp=email ) Change subject: server: Move conn->file_hdr release to osmo_pcap_conn_close() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39314?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ib822a0544b7a487614df28214813f31234eb6a0f Gerrit-Change-Number: 39314 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:25:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in osmo-pcap[master]: cosmetic: server: Fix formatting of return in main()

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39313?usp=email ) Change subject: cosmetic: server: Fix formatting of return in main() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39313?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I70af88cd62258f6b6de71d5ba9d8c29699c96f68 Gerrit-Change-Number: 39313 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:25:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in osmo-pcap[master]: tests: Remove unneeded .o files after osmo-pcap-server network/core f...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39311?usp=email ) Change subject: tests: Remove unneeded .o files after osmo-pcap-server network/core file split ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I8c90d986c5ca60cc3c1083dc0c643d66044dc40e Gerrit-Change-Number: 39311 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:24:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025