January 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: jobs/master-builds: add ot290-gsmtap

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39334?usp=email ) Change subject: jobs/master-builds: add ot290-gsmtap ...................................................................... jobs/master-builds: add ot290-gsmtap This job didn't have a jenkins job builder config yet and ran without docker on label=osmocom-master-debian10, which we are removing. Related: https://jenkins.osmocom.org/jenkins/job/master-ot290-gsmtap/ Related: OS#6186 Change-Id: Iec1a07896dc2817f7671463ddba438b727f41b5d --- M jobs/master-builds.yml 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/34/39334/1 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index dce4849..30d9e4d 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -433,6 +433,11 @@ - osmo-python-tests: repos_url: '{gerrit_url}/python/{repos}' + - ot290-gsmtap: + repos_url: '{gitea_url}/phone-side/{repos}' + cmd: '{docker_run_ccache} {docker_img} {timeout_cmd} make -C /build/src' + email: '' + - pyosmocom: repos_url: '{gerrit_url}/python/{repos}' concurrent: false -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39334?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iec1a07896dc2817f7671463ddba438b727f41b5d Gerrit-Change-Number: 39334 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in osmo-e1d[master]: Avoid segfault during 'show octoi-clients' VTY command

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/39226?usp=email ) Change subject: Avoid segfault during 'show octoi-clients' VTY command ...................................................................... Avoid segfault during 'show octoi-clients' VTY command There might be a client without an octoi_sock, so we cannot unconditionally try to use it for printing information. Closes: OS#6662 Change-Id: I4a35087db6dc970f9ce9605853daab653279c5b0 --- M src/octoi/octoi_clnt_vty.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: tnt: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/octoi/octoi_clnt_vty.c b/src/octoi/octoi_clnt_vty.c index afca60c..3ea3a9a 100644 --- a/src/octoi/octoi_clnt_vty.c +++ b/src/octoi/octoi_clnt_vty.c @@ -243,7 +243,8 @@ struct octoi_sock *sock = clnt->sock; octoi_vty_show_one_account(vty, "", clnt->cfg.account); - vty_show_octoi_sock(vty, sock); + if (sock) + vty_show_octoi_sock(vty, sock); } return CMD_SUCCESS; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/39226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4a35087db6dc970f9ce9605853daab653279c5b0 Gerrit-Change-Number: 39226 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com>

5 months, 1 week

1
0
0 0

[XS] Change in osmo-e1d[master]: Avoid segfault during 'show octoi-clients' VTY command

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-e1d/+/39226?usp=email ) Change subject: Avoid segfault during 'show octoi-clients' VTY command ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/39226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4a35087db6dc970f9ce9605853daab653279c5b0 Gerrit-Change-Number: 39226 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:37:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[S] Change in pysim[master]: cards: Avoid exception seen with (some) GSM-R SIM cards

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/39292?usp=email ) Change subject: cards: Avoid exception seen with (some) GSM-R SIM cards ...................................................................... cards: Avoid exception seen with (some) GSM-R SIM cards Some old cards are classic SIM and not based on UICCs. Such cards do not offer the capability of selecting applications. Let's avoid running into an exception by providing dummy methods that simply fail for each AID selection. Change-Id: Ib3457496380c0c5096052ad7799970ee620dee33 Closes: OS#6691 --- M pySim/cards.py 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved dexter: Looks good to me, but someone else must approve diff --git a/pySim/cards.py b/pySim/cards.py index b7958f4..dedb2d6 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -73,6 +73,16 @@ # callers having to do hasattr('read_aids') ahead of every call. return [] + def adf_present(self, adf: str = "usim") -> bool: + # a non-UICC doesn't have any applications. Convenience helper to avoid + # callers having to do hasattr('adf_present') ahead of every call. + return False + + def select_adf_by_aid(self, adf: str = "usim", scc: Optional[SimCardCommands] = None) -> Tuple[Optional[Hexstr], Optional[SwHexstr]]: + # a non-UICC doesn't have any applications. Convenience helper to avoid + # callers having to do hasattr('select_adf_by_aid') ahead of every call. + return (None, None) + class SimCardBase(CardBase): """Here we only add methods for commands specified in TS 51.011, without -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39292?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib3457496380c0c5096052ad7799970ee620dee33 Gerrit-Change-Number: 39292 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

5 months, 1 week

1
0
0 0

[S] Change in pysim[master]: cards: Avoid exception seen with (some) GSM-R SIM cards

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/39292?usp=email ) Change subject: cards: Avoid exception seen with (some) GSM-R SIM cards ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39292?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib3457496380c0c5096052ad7799970ee620dee33 Gerrit-Change-Number: 39292 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:36:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[S] Change in osmo-gsm-manuals[master]: bibliography.adoc: add TW-TS-* references

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email ) Change subject: bibliography.adoc: add TW-TS-* references ...................................................................... bibliography.adoc: add TW-TS-* references Some Osmocom components include support for interfaces that are defined in Themyscira Wireless specs (TW-TS): * OsmoBTS includes support for TW-TS-001, may also support TW-TS-002 for HRv1 codec in the future; * OsmoBSC includes support for TW-TS-003 BSSMAP extension. Therefore, these specs should be linked from Osmocom bibliography. Change-Id: Ia34a61b5f834f2c70f81012dcc816dd6014c784f --- M common/chapters/bibliography.adoc 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/common/chapters/bibliography.adoc b/common/chapters/bibliography.adoc index 9d635b0..bebad30 100644 --- a/common/chapters/bibliography.adoc +++ b/common/chapters/bibliography.adoc @@ -227,3 +227,13 @@ License. https://www.gnu.org/licenses/agpl-3.0.en.html - [[[freeswitch_pbx]]] FreeSWITCH SIP PBX https://freeswitch.org + +- [[[tw-ts-001]]] TW-TS-001: Enhanced RTP transport of FR and EFR codec frames + in an IP-based GSM RAN + https://www.freecalypso.org/specs/tw-ts-001-v010100.txt +- [[[tw-ts-002]]] TW-TS-002: Enhanced RTP transport of HRv1 codec frames + in an IP-based GSM RAN + https://www.freecalypso.org/specs/tw-ts-002-v010100.txt +- [[[tw-ts-003]]] TW-TS-003: BSSMAP extension for selection of enhanced RTP + transport formats + https://www.freecalypso.org/specs/tw-ts-003-v010002.txt -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia34a61b5f834f2c70f81012dcc816dd6014c784f Gerrit-Change-Number: 39289 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[S] Change in osmo-gsm-manuals[master]: bibliography.adoc: add TW-TS-* references

by laforge

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email ) Change subject: bibliography.adoc: add TW-TS-* references ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia34a61b5f834f2c70f81012dcc816dd6014c784f Gerrit-Change-Number: 39289 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:36:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in libosmo-netif[master]: add dependency on libosmovty

by laforge

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39308?usp=email ) Change subject: add dependency on libosmovty ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I would suggest to merge this into the actual commit that makes use of libosmovty. So that change will work atomically as-is. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I57cb919891e5c7ee0f828b98af11199cd9c123f8 Gerrit-Change-Number: 39308 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:36:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: L3_Templates: add MM cause codes

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39264?usp=email ) Change subject: L3_Templates: add MM cause codes ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39264?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I396ddaf5b08faddcf002317307dcc20840898aa9 Gerrit-Change-Number: 39264 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:34:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: add testcases for PDP Context Status

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email ) Change subject: SGSN: add testcases for PDP Context Status ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5a29e667f53cc2834fbddd2c5dc901d3e6ae72c7 Gerrit-Change-Number: 39262 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:34:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025