January 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ci[master]: scripts/{manuals,tarballs}: skip old sigtran tags

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39358?usp=email ) Change subject: scripts/{manuals,tarballs}: skip old sigtran tags ...................................................................... scripts/{manuals,tarballs}: skip old sigtran tags After the old libosmo-sccp.git tags have been imported into libosmo-sigtran.git, they now need to be ignored in the manuals and release tarballs job. Related: OS#6683 Change-Id: Ia182f79ba3f0a80b98af3c1c77a1390f5d08ca93 --- M scripts/manuals/publish-manuals-for-tags.sh M scripts/tarballs/publish-tarballs-for-tags.sh 2 files changed, 60 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/58/39358/1 diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh index 77ad3d2..902019b 100755 --- a/scripts/manuals/publish-manuals-for-tags.sh +++ b/scripts/manuals/publish-manuals-for-tags.sh @@ -195,6 +195,36 @@ libosmo-sccp:1.1.0, libosmo-sccp:1.2.0, + libosmo-sigtran:0.0.1, + libosmo-sigtran:0.0.2, + libosmo-sigtran:0.0.3, + libosmo-sigtran:0.0.4, + libosmo-sigtran:0.0.5, + libosmo-sigtran:0.0.5.1, + libosmo-sigtran:0.0.6, + libosmo-sigtran:0.0.6.1, + libosmo-sigtran:0.0.6.2, + libosmo-sigtran:0.0.6.3, + libosmo-sigtran:0.10.0, + libosmo-sigtran:0.7.0, + libosmo-sigtran:0.8.0, + libosmo-sigtran:0.8.1, + libosmo-sigtran:0.9.0, + libosmo-sigtran:1.0.0, + libosmo-sigtran:1.1.0, + libosmo-sigtran:1.2.0, + libosmo-sigtran:1.2.1, + libosmo-sigtran:1.3.0, + libosmo-sigtran:1.4.0, + libosmo-sigtran:1.5.0, + libosmo-sigtran:1.6.0, + libosmo-sigtran:1.7.0, + libosmo-sigtran:1.7.1, + libosmo-sigtran:1.8.0, + libosmo-sigtran:1.8.1, + libosmo-sigtran:1.8.2, + libosmo-sigtran:1.9.0, + osmo-trx:0.2.0, osmo-trx:0.3.0, osmo-trx:0.4.0, diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh b/scripts/tarballs/publish-tarballs-for-tags.sh index 0335bd3..e4ca1c8 100755 --- a/scripts/tarballs/publish-tarballs-for-tags.sh +++ b/scripts/tarballs/publish-tarballs-for-tags.sh @@ -115,6 +115,36 @@ libosmo-sccp-legacy:2.0.0, libosmo-sccp-legacy:2.0.1, libosmo-sccp-legacy:2.0.2, + + libosmo-sigtran:0.0.1, + libosmo-sigtran:0.0.2, + libosmo-sigtran:0.0.3, + libosmo-sigtran:0.0.4, + libosmo-sigtran:0.0.5, + libosmo-sigtran:0.0.5.1, + libosmo-sigtran:0.0.6, + libosmo-sigtran:0.0.6.1, + libosmo-sigtran:0.0.6.2, + libosmo-sigtran:0.0.6.3, + libosmo-sigtran:0.10.0, + libosmo-sigtran:0.7.0, + libosmo-sigtran:0.8.0, + libosmo-sigtran:0.8.1, + libosmo-sigtran:0.9.0, + libosmo-sigtran:1.0.0, + libosmo-sigtran:1.1.0, + libosmo-sigtran:1.2.0, + libosmo-sigtran:1.2.1, + libosmo-sigtran:1.3.0, + libosmo-sigtran:1.4.0, + libosmo-sigtran:1.5.0, + libosmo-sigtran:1.6.0, + libosmo-sigtran:1.7.0, + libosmo-sigtran:1.7.1, + libosmo-sigtran:1.8.0, + libosmo-sigtran:1.8.1, + libosmo-sigtran:1.8.2, + libosmo-sigtran:1.9.0, " mkdir -p \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39358?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia182f79ba3f0a80b98af3c1c77a1390f5d08ca93 Gerrit-Change-Number: 39358 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[L] Change in osmo-mgw[master]: mgw: CRCX: Split mgcp header pars parsing into a previous step

by neels

Attention is currently required from: daniel, laforge, pespin. neels has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39224?usp=email ) Change subject: mgw: CRCX: Split mgcp header pars parsing into a previous step ...................................................................... Patch Set 5: (5 comments) File include/osmocom/mgcp/mgcp_protocol.h: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/219b8149_7ba9106c?usp… : PS4, Line 7: #define MGCP_PARSE_HDR_PARS_OSMUX_CID_WILDCARD (-1) > Yeah in general, but in this case it's not a closed-set of options, but 2 specific options within in […] i disagree with that position. i feel that lists of separate #defines for any number of related ints, nevermind the used range, is a hack from times where our early ancestors didn't know about curly braces yet and had barely discovered fire ... enums are an actual part of the C language proper that can be used as return type or argument type to clarify things, #defines are a preprocessor shim, much like a flea circus... i will not block this, but i challenge you to admit that mentioning the int range is just a lame excuse. File src/libosmo-mgcp/mgcp_msg.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/df8aab49_10bc8aff?usp… : PS4, Line 210: goto mgcp_header_done; > I prefer handling it below as it is now, and as it used to be too. […] It is a label with a single caller, that simply does "return 0": there is no logic to preserve. It is the textbook example of meaningless bloat. it is a non-functional cosmetic issue, so i am dialing back a bit, but i find this beyond weird. https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/e66fc108_5abbf072?usp… : PS4, Line 218: return 0; > To me this makes it easier to understand that you can finish properly based on whether you arrived t […] empty words. (resolving this one so we don't say the same things twice) File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/57f448d3_6904a35a?usp… : PS4, Line 873: hpars->remote_osmux_cid = MGCP_PARSE_HDR_PARS_OSMUX_CID_UNSET; > Yeah well a lot of stuff is quite fucked up, but we cannot fix it all in one commit. […] This patch does exactly the right thing: it introduces proper layering boundaries. So I would like the new code to observe the boundaries that it introduces. This is not about a fix of earlier code. https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/90590321_9523a011?usp… : PS4, Line 899: endp->x_osmo_ign |= hpars->x_osmo_ign; > Yes |= because it's in the endp, it's shared by several conns. […] ok! -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3ee5158c254213203830fe9c38de11c15b4b19c1 Gerrit-Change-Number: 39224 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2025 11:55:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: scripts/repo-install-test: add disconnect hint

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39357?usp=email ) Change subject: scripts/repo-install-test: add disconnect hint ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I208cacaaf4018dc3adf5c4b878147c19769381ff Gerrit-Change-Number: 39357 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2025 11:52:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: ansible/hosts: add comments with usage hints

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39356?usp=email ) Change subject: ansible/hosts: add comments with usage hints ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39356?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7b9c14db47d747dab4d96464ab67f4bec5cf9b7a Gerrit-Change-Number: 39356 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2025 11:52:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: scripts/repo-install-test: add disconnect hint

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39357?usp=email ) Change subject: scripts/repo-install-test: add disconnect hint ...................................................................... scripts/repo-install-test: add disconnect hint Add a hint that would have been useful when we set up build5. Change-Id: I208cacaaf4018dc3adf5c4b878147c19769381ff --- M scripts/repo-install-test.sh 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/57/39357/1 diff --git a/scripts/repo-install-test.sh b/scripts/repo-install-test.sh index 66604f6..9345876 100755 --- a/scripts/repo-install-test.sh +++ b/scripts/repo-install-test.sh @@ -173,6 +173,14 @@ echo "Contents of $LOG_FILE:" echo cat "$LOG_FILE" + echo + echo "---" + echo "NOTE: If you have just set up a new jenkins node, and get the" + echo "error 'Could not access KVM kernel module: Permission denied'," + echo "then you probably need to disconnect jenkins, connect it again" + echo "and retry." + echo "---" + echo } qemu_ssh_wait() { -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I208cacaaf4018dc3adf5c4b878147c19769381ff Gerrit-Change-Number: 39357 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: ansible/hosts: add comments with usage hints

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39356?usp=email ) Change subject: ansible/hosts: add comments with usage hints ...................................................................... ansible/hosts: add comments with usage hints When adding build5, these steps were not intuitive so add some documentation hints about them. Change-Id: I7b9c14db47d747dab4d96464ab67f4bec5cf9b7a --- M ansible/hosts 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/56/39356/1 diff --git a/ansible/hosts b/ansible/hosts index 57966d3..d8ed3fe 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -6,6 +6,7 @@ build4-deb12build-ansible ansible_host=2a01:4f8:121:200a::1:3 build5-deb12build-ansible ansible_host=2a01:4f8:140:926a::1:3 +# Add new x86_64 entries to [coverity_slaves] and [qemu] too! [jenkins_slaves] build4-deb12build-ansible ansible_host=2a01:4f8:121:200a::1:3 osmocom_jenkins_slave_fstrim=True docker_max_image_space="50 GB" build5-deb12build-ansible ansible_host=2a01:4f8:140:926a::1:3 osmocom_jenkins_slave_fstrim=True docker_max_image_space="50 GB" @@ -22,7 +23,9 @@ build5-obsworker ansible_host=2a01:4f8:140:926a::1:2 obs_worker_instances=8 obs_worker_jobs=8 lx2-1-obs-aarch64-1 ansible_host=2a02:8106:13:1e34:4e9:e7ff:fe97:fe92 obs_worker_instances=1 obs_worker_jobs=4 -# Need to have kvm inside lxc, see OS#5365 +# Need to have kvm inside lxc, see OS#5365. Make sure to disconnect and +# reconnect the jenkins agent after running this playbook, so its login session +# gets the kvm group! [qemu] build4-deb12build-ansible ansible_host=2a01:4f8:121:200a::1:3 build5-deb12build-ansible ansible_host=2a01:4f8:140:926a::1:3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39356?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7b9c14db47d747dab4d96464ab67f4bec5cf9b7a Gerrit-Change-Number: 39356 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[M] Change in osmo-pcap[master]: server: Introduce struct osmo_pcap_wr_file

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39353?usp=email ) Change subject: server: Introduce struct osmo_pcap_wr_file ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39353?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I5244fbc7a5dc047e1f5f7b77954cbb9c1f610181 Gerrit-Change-Number: 39353 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2025 11:26:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[M] Change in osmo-pcap[master]: server: Use osmo_stream_srv for non-tls read tcp sock

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39343?usp=email ) Change subject: server: Use osmo_stream_srv for non-tls read tcp sock ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcap/+/39343/comment/6e672c29_9526261a?us… : PS2, Line 9: TLS handling adds a lot of complexity, so TLS sockets are still read : through the previous code paths, and conversion to osmo_stream_srv is : left as a future improvement. one might even argue that osmo_stream itself should integrate the TLS support at some point, so that all of those details are kept out of the applications just wanting to use a TLS socket. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39343?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I537620fcad6c8e65206a41a1c21bd4b6453fbed4 Gerrit-Change-Number: 39343 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2025 11:26:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[M] Change in osmo-pcap[master]: server: Use osmo_stream_srv_link on tcp listen socket

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39324?usp=email ) Change subject: server: Use osmo_stream_srv_link on tcp listen socket ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I3562185f98685ea5a412273212e6dfbe55b360e2 Gerrit-Change-Number: 39324 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2025 11:25:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in osmo-pcap[master]: server: Limit rx buffer size to UINT16_MAX

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39340?usp=email ) Change subject: server: Limit rx buffer size to UINT16_MAX ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I96bfe1625510cca67f5781e2895caf2a3612ec62 Gerrit-Change-Number: 39340 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jan 2025 11:24:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025