Attention is currently required from: laforge, lynxis lazus, pespin.
neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email )
Change subject: vlr: add PS support
......................................................................
Patch Set 5:
(2 comments)
File src/libvlr/vlr_lu_fsm.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/c5303c2f_54ae6b9a?usp… :
PS5, Line 357: int N; /*! counter of timeouts */
> I would like to have it in osmo_fsm. […]
N is a good name IMO
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/2ffd4493_c0fe73a7?usp… :
PS5, Line 771: /*! count times timer T timed out */
> (maybe: "count nr of times that timer... […]
.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0
Gerrit-Change-Number: 38490
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 16 Jan 2025 13:26:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39356?usp=email )
Change subject: ansible/hosts: add comments with usage hints
......................................................................
ansible/hosts: add comments with usage hints
When adding build5, these steps were not intuitive so add some
documentation hints about them.
Change-Id: I7b9c14db47d747dab4d96464ab67f4bec5cf9b7a
---
M ansible/hosts
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
neels: Looks good to me, approved
diff --git a/ansible/hosts b/ansible/hosts
index 57966d3..d8ed3fe 100644
--- a/ansible/hosts
+++ b/ansible/hosts
@@ -6,6 +6,7 @@
build4-deb12build-ansible ansible_host=2a01:4f8:121:200a::1:3
build5-deb12build-ansible ansible_host=2a01:4f8:140:926a::1:3
+# Add new x86_64 entries to [coverity_slaves] and [qemu] too!
[jenkins_slaves]
build4-deb12build-ansible ansible_host=2a01:4f8:121:200a::1:3 osmocom_jenkins_slave_fstrim=True docker_max_image_space="50 GB"
build5-deb12build-ansible ansible_host=2a01:4f8:140:926a::1:3 osmocom_jenkins_slave_fstrim=True docker_max_image_space="50 GB"
@@ -22,7 +23,9 @@
build5-obsworker ansible_host=2a01:4f8:140:926a::1:2 obs_worker_instances=8 obs_worker_jobs=8
lx2-1-obs-aarch64-1 ansible_host=2a02:8106:13:1e34:4e9:e7ff:fe97:fe92 obs_worker_instances=1 obs_worker_jobs=4
-# Need to have kvm inside lxc, see OS#5365
+# Need to have kvm inside lxc, see OS#5365. Make sure to disconnect and
+# reconnect the jenkins agent after running this playbook, so its login session
+# gets the kvm group!
[qemu]
build4-deb12build-ansible ansible_host=2a01:4f8:121:200a::1:3
build5-deb12build-ansible ansible_host=2a01:4f8:140:926a::1:3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39356?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I7b9c14db47d747dab4d96464ab67f4bec5cf9b7a
Gerrit-Change-Number: 39356
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39357?usp=email )
Change subject: scripts/repo-install-test: add disconnect hint
......................................................................
scripts/repo-install-test: add disconnect hint
Add a hint that would have been useful when we set up build5.
Change-Id: I208cacaaf4018dc3adf5c4b878147c19769381ff
---
M scripts/repo-install-test.sh
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
neels: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/scripts/repo-install-test.sh b/scripts/repo-install-test.sh
index 66604f6..9345876 100755
--- a/scripts/repo-install-test.sh
+++ b/scripts/repo-install-test.sh
@@ -173,6 +173,14 @@
echo "Contents of $LOG_FILE:"
echo
cat "$LOG_FILE"
+ echo
+ echo "---"
+ echo "NOTE: If you have just set up a new jenkins node, and get the"
+ echo "error 'Could not access KVM kernel module: Permission denied',"
+ echo "then you probably need to disconnect jenkins, connect it again"
+ echo "and retry."
+ echo "---"
+ echo
}
qemu_ssh_wait() {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39357?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I208cacaaf4018dc3adf5c4b878147c19769381ff
Gerrit-Change-Number: 39357
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>