September 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: jobs/osmo-gsm-tester-build: fix Missing parameter

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38088?usp=email ) Change subject: jobs/osmo-gsm-tester-build: fix Missing parameter ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3b6b16964a4d8a51fd3ecc0d670805182a8c6586 Gerrit-Change-Number: 38088 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Sep 2024 12:37:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: move t_ConnHdlrPars back to S1GW_Tests

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38099?usp=email ) Change subject: s1gw: move t_ConnHdlrPars back to S1GW_Tests ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38099/comment/68638a6c_4259… : PS1, Line 168: var ConnHdlrPars pars := valueof(t_ConnHdlrPars); I really don't see why you prefer having a valueof(t_ConnHdlrPars) instead of an already in place function which can be extended later on, but I won't bother discussing. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38099?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc34d0219a616a239c0595e61a783f18fbc91b36 Gerrit-Change-Number: 38099 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Sep 2024 12:36:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: send the actual Recovery Time Stamp

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38040?usp=email ) Change subject: s1gw: send the actual Recovery Time Stamp ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I350d28289526d8264ef9b70e796ef76ee7fcbb4b Gerrit-Change-Number: 38040 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Sep 2024 12:34:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: cache PFCP Recovery Timestamp in ConnHdlr

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38098?usp=email ) Change subject: s1gw: cache PFCP Recovery Timestamp in ConnHdlr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38098?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I71f1473b52c893245b70ef67599a2f33569c37dd Gerrit-Change-Number: 38098 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Sep 2024 12:34:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: pcuif: fix TXT_IND/PCU_VERSION BTS initialization behavior

by pespin

Attention is currently required from: dexter, fixeria. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38091?usp=email ) Change subject: pcuif: fix TXT_IND/PCU_VERSION BTS initialization behavior ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: afaiu TXT_IND is sent once to globally state to the peer that it can start initialization, so in this primitive the bts_nr can simply be ignored? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38091?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie92f5833a80b06e78c6cec8f03f054e2e2625fad Gerrit-Change-Number: 38091 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Sep 2024 12:33:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in docker-playground[master]: pcuif: increase PCUIF version number

by pespin

Attention is currently required from: dexter, fixeria. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/docker-playground/+/38094?usp=email ) Change subject: pcuif: increase PCUIF version number ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: See my comments in related patches, I think you are going in the wrong direction. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I15f7150b51047379a557a1f8df6330eca597f2e3 Gerrit-Change-Number: 38094 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Sep 2024 12:33:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: pcuif: fix TXT_IND/PCU_VERSION BTS initialization behavior

by pespin

Attention is currently required from: dexter, fixeria. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38093?usp=email ) Change subject: pcuif: fix TXT_IND/PCU_VERSION BTS initialization behavior ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: afaiu TXT_IND is sent once to globally state to the peer that it can start initialization, so in this primitive the bts_nr can simply be ignored? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38093?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idce13d55fc5bdbf5b366e3a60d9b46aacfc701a9 Gerrit-Change-Number: 38093 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Sep 2024 12:32:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-pcu[master]: pcuif: fix TXT_IND/PCU_VERSION BTS initialization behavior

by pespin

Attention is currently required from: dexter, fixeria. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-pcu/+/38092?usp=email ) Change subject: pcuif: fix TXT_IND/PCU_VERSION BTS initialization behavior ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: afaiu TXT_IND is sent once to globally state to the peer that it can start initialization, so in this primitive the bts_nr can simply be ignored? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/38092?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id01966a1ee52d0f5e465dc2e0eaf85e5b7942f81 Gerrit-Change-Number: 38092 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Sep 2024 12:31:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[M] Change in osmo-bts[master]: pcuif: fix TXT_IND/PCU_VERSION BTS initialization behavior

by pespin

Attention is currently required from: dexter, fixeria. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-bts/+/38090?usp=email ) Change subject: pcuif: fix TXT_IND/PCU_VERSION BTS initialization behavior ...................................................................... Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38090?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5316d3b7cef416eb19bb256f4ccc1468b3efe1c6 Gerrit-Change-Number: 38090 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Sep 2024 12:30:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[M] Change in osmo-bts[master]: pcuif: fix TXT_IND/PCU_VERSION BTS initialization behavior

by pespin

Attention is currently required from: dexter, fixeria. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-bts/+/38090?usp=email ) Change subject: pcuif: fix TXT_IND/PCU_VERSION BTS initialization behavior ...................................................................... Patch Set 1: (5 comments) Patchset: PS1: I'm not really understanding this patch tbh. if TXT_IND is sent once after socket gets connected, then it just means it's a global message and the bts_nr is simply not used, so it can be ignored... File include/osmo-bts/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-bts/+/38090/comment/c6a7a337_b3a91149?usp… : PS1, Line 262: #define PCU_IF_BTS_NR_BCAST 0xff we are jsut increasing the bts_nr in osmo-bsc to 16bit, so this doesn't look like a good idea. File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/38090/comment/2c614a92_c57b35a0?usp… : PS1, Line 868: /* we use the reception of the PCU_VERSION as a trigger to make the PCU available for This is really only osmo-bts inside a bts SM, never really going to be differnet bts (it's osmo-bts code), so if at all we should start by differentiating between cell and bts in PCUIF. I see no clear use in this right now. https://gerrit.osmocom.org/c/osmo-bts/+/38090/comment/c75935ab_1ffa86ee?usp… : PS1, Line 954: #define ENSURE_BTS_OBJECT() \ > Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Please fix. https://gerrit.osmocom.org/c/osmo-bts/+/38090/comment/239a3946_4a1e4e74?usp… : PS1, Line 968: ENSURE_BTS_OBJECT(); This can probably be done once above the switch? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38090?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5316d3b7cef416eb19bb256f4ccc1468b3efe1c6 Gerrit-Change-Number: 38090 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Sep 2024 12:30:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024