Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38118?usp=email )
Change subject: utils: support alpha identifier in enc/dec_msisdn
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
do we really want to continue to use those functions if we have proper construct encoder/decoder in place, which handle all scenarios? I'd rathe say as soon as we've converted all users, we shoul remove {enc,dec}_msisdn?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/38118?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I19ec8ba14551ec282fc0cc12ae2f6d528bdfc527
Gerrit-Change-Number: 38118
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Sep 2024 11:33:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38117?usp=email )
Change subject: ts_51_011: replace encoding of EF.MSISDN with construct model
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I think this is incompatible with earlier versions of pySim, right? So if somebody has existing scripts to update the MSISDN, it would not work with the new format. I know we did that quite a bit in the early development of pySim-shell days, but today I would say we have many more users and existing manuals / documentations / scripts / ...
At the same time we don't want to prevent improvements.
The best is probably to start some kind of changelog where we document incompatible changes.
Alternatively, at least in this case, we could add some kind of compatibility wrapper. if the caller provides a dict with 'msisdn' as key, we know it's the old format and we could convert that to the new json format before calling the encoder?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/38117?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I647f5c63f7f87902a86c0c5d8e92fdc7f4350a5a
Gerrit-Change-Number: 38117
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Sep 2024 11:32:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No