August 2024 - gerrit-log - lists.osmocom.org

[L] Change in ...osmo-s1gw[master]: pfcp_peer: PFCP peer implementation

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37268?usp=email ) Change subject: pfcp_peer: PFCP peer implementation ...................................................................... Patch Set 10: (1 comment) File src/osmo_s1gw_sup.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37268/comment/ec0e92d6_5b57… : PS9, Line 68: UpfRemPort > I find this slightly confusing, why not name it UpfRemAddr, like UpfLocAddr? Oh, this is actually a typo. Fixed, thanks! -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37268?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7bad0069dca2111006039d12e744a2bd6d2cb86e Gerrit-Change-Number: 37268 Gerrit-PatchSet: 10 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Aug 2024 15:06:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 year, 1 month

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: [TEST] contrib/generate_build_dep.sh: manually install meck

by fixeria

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37787?usp=email ) Change subject: [TEST] contrib/generate_build_dep.sh: manually install meck ...................................................................... Abandoned squashed into https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37317 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id36eab57cf4dce723c8bbf2554c35fe85b6e2378 Gerrit-Change-Number: 37787 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de>

1 year, 1 month

1
0
0 0

[L] Change in ...osmo-s1gw[master]: erab_fsm: E-RAB FSM implementation

by fixeria

Attention is currently required from: fixeria, laforge, osmith, pespin. Hello Jenkins Builder, laforge, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37317?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified-1 by Jenkins Builder Change subject: erab_fsm: E-RAB FSM implementation ...................................................................... erab_fsm: E-RAB FSM implementation The E-RAB FSM will be used in follow-up patches. This patch also adds 'meck' dependency to the test profile, which is needed to mock the pfcp_peer API in the unit tests. Change-Id: Ic57e14675339b7cadb0cdd7cbc5d3a56288d7297 --- M contrib/generate_build_dep.sh M rebar.config A src/erab_fsm.erl A test/erab_fsm_test.erl A test/pfcp_mock.erl A test/pfcp_mock.hrl 6 files changed, 671 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/17/37317/11 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic57e14675339b7cadb0cdd7cbc5d3a56288d7297 Gerrit-Change-Number: 37317 Gerrit-PatchSet: 11 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 year, 1 month

1
0
0 0

[XS] Change in osmo-sgsn[master]: build: remove indirect libosmo-netif dependency

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37792?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: build: remove indirect libosmo-netif dependency ...................................................................... build: remove indirect libosmo-netif dependency Neither we include its headers nor call any of its functions. It's actually a dependency of libosmo-sccp, which is required for '--enable-iu', so keep it in contrib/jenkins.sh. Change-Id: Ia3395fd335d3a693c314b29b8e92968eef55da9a Related: OS#6535 --- M configure.ac M contrib/jenkins.sh M debian/control 3 files changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/92/37792/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia3395fd335d3a693c314b29b8e92968eef55da9a Gerrit-Change-Number: 37792 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 year, 1 month

1
0
0 0

[XS] Change in osmo-sgsn[master]: build: remove unused libosmo-netif dependency

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37792?usp=email ) Change subject: build: remove unused libosmo-netif dependency ...................................................................... build: remove unused libosmo-netif dependency Neither we include its headers nor call any of its functions. Change-Id: Ia3395fd335d3a693c314b29b8e92968eef55da9a Related: OS#6535 --- M configure.ac M contrib/jenkins.sh M debian/control 3 files changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/92/37792/1 diff --git a/configure.ac b/configure.ac index 7e318aa..5286d2e 100644 --- a/configure.ac +++ b/configure.ac @@ -44,7 +44,6 @@ PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.10.0) PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.10.0) PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.6.0) -PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.8.0) PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.12.0) diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 321beef..6d83682 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -33,7 +33,6 @@ export PATH="$inst/bin:$PATH" osmo-build-dep.sh libosmo-abis -osmo-build-dep.sh libosmo-netif osmo-build-dep.sh osmo-ggsn osmo-build-dep.sh osmo-hlr diff --git a/debian/control b/debian/control index c9c224b..a5c0c6e 100644 --- a/debian/control +++ b/debian/control @@ -14,7 +14,6 @@ libgtp-dev (>= 1.12.0), libosmocore-dev (>= 1.10.0), libosmo-abis-dev (>= 1.6.0), - libosmo-netif-dev (>= 1.5.0), libosmo-gsup-client-dev (>= 1.8.0), libasn1c-dev (>= 0.9.30), libosmo-ranap-dev (>= 1.6.0), -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia3395fd335d3a693c314b29b8e92968eef55da9a Gerrit-Change-Number: 37792 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 year, 1 month

1
0
0 0

[XS] Change in osmo-sgsn[master]: build: do not link against libosmo-abis

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37793?usp=email ) Change subject: build: do not link against libosmo-abis ...................................................................... build: do not link against libosmo-abis We use 'struct ipa_client_conn' from libosmo-abis: src/sgsn/sgsn_vty.c:56:#include <osmocom/abis/ipa.h> but do not call any of its API directly, so linking against it is not necessary. Remove it from $LDADD, but keep in $CFLAGS. Change-Id: I11168a7b25942d6c70566441fb0a1d26c3ae5c43 Related: OS#6535 --- M src/sgsn/Makefile.am M tests/sgsn/Makefile.am M tests/sndcp_xid/Makefile.am M tests/xid/Makefile.am 4 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/93/37793/1 diff --git a/src/sgsn/Makefile.am b/src/sgsn/Makefile.am index 93b9fa0..487dead 100644 --- a/src/sgsn/Makefile.am +++ b/src/sgsn/Makefile.am @@ -79,7 +79,6 @@ $(top_builddir)/src/gprs/gprs_utils.o \ $(top_builddir)/src/gprs/sgsn_ares.o \ $(OSMO_LIBS) \ - $(LIBOSMOABIS_LIBS) \ $(LIBOSMOGSUPCLIENT_LIBS) \ $(LIBCARES_LIBS) \ $(LIBGTP_LIBS) \ diff --git a/tests/sgsn/Makefile.am b/tests/sgsn/Makefile.am index c6c1f4a..9cffdfd 100644 --- a/tests/sgsn/Makefile.am +++ b/tests/sgsn/Makefile.am @@ -84,7 +84,6 @@ $(top_builddir)/src/gprs/gprs_llc_parse.o \ $(top_builddir)/src/gprs/crc24.o \ $(top_builddir)/src/gprs/sgsn_ares.o \ - $(LIBOSMOABIS_LIBS) \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOGSM_LIBS) \ diff --git a/tests/sndcp_xid/Makefile.am b/tests/sndcp_xid/Makefile.am index c4702b8..08bd27f 100644 --- a/tests/sndcp_xid/Makefile.am +++ b/tests/sndcp_xid/Makefile.am @@ -10,7 +10,6 @@ sndcp_xid_test_LDADD = \ $(top_builddir)/src/sgsn/gprs_sndcp_xid.o \ - $(LIBOSMOABIS_LIBS) \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOGB_LIBS) \ diff --git a/tests/xid/Makefile.am b/tests/xid/Makefile.am index d3a260b..284e392 100644 --- a/tests/xid/Makefile.am +++ b/tests/xid/Makefile.am @@ -27,7 +27,6 @@ xid_test_LDADD = \ $(top_builddir)/src/sgsn/gprs_llc_xid.o \ - $(LIBOSMOABIS_LIBS) \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOGB_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I11168a7b25942d6c70566441fb0a1d26c3ae5c43 Gerrit-Change-Number: 37793 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 year, 1 month

1
0
0 0

[S] Change in gapk[master]: Bump version: 1.1.1.1-b8d6 → 1.1.2

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/gapk/+/37791?usp=email ) Change subject: Bump version: 1.1.1.1-b8d6 → 1.1.2 ...................................................................... Bump version: 1.1.1.1-b8d6 → 1.1.2 Change-Id: Ia936115cfd6ef979f8cf80a02870055af65dc85d --- M debian/changelog 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/changelog b/debian/changelog index 4cbf688..95e1b53 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,19 @@ +gapk (1.1.2) unstable; urgency=medium + + * Update debian/changelog, it was not updated in the 1.1.1 release + * Use release helper from libosmocore + + -- Oliver Smith <osmith(a)sysmocom.de> Fri, 09 Aug 2024 11:28:01 +0200 + +gapk (1.1.1) unstable; urgency=medium + + [ Oliver Smith ] + * contrib: remove rpm spec file + * debian: initial + * gitignore: add .version and *~ + + -- Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Wed, 31 Jul 2024 17:02:00 +0200 + gapk (1.1) unstable; urgency=medium * Initial debian packaging -- To view, visit https://gerrit.osmocom.org/c/gapk/+/37791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: Ia936115cfd6ef979f8cf80a02870055af65dc85d Gerrit-Change-Number: 37791 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 year, 1 month

1
0
0 0

[XS] Change in gapk[master]: Use release helper from libosmocore

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/gapk/+/37790?usp=email ) Change subject: Use release helper from libosmocore ...................................................................... Use release helper from libosmocore Related: OS#1861 Change-Id: I055fa322b70d58323810e084afca733256afac42 --- M Makefile.am M configure.ac 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/Makefile.am b/Makefile.am index f2a2c31..fe79f2d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -20,6 +20,8 @@ .version \ $(NULL) +@RELMAKE@ + # versioning magic $(top_srcdir)/.version: echo $(VERSION) > $@-t && mv $@-t $@ diff --git a/configure.ac b/configure.ac index 904b371..6e1533d 100644 --- a/configure.ac +++ b/configure.ac @@ -11,6 +11,10 @@ # kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) +dnl include release helper +RELMAKE='-include osmo-release.mk' +AC_SUBST([RELMAKE]) + AC_CONFIG_SRCDIR([src/app_osmo_gapk.c]) AC_CONFIG_HEADERS([config.h]) AC_CONFIG_MACRO_DIR([m4]) -- To view, visit https://gerrit.osmocom.org/c/gapk/+/37790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I055fa322b70d58323810e084afca733256afac42 Gerrit-Change-Number: 37790 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 year, 1 month

1
0
0 0

[S] Change in gapk[master]: Bump version: 1.1.1.1-b8d6 → 1.1.2

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/gapk/+/37791?usp=email ) Change subject: Bump version: 1.1.1.1-b8d6 → 1.1.2 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/37791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: Ia936115cfd6ef979f8cf80a02870055af65dc85d Gerrit-Change-Number: 37791 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Aug 2024 09:33:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year, 1 month

1
0
0 0

[XS] Change in gapk[master]: Use release helper from libosmocore

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/gapk/+/37790?usp=email ) Change subject: Use release helper from libosmocore ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/37790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I055fa322b70d58323810e084afca733256afac42 Gerrit-Change-Number: 37790 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Aug 2024 09:33:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024