Attention is currently required from: fixeria.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37462?usp=email )
Change subject: sctp_proxy: maintain opaque state for s1ap_proxy
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37462?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I6ea8479c1a66bca330a7d4030cc7cdf55a76b12c
Gerrit-Change-Number: 37462
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Aug 2024 08:52:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37787?usp=email )
Change subject: [TEST] contrib/generate_build_dep.sh: manually install meck
......................................................................
Patch Set 2:
(1 comment)
File contrib/generate_build_dep.sh:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37787/comment/143841cd_56fb… :
PS2, Line 20: git clone https://github.com/eproxus/meck _checkouts/meck
> I suggest using --depth 1, and download a specific tag so it doesn't fail unexpectedly if there shou […]
Full ack. This patch has been submitted to test if cloning manually does the trick. I'll rework it and rebase, setting WIP for now. Thanks for your input!
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37787?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Id36eab57cf4dce723c8bbf2554c35fe85b6e2378
Gerrit-Change-Number: 37787
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Aug 2024 08:39:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: fixeria.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37787?usp=email )
Change subject: [TEST] contrib/generate_build_dep.sh: manually install meck
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
This looks like the right approach, given that rebar3 can't fetch the test deps.
File contrib/generate_build_dep.sh:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37787/comment/8b583a76_9f2d… :
PS2, Line 20: git clone https://github.com/eproxus/meck _checkouts/meck
I suggest using --depth 1, and download a specific tag so it doesn't fail unexpectedly if there should be breaking changes in master:
```
git clone --depth 1 --branch 0.9.2 https://github.com/eproxus/meck _checkouts/meck
```
Furthermore I suggest setting the same version in rebar.config, and adding a comment to rebar.config that if the version gets modified there, it must also be adjusted in generate_build_dep.sh.
Also I would move it before the "delete erlang bytecode" line. There doesn't seem to be any in the git repository, but then it's directly obvious that we don't use bytecode from there.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37787?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Id36eab57cf4dce723c8bbf2554c35fe85b6e2378
Gerrit-Change-Number: 37787
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Aug 2024 08:25:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: osmith.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37789?usp=email )
Change subject: Bump version to 0.1.1
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37789?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Id5bfda6a755a034c526b066e70199b7655f81e18
Gerrit-Change-Number: 37789
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Aug 2024 08:12:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes