August 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: s1gw: Rename functions to include s1ap information

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37945?usp=email ) Change subject: s1gw: Rename functions to include s1ap information ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37945?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic4b06712f3222bada71ff5ca8a6c65ec9c92ae1e Gerrit-Change-Number: 37945 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 29 Aug 2024 12:57:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: Rename functions to include s1ap information

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37945?usp=email ) Change subject: s1gw: Rename functions to include s1ap information ...................................................................... s1gw: Rename functions to include s1ap information Change-Id: Ic4b06712f3222bada71ff5ca8a6c65ec9c92ae1e --- M s1gw/ConnHdlr.ttcn M s1gw/S1AP_Server.ttcn M s1gw/S1GW_Tests.ttcn 3 files changed, 25 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/37945/1 diff --git a/s1gw/ConnHdlr.ttcn b/s1gw/ConnHdlr.ttcn index 12c7414..071b69d 100644 --- a/s1gw/ConnHdlr.ttcn +++ b/s1gw/ConnHdlr.ttcn @@ -73,7 +73,7 @@ } -function f_ConnHdlr_connect(charstring local_addr, charstring remote_addr) runs on ConnHdlr { +function f_ConnHdlr_s1ap_connect(charstring local_addr, charstring remote_addr) runs on ConnHdlr { var Result res; timer T; @@ -104,7 +104,7 @@ } } -function f_ConnHdlr_disconnect() runs on ConnHdlr { +function f_ConnHdlr_s1ap_disconnect() runs on ConnHdlr { var Result res; S1AP_CodecPort_CtrlFunct.f_IPL4_close(S1AP_ENB, g_s1ap_conn_id, @@ -117,7 +117,7 @@ log("eNB connection closed"); } -function f_ConnHdlr_expect_shutdown() runs on ConnHdlr { +function f_ConnHdlr_s1ap_expect_shutdown() runs on ConnHdlr { S1AP_ENB.receive(tr_SctpShutDownEvent(g_s1ap_conn_id)); S1AP_ENB.receive(tr_SctpAssocChange(SCTP_SHUTDOWN_COMP, g_s1ap_conn_id)); S1AP_ENB.receive(PortEvent:{connClosed := ?}); @@ -182,7 +182,7 @@ } } -function f_ConnHdlr_setup(Global_ENB_ID genb_id, float Tval := 5.0) runs on ConnHdlr { +function f_ConnHdlr_s1ap_setup(Global_ENB_ID genb_id, float Tval := 5.0) runs on ConnHdlr { var S1AP_PDU pdu; timer T; diff --git a/s1gw/S1AP_Server.ttcn b/s1gw/S1AP_Server.ttcn index 904f106..5bd83a4 100644 --- a/s1gw/S1AP_Server.ttcn +++ b/s1gw/S1AP_Server.ttcn @@ -325,21 +325,21 @@ inout S1APSRV_close_conn; } with { extension "internal" }; -function f_ConnHdlr_register(Global_ENB_ID genb_id) +function f_ConnHdlr_s1ap_register(Global_ENB_ID genb_id) runs on S1APSRV_ConnHdlr { S1AP_PROC.call(S1APSRV_register:{self, genb_id}) { [] S1AP_PROC.getreply(S1APSRV_register:{?, ?}) { }; } } -function f_ConnHdlr_unregister(Global_ENB_ID genb_id) +function f_ConnHdlr_s1ap_unregister(Global_ENB_ID genb_id) runs on S1APSRV_ConnHdlr { S1AP_PROC.call(S1APSRV_unregister:{self, genb_id}) { [] S1AP_PROC.getreply(S1APSRV_unregister:{?, ?}) { }; } } -function f_ConnHdlr_close_conn(Global_ENB_ID genb_id) +function f_ConnHdlr_s1ap_close_conn(Global_ENB_ID genb_id) runs on S1APSRV_ConnHdlr { S1AP_PROC.call(S1APSRV_close_conn:{self, genb_id}) { [] S1AP_PROC.getreply(S1APSRV_close_conn:{?, ?}) { }; diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index 9448ed5..257ca96 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -116,14 +116,14 @@ function f_TC_setup(charstring id) runs on ConnHdlr { f_ConnHdlr_register_pfcp(); - f_ConnHdlr_register(g_pars.genb_id); + f_ConnHdlr_s1ap_register(g_pars.genb_id); - f_ConnHdlr_connect(mp_enb_bind_ip, mp_s1gw_enb_ip); - f_ConnHdlr_setup(g_pars.genb_id); + f_ConnHdlr_s1ap_connect(mp_enb_bind_ip, mp_s1gw_enb_ip); + f_ConnHdlr_s1ap_setup(g_pars.genb_id); f_sleep(0.5); /* keep the connection idle for some time */ - f_ConnHdlr_disconnect(); + f_ConnHdlr_s1ap_disconnect(); - f_ConnHdlr_unregister(g_pars.genb_id); + f_ConnHdlr_s1ap_unregister(g_pars.genb_id); } testcase TC_setup() runs on test_CT { var ConnHdlrPars pars := valueof(t_ConnHdlrPars); @@ -154,18 +154,18 @@ /* MME terminates connection, expect S1GW to terminate the eNB connection */ function f_TC_conn_term_by_mme(charstring id) runs on ConnHdlr { f_ConnHdlr_register_pfcp(); - f_ConnHdlr_register(g_pars.genb_id); + f_ConnHdlr_s1ap_register(g_pars.genb_id); - f_ConnHdlr_connect(mp_enb_bind_ip, mp_s1gw_enb_ip); - f_ConnHdlr_setup(g_pars.genb_id); + f_ConnHdlr_s1ap_connect(mp_enb_bind_ip, mp_s1gw_enb_ip); + f_ConnHdlr_s1ap_setup(g_pars.genb_id); f_sleep(0.5); /* keep the connection idle for some time */ /* MME (S1AP_Server_CT) terminates connection */ - f_ConnHdlr_close_conn(g_pars.genb_id); + f_ConnHdlr_s1ap_close_conn(g_pars.genb_id); /* expect our eNB connection to be released gracefully */ - f_ConnHdlr_expect_shutdown(); + f_ConnHdlr_s1ap_expect_shutdown(); - f_ConnHdlr_unregister(g_pars.genb_id); + f_ConnHdlr_s1ap_unregister(g_pars.genb_id); } testcase TC_conn_term_by_mme() runs on test_CT { var ConnHdlrPars pars := valueof(t_ConnHdlrPars); @@ -182,9 +182,9 @@ function f_TC_conn_term_mme_unavail(charstring id) runs on ConnHdlr { f_ConnHdlr_register_pfcp(); /* establish an eNB connection to the S1GW */ - f_ConnHdlr_connect(mp_enb_bind_ip, mp_s1gw_enb_ip); + f_ConnHdlr_s1ap_connect(mp_enb_bind_ip, mp_s1gw_enb_ip); /* expect our eNB connection to be released gracefully */ - f_ConnHdlr_expect_shutdown(); + f_ConnHdlr_s1ap_expect_shutdown(); setverdict(pass); } testcase TC_conn_term_mme_unavail() runs on test_CT { @@ -204,9 +204,9 @@ var S1AP_PDU pdu; f_ConnHdlr_register_pfcp(); - f_ConnHdlr_register(g_pars.genb_id); - f_ConnHdlr_connect(mp_enb_bind_ip, mp_s1gw_enb_ip); - f_ConnHdlr_setup(g_pars.genb_id); + f_ConnHdlr_s1ap_register(g_pars.genb_id); + f_ConnHdlr_s1ap_connect(mp_enb_bind_ip, mp_s1gw_enb_ip); + f_ConnHdlr_s1ap_setup(g_pars.genb_id); log("eNB <- [S1GW] <- MME: E-RAB SETUP REQUEST"); var template (value) E_RABToBeSetupListBearerSUReq items_req; @@ -259,8 +259,8 @@ items_res := ts_S1AP_RABSetupListBearerSURes(item_res); f_ConnHdlr_rx_s1ap_from_enb(pdu, tr_S1AP_RABSetupRsp(mme_id, enb_id, items_res)); - f_ConnHdlr_disconnect(); - f_ConnHdlr_unregister(g_pars.genb_id); + f_ConnHdlr_s1ap_disconnect(); + f_ConnHdlr_s1ap_unregister(g_pars.genb_id); } testcase TC_e_rab_setup() runs on test_CT { var ConnHdlrPars pars := valueof(t_ConnHdlrPars); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37945?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic4b06712f3222bada71ff5ca8a6c65ec9c92ae1e Gerrit-Change-Number: 37945 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[XS] Change in pysim[master]: ts_31_102: Add mssing help string for get_identity parameter --nswo-c...

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37944?usp=email ) Change subject: ts_31_102: Add mssing help string for get_identity parameter --nswo-context ...................................................................... ts_31_102: Add mssing help string for get_identity parameter --nswo-context Related: OS#6531 Change-Id: I3ebd3a2ceb7f2580f4cd939b3f002f38f236d7f2 --- M pySim/ts_31_102.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/44/37944/1 diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 5c010ad..f4f7fb6 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -1761,7 +1761,8 @@ self._cmd.poutput('SW: %s, data: %s' % (sw, data)) get_id_parser = argparse.ArgumentParser() - get_id_parser.add_argument("--nswo-context", action='store_true') + get_id_parser.add_argument("--nswo-context", action='store_true', + help='SUCI 5G Non-Seamless WLAN Offload configuration') @cmd2.with_argparser(get_id_parser) def do_get_identity(self, opts): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37944?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3ebd3a2ceb7f2580f4cd939b3f002f38f236d7f2 Gerrit-Change-Number: 37944 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: osmo-s1gw.config: enable colors in logging

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37941?usp=email ) Change subject: s1gw: osmo-s1gw.config: enable colors in logging ...................................................................... Patch Set 1: (1 comment) File s1gw/osmo-s1gw.config: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37941/comment/1810f2fe_e9d2… : PS1, Line 27: #{formatter => > is this really outpitting log file with colors? I tried myself but couldn't get it to work. Yes, I tested it :D -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49fa2ca9d7aea5a2728d07f176b80a6438551047 Gerrit-Change-Number: 37941 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Aug 2024 13:42:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: PFCP: fix SEID value in {ts,tr}_PFCP_Session_Est_Req

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37943?usp=email ) Change subject: PFCP: fix SEID value in {ts,tr}_PFCP_Session_Est_Req ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37943?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iacfbd68336b6fc4481c15ca5b304636df4491da4 Gerrit-Change-Number: 37943 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Aug 2024 13:42:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: PFCP: rework templates, get rid of functions

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37942?usp=email ) Change subject: PFCP: rework templates, get rid of functions ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37942?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I04735adf88c81b949e1dca6e9ab9a3b37ba78bd6 Gerrit-Change-Number: 37942 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Aug 2024 13:42:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: osmo-s1gw.config: enable colors in logging

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37941?usp=email ) Change subject: s1gw: osmo-s1gw.config: enable colors in logging ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File s1gw/osmo-s1gw.config: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37941/comment/0a786887_af98… : PS1, Line 27: #{formatter => is this really outpitting log file with colors? I tried myself but couldn't get it to work. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49fa2ca9d7aea5a2728d07f176b80a6438551047 Gerrit-Change-Number: 37941 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Aug 2024 13:41:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: osmo-s1gw.config: fix pfcp_{loc,rem}_addr comments

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37940?usp=email ) Change subject: s1gw: osmo-s1gw.config: fix pfcp_{loc,rem}_addr comments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37940?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4b5b18750de48b5db1a23a95a427ba1fd3d3905d Gerrit-Change-Number: 37940 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Aug 2024 13:40:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: S1GW_Tests.cfg: add PFCP related module params

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37939?usp=email ) Change subject: s1gw: S1GW_Tests.cfg: add PFCP related module params ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File s1gw/S1GW_Tests.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37939/comment/c001a894_b6ea… : PS1, Line 18: S1GW_Tests.mp_s1gw_upf_ip := "127.0.3.1"; uh weird I thought I had done this already. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37939?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id134f2fd0e2e138ee6cb7a8f8a3e2af7f027bda4 Gerrit-Change-Number: 37939 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Aug 2024 13:40:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: cosmetic: reorder module parameters

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37938?usp=email ) Change subject: s1gw: cosmetic: reorder module parameters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ee5d2e283327f52320ef5580b195c42e400c8de Gerrit-Change-Number: 37938 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Aug 2024 13:39:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024