August 2024 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: commands: avoid double lchan patching

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37937?usp=email ) Change subject: commands: avoid double lchan patching ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I think it's actually confusing to read apply_lchan=False in such commands. This can easily raise the impression that a given command will not work over lchans. I'd keep it as-is, if it's only a cosmetic issue. Alterntaively, we might also consider removing the cla_byte @property lchan patching and leave it to the lower layers? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I420f8a5f7ff8d9e5ef94d6519fb3716d6c7caf64 Gerrit-Change-Number: 37937 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:04:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

10 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: S1GW_Tests.cfg: add PFCP related module params

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37939?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: s1gw: S1GW_Tests.cfg: add PFCP related module params ...................................................................... s1gw: S1GW_Tests.cfg: add PFCP related module params Change-Id: Id134f2fd0e2e138ee6cb7a8f8a3e2af7f027bda4 --- M s1gw/S1GW_Tests.cfg 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/39/37939/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37939?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id134f2fd0e2e138ee6cb7a8f8a3e2af7f027bda4 Gerrit-Change-Number: 37939 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

10 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: cosmetic: reorder module parameters

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37938?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: s1gw: cosmetic: reorder module parameters ...................................................................... s1gw: cosmetic: reorder module parameters Change-Id: I6ee5d2e283327f52320ef5580b195c42e400c8de --- M s1gw/S1GW_Tests.cfg M s1gw/S1GW_Tests.ttcn 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/38/37938/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ee5d2e283327f52320ef5580b195c42e400c8de Gerrit-Change-Number: 37938 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

10 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: PFCP: fix SEID value in {ts,tr}_PFCP_Session_Est_Req

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37943?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: PFCP: fix SEID value in {ts,tr}_PFCP_Session_Est_Req ...................................................................... PFCP: fix SEID value in {ts,tr}_PFCP_Session_Est_Req According to 3GPP TS 29.244, section 7.2.2.4.2 "Conditions for Sending SEID=0 in PFCP Header": if a peer's SEID is not available, the SEID field shall still be present in the header and its value shall be set to "0" in the following messages: * PFCP Session Establishment Request message on Sxa/Sxb/Sxc/N4; ... Change-Id: Iacfbd68336b6fc4481c15ca5b304636df4491da4 Related: SYS#6772 --- M library/PFCP_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/43/37943/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37943?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iacfbd68336b6fc4481c15ca5b304636df4491da4 Gerrit-Change-Number: 37943 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

10 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: osmo-s1gw.config: fix pfcp_{loc,rem}_addr comments

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37940?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: s1gw: osmo-s1gw.config: fix pfcp_{loc,rem}_addr comments ...................................................................... s1gw: osmo-s1gw.config: fix pfcp_{loc,rem}_addr comments Change-Id: I4b5b18750de48b5db1a23a95a427ba1fd3d3905d --- M s1gw/osmo-s1gw.config 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/37940/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37940?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4b5b18750de48b5db1a23a95a427ba1fd3d3905d Gerrit-Change-Number: 37940 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

10 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: rename module ConnHdlr -> S1GW_ConnHdlr

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37950?usp=email ) Change subject: s1gw: rename module ConnHdlr -> S1GW_ConnHdlr ...................................................................... s1gw: rename module ConnHdlr -> S1GW_ConnHdlr This fixes the following warning: ConnHdlr.ttcn:39.1-43.1: warning: Definition with name `ConnHdlr' hides a module identifier Change-Id: I47364a35720059d6a51f004a5692b9a0c1ad98d8 --- R s1gw/S1GW_ConnHdlr.ttcn M s1gw/S1GW_Tests.ttcn 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/37950/1 diff --git a/s1gw/ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn similarity index 99% rename from s1gw/ConnHdlr.ttcn rename to s1gw/S1GW_ConnHdlr.ttcn index 12c7414..e441501 100644 --- a/s1gw/ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -11,7 +11,7 @@ * SPDX-License-Identifier: GPL-2.0-or-later */ -module ConnHdlr { +module S1GW_ConnHdlr { import from General_Types all; import from Osmocom_Types all; diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index 9448ed5..0dd0ea3 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -35,7 +35,7 @@ import from SCTP_Templates all; import from S1AP_Server all; -import from ConnHdlr all; +import from S1GW_ConnHdlr all; modulepar { charstring mp_s1gw_enb_ip := "127.0.1.1"; /* eNB facing address of the S1GW */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I47364a35720059d6a51f004a5692b9a0c1ad98d8 Gerrit-Change-Number: 37950 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

10 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP: drop no longer needed {ts,tr}_PDU_PFCP

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37951?usp=email ) Change subject: PFCP: drop no longer needed {ts,tr}_PDU_PFCP ...................................................................... PFCP: drop no longer needed {ts,tr}_PDU_PFCP Change-Id: I6091d7e76e852d2487b784fb2b3e39b416a48195 Related: SYS#6772 --- M library/PFCP_Templates.ttcn 1 file changed, 0 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/51/37951/1 diff --git a/library/PFCP_Templates.ttcn b/library/PFCP_Templates.ttcn index 143175a..ad90ff2 100644 --- a/library/PFCP_Templates.ttcn +++ b/library/PFCP_Templates.ttcn @@ -113,17 +113,6 @@ message_body := ? }; -template (value) PDU_PFCP ts_PDU_PFCP(LIN3_BO_LAST sequence_number := 0, template (omit) OCT8 seid := omit) -modifies ts_PDU_PFCP_ := { - seid := seid, - sequence_number := sequence_number -}; - -template (present) PDU_PFCP tr_PDU_PFCP(template OCT8 seid := *) -modifies tr_PDU_PFCP_ := { - seid := seid -}; - /* 7.4.4.1 PFCP Association Setup Request */ template (value) PDU_PFCP ts_PFCP_Assoc_Setup_Req(template (value) Node_ID node_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6091d7e76e852d2487b784fb2b3e39b416a48195 Gerrit-Change-Number: 37951 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

10 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP: add Heartbeat Req/Resp templates

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37952?usp=email ) Change subject: PFCP: add Heartbeat Req/Resp templates ...................................................................... PFCP: add Heartbeat Req/Resp templates Change-Id: I569b47b6ebc3ca238da544488cac69dfc1db1dfe Related: SYS#6772 --- M library/PFCP_Templates.ttcn 1 file changed, 44 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/37952/1 diff --git a/library/PFCP_Templates.ttcn b/library/PFCP_Templates.ttcn index ad90ff2..f3b6893 100644 --- a/library/PFCP_Templates.ttcn +++ b/library/PFCP_Templates.ttcn @@ -73,13 +73,14 @@ template (value) Node_ID ts_PFCP_Node_ID_ipv4(OCT4 ip_value) := ts_PFCP_Node_ID(PFCP_Node_ID_IPv4, ip_value); template (value) Node_ID ts_PFCP_Node_ID_fqdn(charstring fqdn) := ts_PFCP_Node_ID(PFCP_Node_ID_FQDN, char2oct(fqdn)); -template (value) Recovery_Time_Stamp ts_PFCP_Recovery_Timestamp(LIN4_BO_LAST time_value) := { +template (value) Recovery_Time_Stamp +ts_PFCP_Recovery_Timestamp(template (value) LIN4_BO_LAST time_value) := { elementIdentifier := 96, lengthIndicator := 0, time_value := time_value }; - -template (present) Recovery_Time_Stamp tr_PFCP_Recovery_Timestamp(template (present) LIN4_BO_LAST time_value := ?) := { +template (present) Recovery_Time_Stamp +tr_PFCP_Recovery_Timestamp(template (present) LIN4_BO_LAST time_value := ?) := { elementIdentifier := 96, lengthIndicator := ?, time_value := time_value @@ -113,6 +114,46 @@ message_body := ? }; +/* 7.4.2.1 Heartbeat Request */ +template (value) PDU_PFCP +ts_PFCP_Heartbeat_Req(template (value) LIN4_BO_LAST recovery_time_stamp) +modifies ts_PDU_PFCP_ := { + message_body := { + heartbeat_request := { + recovery_time_stamp := ts_PFCP_Recovery_Timestamp(recovery_time_stamp) + } + } +}; +template (present) PDU_PFCP +tr_PFCP_Heartbeat_Req(template (present) LIN4_BO_LAST recovery_time_stamp := ?) +modifies tr_PDU_PFCP_ := { + message_body := { + heartbeat_request := { + recovery_time_stamp := tr_PFCP_Recovery_Timestamp(recovery_time_stamp) + } + } +}; + +/* 7.4.2.2 Heartbeat Response */ +template (value) PDU_PFCP +ts_PFCP_Heartbeat_Resp(template (value) LIN4_BO_LAST recovery_time_stamp) +modifies ts_PDU_PFCP_ := { + message_body := { + heartbeat_response := { + recovery_time_stamp := ts_PFCP_Recovery_Timestamp(recovery_time_stamp) + } + } +}; +template (present) PDU_PFCP +tr_PFCP_Heartbeat_Resp(template (present) LIN4_BO_LAST recovery_time_stamp := ?) +modifies tr_PDU_PFCP_ := { + message_body := { + heartbeat_response := { + recovery_time_stamp := tr_PFCP_Recovery_Timestamp(recovery_time_stamp) + } + } +}; + /* 7.4.4.1 PFCP Association Setup Request */ template (value) PDU_PFCP ts_PFCP_Assoc_Setup_Req(template (value) Node_ID node_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I569b47b6ebc3ca238da544488cac69dfc1db1dfe Gerrit-Change-Number: 37952 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

10 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP_Emulation: respond to incoming Heartbeat Req

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37953?usp=email ) Change subject: PFCP_Emulation: respond to incoming Heartbeat Req ...................................................................... PFCP_Emulation: respond to incoming Heartbeat Req This is a mandatory procedure that every 3GPP TS 29.244 compliant peer shall support. Change-Id: I93990feb1864701e2903af85480093ef751bafe5 Related: SYS#6772 --- M library/PFCP_CodecPort.ttcn M library/PFCP_Emulation.ttcn 2 files changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/37953/1 diff --git a/library/PFCP_CodecPort.ttcn b/library/PFCP_CodecPort.ttcn index 8d4078d..783ffb0 100644 --- a/library/PFCP_CodecPort.ttcn +++ b/library/PFCP_CodecPort.ttcn @@ -26,6 +26,12 @@ PDU_PFCP pdu } +template (present) PFCP_Unitdata +tr_PFCP_UD(template (present) PDU_PFCP pdu := ?) := { + peer := ?, + pdu := pdu +} + /* Translation port on top of IPL4asp; ASP_Event passed through transparently */ type port PFCP_PT message { out PFCP_Unitdata; diff --git a/library/PFCP_Emulation.ttcn b/library/PFCP_Emulation.ttcn index d872367..2fb3a8a 100644 --- a/library/PFCP_Emulation.ttcn +++ b/library/PFCP_Emulation.ttcn @@ -15,6 +15,7 @@ import from General_Types all; import from Osmocom_Types all; import from PFCP_Types all; +import from PFCP_Templates all; import from PFCP_CodecPort all; import from PFCP_CodecPort_CtrlFunct all; @@ -123,7 +124,15 @@ while (true) { alt { - [] PFCP.receive(PFCP_Unitdata:?) -> value ud { + [] PFCP.receive(tr_PFCP_UD(tr_PFCP_Heartbeat_Req)) -> value ud { + log("Rx Heartbeat Req: ", ud.pdu); + pdu := valueof(ts_PFCP_Heartbeat_Resp(g_recovery_timestamp)); + pdu.sequence_number := ud.pdu.sequence_number; + ud.pdu := pdu; + PFCP.send(ud); + } + + [] PFCP.receive(tr_PFCP_UD(?)) -> value ud { log("PFCP_Emulation main() PFCP.receive: ", ud); vc_conn := null; if (ud.pdu.s_flag == '1'B) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93990feb1864701e2903af85480093ef751bafe5 Gerrit-Change-Number: 37953 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

10 months

1
0
0 0

[S] Change in pysim[master]: commands: get rid of cla4lchan

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37936?usp=email ) Change subject: commands: get rid of cla4lchan ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia795f3c16a8875484fce3b44e61497d5aa52b447 Gerrit-Change-Number: 37936 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:01:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024