August 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-dev[master]: osmo-uninstall.sh: more files

by laforge

Attention is currently required from: fixeria, neels, osmith. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-dev/+/37851?usp=email ) Change subject: osmo-uninstall.sh: more files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/37851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ic7ae31f37aced3ac4d5dd4ab2472fda6c27966a0 Gerrit-Change-Number: 37851 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:22:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months

1
0
0 0

[XS] Change in osmo-dev[master]: osmo-uninstall.sh: add -x and -e

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-dev/+/37850?usp=email ) Change subject: osmo-uninstall.sh: add -x and -e ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/37850?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I226aed2ddce9a01fc9399a8ba656a2496b1efa61 Gerrit-Change-Number: 37850 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:21:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months

1
0
0 0

[XS] Change in osmo-sgsn[master]: sm: pdpctx_timer_stop(): warn about timer not running

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37852?usp=email ) Change subject: sm: pdpctx_timer_stop(): warn about timer not running ...................................................................... sm: pdpctx_timer_stop(): warn about timer not running Similarly to 282de031, this commit turns errors like: DGPRS ERROR PDP(---/0) Stopping PDP timer 3395 but 0 is running into warnings with a more accurate reason: DGPRS ERROR PDP(---/0) Stopping *inactive* PDP timer 3395 Change-Id: I64932d1cbd93667ab2e94e04691d6601435dba81 Related: 282de031 "gmm: mmctx_timer_stop(): warn about timer not running" --- M src/sgsn/gprs_sm.c 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sgsn/gprs_sm.c b/src/sgsn/gprs_sm.c index 88d1feb..bcf2923 100644 --- a/src/sgsn/gprs_sm.c +++ b/src/sgsn/gprs_sm.c @@ -114,9 +114,14 @@ static void pdpctx_timer_stop(struct sgsn_pdp_ctx *pdp, unsigned int T) { - if (pdp->T != T) + if (!osmo_timer_pending(&pdp->timer)) { + LOGPDPCTXP(LOGL_NOTICE, pdp, "Stopping *inactive* PDP timer %u\n", T); + return; + } + if (pdp->T != T) { LOGPDPCTXP(LOGL_ERROR, pdp, "Stopping PDP timer %u but " "%u is running\n", T, pdp->T); + } osmo_timer_del(&pdp->timer); } -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37852?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I64932d1cbd93667ab2e94e04691d6601435dba81 Gerrit-Change-Number: 37852 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

10 months

1
0
0 0

[XS] Change in osmo-sgsn[master]: sm: pdpctx_timer_stop(): warn about timer not running

by laforge

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37852?usp=email ) Change subject: sm: pdpctx_timer_stop(): warn about timer not running ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37852?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I64932d1cbd93667ab2e94e04691d6601435dba81 Gerrit-Change-Number: 37852 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:21:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months

1
0
0 0

[XS] Change in pysim[master]: ts_31_102: Add mssing help string for get_identity parameter --nswo-c...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37944?usp=email ) Change subject: ts_31_102: Add mssing help string for get_identity parameter --nswo-context ...................................................................... ts_31_102: Add mssing help string for get_identity parameter --nswo-context Related: OS#6531 Change-Id: I3ebd3a2ceb7f2580f4cd939b3f002f38f236d7f2 --- M pySim/ts_31_102.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 5c010ad..c82cd2f 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -1761,7 +1761,8 @@ self._cmd.poutput('SW: %s, data: %s' % (sw, data)) get_id_parser = argparse.ArgumentParser() - get_id_parser.add_argument("--nswo-context", action='store_true') + get_id_parser.add_argument("--nswo-context", action='store_true', + help='use SUCI 5G Non-Seamless WLAN Offload context') @cmd2.with_argparser(get_id_parser) def do_get_identity(self, opts): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37944?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3ebd3a2ceb7f2580f4cd939b3f002f38f236d7f2 Gerrit-Change-Number: 37944 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

10 months

1
0
0 0

[XS] Change in pysim[master]: scp: fix key length in dek_encrypt and dek_decrypt

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37931?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: scp: fix key length in dek_encrypt and dek_decrypt ...................................................................... scp: fix key length in dek_encrypt and dek_decrypt When creating the DES cipher object with DES.new, we use the property card_keys.dek. This property may hold a 16 byte key, but DES uses an 8 byte key (56 bit + 8 bit integrity). Pycryptodome does not automatically ignore excess key bytes. Instead it throws an exception. This means we need to make sure to supply only the first 8 bytes of card_keys.dek See also: https://pycryptodome.readthedocs.io/en/latest/src/cipher/des.html Related: OS#6531 Change-Id: I92e0dc6a6196b532bd8b53fca7b9e78070d6903f --- M pySim/global_platform/scp.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/global_platform/scp.py b/pySim/global_platform/scp.py index f68bcf9..17463ff 100644 --- a/pySim/global_platform/scp.py +++ b/pySim/global_platform/scp.py @@ -230,11 +230,11 @@ super().__init__(*args, **kwargs) def dek_encrypt(self, plaintext:bytes) -> bytes: - cipher = DES.new(self.card_keys.dek, DES.MODE_ECB) + cipher = DES.new(self.card_keys.dek[:8], DES.MODE_ECB) return cipher.encrypt(plaintext) def dek_decrypt(self, ciphertext:bytes) -> bytes: - cipher = DES.new(self.card_keys.dek, DES.MODE_ECB) + cipher = DES.new(self.card_keys.dek[:8], DES.MODE_ECB) return cipher.decrypt(ciphertext) def _compute_cryptograms(self, card_challenge: bytes, host_challenge: bytes): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37931?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I92e0dc6a6196b532bd8b53fca7b9e78070d6903f Gerrit-Change-Number: 37931 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

10 months

1
0
0 0

[XS] Change in pysim[master]: ts_31_102: Add mssing help string for get_identity parameter --nswo-c...

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37944?usp=email ) Change subject: ts_31_102: Add mssing help string for get_identity parameter --nswo-context ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37944?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3ebd3a2ceb7f2580f4cd939b3f002f38f236d7f2 Gerrit-Change-Number: 37944 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:11:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP_Emulation: respond to incoming Heartbeat Req

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37953?usp=email ) Change subject: PFCP_Emulation: respond to incoming Heartbeat Req ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93990feb1864701e2903af85480093ef751bafe5 Gerrit-Change-Number: 37953 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:11:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP: add Heartbeat Req/Resp templates

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37952?usp=email ) Change subject: PFCP: add Heartbeat Req/Resp templates ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I569b47b6ebc3ca238da544488cac69dfc1db1dfe Gerrit-Change-Number: 37952 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:11:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP: drop no longer needed {ts,tr}_PDU_PFCP

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37951?usp=email ) Change subject: PFCP: drop no longer needed {ts,tr}_PDU_PFCP ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6091d7e76e852d2487b784fb2b3e39b416a48195 Gerrit-Change-Number: 37951 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:11:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024