August 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: PFCP_Emulation: respond to incoming Heartbeat Req

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37953?usp=email ) Change subject: PFCP_Emulation: respond to incoming Heartbeat Req ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93990feb1864701e2903af85480093ef751bafe5 Gerrit-Change-Number: 37953 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 12:36:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP: add Heartbeat Req/Resp templates

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37952?usp=email ) Change subject: PFCP: add Heartbeat Req/Resp templates ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I569b47b6ebc3ca238da544488cac69dfc1db1dfe Gerrit-Change-Number: 37952 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 12:35:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP: drop no longer needed {ts,tr}_PDU_PFCP

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37951?usp=email ) Change subject: PFCP: drop no longer needed {ts,tr}_PDU_PFCP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6091d7e76e852d2487b784fb2b3e39b416a48195 Gerrit-Change-Number: 37951 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 12:35:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months

1
0
0 0

[S] Change in pysim[master]: tests: move pySim-prog test and its data into a sub directory

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37823?usp=email ) Change subject: tests: move pySim-prog test and its data into a sub directory ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic995a7f600d164fc0be3c2eb8255dbe043429bea Gerrit-Change-Number: 37823 Gerrit-PatchSet: 13 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:52:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months

1
0
0 0

[XS] Change in pysim[master]: tests: move pySim-trace test and its data into a sub directory

by laforge

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37822?usp=email ) Change subject: tests: move pySim-trace test and its data into a sub directory ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I565b4268a05c1a1334b5e7d3fbcd9ef2ef0f0c4c Gerrit-Change-Number: 37822 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:52:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months

1
0
0 0

[XS] Change in pysim[master]: tests: move unittests into a sub directory

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37821?usp=email ) ( 9 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: tests: move unittests into a sub directory ...................................................................... tests: move unittests into a sub directory We currently mix the unit-tests with the shell script based integration tests. Let's put them into a dedicated sub directory. Related: OS#6531 Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24 --- M contrib/jenkins.sh R tests/unittests/test_apdu.py R tests/unittests/test_construct.py R tests/unittests/test_esim.py R tests/unittests/test_esim_bsp.py R tests/unittests/test_esim_saip.py R tests/unittests/test_euicc.py R tests/unittests/test_files.py R tests/unittests/test_globalplatform.py R tests/unittests/test_ota.py R tests/unittests/test_sms.py R tests/unittests/test_tlv.py R tests/unittests/test_tlvs.py R tests/unittests/test_utils.py 14 files changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 16ab1c4..3dabdd7 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -27,7 +27,7 @@ pip install pyshark # Execute automatically discovered unit tests first - python -m unittest discover -v -s tests/ + python -m unittest discover -v -s tests/unittests # Run the test with physical cards cd pysim-testdata @@ -58,7 +58,7 @@ --disable E1102 \ --disable E0401 \ --enable W0301 \ - pySim tests/*.py *.py \ + pySim tests/unittests/*.py *.py \ contrib/*.py ;; "docs") diff --git a/tests/test_apdu.py b/tests/unittests/test_apdu.py similarity index 100% rename from tests/test_apdu.py rename to tests/unittests/test_apdu.py diff --git a/tests/test_construct.py b/tests/unittests/test_construct.py similarity index 100% rename from tests/test_construct.py rename to tests/unittests/test_construct.py diff --git a/tests/test_esim.py b/tests/unittests/test_esim.py similarity index 100% rename from tests/test_esim.py rename to tests/unittests/test_esim.py diff --git a/tests/test_esim_bsp.py b/tests/unittests/test_esim_bsp.py similarity index 100% rename from tests/test_esim_bsp.py rename to tests/unittests/test_esim_bsp.py diff --git a/tests/test_esim_saip.py b/tests/unittests/test_esim_saip.py similarity index 100% rename from tests/test_esim_saip.py rename to tests/unittests/test_esim_saip.py diff --git a/tests/test_euicc.py b/tests/unittests/test_euicc.py similarity index 100% rename from tests/test_euicc.py rename to tests/unittests/test_euicc.py diff --git a/tests/test_files.py b/tests/unittests/test_files.py similarity index 100% rename from tests/test_files.py rename to tests/unittests/test_files.py diff --git a/tests/test_globalplatform.py b/tests/unittests/test_globalplatform.py similarity index 100% rename from tests/test_globalplatform.py rename to tests/unittests/test_globalplatform.py diff --git a/tests/test_ota.py b/tests/unittests/test_ota.py similarity index 100% rename from tests/test_ota.py rename to tests/unittests/test_ota.py diff --git a/tests/test_sms.py b/tests/unittests/test_sms.py similarity index 100% rename from tests/test_sms.py rename to tests/unittests/test_sms.py diff --git a/tests/test_tlv.py b/tests/unittests/test_tlv.py similarity index 100% rename from tests/test_tlv.py rename to tests/unittests/test_tlv.py diff --git a/tests/test_tlvs.py b/tests/unittests/test_tlvs.py similarity index 100% rename from tests/test_tlvs.py rename to tests/unittests/test_tlvs.py diff --git a/tests/test_utils.py b/tests/unittests/test_utils.py similarity index 100% rename from tests/test_utils.py rename to tests/unittests/test_utils.py -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24 Gerrit-Change-Number: 37821 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

10 months

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: Let's keep this patch in review until we have functional or at least unit tests. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:39:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

10 months

1
0
0 0

[S] Change in osmo-upf[master]: pfcp-tool: always use specific PDR ids for access and core

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37756?usp=email ) Change subject: pfcp-tool: always use specific PDR ids for access and core ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37756?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic343494001c70a84f3402ce5749d08e729551b26 Gerrit-Change-Number: 37756 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:25:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months

1
0
0 0

[XS] Change in pysim[master]: suci-tutorial: fix incorrect hnet_pubkey value

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37946?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: suci-tutorial: fix incorrect hnet_pubkey value ...................................................................... suci-tutorial: fix incorrect hnet_pubkey value The first hnet_pubkey value with the identifier 27 seems to be incorrect. It differs from the value suggested in 3GPP TS 31.121, section 4.9.4 and also does not work with the on card SUCI calculation. The tutorial also contains a reference to 3GPP TS 33.501, Annex C.4. This spec specifies an ECIES Profile A and an ECIES Profile B. The tutorial recommends to use a key from profile B, but it actually uses a key from profile A. Related: OS#6531 Change-Id: I6fddf8a6efc28ad0d40b1715973429904e00d2b2 --- M docs/suci-tutorial.rst 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/docs/suci-tutorial.rst b/docs/suci-tutorial.rst index b4c950f..60d2190 100644 --- a/docs/suci-tutorial.rst +++ b/docs/suci-tutorial.rst @@ -97,7 +97,7 @@ {"priority": 2, "identifier": 0, "key_index": 0}], "hnet_pubkey_list": [ {"hnet_pubkey_identifier": 27, - "hnet_pubkey": "0272DA71976234CE833A6907425867B82E074D44EF907DFB4B3E21C1C2256EBCD1"}, + "hnet_pubkey": "0472DA71976234CE833A6907425867B82E074D44EF907DFB4B3E21C1C2256EBCD15A7DED52FCBB097A4ED250E036C7B9C8C7004C4EEDC4F068CD7BF8D3F900E3B4"}, {"hnet_pubkey_identifier": 30, "hnet_pubkey": "5A8D38864820197C3394B92613B20B91633CBD897119273BF8E4A6F4EEC0A650"}] } @@ -106,7 +106,7 @@ :: - pySIM-shell (00:MF/ADF.USIM/DF.5GS/EF.SUCI_Calc_Info)> update_binary_decoded '{ "prot_scheme_id_list": [ {"priority": 0, "identifier": 2, "key_index": 1}, {"priority": 1, "identifier": 1, "key_index": 2}, {"priority": 2, "identifier": 0, "key_index": 0}], "hnet_pubkey_list": [ {"hnet_pubkey_identifier": 27, "hnet_pubkey": "0272DA71976234CE833A6907425867B82E074D44EF907DFB4B3E21C1C2256EBCD1"}, {"hnet_pubkey_identifier": 30, "hnet_pubkey": "5A8D38864820197C3394B92613B20B91633CBD897119273BF8E4A6F4EEC0A650"}]}' + pySIM-shell (00:MF/ADF.USIM/DF.5GS/EF.SUCI_Calc_Info)> update_binary_decoded '{ "prot_scheme_id_list": [ {"priority": 0, "identifier": 2, "key_index": 1}, {"priority": 1, "identifier": 1, "key_index": 2}, {"priority": 2, "identifier": 0, "key_index": 0}], "hnet_pubkey_list": [ {"hnet_pubkey_identifier": 27, "hnet_pubkey": "0472DA71976234CE833A6907425867B82E074D44EF907DFB4B3E21C1C2256EBCD15A7DED52FCBB097A4ED250E036C7B9C8C7004C4EEDC4F068CD7BF8D3F900E3B4"}, {"hnet_pubkey_identifier": 30, "hnet_pubkey": "5A8D38864820197C3394B92613B20B91633CBD897119273BF8E4A6F4EEC0A650"}]}' WARNING: These are TEST KEYS with publicly known/specified private keys, and hence unsafe for live/secure deployments! For use in production networks, you need to generate your own set[s] of keys. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6fddf8a6efc28ad0d40b1715973429904e00d2b2 Gerrit-Change-Number: 37946 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

10 months

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors

by laforge

Attention is currently required from: fixeria, lynxis lazus, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 30 Aug 2024 05:23:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024