Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37641?usp=email )
Change subject: pySim-shell: enable export of DF and ADF files
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/37641/comment/33ad01bb_8304118d?usp=em… :
PS2, Line 602:
> I made it conditionally because I the information from the ADF (ADF. […]
I'd simply include everything by default. One can always easily delete parts from the output, if one doesn't want them.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37641?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3ee661dbae5c11fec23911775f352ac13bc2c6e5
Gerrit-Change-Number: 37641
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Aug 2024 14:11:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: fixeria.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email )
Change subject: add debian package files
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
Patchset:
PS3:
This needs a `contrib/generate_build_dep.sh` like in osmo_dia2gsup, otherwise:
```
dh_auto_build
make -j17
make[2]: Entering directory '/obs/_temp/binpkgs/osmo-s1gw'
rebar3 asn compile
===> Fetching provider_asn1 (from {git,"https://github.com/knusbaum/provider_asn1.git",
{tag,"0.4.0"}})
===> Errors loading plugin {provider_asn1,".*",
{git,
"https://github.com/knusbaum/provider_asn1.git",
{tag,"0.4.0"}}}. Run rebar3 with DEBUG=1 set to see errors.
===> Command asn not found
make[2]: *** [Makefile:15: include/S1AP-*.hrl] Error 1
```
This can be reproduced by checking out https://gerrit.osmocom.org/c/osmo-ci/+/37773 and running `path-to-osmo-ci/scripts/obs/gerrit_binpkgs.sh debian:12` from the osmo-s1gw directory.
I'm looking into how this needs to be adjusted to make it pass.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I5446c70c1c1f232a2a45de60be7068cfd683a99c
Gerrit-Change-Number: 37730
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Aug 2024 09:04:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, laforge.
Hello Jenkins Builder, fixeria, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/37642?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: filesystem: add export method for ADF files
......................................................................
filesystem: add export method for ADF files
This patch adds an export method to CardADF, which calls the application
specific export method in CardApplication class
Related: OS#6092
Change-Id: I8129656096ecaf41b36e5f2afbbfbebcd0587886
---
M pySim/filesystem.py
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/42/37642/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37642?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I8129656096ecaf41b36e5f2afbbfbebcd0587886
Gerrit-Change-Number: 37642
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: neels.
dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37755?usp=email )
Change subject: pfcp-tool: fix extra newline in vty_out
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37755?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ib3bb0795238f251ea5b515fe639280be66542a01
Gerrit-Change-Number: 37755
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Aug 2024 13:43:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: neels.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/37764?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: osmo-pfcp-tool: add GTP flooding using io_uring
......................................................................
osmo-pfcp-tool: add GTP flooding using io_uring
Freely copying from gtp-load-gen.c, implement GTP flooding in
osmo-pfcp-tool scripts.
Add dependency liburing. It can be disabled with
configure --disable-uring
in which case the new 'gtp flood' command only logs an error.
This verbosely commented example script serves as a good explanation:
contrib/osmo-pfcp-tool-scripts/gtp_flood.vty
Related: SYS#6590
Change-Id: I332aa0e2efd55f6e357cde4752a3d8b584db531b
---
M TODO-RELEASE
M configure.ac
A contrib/osmo-pfcp-tool-scripts/gtp_flood.vty
M debian/control
M include/osmocom/pfcptool/Makefile.am
A include/osmocom/pfcptool/checksum.h
A include/osmocom/pfcptool/gtp_flood.h
M include/osmocom/pfcptool/pfcp_tool.h
A include/osmocom/pfcptool/range.h
M src/osmo-pfcp-tool/Makefile.am
A src/osmo-pfcp-tool/checksum.c
A src/osmo-pfcp-tool/gtp_flood.c
M src/osmo-pfcp-tool/osmo_pfcp_tool_main.c
M src/osmo-pfcp-tool/pfcp_tool.c
M src/osmo-pfcp-tool/pfcp_tool_vty.c
A src/osmo-pfcp-tool/range.c
16 files changed, 1,299 insertions(+), 27 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/64/37764/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37764?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I332aa0e2efd55f6e357cde4752a3d8b584db531b
Gerrit-Change-Number: 37764
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Attention is currently required from: laforge.
fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37778?usp=email )
Change subject: pySim.cards: Make file_exists() check for activated/deactivated
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37778?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I73bd1ab3780e475c96a10cd5dbdd45b829c67335
Gerrit-Change-Number: 37778
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 06 Aug 2024 18:50:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes