Attention is currently required from: fixeria.
Hello Jenkins Builder, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37719?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: examples/sys.config: add default lager formatting config
......................................................................
examples/sys.config: add default lager formatting config
Related: OS#6450
Change-Id: I2b9c3111a0539703f96c265ae16a0413460d0217
---
M examples/sys.config
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/19/37719/4
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37719?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: I2b9c3111a0539703f96c265ae16a0413460d0217
Gerrit-Change-Number: 37719
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37752?usp=email )
Change subject: includes: sgsn.h: use full path include for gtp.h
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37752?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I764644110c0f332b18117e1e8311ddc55eafd5fa
Gerrit-Change-Number: 37752
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 05 Aug 2024 12:39:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37317?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: erab_fsm: E-RAB FSM implementation
......................................................................
erab_fsm: E-RAB FSM implementation
Change-Id: Ic57e14675339b7cadb0cdd7cbc5d3a56288d7297
---
M rebar.config
A src/erab_fsm.erl
A test/erab_fsm_test.erl
A test/pfcp_mock.erl
A test/pfcp_mock.hrl
5 files changed, 663 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/17/37317/10
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37317?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ic57e14675339b7cadb0cdd7cbc5d3a56288d7297
Gerrit-Change-Number: 37317
Gerrit-PatchSet: 10
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/33938?usp=email )
Change subject: do not merge: testing CI
......................................................................
Abandoned
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/33938?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: Ic78700d85b24a7d4b777360902410ebe21449eda
Gerrit-Change-Number: 33938
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37643?usp=email )
Change subject: ara_m: add export support for the ARA-M application
......................................................................
Patch Set 3:
(1 comment)
File pySim/ara_m.py:
https://gerrit.osmocom.org/c/pysim/+/37643/comment/aaf0937c_11dd4895?usp=em… :
PS2, Line 425: if 'ref_ar_do' in ref_ar_do_list:
: for ref_ar_do in ref_ar_do_list['ref_ar_do']:
: if 'ref_do' in ref_ar_do:
: ref_do_list = ref_ar_do['ref_do']
: if 'ar_do' in ref_ar_do:
: ar_do_list = ref_ar_do['ar_do']
:
: if ref_do_list and ar_do_list:
: aid_ref_do = None
: dev_app_id_ref_do = None
: apdu_ar_do = None
: nfc_ar_do = None
: perm_ar_do = None
: pkg_ref_do = None
: for ref_do in ref_do_list:
: if 'aid_ref_do' in ref_do:
: aid_ref_do = ref_do['aid_ref_do']
: if 'dev_app_id_ref_do' in ref_do:
: dev_app_id_ref_do = ref_do['dev_app_id_ref_do']
: if 'pkg_ref_do' in ref_do:
: pkg_ref_do = ref_do['pkg_ref_do']
: for ar_do in ar_do_list:
: if 'apdu_ar_do' in ar_do:
: apdu_ar_do = ar_do['apdu_ar_do']
: if 'nfc_ar_do' in ar_do:
: nfc_ar_do = ar_do['nfc_ar_do']
: if 'perm_ar_do' in ar_do:
: perm_ar_do = ar_do['perm_ar_do']
> why do we need all those maipulations? it's a lot of hand-written code which I'd rather avoid (also, […]
I have put it into a helper function, now it is much shorter.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37643?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I811cb9d25cb8ee194b4ead5fb2cabf1fdc0c1c43
Gerrit-Change-Number: 37643
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Aug 2024 13:23:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: osmith.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email )
Change subject: add debian package files
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
> With this patch checked out and `gbp dch --ignore-branch --since=0.1.0`, I got: [...]
Interestingly enough, I was getting a different output with exactly the same command. I ended up grabbing this file from `gapk.git` and changing it a bit. This should be enough, I guess. At least I can build the package using `dpkg-buildpackage -B --no-sign`.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I5446c70c1c1f232a2a45de60be7068cfd683a99c
Gerrit-Change-Number: 37730
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Aug 2024 18:06:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37784?usp=email )
Change subject: filesystem: fix typo
......................................................................
filesystem: fix typo
Change-Id: I17f184bbcf494c5fe944602224cf72d6a22cbc9d
---
M pySim/filesystem.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
dexter: Looks good to me, approved
diff --git a/pySim/filesystem.py b/pySim/filesystem.py
index e3efcab..624619b 100644
--- a/pySim/filesystem.py
+++ b/pySim/filesystem.py
@@ -64,7 +64,7 @@
Args:
fid : File Identifier (4 hex digits)
sfid : Short File Identifier (2 hex digits, optional)
- name : Brief name of the file, lik EF_ICCID
+ name : Brief name of the file, like EF_ICCID
desc : Description of the file
parent : Parent CardFile object within filesystem hierarchy
profile : Card profile that this file should be part of
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37784?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I17f184bbcf494c5fe944602224cf72d6a22cbc9d
Gerrit-Change-Number: 37784
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37774?usp=email )
Change subject: runtime: integrate escape route for applications without ADF support
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37774?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie6f37d13af880d24a9c7a8a95cef436b603587c7
Gerrit-Change-Number: 37774
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Aug 2024 07:29:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes