lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

July 2024

  • 1 participants
  • 1379 discussions
[S] Change in osmo-ci[master]: publish-tarballs-for-tags.sh: publish osmo-epdg's versions
by lynxis lazus 02 Jul '24

02 Jul '24
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/37324?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: publish-tarballs-for-tags.sh: publish osmo-epdg's versions ...................................................................... publish-tarballs-for-tags.sh: publish osmo-epdg's versions Change-Id: I3445e76f6fd6ebb49ada5dc4320c6b9fa717f00c --- M scripts/common.sh M scripts/tarballs/publish-tarballs-for-tags.sh 2 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/24/37324/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3445e76f6fd6ebb49ada5dc4320c6b9fa717f00c Gerrit-Change-Number: 37324 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
1 0
0 0
[S] Change in osmo-ci[master]: publish-tarballs-for-tags.sh: publish osmo-epdg's versions
by lynxis lazus 02 Jul '24

02 Jul '24
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/37324?usp=email ) Change subject: publish-tarballs-for-tags.sh: publish osmo-epdg's versions ...................................................................... publish-tarballs-for-tags.sh: publish osmo-epdg's versions Change-Id: I3445e76f6fd6ebb49ada5dc4320c6b9fa717f00c --- M scripts/common.sh M scripts/tarballs/publish-tarballs-for-tags.sh 2 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/24/37324/1 diff --git a/scripts/common.sh b/scripts/common.sh index e1d8718..d7cb5b6 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -80,6 +80,9 @@ local url ret pattern case "$project" in + strongswan-epdg) + pattern='refs/tags/osmo-epdg-[0-9.]*$' + ;; gapk|osmo-fl2k|rtl-sdr) pattern='refs/tags/v[0-9.]*$' ;; @@ -139,6 +142,9 @@ osmo-isdntap) echo "$OSMO_GIT_URL_GITEA"/retronetworking/"$1" ;; + strongswan-epdg) + echo "$OSMO_GIT_URL_GITEA"/ims-volte-vowifi/"$1" + ;; osmo_dia2gsup|osmo-epdg) echo "$OSMO_GIT_URL_GERRIT"/erlang/"$1" ;; diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh b/scripts/tarballs/publish-tarballs-for-tags.sh index 46a2e17..a3cbad1 100755 --- a/scripts/tarballs/publish-tarballs-for-tags.sh +++ b/scripts/tarballs/publish-tarballs-for-tags.sh @@ -23,6 +23,7 @@ osmo-cbc osmo-e1-recorder osmo-e1d + osmo-epdg osmo-fl2k osmo-gbproxy osmo-ggsn @@ -46,6 +47,7 @@ osmocom-bb rtl-sdr simtrace2 + strongswan-epdg " # Old release tags that are duplicates or where generating the tarball fails -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3445e76f6fd6ebb49ada5dc4320c6b9fa717f00c Gerrit-Change-Number: 37324 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: asterisk: SIP: Fix INVITE template use
by pespin 02 Jul '24

02 Jul '24
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37323?usp=email ) Change subject: asterisk: SIP: Fix INVITE template use ...................................................................... asterisk: SIP: Fix INVITE template use New optional parameters for extra headers were added to tr_SIP_INVITE, but this user was not updated to keep the previous logic. Change-Id: I98b23533f35ffa09f488cb520ed9282935793408 --- M asterisk/SIP_ConnectionHandler.ttcn 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/37323/1 diff --git a/asterisk/SIP_ConnectionHandler.ttcn b/asterisk/SIP_ConnectionHandler.ttcn index 3bc4f1d..0cb6167 100644 --- a/asterisk/SIP_ConnectionHandler.ttcn +++ b/asterisk/SIP_ConnectionHandler.ttcn @@ -564,7 +564,8 @@ tr_From(tr_Addr_Union_from_val(g_pars.cp.calling.addr), *), tr_To(tr_Addr_Union_from_val(g_pars.cp.called.addr), *), tr_Via_from(f_tr_HostPort(g_pars.remote_sip_host, g_pars.remote_sip_port)), - ?, ?); + ?, + body := ?); var charstring sip_expect_str := log2str(exp_req); [] SIP.receive(exp_req) -> value g_rx_sip_req { @@ -695,7 +696,7 @@ g_pars.cp.to_addr, tr_Via_from(f_tr_HostPort(g_pars.remote_sip_host, g_pars.remote_sip_port)), exp_seq_nr, - ?); + body := ?); var charstring sip_expect_str := log2str(exp_req); [] SIP.receive(exp_req) -> value g_rx_sip_req { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37323?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98b23533f35ffa09f488cb520ed9282935793408 Gerrit-Change-Number: 37323 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[S] Change in docker-playground[master]: ttcn3-asterisk: Fix ICSI value encoding
by pespin 02 Jul '24

02 Jul '24
pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37315?usp=email ) Change subject: ttcn3-asterisk: Fix ICSI value encoding ...................................................................... ttcn3-asterisk: Fix ICSI value encoding As seen in TS 24.229 7.2A.8.2 example. Change-Id: I02b3d54003bb02e999b27b533a651299dbb53503 --- M ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved neels: Looks good to me, but someone else must approve diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf index 8dc4e6c..ac08fe2 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf @@ -94,7 +94,7 @@ expiration=600000 ims_aka=yes contact_user=volte_ims -contact_header_params=+g.3gpp.icsi-ref="urn\%3Aurn-7\%3A3gpp-service.ims.icsi.mmtel"\;audio\;+sip.instance="<urn:gsma:imei:35876110-027790-0>" +contact_header_params=+g.3gpp.icsi-ref="urn%3Aurn-7%3A3gpp-service.ims.icsi.mmtel"\;audio\;+sip.instance="<urn:gsma:imei:35876110-027790-0>" endpoint=volte_ims line=yes manual_register=yes -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02b3d54003bb02e999b27b533a651299dbb53503 Gerrit-Change-Number: 37315 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
[S] Change in docker-playground[master]: ttcn3-asterisk: Fix ICSI value encoding
by pespin 02 Jul '24

02 Jul '24
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37315?usp=email ) Change subject: ttcn3-asterisk: Fix ICSI value encoding ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02b3d54003bb02e999b27b533a651299dbb53503 Gerrit-Change-Number: 37315 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 13:41:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: fix SDP precondition validation
by pespin 02 Jul '24

02 Jul '24
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37322?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: asterisk: IMS: fix SDP precondition validation ...................................................................... asterisk: IMS: fix SDP precondition validation Change-Id: I8e22f76f7c0a8e6fda70252b330b1b174ca5c66f --- M asterisk/IMS_ConnectionHandler.ttcn M library/SDP_Templates.ttcn 2 files changed, 39 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/37322/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37322?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8e22f76f7c0a8e6fda70252b330b1b174ca5c66f Gerrit-Change-Number: 37322 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Fix INVITE Contact header validation
by pespin 02 Jul '24

02 Jul '24
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37314?usp=email ) Change subject: asterisk: IMS: Fix INVITE Contact header validation ...................................................................... asterisk: IMS: Fix INVITE Contact header validation Related: SYS#6984 Change-Id: Icfc055859527c9c09ba0fa2648a85ac2ac2fa0bb --- M asterisk/IMS_ConnectionHandler.ttcn 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index af44647..32c129e 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -381,7 +381,7 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str(g_name & ": Received unexpected empty Contact attributes (omit)")); } - f_sip_param_match_value_or_fail(caddr.contactParams, "+g.3gpp.icsi-ref", "\"urn\\%3Aurn-7\\%3A3gpp-service.ims.icsi.mmtel\""); + f_sip_param_match_value_or_fail(caddr.contactParams, "+g.3gpp.icsi-ref", "\"urn%3Aurn-7%3A3gpp-service.ims.icsi.mmtel\""); f_sip_param_match_value_or_fail(caddr.contactParams, "+sip.instance", "\"<urn:gsma:imei:" & g_pars.subscr.imei & ">\""); f_sip_param_match_value_or_fail(caddr.contactParams, "audio", omit); @@ -478,7 +478,7 @@ } /* GSMA FCM.01 3.2.3.3: "The INVITE request contains Within the Contact header [...] the IMS * Communication Service Identifier's (ICSI) for IMS Multimedia Telephony" */ - f_sip_param_match_value_or_fail(caddr.contactParams, "+g.3gpp.icsi-ref", "\"urn\\%3Aurn-7\\%3A3gpp-service.ims.icsi.mmtel\""); + f_sip_param_match_value_or_fail(caddr.contactParams, "+g.3gpp.icsi-ref", "\"urn%3Aurn-7%3A3gpp-service.ims.icsi.mmtel\""); /* "The UE must include the audio media feature tag, as defined in IETF RFC 3840, * in the Contact header field of the SIP INVITE request, and in the Contact header * field of the SIP response to the SIP INVITE request" */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37314?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icfc055859527c9c09ba0fa2648a85ac2ac2fa0bb Gerrit-Change-Number: 37314 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: asterisk: Set DedicatedBearerStatus to Down when call finishes
by pespin 02 Jul '24

02 Jul '24
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37312?usp=email ) Change subject: asterisk: Set DedicatedBearerStatus to Down when call finishes ...................................................................... asterisk: Set DedicatedBearerStatus to Down when call finishes Update the correct state so that asterisk doesn't believe the bearer is still up. Change-Id: Idf4d250e6edb830fe7e2d85dc15e0b3c4d8c3a8b --- M asterisk/Asterisk_Tests.ttcn 1 file changed, 33 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index f6b6b3e..3dbb81c 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -65,6 +65,9 @@ port Coord_PT COORD; port IMSCoord_PT IMS_COORD; + + /* Store Channel name obtained from Newchannel AMI event: */ + var charstring g_asterisk_chan_name; } const charstring broadcast_sip_extension := "0500"; @@ -688,8 +691,9 @@ ami_msg := f_ami_wait_rx_msg(AMI_CLIENT, tr_AMI_Event_Newchannel(mp_volte_ims_outbound_registration), fail_others := false); + g_asterisk_chan_name := valueof(f_ami_msg_get_value(ami_msg, AMI_FIELD_CHANNEL)); f_ami_action_DedicatedBearerStatus(AMI_CLIENT, - f_ami_msg_get_value(ami_msg, AMI_FIELD_CHANNEL), + g_asterisk_chan_name, "Up", fail_others := false); COORD.receive(COORD_CMD_CALL_ESTABLISHED) from vc_conn_sip; @@ -769,6 +773,12 @@ COORD.send(COORD_CMD_HANGUP) to vc_conn_sip; IMS_COORD.receive(IMS_COORD_CMD_CALL_FINISHED) from vc_conn_ims; + /* Notify network released dedicated bearer: */ + AMI_CLIENT.clear; + f_ami_action_DedicatedBearerStatus(AMI_CLIENT, + g_asterisk_chan_name, + "Down", fail_others := false); + /* Trigger unregistration: */ f_sleep(1.0); COORD.send(COORD_CMD_UNREGISTER) to vc_conn_sip; @@ -804,6 +814,7 @@ COORD.receive(IMS_COORD_CMD_HANGUP); f_IMS_do_call_hangup(); setverdict(pass); + COORD.send(IMS_COORD_CMD_CALL_FINISHED); as_IMS_unregister(); } @@ -845,11 +856,12 @@ ami_msg := f_ami_wait_rx_msg(AMI_CLIENT, tr_AMI_Event_Newchannel(mp_volte_ims_outbound_registration), fail_others := false); + g_asterisk_chan_name := valueof(f_ami_msg_get_value(ami_msg, AMI_FIELD_CHANNEL)); if (ims_pars.subscr.cp.mt.tx_coord_cmd_session_progress) { IMS_COORD.receive(IMS_COORD_CMD_CALL_SESSION_PROGRESS) from vc_conn_ims; } f_ami_action_DedicatedBearerStatus(AMI_CLIENT, - f_ami_msg_get_value(ami_msg, AMI_FIELD_CHANNEL), + g_asterisk_chan_name, "Up", fail_others := false); IMS_COORD.receive(IMS_COORD_CMD_CALL_ESTABLISHED) from vc_conn_ims; @@ -860,6 +872,13 @@ IMS_COORD.send(IMS_COORD_CMD_HANGUP) to vc_conn_ims; + /* Notify network released dedicated bearer: */ + IMS_COORD.receive(IMS_COORD_CMD_CALL_FINISHED) from vc_conn_ims; + AMI_CLIENT.clear; + f_ami_action_DedicatedBearerStatus(AMI_CLIENT, + g_asterisk_chan_name, + "Down", fail_others := false); + /* Trigger unregistration: */ f_sleep(1.0); AMI_CLIENT.clear; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37312?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idf4d250e6edb830fe7e2d85dc15e0b3c4d8c3a8b Gerrit-Change-Number: 37312 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Validate Accept header in MO INVITE
by pespin 02 Jul '24

02 Jul '24
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37313?usp=email ) Change subject: asterisk: IMS: Validate Accept header in MO INVITE ...................................................................... asterisk: IMS: Validate Accept header in MO INVITE Related: SYS#6968 Change-Id: I7e419ae1cde384590b54c87c198cc411640c4594 --- M asterisk/IMS_ConnectionHandler.ttcn M library/SIP_Templates.ttcn 2 files changed, 42 insertions(+), 1 deletion(-) Approvals: neels: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index 881240b..af44647 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -1174,6 +1174,7 @@ via, calling_contact, g_pars.subscr.cp.sip_seq_nr, + accept := ts_Accept({ ts_AcceptBody("application/sdp"), ts_AcceptBody("application/3gpp-ims+xml") }), min_SE := min_SE, session_expires := session_expires, supported := supported, @@ -1400,6 +1401,7 @@ altstep as_IMS_mo_call_accept(boolean exp_update_to_direct_rtp := false, boolean fail_others := true) runs on IMS_ConnHdlr { + /* 3GPP TS 24.229 5.1.3.1 Initial INVITE request */ var template (present) PDU_SIP_Request exp_req := tr_SIP_INVITE(f_tr_SipUrl_opt_defport(ts_SipUrl_from_Addr_Union(g_pars.subscr.cp.called.addr)), ?, @@ -1407,6 +1409,7 @@ tr_To(tr_Addr_Union_from_val(g_pars.subscr.cp.called.addr), *), tr_Via_from(f_tr_HostPort(g_pars.subscr.remote_sip_host, g_pars.subscr.ipsec_remote_port_s)), ?, + accept := tr_Accept(superset(tr_AcceptBody("application/sdp"), tr_AcceptBody("application/3gpp-ims+xml"))), supported := tr_Supported(superset("timer")), body := ?); var charstring sip_expect_str := log2str(exp_req); diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index ffc4550..bfb3655 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -69,6 +69,26 @@ } } +// [20.1, RFC2616 14.1] +template (present) AcceptBody tr_AcceptBody(template (present) charstring mediaRange, + template SemicolonParam_List acceptParam := *) := { + mediaRange := mediaRange, + acceptParam := acceptParam +} +template (value) AcceptBody ts_AcceptBody(template (value) charstring mediaRange, + template (omit) SemicolonParam_List acceptParam := omit) := { + mediaRange := mediaRange, + acceptParam := acceptParam +} +template (present) Accept tr_Accept(template AcceptBody_List acceptArgs := *) := { + fieldName := ACCEPT_E, + acceptArgs := acceptArgs +} +template (value) Accept ts_Accept(template (omit) AcceptBody_List acceptArgs := omit) := { + fieldName := ACCEPT_E, + acceptArgs := acceptArgs +} + // [20.5] template (present) Allow tr_Allow(template Method_List methods := *) := { fieldName := ALLOW_E, @@ -711,7 +731,8 @@ template (value) Via via, template (omit) ContentLength content_length := ts_ContentLength(0), template (omit) ContentType content_type := omit, - template (omit)Authorization authorization := omit, + template (omit) Accept accept := omit, + template (omit) Authorization authorization := omit, template (omit) Allow allow := ts_Allow(c_SIP_defaultMethods), template (omit) Expires expires := omit, template (omit) MinExpires minExpires := omit, @@ -728,6 +749,7 @@ template (omit) UserAgent userAgent := ts_UserAgent({ "osmo-ttcn3-hacks/0.23" }), template (omit) WwwAuthenticate wwwAuthenticate := omit ) modifies ts_SIP_msgHeader_empty := { + accept := accept, allow := allow, authorization := authorization, callId := { @@ -771,6 +793,7 @@ template integer seq_nr := ?, template ContentLength content_length := *, template ContentType content_type := *, + template Accept accept := *, template Allow allow := *, template Authorization authorization := *, template Expires expires := *, @@ -787,6 +810,7 @@ template UserAgent userAgent := *, template WwwAuthenticate wwwAuthenticate := * ) modifies t_SIP_msgHeader_any := { + accept := accept, allow := allow, authorization := authorization, callId := { @@ -880,6 +904,7 @@ template (value) Via via, template (value) Contact contact, integer seq_nr, + template (omit) Accept accept := omit, template (omit) Min_SE min_SE := omit, template (omit) Session_expires session_expires := omit, template (omit) Supported supported := omit, @@ -890,6 +915,7 @@ via, content_length := f_ContentLength(body), content_type := f_ContentTypeOrOmit(ts_CT_SDP, body), + accept := accept, min_SE := min_SE, session_expires := session_expires, supported := supported), @@ -903,6 +929,7 @@ template To to_addr, template Via via := tr_Via_from(f_tr_HostPort_opt_defport(?)), template integer seq_nr, + template Accept accept := *, template Min_SE min_SE := *, template Session_expires session_expires := *, template Supported supported := *, @@ -910,6 +937,7 @@ requestLine := tr_SIP_ReqLine(INVITE_E, uri), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, ?, via, "INVITE", seq_nr, + accept := accept, min_SE := min_SE, session_expires := session_expires), messageBody := body, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37313?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7e419ae1cde384590b54c87c198cc411640c4594 Gerrit-Change-Number: 37313 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Fix INVITE Contact header validation
by pespin 02 Jul '24

02 Jul '24
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37314?usp=email ) Change subject: asterisk: IMS: Fix INVITE Contact header validation ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37314?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icfc055859527c9c09ba0fa2648a85ac2ac2fa0bb Gerrit-Change-Number: 37314 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 12:49:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 134
  • 135
  • 136
  • 137
  • 138
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.