July 2024 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-s1gw[master]: Makefile: allow overriding the config file

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37316?usp=email ) Change subject: Makefile: allow overriding the config file ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37316?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If077e9c0e06d7b081b5254bcded77ee65bcd8e5d Gerrit-Change-Number: 37316 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jul 2024 00:39:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[L] Change in ...osmo-s1gw[master]: pfcp_peer: PFCP peer implementation

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37268?usp=email ) Change subject: pfcp_peer: PFCP peer implementation ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37268?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7bad0069dca2111006039d12e744a2bd6d2cb86e Gerrit-Change-Number: 37268 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 02 Jul 2024 23:40:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: rebar.{config,lock}: add pfcplib to deps[]

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37267?usp=email ) Change subject: rebar.{config,lock}: add pfcplib to deps[] ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37267?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I4cf3b3b09b19ebabbaad082c616c31ffc1327fd7 Gerrit-Change-Number: 37267 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 23:40:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: config/sys.config: print prefix before msg, if present

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37327?usp=email ) Change subject: config/sys.config: print prefix before msg, if present ...................................................................... config/sys.config: print prefix before msg, if present It's sometimes desirable to add some context to logging messages, like the FSM name and identifier, for instance. With this patch, this can be easily achieved by passing an arbitrary prefix string to a logging function/macro: %% EXAMPLE: adding metadata to a specific log macro ?LOG_INFO("The planet is fine...", #{prefix = "EARTH"}). or by setting it for all logging of a process: %% EXAMPLE: adding context for the whole process logger:set_process_metadata(#{prefix => "E-RAB FSM"}). Change-Id: Ib88801b8d38976b98a02ed06e1638e0e9056bafb --- M config/sys.config 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/27/37327/1 diff --git a/config/sys.config b/config/sys.config index 5ccd43d..cf8ff34 100644 --- a/config/sys.config +++ b/config/sys.config @@ -27,6 +27,7 @@ single_line => false, template => [time, " ", color, "[", level, "]", {pid, [" ", pid, ""], ""}, + {prefix, [" ", prefix, " ::"], ""}, " ", msg, {mfa, [" (", mfa, ":", line, ")"], ""}, reset, "\n"]}}}}]}]}]. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37327?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib88801b8d38976b98a02ed06e1638e0e9056bafb Gerrit-Change-Number: 37327 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 3 weeks

1
0
0 0

[L] Change in ...osmo-s1gw[master]: erab_fsm: E-RAB FSM implementation

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37317?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: erab_fsm: E-RAB FSM implementation ...................................................................... erab_fsm: E-RAB FSM implementation Change-Id: Ic57e14675339b7cadb0cdd7cbc5d3a56288d7297 --- A src/erab_fsm.erl M src/pfcp_peer.erl 2 files changed, 386 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/17/37317/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic57e14675339b7cadb0cdd7cbc5d3a56288d7297 Gerrit-Change-Number: 37317 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-remsim[master]: remsim_client: add support to set sim presence pin polarity

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/36983?usp=email ) Change subject: remsim_client: add support to set sim presence pin polarity ...................................................................... remsim_client: add support to set sim presence pin polarity The sim presence pin allows the simtrace2 to inform the modem about the presence of the simcard. On a generic simcard slot a button is pressed by the simcard which generate a high or low voltage level. Even there are specifications of minipcie or ngff defining this signal, certain modems don't follow the specification and require a different signal level. Related: SYS#6946 Depends-on: Iacde63e667472a85a5f18cb4ca99dcfa1a84dd59 (simtrace2) Change-Id: Iaa61967d2e8cd5c2269b73f4e65b42072e0ec513 --- M TODO-RELEASE M src/client/Makefile.am M src/client/client.h M src/client/remsim_client_main.c M src/client/user_simtrace2.c 5 files changed, 45 insertions(+), 3 deletions(-) Approvals: neels: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 4a35f50..7aeffd4 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line libosmocore > 1.9.0 working (compiling) gsmtap_inst_fd2() +libosmo-simtrace2 >= 0.9.0 required to compile (sim presence polarity) diff --git a/src/client/Makefile.am b/src/client/Makefile.am index b4d5bd5..f158424 100644 --- a/src/client/Makefile.am +++ b/src/client/Makefile.am @@ -32,7 +32,7 @@ bin_PROGRAMS += osmo-remsim-client-st2 osmo_remsim_client_st2_SOURCES = user_simtrace2.c remsim_client_main.c \ remsim_client.c main_fsm.c ../rspro_client_fsm.c ../debug.c -osmo_remsim_client_st2_CPPFLAGS = -DUSB_SUPPORT +osmo_remsim_client_st2_CPPFLAGS = -DUSB_SUPPORT -DSIMTRACE_SUPPORT osmo_remsim_client_st2_CFLAGS = $(AM_CFLAGS) osmo_remsim_client_st2_LDADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOABIS_LIBS) \ $(OSMOUSB_LIBS) $(OSMOSIMTRACE2_LIBS) \ diff --git a/src/client/client.h b/src/client/client.h index 8fcbcb3..df95312 100644 --- a/src/client/client.h +++ b/src/client/client.h @@ -86,6 +86,13 @@ int addr; char *path; } usb; + + /* only valid for simtrace2 devices */ + struct { + /* allow to define sim presence pin behaviour */ + bool presence_valid; + bool presence_pol; + } simtrace; }; struct bankd_client { diff --git a/src/client/remsim_client_main.c b/src/client/remsim_client_main.c index 372cc92..2f9b8e0 100644 --- a/src/client/remsim_client_main.c +++ b/src/client/remsim_client_main.c @@ -36,6 +36,9 @@ " -r --atr-ignore-rspro Ignore any ATR from bankd; use only ATR given by -a)\n" " -e --event-script <path> event script to be called by client\n" " -L --disable-color Disable colors for logging to stderr\n" +#ifdef SIMTRACE_SUPPORT + " -Z --set-sim-presence <0-1> Define the presence pin behaviour (only supported on some boards)\n" +#endif #ifdef USB_SUPPORT " -V --usb-vendor VENDOR_ID\n" " -P --usb-product PRODUCT_ID\n" @@ -79,6 +82,9 @@ }; c = getopt_long(argc, argv, "hvd:i:p:c:n:a:re:L" +#ifdef SIMTRACE_SUPPORT + "Z:" +#endif #ifdef USB_SUPPORT "V:P:C:I:S:A:H:" #endif @@ -128,6 +134,12 @@ case 'L': log_set_use_color(osmo_stderr_target, 0); break; +#ifdef SIMTRACE_SUPPORT + case 'Z': + cfg->simtrace.presence_valid = true; + cfg->simtrace.presence_pol = atoi(optarg); + break; +#endif #ifdef USB_SUPPORT case 'V': cfg->usb.vendor_id = strtol(optarg, NULL, 16); diff --git a/src/client/user_simtrace2.c b/src/client/user_simtrace2.c index 8dd3423..3bc32e2 100644 --- a/src/client/user_simtrace2.c +++ b/src/client/user_simtrace2.c @@ -396,6 +396,7 @@ struct osmo_st2_transport *transp; struct osmo_st2_cardem_inst *ci; struct client_config *cfg = bc->cfg; + struct cardemu_usb_msg_config cardem_config = { .features = CEMU_FEAT_F_STATUS_IRQ }; int rc, i; rc = osmo_libusb_init(NULL); @@ -456,8 +457,12 @@ for (i = 0; i < 4; i++) allocate_and_submit_in(ci); - /* request firmware to generate STATUS on IRQ endpoint */ - osmo_st2_cardem_request_config(ci, CEMU_FEAT_F_STATUS_IRQ); + /* request firmware to generate STATUS on IRQ endpoint, set presence polarity */ + if (cfg->simtrace.presence_valid) { + cardem_config.pres_pol = cfg->simtrace.presence_pol ? CEMU_CONFIG_PRES_POL_PRES_H : 0; + cardem_config.pres_pol |= CEMU_CONFIG_PRES_POL_VALID; + } + osmo_st2_cardem_request_config2(ci, &cardem_config); while (1) { osmo_select_main(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Iaa61967d2e8cd5c2269b73f4e65b42072e0ec513 Gerrit-Change-Number: 36983 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-remsim[master]: remsim_client: add support to set sim presence pin polarity

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/36983?usp=email ) Change subject: remsim_client: add support to set sim presence pin polarity ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Iaa61967d2e8cd5c2269b73f4e65b42072e0ec513 Gerrit-Change-Number: 36983 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 02 Jul 2024 19:36:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in docker-playground[master]: asterisk: pjsip.conf: Set IMEI

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37326?usp=email ) Change subject: asterisk: pjsip.conf: Set IMEI ...................................................................... asterisk: pjsip.conf: Set IMEI Newer asterisk VoLTE code being developed (jolly/work) now has a config to set the IMEI instead of the whole contact header. Use it. Change-Id: I5d4584fac309bea4afe3929bdca047c31c93b457 --- M ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf index ac08fe2..f7bf49a 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf @@ -94,7 +94,7 @@ expiration=600000 ims_aka=yes contact_user=volte_ims -contact_header_params=+g.3gpp.icsi-ref="urn%3Aurn-7%3A3gpp-service.ims.icsi.mmtel"\;audio\;+sip.instance="<urn:gsma:imei:35876110-027790-0>" +imei=35876110-027790-0 endpoint=volte_ims line=yes manual_register=yes -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37326?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5d4584fac309bea4afe3929bdca047c31c93b457 Gerrit-Change-Number: 37326 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 3 weeks

1
0
0 0

[S] Change in docker-playground[master]: asterisk: pjsip.conf: Set IMEI

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37326?usp=email ) Change subject: asterisk: pjsip.conf: Set IMEI ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Merging to avoid test failing due to new config from new asterisk. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37326?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5d4584fac309bea4afe3929bdca047c31c93b457 Gerrit-Change-Number: 37326 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 17:12:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in docker-playground[master]: asterisk: pjsip.conf: Set IMEI

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37326?usp=email ) Change subject: asterisk: pjsip.conf: Set IMEI ...................................................................... asterisk: pjsip.conf: Set IMEI Newer asterisk VoLTE code being developed (jolly/work) now has a config to set the IMEI instead of the whole contact header. Use it. Change-Id: I5d4584fac309bea4afe3929bdca047c31c93b457 --- M ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/26/37326/1 diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf index ac08fe2..f7bf49a 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf @@ -94,7 +94,7 @@ expiration=600000 ims_aka=yes contact_user=volte_ims -contact_header_params=+g.3gpp.icsi-ref="urn%3Aurn-7%3A3gpp-service.ims.icsi.mmtel"\;audio\;+sip.instance="<urn:gsma:imei:35876110-027790-0>" +imei=35876110-027790-0 endpoint=volte_ims line=yes manual_register=yes -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37326?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5d4584fac309bea4afe3929bdca047c31c93b457 Gerrit-Change-Number: 37326 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024