July 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Introduce test TC_ims_call_mo_session_timer

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37310?usp=email ) Change subject: asterisk: Introduce test TC_ims_call_mo_session_timer ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia87feb6499283a7b51644c391c94a2259415bca2 Gerrit-Change-Number: 37310 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 02:07:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-mgw[master]: fix E1 TS output when used with osmo-e1d

by falconia

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37311?usp=email ) Change subject: fix E1 TS output when used with osmo-e1d ...................................................................... fix E1 TS output when used with osmo-e1d The original code did E1 raw TS output by posting directly to &ts->raw.tx_queue instead of calling e1inp_ts_send_raw(); doing so bypasses the call to driver->want_write performed in e1inp layer. This approach worked for DAHDI where no select-for-write is used; however, e1inp interface to osmo-e1d does use select-for-write, hence applications like osmo-mgw do need to use e1inp_ts_send_raw() API in order to work correctly. Change-Id: I6ce9a1dea6834632faf75059e85ca9a0c25d57c2 --- M src/libosmo-mgcp/mgcp_e1.c 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/11/37311/1 diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c index 1180e03..1428824 100644 --- a/src/libosmo-mgcp/mgcp_e1.c +++ b/src/libosmo-mgcp/mgcp_e1.c @@ -324,7 +324,7 @@ msgb_length(msg) > DEBUG_BYTES_MAX ? DEBUG_BYTES_MAX : msgb_length(msg))); #endif /* Hand data over to the E1 stack */ - msgb_enqueue(&ts->raw.tx_queue, msg); + e1inp_ts_send_raw(ts, msg); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6ce9a1dea6834632faf75059e85ca9a0c25d57c2 Gerrit-Change-Number: 37311 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

11 months, 3 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: build config: add --disable-ortp option

by falconia

falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email ) Change subject: build config: add --disable-ortp option ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I554260483b94d812ac3a957c969a902870f53883 Gerrit-Change-Number: 36975 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 02:11:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Support validating Session-Expires and Min-SE during I...

by neels

Attention is currently required from: daniel, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37304?usp=email ) Change subject: asterisk: IMS: Support validating Session-Expires and Min-SE during INVITE ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie0d19243578f6a5e2962216a869694f7df7ea9cd Gerrit-Change-Number: 37304 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 02:06:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-asterisk: Fix ICSI value encoding

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37315?usp=email ) Change subject: ttcn3-asterisk: Fix ICSI value encoding ...................................................................... ttcn3-asterisk: Fix ICSI value encoding As seen in TS 24.229 7.2A.8.2 example. Change-Id: I02b3d54003bb02e999b27b533a651299dbb53503 --- M ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/15/37315/1 diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf index 8dc4e6c..ac08fe2 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf @@ -94,7 +94,7 @@ expiration=600000 ims_aka=yes contact_user=volte_ims -contact_header_params=+g.3gpp.icsi-ref="urn\%3Aurn-7\%3A3gpp-service.ims.icsi.mmtel"\;audio\;+sip.instance="<urn:gsma:imei:35876110-027790-0>" +contact_header_params=+g.3gpp.icsi-ref="urn%3Aurn-7%3A3gpp-service.ims.icsi.mmtel"\;audio\;+sip.instance="<urn:gsma:imei:35876110-027790-0>" endpoint=volte_ims line=yes manual_register=yes -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02b3d54003bb02e999b27b533a651299dbb53503 Gerrit-Change-Number: 37315 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 3 weeks

1
0
0 0

[L] Change in ...osmo-s1gw[master]: erab_fsm: E-RAB FSM implementation

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37317?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: erab_fsm: E-RAB FSM implementation ...................................................................... erab_fsm: E-RAB FSM implementation Change-Id: Ic57e14675339b7cadb0cdd7cbc5d3a56288d7297 --- A src/erab_fsm.erl M src/pfcp_peer.erl 2 files changed, 356 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/17/37317/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic57e14675339b7cadb0cdd7cbc5d3a56288d7297 Gerrit-Change-Number: 37317 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: Set DedicatedBearerStatus to Down when call finishes

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37312?usp=email ) Change subject: asterisk: Set DedicatedBearerStatus to Down when call finishes ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File asterisk/IMS_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37312/comment/bc356817_0082… PS1, Line 169: (unrelated whitespace) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37312?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idf4d250e6edb830fe7e2d85dc15e0b3c4d8c3a8b Gerrit-Change-Number: 37312 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 02:08:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-ci[master]: publish-tarballs-for-tags.sh: publish osmo-epdg's versions

by osmith

Attention is currently required from: lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37324?usp=email ) Change subject: publish-tarballs-for-tags.sh: publish osmo-epdg's versions ...................................................................... Patch Set 3: Code-Review-1 (1 comment) Patchset: PS3: As discussed in chat, this currently fails for strongswan-epdg while running the configure script: * "checking version from Git repository... configure: error: 5.9.3 is not a prefix of osmo-epdg-0.1.0, tag missing?" * "configure: error: GNU gperf required to generate e.g. ./src/libstrongswan/crypto/proposal/proposal_keywords_static.c" (could be installed by adjusting install-depends.sh) It seemed like you would prefer to just get a simple git archive instead of running configure and "make dist-bzip2". To do that: ``` diff --git a/scripts/tarballs/prefer-configure.sh b/scripts/tarballs/prefer-configure.sh index 295b239..daafd14 100755 --- a/scripts/tarballs/prefer-configure.sh +++ b/scripts/tarballs/prefer-configure.sh @@ -10,6 +10,10 @@ if ! [ -e configure.ac ]; then fi case "$PROJECT" in +strongswan-epdg) + # Use a simple git archive instead of running configure and "make dist-bzip2" + exit 1 + ;; gapk) case "$TAG" in v0.*|v1.0) ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3445e76f6fd6ebb49ada5dc4320c6b9fa717f00c Gerrit-Change-Number: 37324 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 03 Jul 2024 10:38:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-hlr[master]: mslookup: don't ignore return value of write()

by fixeria

Attention is currently required from: neels, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/37328?usp=email ) Change subject: mslookup: don't ignore return value of write() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/37328?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4b2e5cabe5306a999197f7c98362d872a3739078 Gerrit-Change-Number: 37328 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jul 2024 09:54:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-hlr[master]: mslookup: don't ignore return value of write()

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/37328?usp=email ) Change subject: mslookup: don't ignore return value of write() ...................................................................... mslookup: don't ignore return value of write() Fix GCC 13.2.0 refuses to build this with -Werror: src/mslookup/osmo-mslookup-client.c: In function 'socket_client_respond_result': src/osmo-hlr/src/mslookup/osmo-mslookup-client.c:432:9: error: ignoring return value of 'write' declared with attribute 'warn_unused_result' [-Werror=unused-result] 432 | write(c->ofd.fd, response, strlen(response)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/mslookup/osmo-mslookup-client.c: In function 'socket_accept': src/osmo-hlr/src/mslookup/osmo-mslookup-client.c:530:17: error: ignoring return value of 'write' declared with attribute 'warn_unused_result' [-Werror=unused-result] 530 | write(c->ofd.fd, CSV_HEADERS, strlen(CSV_HEADERS)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I4b2e5cabe5306a999197f7c98362d872a3739078 --- M src/mslookup/osmo-mslookup-client.c 1 file changed, 32 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/28/37328/1 diff --git a/src/mslookup/osmo-mslookup-client.c b/src/mslookup/osmo-mslookup-client.c index 37f1256..0a29645 100644 --- a/src/mslookup/osmo-mslookup-client.c +++ b/src/mslookup/osmo-mslookup-client.c @@ -429,7 +429,11 @@ void socket_client_respond_result(struct socket_client *c, const char *response) { - write(c->ofd.fd, response, strlen(response)); + size_t len = strlen(response); + int rc = write(c->ofd.fd, response, len); + + if (rc != len) + print_error("%s: write() returned %d instead of %zu\n", __func__, rc, len); } static int socket_read_cb(struct osmo_fd *ofd) @@ -526,8 +530,13 @@ llist_add(&c->entry, &globals.socket_clients); - if (globals.format == FORMAT_CSV && cmdline_opts.csv_headers) - write(c->ofd.fd, CSV_HEADERS, strlen(CSV_HEADERS)); + if (globals.format == FORMAT_CSV && cmdline_opts.csv_headers) { + size_t len = strlen(CSV_HEADERS); + int rc = write(c->ofd.fd, CSV_HEADERS, strlen(CSV_HEADERS)); + + if (rc != len) + print_error("%s: write() returned %d instead of %zu\n", __func__, rc, len); + } return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/37328?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4b2e5cabe5306a999197f7c98362d872a3739078 Gerrit-Change-Number: 37328 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024