July 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Fix To header 'tag' attr not set in resync 401 Unautho...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37394?usp=email ) Change subject: asterisk: IMS: Fix To header 'tag' attr not set in resync 401 Unauthorized response ...................................................................... asterisk: IMS: Fix To header 'tag' attr not set in resync 401 Unauthorized response Change-Id: I74a014eb5cb5084726ef6b0462030a20fdbb3339 --- M asterisk/IMS_ConnectionHandler.ttcn 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: jolly: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index f84d504..dd187ad 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -896,6 +896,7 @@ f_ims_setup_ipsec(); security_server := f_gen_Security_server(); + to_addr.toParams := f_sip_param_set(to_addr.toParams, "tag", f_sip_rand_tag()); /* Tx again 401 Unauthorized, this time our AMI interface will accept it: */ tx_resp := ts_SIP_Response_Unauthorized(sip_call_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37394?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I74a014eb5cb5084726ef6b0462030a20fdbb3339 Gerrit-Change-Number: 37394 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: f_TC_ims_registration_423_interval_too_brief: Fix To addres...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37395?usp=email ) Change subject: asterisk: f_TC_ims_registration_423_interval_too_brief: Fix To address 'tag' attribute ...................................................................... asterisk: f_TC_ims_registration_423_interval_too_brief: Fix To address 'tag' attribute Change-Id: Ifd79d9cdc03f87f104a66564455e57bb7a462fe8 --- M asterisk/Asterisk_Tests.ttcn 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index 9502ee8..6fe5577 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -580,6 +580,8 @@ /* Test IMS re-registration based on Expires (TS 24.229 5.1.1.4.1, RFC 3261 10.3)*/ private function f_TC_ims_registration_423_interval_too_brief(charstring id) runs on IMS_ConnHdlr { + var template (value) To to_addr; + f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.registrar_sip_record.addr))); var template (present) PDU_SIP_Request exp_req := @@ -591,6 +593,9 @@ expires := tr_Expires(int2str(g_pars.subscr.registrar_expires))); SIP.receive(exp_req) -> value g_rx_sip_req; + to_addr := g_rx_sip_req.msgHeader.toField; + to_addr.toParams := f_sip_param_set(to_addr.toParams, "tag", f_sip_rand_tag()); + /* Double it and expect UAC to use it. */ g_pars.subscr.registrar_expires := g_pars.subscr.registrar_expires * 2; @@ -599,7 +604,7 @@ tx_resp := ts_SIP_Response_423_Interval_Too_Brief( g_rx_sip_req.msgHeader.callId.callid, g_rx_sip_req.msgHeader.fromField, - g_rx_sip_req.msgHeader.toField, + to_addr, g_rx_sip_req.msgHeader.via, g_rx_sip_req.msgHeader.cSeq.seqNumber, minExpires := ts_MinExpires(int2str(g_pars.subscr.registrar_expires)), -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifd79d9cdc03f87f104a66564455e57bb7a462fe8 Gerrit-Change-Number: 37395 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: Log unexpected AMI msg

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37396?usp=email ) Change subject: asterisk: Log unexpected AMI msg ...................................................................... asterisk: Log unexpected AMI msg Change-Id: I406a00a54cb6d956e465001b8da0b14ea3e24195 --- M asterisk/Asterisk_Tests.ttcn 1 file changed, 21 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index 6fe5577..ca1ec72 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -421,9 +421,18 @@ f_str_tolower(oct2str(pars.subscr.auth.ik))); if (exp_ami_ev_registered) { - AMI_CLIENT.receive(tr_AMI_Event_Registry(f_sip_SipAddr_to_str(pars.subscr.local_sip_record), - "sip:" & mp_ims_domain, - "Registered")); + var AMI_Msg ami_msg_rx; + var template (present) AMI_Msg ami_msg_exp := + tr_AMI_Event_Registry(f_sip_SipAddr_to_str(pars.subscr.local_sip_record), + "sip:" & mp_ims_domain, + "Registered"); + alt { + [] AMI_CLIENT.receive(ami_msg_exp); + [] AMI_CLIENT.receive(AMI_Msg:?) -> value ami_msg_rx { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Unexpected AMI msg: ", ami_msg_rx, " vs exp: ", ami_msg_exp)); + } + } } } [resync] AMI_CLIENT.receive(tr_AMI_Event_AuthRequest(mp_volte_ims_outbound_registration, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I406a00a54cb6d956e465001b8da0b14ea3e24195 Gerrit-Change-Number: 37396 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: Log unexpected AMI msg

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37396?usp=email ) Change subject: asterisk: Log unexpected AMI msg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I406a00a54cb6d956e465001b8da0b14ea3e24195 Gerrit-Change-Number: 37396 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Jul 2024 16:49:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: f_TC_ims_registration_423_interval_too_brief: Fix To addres...

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37395?usp=email ) Change subject: asterisk: f_TC_ims_registration_423_interval_too_brief: Fix To address 'tag' attribute ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifd79d9cdc03f87f104a66564455e57bb7a462fe8 Gerrit-Change-Number: 37395 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Jul 2024 16:49:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Fix To header 'tag' attr not set in resync 401 Unautho...

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37394?usp=email ) Change subject: asterisk: IMS: Fix To header 'tag' attr not set in resync 401 Unauthorized response ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37394?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I74a014eb5cb5084726ef6b0462030a20fdbb3339 Gerrit-Change-Number: 37394 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Jul 2024 16:49:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-asterisk: Small improvements to ease introducing IPv6 support

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37349?usp=email ) Change subject: ttcn3-asterisk: Small improvements to ease introducing IPv6 support ...................................................................... ttcn3-asterisk: Small improvements to ease introducing IPv6 support Change-Id: If5200e9ba7774f5ec1037584dcb1f8ca2e45f835 --- M ttcn3-asterisk-ims-ue-test/asterisk/manager.conf M ttcn3-asterisk-ims-ue-test/dnsmasq/dnsmasq.conf M ttcn3-asterisk-ims-ue-test/ttcn3/Asterisk_Tests.cfg 3 files changed, 13 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/manager.conf b/ttcn3-asterisk-ims-ue-test/asterisk/manager.conf index 67f7b02..a5cbe11 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/manager.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/manager.conf @@ -8,6 +8,6 @@ [test_user] secret = 1234 ;deny=0.0.0.0/0.0.0.0 -permit=172.18.11.103/255.255.0.0 +permit=172.18.11.103/24 read = all,system,call,log,verbose,command,agent,user write = all,system,call,log,verbose,command,agent,user diff --git a/ttcn3-asterisk-ims-ue-test/dnsmasq/dnsmasq.conf b/ttcn3-asterisk-ims-ue-test/dnsmasq/dnsmasq.conf index 8aea943..9c7b703 100644 --- a/ttcn3-asterisk-ims-ue-test/dnsmasq/dnsmasq.conf +++ b/ttcn3-asterisk-ims-ue-test/dnsmasq/dnsmasq.conf @@ -2,7 +2,7 @@ log-queries #dont use hosts nameservers no-resolv -listen-address=::1,127.0.0.1,172.18.11.200 +listen-address=::1,fd02:db8:11::200,127.0.0.1,172.18.11.200 #use google as default nameservers server=8.8.4.4 diff --git a/ttcn3-asterisk-ims-ue-test/ttcn3/Asterisk_Tests.cfg b/ttcn3-asterisk-ims-ue-test/ttcn3/Asterisk_Tests.cfg index 840cbf7..52cf985 100644 --- a/ttcn3-asterisk-ims-ue-test/ttcn3/Asterisk_Tests.cfg +++ b/ttcn3-asterisk-ims-ue-test/ttcn3/Asterisk_Tests.cfg @@ -24,7 +24,8 @@ Asterisk_Tests.mp_local_ims_port := 5060 Asterisk_Tests.mp_ims_domain := "ims.mnc001.mcc238.3gppnetwork.org" Asterisk_Tests.mp_ims_imsi := "238010000090828" -Asterisk_Tests.mp_ims_imei := "35876110-027790-0"; +Asterisk_Tests.mp_ims_imei := "35876110-027790-0" +Asterisk_Tests.mp_ami_local_host := "172.18.11.103" Asterisk_Tests.mp_ami_remote_host := "172.18.11.10" IMS_ConnectionHandler.mp_ipsec_setup_script_path := "/osmo-ttcn3-hacks/asterisk/IMS_ipsec_setup.sh" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37349?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If5200e9ba7774f5ec1037584dcb1f8ca2e45f835 Gerrit-Change-Number: 37349 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 3 weeks

1
0
0 0

[M] Change in docker-playground[master]: ttcn3-asterisk: Allow running testsuite with IPv4 and IPv6 configs

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37350?usp=email ) Change subject: ttcn3-asterisk: Allow running testsuite with IPv4 and IPv6 configs ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37350?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1de922c681fef4d308898cd592544aef25901c7b Gerrit-Change-Number: 37350 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 05 Jul 2024 16:48:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Makefile: new file

by osmith

Attention is currently required from: daniel, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37340?usp=email ) Change subject: Makefile: new file ...................................................................... Patch Set 1: (1 comment) File Makefile: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37340/comment/b1ed3fb3_… PS1, Line 18: $(GEN_FILES) > not defined Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ida7ce261bfaac845ecdbec43e0bdd7d1669e5486 Gerrit-Change-Number: 37340 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Jul 2024 10:07:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Makefile: new file

by osmith

Attention is currently required from: daniel, fixeria, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37340?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by daniel, Code-Review+2 by pespin, Code-Review-1 by fixeria, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: Makefile: new file ...................................................................... Makefile: new file Add a Makefile similar to the ones in osmo-epdg and osmo-s1gw. Change-Id: Ida7ce261bfaac845ecdbec43e0bdd7d1669e5486 --- A Makefile 1 file changed, 41 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/40/37340/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ida7ce261bfaac845ecdbec43e0bdd7d1669e5486 Gerrit-Change-Number: 37340 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

11 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024