July 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: ts_SIP_UPDATE: Add missing SDP Content-Length/Type hea...

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37347?usp=email ) Change subject: SIP_Templates: ts_SIP_UPDATE: Add missing SDP Content-Length/Type headers ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I510779191aa393b901839845c22efc7dc4324dd2 Gerrit-Change-Number: 37347 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Jul 2024 16:03:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Decode last received SDP before validating

by jolly

Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37348?usp=email ) Change subject: asterisk: IMS: Decode last received SDP before validating ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37348?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I976b79d4b6f50514777b35e3a0520e57930f4a1d Gerrit-Change-Number: 37348 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Jul 2024 16:03:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-asterisk: Small improvements to ease introducing IPv6 support

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37349?usp=email ) Change subject: ttcn3-asterisk: Small improvements to ease introducing IPv6 support ...................................................................... ttcn3-asterisk: Small improvements to ease introducing IPv6 support Change-Id: If5200e9ba7774f5ec1037584dcb1f8ca2e45f835 --- M ttcn3-asterisk-ims-ue-test/asterisk/manager.conf M ttcn3-asterisk-ims-ue-test/dnsmasq/dnsmasq.conf M ttcn3-asterisk-ims-ue-test/ttcn3/Asterisk_Tests.cfg 3 files changed, 13 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/49/37349/1 diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/manager.conf b/ttcn3-asterisk-ims-ue-test/asterisk/manager.conf index 67f7b02..a5cbe11 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/manager.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/manager.conf @@ -8,6 +8,6 @@ [test_user] secret = 1234 ;deny=0.0.0.0/0.0.0.0 -permit=172.18.11.103/255.255.0.0 +permit=172.18.11.103/24 read = all,system,call,log,verbose,command,agent,user write = all,system,call,log,verbose,command,agent,user diff --git a/ttcn3-asterisk-ims-ue-test/dnsmasq/dnsmasq.conf b/ttcn3-asterisk-ims-ue-test/dnsmasq/dnsmasq.conf index 8aea943..9c7b703 100644 --- a/ttcn3-asterisk-ims-ue-test/dnsmasq/dnsmasq.conf +++ b/ttcn3-asterisk-ims-ue-test/dnsmasq/dnsmasq.conf @@ -2,7 +2,7 @@ log-queries #dont use hosts nameservers no-resolv -listen-address=::1,127.0.0.1,172.18.11.200 +listen-address=::1,fd02:db8:11::200,127.0.0.1,172.18.11.200 #use google as default nameservers server=8.8.4.4 diff --git a/ttcn3-asterisk-ims-ue-test/ttcn3/Asterisk_Tests.cfg b/ttcn3-asterisk-ims-ue-test/ttcn3/Asterisk_Tests.cfg index 840cbf7..52cf985 100644 --- a/ttcn3-asterisk-ims-ue-test/ttcn3/Asterisk_Tests.cfg +++ b/ttcn3-asterisk-ims-ue-test/ttcn3/Asterisk_Tests.cfg @@ -24,7 +24,8 @@ Asterisk_Tests.mp_local_ims_port := 5060 Asterisk_Tests.mp_ims_domain := "ims.mnc001.mcc238.3gppnetwork.org" Asterisk_Tests.mp_ims_imsi := "238010000090828" -Asterisk_Tests.mp_ims_imei := "35876110-027790-0"; +Asterisk_Tests.mp_ims_imei := "35876110-027790-0" +Asterisk_Tests.mp_ami_local_host := "172.18.11.103" Asterisk_Tests.mp_ami_remote_host := "172.18.11.10" IMS_ConnectionHandler.mp_ipsec_setup_script_path := "/osmo-ttcn3-hacks/asterisk/IMS_ipsec_setup.sh" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37349?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If5200e9ba7774f5ec1037584dcb1f8ca2e45f835 Gerrit-Change-Number: 37349 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 3 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Makefile: new file

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37340?usp=email ) Change subject: Makefile: new file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ida7ce261bfaac845ecdbec43e0bdd7d1669e5486 Gerrit-Change-Number: 37340 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Jul 2024 15:39:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Decode last received SDP before validating

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37348?usp=email ) Change subject: asterisk: IMS: Decode last received SDP before validating ...................................................................... asterisk: IMS: Decode last received SDP before validating Change-Id: I976b79d4b6f50514777b35e3a0520e57930f4a1d --- M asterisk/IMS_ConnectionHandler.ttcn 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/48/37348/1 diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index c7d87b2..f84d504 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -1291,6 +1291,7 @@ g_rx_sip_resp.msgHeader.cSeq.seqNumber + 1, "OK", body := ?); as_SIP_expect_resp(exp); + f_SDP_decodeMessage(g_rx_sip_resp.messageBody, g_pars.subscr.cp.peer_sdp); /* Validate SDP in 200 OK (UPDATE) contains the preconditions: * a=curr:qos local sendrecv -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37348?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I976b79d4b6f50514777b35e3a0520e57930f4a1d Gerrit-Change-Number: 37348 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: ts_SIP_UPDATE: Add missing SDP Content-Length/Type hea...

by jolly

Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37347?usp=email ) Change subject: SIP_Templates: ts_SIP_UPDATE: Add missing SDP Content-Length/Type headers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I510779191aa393b901839845c22efc7dc4324dd2 Gerrit-Change-Number: 37347 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Jul 2024 15:32:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: ts_SIP_UPDATE: Add missing SDP Content-Length/Type hea...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37347?usp=email ) Change subject: SIP_Templates: ts_SIP_UPDATE: Add missing SDP Content-Length/Type headers ...................................................................... SIP_Templates: ts_SIP_UPDATE: Add missing SDP Content-Length/Type headers Change-Id: I510779191aa393b901839845c22efc7dc4324dd2 --- M library/SIP_Templates.ttcn 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/47/37347/1 diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index c05ab02..eda1a33 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -1095,6 +1095,8 @@ msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, contact, "UPDATE", seq_nr, via, + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body), require := require), messageBody := body, payload := omit -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I510779191aa393b901839845c22efc7dc4324dd2 Gerrit-Change-Number: 37347 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 3 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Makefile: new file

by daniel

Attention is currently required from: osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37340?usp=email ) Change subject: Makefile: new file ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ida7ce261bfaac845ecdbec43e0bdd7d1669e5486 Gerrit-Change-Number: 37340 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Jul 2024 15:25:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-dev[master]: gen_makefile: fix meson warning

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/37341?usp=email ) Change subject: gen_makefile: fix meson warning ...................................................................... gen_makefile: fix meson warning Fix for: WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated. Change-Id: I5de0285012344876dbe47f1ae663bf93c45aade0 --- M gen_makefile.py 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved; Verified diff --git a/gen_makefile.py b/gen_makefile.py index 9b896b2..ff8ab78 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -263,7 +263,7 @@ -chmod -R ug+w {build_proj} -rm -rf {build_proj} mkdir -p {build_proj} - cd {build_proj}; {cflags}{docker_cmd}meson {build_to_src} . + cd {build_proj}; {cflags}{docker_cmd}meson setup {build_to_src} . sync touch $@ ''' -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/37341?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I5de0285012344876dbe47f1ae663bf93c45aade0 Gerrit-Change-Number: 37341 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 3 weeks

1
0
0 0

[M] Change in osmo-dev[master]: gen_makefile: write content into a buffer first

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/37343?usp=email ) Change subject: gen_makefile: write content into a buffer first ...................................................................... gen_makefile: write content into a buffer first Instead of directly writing the new Makefile, write the new content into a buffer variable first. This ensures that we don't abort half-way while writing the Makefile, and it allows replacing spaces -> tabs in the next patch. Change-Id: I9a0ee9aa5047b7d9af9673465441039cd55c221b --- M gen_makefile.py 1 file changed, 44 insertions(+), 27 deletions(-) Approvals: osmith: Looks good to me, approved; Verified diff --git a/gen_makefile.py b/gen_makefile.py index ca9003a..76c81f8 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -465,19 +465,15 @@ if not build_dir: build_dir = make_dir -output = os.path.join(make_dir, args.output) -print('Writing to %r' % output) +content = '# This Makefile was generated by %s\n' % os.path.basename(sys.argv[0]) -with open(output, 'w') as out: - out.write('# This Makefile was generated by %s\n' % os.path.basename(sys.argv[0])) +configure_opts_args = "" +for f in configure_opts_files: + if not f.endswith(".deps"): + configure_opts_args += f' \\\n\t\t{os.path.relpath(f, make_dir)}' - configure_opts_args = "" - for f in configure_opts_files: - if not f.endswith(".deps"): - configure_opts_args += f' \\\n\t\t{os.path.relpath(f, make_dir)}' - - # convenience: add a regen target that updates the generated makefile itself - out.write(r''' +# convenience: add a regen target that updates the generated makefile itself +content += r''' default: usrp # @@ -567,26 +563,33 @@ docker_cmd=f' \\\n\t\t--docker-cmd "{args.docker_cmd}"' if args.docker_cmd else '', build_debug=f' \\\n\t\t--build-debug' if args.build_debug else '', auto_distclean=' \\\n\t\t--auto-distclean' if args.auto_distclean else '', - )) +) - # convenience target: clone all repositories first - out.write('clone: \\\n\t' + ' \\\n\t'.join([ '.make.%s.clone' % p for p, d in projects_deps ]) + '\n\n') +# convenience target: clone all repositories first +content += 'clone: \\\n\t' + ' \\\n\t'.join([ '.make.%s.clone' % p for p, d in projects_deps ]) + '\n\n' - # convenience target: clean all - out.write('clean: \\\n\t' + ' \\\n\t'.join([ '%s-clean' % p for p, d in projects_deps ]) + '\n\n') +# convenience target: clean all +content += 'clean: \\\n\t' + ' \\\n\t'.join([ '%s-clean' % p for p, d in projects_deps ]) + '\n\n' - # now the actual useful build rules - out.write('all: clone all-install\n\n') +# now the actual useful build rules +content += 'all: clone all-install\n\n' - out.write('all-install: \\\n\t' + ' \\\n\t'.join([ '.make.%s.install' % p for p, d in projects_deps ]) + '\n\n') +content += 'all-install: \\\n\t' + ' \\\n\t'.join([ '.make.%s.install' % p for p, d in projects_deps ]) + '\n\n' - for proj, deps in projects_deps: - all_config_opts = [] - all_config_opts.extend(configure_opts.get('ALL') or []) - all_config_opts.extend(configure_opts.get(proj) or []) - out.write(gen_make(proj, deps, all_config_opts, args.jobs, - make_dir, args.src_dir, build_dir, args.url, args.push_url, - args.sudo_make_install, args.no_ldconfig, - args.ldconfig_without_sudo, args.make_check)) +for proj, deps in projects_deps: + all_config_opts = [] + all_config_opts.extend(configure_opts.get('ALL') or []) + all_config_opts.extend(configure_opts.get(proj) or []) + content += gen_make(proj, deps, all_config_opts, args.jobs, + make_dir, args.src_dir, build_dir, args.url, args.push_url, + args.sudo_make_install, args.no_ldconfig, + args.ldconfig_without_sudo, args.make_check) + + +output = os.path.join(make_dir, args.output) +print('Writing to %r' % output) + +with open(output, 'w') as out: + out.write(content) # vim: expandtab tabstop=2 shiftwidth=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/37343?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I9a0ee9aa5047b7d9af9673465441039cd55c221b Gerrit-Change-Number: 37343 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024