Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email )
Change subject: smpp: fix password[] length in struct esme
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/smpp/smpp.h:
https://gerrit.osmocom.org/c/osmo-msc/+/37238/comment/411a7102_8dbb2472
PS1, Line 26: char password[SMPP_PASSWD_LEN + 1];
this is probably breaking the ABI, better add it to TODO-RELEASE
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I07e7193460580a3c972a24700e75c925d1e50411
Gerrit-Change-Number: 37238
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Jun 2024 10:51:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email )
Change subject: s1gw: add TC_e_rab_setup
......................................................................
Patch Set 3:
(2 comments)
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245/comment/e8c3b295_265e…
PS3, Line 176: S1AP_CONN
is S1AP_CONN and S1AP_ENB swapped in f_ConnHdlr_rx_s1ap_from_enb and f_ConnHdlr_rx_s1ap_from_mme?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245/comment/d01ce712_64f9…
PS3, Line 181: setverdict(fail, "Rx unexpected S1AP PDU: ", pdu);
maybe note from eNB / MME here and below?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I94eb8cac4b5659c0f6f1bb248a80692b8cf84b6f
Gerrit-Change-Number: 37245
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Jun 2024 07:43:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
