June 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: debian/copyright: remove include/openbsc/slhc.h (no such file)

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email ) Change subject: debian/copyright: remove include/openbsc/slhc.h (no such file) ...................................................................... debian/copyright: remove include/openbsc/slhc.h (no such file) Change-Id: Ib1f2395798010381d67d79c46778bb0caef17046 --- M debian/copyright 1 file changed, 9 insertions(+), 25 deletions(-) Approvals: neels: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/copyright b/debian/copyright index ac8ed52..1bde2c2 100644 --- a/debian/copyright +++ b/debian/copyright @@ -146,28 +146,3 @@ . On Debian systems, the complete text of the GNU General Public License Version 3 can be found in `/usr/share/common-licenses/GPL-3'. - -Files: include/openbsc/slhc.h -Copyright: 1989 Regents of the University of California. -License: __UNKNOWN__ - Redistribution and use in source and binary forms are permitted - provided that the above copyright notice and this paragraph are - duplicated in all such forms and that any documentation, - advertising materials, and other materials related to such - distribution and use acknowledge that the software was developed - by the University of California, Berkeley. The name of the - University may not be used to endorse or promote products derived - from this software without specific prior written permission. - THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR - IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED - WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. - . - Van Jacobson (van(a)helios.ee.lbl.gov), Dec 31, 1989: - - Initial distribution. - . - modified for KA9Q Internet Software Package by - Katie Stevens (dkstevens(a)ucdavis.edu) - University of California, Davis - Computing Services - - 01-31-90 initial adaptation - -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib1f2395798010381d67d79c46778bb0caef17046 Gerrit-Change-Number: 37236 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

[S] Change in osmo-msc[master]: debian/copyright: remove include/openbsc/slhc.h (no such file)

by pespin

Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email ) Change subject: debian/copyright: remove include/openbsc/slhc.h (no such file) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib1f2395798010381d67d79c46778bb0caef17046 Gerrit-Change-Number: 37236 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:56:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: respond to enableUsingDD

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37234?usp=email ) Change subject: IPAd_Tests: respond to enableUsingDD ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37234?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I892485368925f9713d1dc0d44bd34277fd992875 Gerrit-Change-Number: 37234 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:56:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[M] Change in libosmocore[master]: codec: make osmo_hr_check_sid() more efficient

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37227?usp=email ) Change subject: codec: make osmo_hr_check_sid() more efficient ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib14204102c03c14d6c5aab42b0ffbef2c3dda3fd Gerrit-Change-Number: 37227 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:55:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmo-msc[master]: smpp: fix password[] length in struct esme

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email ) Change subject: smpp: fix password[] length in struct esme ...................................................................... smpp: fix password[] length in struct esme Change-Id: I07e7193460580a3c972a24700e75c925d1e50411 --- M include/osmocom/smpp/smpp.h 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved neels: Looks good to me, but someone else must approve diff --git a/include/osmocom/smpp/smpp.h b/include/osmocom/smpp/smpp.h index d48cd79..0d34345 100644 --- a/include/osmocom/smpp/smpp.h +++ b/include/osmocom/smpp/smpp.h @@ -23,7 +23,7 @@ uint8_t smpp_version; char system_id[SMPP_SYS_ID_LEN + 1]; - char password[SMPP_SYS_ID_LEN + 1]; + char password[SMPP_PASSWD_LEN + 1]; }; #define LOGPESME(ESME, LEVEL, FMT, ARGS...) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I07e7193460580a3c972a24700e75c925d1e50411 Gerrit-Change-Number: 37238 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

[S] Change in osmo-msc[master]: smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37237?usp=email ) Change subject: smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN ...................................................................... smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN Change-Id: I3f8d9a8e3739679995ddb037a8f3d58a627d36bc --- M include/osmocom/smpp/smpp.h 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/smpp/smpp.h b/include/osmocom/smpp/smpp.h index a2832d3..d48cd79 100644 --- a/include/osmocom/smpp/smpp.h +++ b/include/osmocom/smpp/smpp.h @@ -2,7 +2,7 @@ #include <osmocom/msc/gsm_data.h> -/* Length limits according to SMPP 3.4 spec including NUL-byte: */ +/* Length limits according to SMPP 3.4 spec excluding NUL-byte: */ #define SMPP_SYS_ID_LEN 15 #define SMPP_PASSWD_LEN 8 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3f8d9a8e3739679995ddb037a8f3d58a627d36bc Gerrit-Change-Number: 37237 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

[S] Change in osmo-msc[master]: utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37239?usp=email ) Change subject: utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow ...................................................................... utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow This patch fixes a warning printed by gcc 14.1.1: CC smpp_mirror-smpp_mirror.o CCLD smpp_mirror In function 'snprintf', inlined from 'bind_transceiver' at smpp_mirror.c:121:2, inlined from 'smpp_esme_init' at smpp_mirror.c:258:9, inlined from 'main' at smpp_mirror.c:299:7: /usr/include/bits/stdio2.h:54:10: warning: '__builtin___snprintf_chk' specified bound 16 exceeds destination size 9 [-Wstringop-overflow=] 54 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, | ^ Take a chance to replace all snprintf() calls with OSMO_STRLCPY_ARRAY. Change-Id: If1df370fbfbca0953abf83ea1840d8bf8a0118be --- M src/utils/smpp_mirror.c 1 file changed, 30 insertions(+), 5 deletions(-) Approvals: neels: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/utils/smpp_mirror.c b/src/utils/smpp_mirror.c index 3356468..340e94f 100644 --- a/src/utils/smpp_mirror.c +++ b/src/utils/smpp_mirror.c @@ -117,9 +117,9 @@ memset(&bind, 0, sizeof(bind)); bind.command_id = BIND_TRANSCEIVER; bind.sequence_number = esme_inc_seq_nr(esme); - snprintf((char *)bind.system_id, SMPP_SYS_ID_LEN + 1, "%s", esme->system_id); - snprintf((char *)bind.password, SMPP_SYS_ID_LEN + 1, "%s", esme->password); - snprintf((char *)bind.system_type, sizeof(bind.system_type), "mirror"); + OSMO_STRLCPY_ARRAY(bind.system_id, esme->system_id); + OSMO_STRLCPY_ARRAY(bind.password, esme->password); + OSMO_STRLCPY_ARRAY(bind.system_type, "mirror"); bind.interface_version = esme->smpp_version; return PACK_AND_SEND(esme, &bind); @@ -287,8 +287,8 @@ if (!esme) exit(2); - snprintf((char *) esme->system_id, sizeof(esme->system_id), "mirror"); - snprintf((char *) esme->password, sizeof(esme->password), "mirror"); + OSMO_STRLCPY_ARRAY(esme->system_id, "mirror"); + OSMO_STRLCPY_ARRAY(esme->password, "mirror"); esme->smpp_version = 0x34; if (argc >= 2) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If1df370fbfbca0953abf83ea1840d8bf8a0118be Gerrit-Change-Number: 37239 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

[S] Change in ...osmo-s1gw[master]: osmo_s1gw.app.src: add logger_color_formatter

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37228?usp=email ) Change subject: osmo_s1gw.app.src: add logger_color_formatter ...................................................................... osmo_s1gw.app.src: add logger_color_formatter This patch fixes 'FORMATTER CRASH' in the logging when running escript. Change-Id: I6f10b22af406ef640bc2eaa2dddca34b009f7e6a Fixes: c5d3c625 "Rework logging config, colorize output" --- M src/osmo_s1gw.app.src 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo_s1gw.app.src b/src/osmo_s1gw.app.src index bc2a8d7..6fd8174 100644 --- a/src/osmo_s1gw.app.src +++ b/src/osmo_s1gw.app.src @@ -6,7 +6,8 @@ {registered, []}, {applications, [ kernel, - stdlib + stdlib, + logger_color_formatter ]}, {modules, []}, {mod, {osmo_s1gw_app, []}}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I6f10b22af406ef640bc2eaa2dddca34b009f7e6a Gerrit-Change-Number: 37228 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

[S] Change in osmo-msc[master]: utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow

by pespin

Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37239?usp=email ) Change subject: utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If1df370fbfbca0953abf83ea1840d8bf8a0118be Gerrit-Change-Number: 37239 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:52:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmo-msc[master]: smpp: fix password[] length in struct esme

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email ) Change subject: smpp: fix password[] length in struct esme ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File include/osmocom/smpp/smpp.h: https://gerrit.osmocom.org/c/osmo-msc/+/37238/comment/8fa6c998_3b1bf346 PS1, Line 26: char password[SMPP_PASSWD_LEN + 1]; > this is probably breaking the ABI, better add it to TODO-RELEASE Ah nevermind, this is not within libsmpp34 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I07e7193460580a3c972a24700e75c925d1e50411 Gerrit-Change-Number: 37238 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:52:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2024