Attention is currently required from: pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37250?usp=email )
Change subject: rtp2trau_hr16: use osmo_hr_check_sid()
......................................................................
Patch Set 1:
(1 comment)
File TODO-RELEASE:
https://gerrit.osmocom.org/c/libosmo-abis/+/37250/comment/b0af0a54_955a4fbe
PS1, Line 12: libosmocodec >1.9.0 bugfix in osmo_hr_check_sid() in case length=0
> the useful hint here is actually ABI/API related, so the interesting info you should add here in dec […]
It is not clear to me exactly how to describe the relevant API aspect here - please help me. The issue is:
* osmo_hr_check_sid() API has been there for ages;
* it was previously broken (returned true on zero-length input, when the correct answer should be false);
* the recent change in libosmocore repo fixed it;
* the present libosmo-abis change depends on that fix.
What is the correct way to express this dependency on the logic fix in the old API?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37250?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ia8fe7e9ea65fadf7f5c136355ca8c24c89f09ef2
Gerrit-Change-Number: 37250
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Jun 2024 19:54:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: ttcn3-s1gw-test: align with the moduleparam naming changes
......................................................................
ttcn3-s1gw-test: align with the moduleparam naming changes
Change-Id: I37b7d91e9e18df463f54cac3e5586942aea21a69
Related: osmo-ttcn3-hacks.git Ice665662c8448c8314d5e6cc1e401e62b635872c
---
M ttcn3-s1gw-test/S1GW_Tests.cfg
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/47/37247/2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I37b7d91e9e18df463f54cac3e5586942aea21a69
Gerrit-Change-Number: 37247
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email )
Change subject: ttcn3-s1gw-test: align with the moduleparam naming changes
......................................................................
Patch Set 1:
(1 comment)
File ttcn3-s1gw-test/S1GW_Tests.cfg:
https://gerrit.osmocom.org/c/docker-playground/+/37247/comment/70c1b22d_fb0…
PS1, Line 11: S1GW_Tests.mp_s1gw_mme_ip := "172.18.10.001";
> why adding those extra leading zeroes? feels confusing tbh, I never saw that in an IP address repres […]
Purely cosmetic reason: for alignment with the other two addresses.
It works. But I'll remove the leading zeros anyway to avoid confusion.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I37b7d91e9e18df463f54cac3e5586942aea21a69
Gerrit-Change-Number: 37247
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Jun 2024 19:01:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: falconia.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37251?usp=email )
Change subject: trau_rtp_conv.c cosmetic: fix typo in name of static function
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37251?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I63bb678f7a1f26fefba070ddc10850db24cb88b3
Gerrit-Change-Number: 37251
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Tue, 18 Jun 2024 18:53:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
