June 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: trau_rtp_conv.c cosmetic: fix typo in name of static function

by laforge

Attention is currently required from: falconia. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37251?usp=email ) Change subject: trau_rtp_conv.c cosmetic: fix typo in name of static function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I63bb678f7a1f26fefba070ddc10850db24cb88b3 Gerrit-Change-Number: 37251 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Thu, 20 Jun 2024 12:45:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in libosmo-abis[master]: rtp2trau_hr16: use osmo_hr_check_sid()

by laforge

Attention is currently required from: falconia. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37250?usp=email ) Change subject: rtp2trau_hr16: use osmo_hr_check_sid() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37250?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia8fe7e9ea65fadf7f5c136355ca8c24c89f09ef2 Gerrit-Change-Number: 37250 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Thu, 20 Jun 2024 12:45:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmo-iuh[master]: support Paging in cn_ranap_rx_initiating_msg_co

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/37254?usp=email ) Change subject: support Paging in cn_ranap_rx_initiating_msg_co ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: RANAP paging is CL (connectionless), right? You appear to be adding it to functions like cn_ranap_rx_initiating_msg_co which as the _co suffix implies deal with connection-oriented RANAP procedures only. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/37254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ie3e66eee1cc4553799e128580d39f3d40f79dcf5 Gerrit-Change-Number: 37254 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jun 2024 12:44:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[M] Change in docker-playground[master]: ttcn3-s1gw-test: run eNB/MME domains in separate networks

by laforge

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37256?usp=email ) Change subject: ttcn3-s1gw-test: run eNB/MME domains in separate networks ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'm not sure what do you win with this tbh, other than making the whole setup more complex and dropp […] I tend to agree with pespin. Unless our applications do anything directly with network interfaces (like SO_BINDTODEVICE or the like), we shouldn't need to create multiple network interfaces in the test setup. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37256?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4c72cb58eeb2d0ccca307dcfcfb04d09bfb0834e Gerrit-Change-Number: 37256 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jun 2024 12:42:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Validate precondition in SDP of MT calls

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37259?usp=email ) Change subject: asterisk: Validate precondition in SDP of MT calls ...................................................................... asterisk: Validate precondition in SDP of MT calls Change-Id: Ibfdc7e61a72655cd89d5d3f0f1d8798325ae1403 --- M asterisk/IMS_ConnectionHandler.ttcn 1 file changed, 71 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/59/37259/1 diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index 34a628d..00e1560 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -486,6 +486,8 @@ type enumerated IMS_gen_sdp_state { IMS_GEN_SDP_None, + IMS_GEN_SDP_MO_INVITE, + IMS_GEN_SDP_MO_UPDATE, IMS_GEN_SDP_MT_Session_Progress, IMS_GEN_SDP_MT_UPDATE_200OK } @@ -517,6 +519,20 @@ select (st) { case (IMS_GEN_SDP_None) { } + case (IMS_GEN_SDP_MO_INVITE) { + sdp := sdp & + "a=curr:qos local none\r\n" & + "a=curr:qos remote none\r\n" & + "a=des:qos mandatory local sendrecv\r\n" & + "a=des:qos optional remote sendrecv\r\n"; + } + case (IMS_GEN_SDP_MO_UPDATE) { + sdp := sdp & + "a=curr:qos local sendrecv\r\n" & + "a=curr:qos remote none\r\n" & + "a=des:qos mandatory local sendrecv\r\n" & + "a=des:qos mandatory remote sendrecv\r\n"; + } case (IMS_GEN_SDP_MT_Session_Progress) { sdp := sdp & "a=curr:qos local none\r\n" & @@ -938,7 +954,7 @@ var Via via; var template (omit) Require require := omit; var template (omit) Supported supported := omit; - var charstring tx_sdp := f_gen_sdp(); + var charstring tx_sdp; var default d_trying, d_ringing; var charstring branch_value; var Contact calling_contact; @@ -964,6 +980,10 @@ /* indicate the support for "reliable provisional response" * and "preconditions mechanism" */ supported := ts_Supported({ "100rel", "precondition" }); + tx_sdp := f_gen_sdp(IMS_GEN_SDP_MO_INVITE); + } else { + /* Don't add any preconditions to SDP: */ + tx_sdp := f_gen_sdp(IMS_GEN_SDP_None); } req := ts_SIP_INVITE(g_pars.subscr.cp.sip_call_id, @@ -986,6 +1006,7 @@ d_trying := activate(as_SIP_ignore_resp(exp)); if (g_pars.subscr.cp.require_precondition_ext) { + var template (present) SDP_attribute_list preconds; /* Rx 183 Session Progress */ exp := tr_SIP_Response_SessionProgress( g_pars.subscr.cp.sip_call_id, @@ -1004,6 +1025,26 @@ } } + /* Validate SDP in Session Progress contains the preconditions: + * a=curr:qos local none + * a=curr:qos remote none + * a=des:qos mandatory local sendrecv + * a=des:qos mandatory remote sendrecv + * a=conf:qos remote sendrecv + */ + preconds := superset( + tr_SDP_curr(c_SDP_PRECON_STATUS_TYPE_local, c_SDP_PRECON_DIR_TAG_none), + tr_SDP_curr(c_SDP_PRECON_STATUS_TYPE_remote, c_SDP_PRECON_DIR_TAG_none), + tr_SDP_des(c_SDP_PRECON_STRENGTH_TAG_mandatory, c_SDP_PRECON_STATUS_TYPE_local, c_SDP_PRECON_DIR_TAG_sendrecv), + tr_SDP_des(c_SDP_PRECON_STRENGTH_TAG_mandatory, c_SDP_PRECON_STATUS_TYPE_remote, c_SDP_PRECON_DIR_TAG_sendrecv), + tr_SDP_conf(c_SDP_PRECON_STATUS_TYPE_remote, c_SDP_PRECON_DIR_TAG_sendrecv)); + if (not ispresent(g_pars.subscr.cp.peer_sdp.attributes) or + not match(g_pars.subscr.cp.peer_sdp.attributes, preconds)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str(g_name & ": Unexpected precondition attrs in Session Progress : ", + g_pars.subscr.cp.peer_sdp.attributes)); + } + /* Tx PRACK */ req := ts_SIP_PRACK(g_pars.subscr.cp.to_addr.addressField.nameAddr.addrSpec, g_pars.subscr.cp.sip_call_id, @@ -1034,6 +1075,7 @@ as_SIP_expect_resp(exp, fail_others := false); /* Tx UPDATE */ + tx_sdp := f_gen_sdp(IMS_GEN_SDP_MO_UPDATE); req := ts_SIP_UPDATE(g_pars.subscr.cp.to_addr.addressField.nameAddr.addrSpec, g_pars.subscr.cp.sip_call_id, g_pars.subscr.cp.from_addr, @@ -1056,6 +1098,24 @@ body := ?); as_SIP_expect_resp(exp, fail_others := false); + /* Validate SDP in 200 OK (UPDATE) contains the preconditions: + * a=curr:qos local sendrecv + * a=curr:qos remote sendrecv + * a=des:qos mandatory local sendrecv + * a=des:qos mandatory remote sendrecv + */ + preconds := superset( + tr_SDP_curr(c_SDP_PRECON_STATUS_TYPE_local, c_SDP_PRECON_DIR_TAG_sendrecv), + tr_SDP_curr(c_SDP_PRECON_STATUS_TYPE_remote, c_SDP_PRECON_DIR_TAG_sendrecv), + tr_SDP_des(c_SDP_PRECON_STRENGTH_TAG_mandatory, c_SDP_PRECON_STATUS_TYPE_local, c_SDP_PRECON_DIR_TAG_sendrecv), + tr_SDP_des(c_SDP_PRECON_STRENGTH_TAG_mandatory, c_SDP_PRECON_STATUS_TYPE_remote, c_SDP_PRECON_DIR_TAG_sendrecv)); + if (not ispresent(g_pars.subscr.cp.peer_sdp.attributes) or + not match(g_pars.subscr.cp.peer_sdp.attributes, preconds)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str(g_name & ": Unexpected precondition attrs in 200 OK (UPDATE): ", + g_pars.subscr.cp.peer_sdp.attributes)); + } + g_pars.subscr.cp.sip_seq_nr := g_rx_sip_resp.msgHeader.cSeq.seqNumber + 1; } @@ -1076,7 +1136,7 @@ *, "INVITE", 200, g_pars.subscr.cp.sip_seq_nr, "OK", - body := ?); + body := *); as_SIP_expect_resp(exp, fail_others := false); deactivate(d_trying); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37259?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibfdc7e61a72655cd89d5d3f0f1d8798325ae1403 Gerrit-Change-Number: 37259 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Validate precondition in SDP of MO calls

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37258?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: asterisk: Validate precondition in SDP of MO calls ...................................................................... asterisk: Validate precondition in SDP of MO calls Change-Id: If37aa4146e02279120bc4856255fb845086fa5a8 --- M asterisk/IMS_ConnectionHandler.ttcn 1 file changed, 90 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/37258/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If37aa4146e02279120bc4856255fb845086fa5a8 Gerrit-Change-Number: 37258 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/SDP_Templates: Add templates for precondition qos attributes

by pespin

Attention is currently required from: Hoernchen, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37257?usp=email ) Change subject: library/SDP_Templates: Add templates for precondition qos attributes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This is used in https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37258 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I656ec1fa77bf3390a690fb0ed385d0be95c0f6b4 Gerrit-Change-Number: 37257 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 20 Jun 2024 11:53:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Validate precondition in SDP of MO calls

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37258?usp=email ) Change subject: asterisk: Validate precondition in SDP of MO calls ...................................................................... asterisk: Validate precondition in SDP of MO calls Change-Id: If37aa4146e02279120bc4856255fb845086fa5a8 --- M asterisk/IMS_ConnectionHandler.ttcn 1 file changed, 90 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/37258/1 diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index 6174881..da922ea 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -484,7 +484,13 @@ [fail_others] as_SIP_fail_resp(sip_expect_str); } -private function f_gen_sdp() runs on IMS_ConnHdlr return charstring { +type enumerated IMS_gen_sdp_state { + IMS_GEN_SDP_None, + IMS_GEN_SDP_MT_Session_Progress, + IMS_GEN_SDP_MT_UPDATE_200OK +} + +private function f_gen_sdp(IMS_gen_sdp_state st := IMS_GEN_SDP_None) runs on IMS_ConnHdlr return charstring { var charstring sdp := "v=0\r\n" & "o=0502 2390 1824 IN IP4 " & g_pars.subscr.cp.local_rtp_addr & "\r\n" & @@ -508,6 +514,25 @@ "a=rtcp:" & int2str(g_pars.subscr.cp.local_rtp_port + 1) & "\r\n" & "a=rtcp-fb:* trr-int 1000\r\n" & "a=rtcp-fb:* ccm tmmbr\r\n"; + select (st) { + case (IMS_GEN_SDP_None) { + } + case (IMS_GEN_SDP_MT_Session_Progress) { + sdp := sdp & + "a=curr:qos local none\r\n" & + "a=curr:qos remote none\r\n" & + "a=des:qos mandatory local sendrecv\r\n" & + "a=des:qos mandatory remote sendrecv\r\n" & + "a=conf:qos remote sendrecv\r\n"; + } + case (IMS_GEN_SDP_MT_UPDATE_200OK) { + sdp := sdp & + "a=curr:qos local sendrecv\r\n" & + "a=curr:qos remote sendrecv\r\n" & + "a=des:qos mandatory local sendrecv\r\n" & + "a=des:qos mandatory remote sendrecv\r\n"; + } + } return sdp; } @@ -1140,7 +1165,7 @@ [] SIP.receive(exp_req) -> value g_rx_sip_req { var template (value) PDU_SIP_Response tx_resp; var Via via; - var charstring tx_sdp; + var template (omit) charstring tx_sdp; var boolean peer_support_precondition := match(g_rx_sip_req.msgHeader.supported.optionsTags, superset("100rel", "precondition")); @@ -1172,13 +1197,30 @@ COORD.send(IMS_COORD_CMD_CALL_TRYING); } - tx_sdp := f_gen_sdp(); - /* Use precondition ? */ if (g_pars.subscr.cp.require_precondition_ext or (g_pars.subscr.cp.support_precondition_ext and peer_support_precondition)) { + var template (present) SDP_attribute_list preconds; + /* Vlidate SDP in INVITE contains the preconditions: + * a=curr:qos local none + * a=curr:qos remote none + * a=des:qos mandatory local sendrecv + * a=des:qos optional remote sendrecv + */ + preconds := superset( + tr_SDP_curr(c_SDP_PRECON_STATUS_TYPE_local, c_SDP_PRECON_DIR_TAG_none), + tr_SDP_curr(c_SDP_PRECON_STATUS_TYPE_remote, c_SDP_PRECON_DIR_TAG_none), + tr_SDP_curr(c_SDP_PRECON_STRENGTH_TAG_mandatory, c_SDP_PRECON_STATUS_TYPE_local, c_SDP_PRECON_DIR_TAG_sendrecv), + tr_SDP_curr(c_SDP_PRECON_STRENGTH_TAG_optional, c_SDP_PRECON_STATUS_TYPE_remote, c_SDP_PRECON_DIR_TAG_sendrecv)); + if (not ispresent(g_pars.subscr.cp.peer_sdp.attributes) or + not match(g_pars.subscr.cp.peer_sdp.attributes, preconds)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str(g_name & ": Unexpected precondition attrs in INVITE : ", + g_pars.subscr.cp.peer_sdp.attributes)); + } + /* Tx 183 Session Progress */ - /* TODO: add a=curr:qos, a=des:qos and a=conf:qos fields to SDP */ + tx_sdp := f_gen_sdp(IMS_GEN_SDP_MT_Session_Progress); tx_resp := ts_SIP_Response_SessionProgress(g_pars.subscr.cp.sip_call_id, g_pars.subscr.cp.from_addr, g_pars.subscr.cp.to_addr, @@ -1221,8 +1263,26 @@ body := ?); as_SIP_expect_req(exp_req); + /* Validate SDP in UPDATE contains the preconditions: + * a=curr:qos local sendrecv + * a=curr:qos remote none + * a=des:qos mandatory local sendrecv + * a=des:qos mandatory remote sendrecv + */ + preconds := superset( + tr_SDP_curr(c_SDP_PRECON_STATUS_TYPE_local, c_SDP_PRECON_DIR_TAG_sendrecv), + tr_SDP_curr(c_SDP_PRECON_STATUS_TYPE_remote, c_SDP_PRECON_DIR_TAG_none), + tr_SDP_curr(c_SDP_PRECON_STRENGTH_TAG_mandatory, c_SDP_PRECON_STATUS_TYPE_local, c_SDP_PRECON_DIR_TAG_sendrecv), + tr_SDP_curr(c_SDP_PRECON_STRENGTH_TAG_mandatory, c_SDP_PRECON_STATUS_TYPE_remote, c_SDP_PRECON_DIR_TAG_sendrecv)); + if (not ispresent(g_pars.subscr.cp.peer_sdp.attributes) or + not match(g_pars.subscr.cp.peer_sdp.attributes, preconds)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str(g_name & ": Unexpected precondition attrs in INVITE: ", + g_pars.subscr.cp.peer_sdp.attributes)); + } + /* Tx 200 OK (UPDATE) */ - /* TODO: add a=curr:qos, a=des:qos and a=conf:qos fields to SDP */ + tx_sdp := f_gen_sdp(IMS_GEN_SDP_MT_UPDATE_200OK); tx_resp := ts_SIP_Response(g_pars.subscr.cp.sip_call_id, g_pars.subscr.cp.from_addr, g_pars.subscr.cp.to_addr, @@ -1234,6 +1294,20 @@ SIP.send(tx_resp); g_pars.subscr.cp.sip_seq_nr := g_pars.subscr.cp.sip_seq_nr + 1; + /* 200 OK (INVITE) has no SDP if we use precondition: */ + tx_sdp := omit; + } else { + /* Check no precondition is sent in SDP */ + if (ispresent(g_pars.subscr.cp.peer_sdp.attributes) and + match (g_pars.subscr.cp.peer_sdp.attributes, superset(tr_SDP_curr_present, + tr_SDP_des_present, + tr_SDP_conf_present))) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str(g_name & ": Unexpected precondition attrs in INVITE: ", + g_pars.subscr.cp.peer_sdp.attributes)); + } + /* 200 OK (INVITE) has SDP if no precondition is used: */ + tx_sdp := f_gen_sdp(); } /* Tx 180 Ringing */ @@ -1246,6 +1320,7 @@ /* Tx 200 OK */ + tx_sdp := f_gen_sdp(); tx_resp := ts_SIP_Response(g_pars.subscr.cp.sip_call_id, g_pars.subscr.cp.from_addr, g_pars.subscr.cp.to_addr, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If37aa4146e02279120bc4856255fb845086fa5a8 Gerrit-Change-Number: 37258 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/SDP_Templates: Add templates for precondition qos attributes

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37257?usp=email ) Change subject: library/SDP_Templates: Add templates for precondition qos attributes ...................................................................... library/SDP_Templates: Add templates for precondition qos attributes Change-Id: I656ec1fa77bf3390a690fb0ed385d0be95c0f6b4 --- M library/SDP_Templates.ttcn 1 file changed, 86 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/57/37257/1 diff --git a/library/SDP_Templates.ttcn b/library/SDP_Templates.ttcn index 525da8e..ece6147 100644 --- a/library/SDP_Templates.ttcn +++ b/library/SDP_Templates.ttcn @@ -147,6 +147,83 @@ } } +/* rfc3312 */ +const charstring c_SDP_PRECON_TYPE_qos := "qos"; +const charstring c_SDP_PRECON_STRENGTH_TAG_mandatory := "mandatory"; +const charstring c_SDP_PRECON_STRENGTH_TAG_optional := "optional"; +const charstring c_SDP_PRECON_STRENGTH_TAG_none := "none"; +const charstring c_SDP_PRECON_STRENGTH_TAG_failure := "failure"; +const charstring c_SDP_PRECON_STRENGTH_TAG_unknown := "unknown"; +const charstring c_SDP_PRECON_STATUS_TYPE_e2e := "e2e"; +const charstring c_SDP_PRECON_STATUS_TYPE_local := "local"; +const charstring c_SDP_PRECON_STATUS_TYPE_remote := "remote"; +const charstring c_SDP_PRECON_DIR_TAG_none := "none"; +const charstring c_SDP_PRECON_DIR_TAG_send := "send"; +const charstring c_SDP_PRECON_DIR_TAG_recv := "recv"; +const charstring c_SDP_PRECON_DIR_TAG_sendrecv := "sendrecv"; + +template (present) SDP_attribute tr_SDP_curr(charstring status_type, + charstring dir_tag, + charstring precondition_type := c_SDP_PRECON_TYPE_qos) := { + curr := { + attr_value := precondition_type & " " & status_type & " " & dir_tag + } +} +template (present) SDP_attribute tr_SDP_curr_present := { + curr := { + attr_value := ? + } +} +template (value) SDP_attribute ts_SDP_curr(charstring status_type, + charstring dir_tag, + charstring precondition_type := c_SDP_PRECON_TYPE_qos) := { + curr := { + attr_value := precondition_type & " " & status_type & " " & dir_tag + } +} + +template (present) SDP_attribute tr_SDP_des(charstring status_type, + charstring strength_tag, + charstring dir_tag, + charstring precondition_type := c_SDP_PRECON_TYPE_qos) := { + curr := { + attr_value := precondition_type & " " & strength_tag & " " & status_type & " " & dir_tag + } +} +template (present) SDP_attribute tr_SDP_des_present := { + des := { + attr_value := ? + } +} +template (value) SDP_attribute ts_SDP_des(charstring status_type, + charstring strength_tag, + charstring dir_tag, + charstring precondition_type := c_SDP_PRECON_TYPE_qos) := { + des := { + attr_value := precondition_type & " " & strength_tag & " " & status_type & " " & dir_tag + } +} + +template (present) SDP_attribute tr_SDP_conf(charstring status_type, + charstring dir_tag, + charstring precondition_type := c_SDP_PRECON_TYPE_qos) := { + conf := { + attr_value := precondition_type & " " & status_type & " " & dir_tag + } +} +template (present) SDP_attribute tr_SDP_conf_present := { + conf := { + attr_value := ? + } +} +template (value) SDP_attribute ts_SDP_conf(charstring status_type, + charstring dir_tag, + charstring precondition_type := c_SDP_PRECON_TYPE_qos) := { + conf := { + attr_value := precondition_type & " " & status_type & " " & dir_tag + } +} + function f_sdp_addr2addrtype(charstring addr) return charstring { for (var integer i := 0; i < lengthof(addr); i := i + 1) { if (addr[i] == ":") { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I656ec1fa77bf3390a690fb0ed385d0be95c0f6b4 Gerrit-Change-Number: 37257 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[M] Change in docker-playground[master]: ttcn3-s1gw-test: run eNB/MME domains in separate networks

by pespin

Attention is currently required from: fixeria, laforge, osmith, pespin. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37256?usp=email ) Change subject: ttcn3-s1gw-test: run eNB/MME domains in separate networks ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm not sure what do you win with this tbh, other than making the whole setup more complex and dropping use of usual docker-container helpers. In the end, osmo-s1gw is really doing nothing with network interfaces, it only handles/work with sockets bound to IP addresses, so the network interface configuration is totally transparent to it and shouldn't matter at all. You can test with 1 netif with several IP addresses, like we do in Asterisk_Tests or iirc in EPDG_Tests. I'm happy to hear I'm wrong about this. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37256?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4c72cb58eeb2d0ccca307dcfcfb04d09bfb0834e Gerrit-Change-Number: 37256 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jun 2024 18:41:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2024