June 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: silence error message for N-STATE prim

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36989?usp=email ) Change subject: silence error message for N-STATE prim ...................................................................... silence error message for N-STATE prim We ignore the N-STATE prim, so don't error about it. Related: SYS#6952 Change-Id: Ic353840a7b2e32c54c2732f58836776a5eddb220 --- M src/osmo-bsc/osmo_bsc_sigtran.c 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/89/36989/1 diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index a1aaaaf..24e5771 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -363,6 +363,11 @@ handle_pcstate_ind(osmo_sccp_get_ss7(sccp), &scu_prim->u.pcstate); break; + case OSMO_PRIM(OSMO_SCU_PRIM_N_STATE, PRIM_OP_INDICATION): + LOGP(DMSC, LOGL_DEBUG, "Ignoring SIGTRAN operation %s on primitive %s\n", + get_value_string(osmo_prim_op_names, oph->operation), osmo_scu_prim_type_name(oph->primitive)); + break; + default: LOGP(DMSC, LOGL_ERROR, "Unhandled SIGTRAN operation %s on primitive %s\n", get_value_string(osmo_prim_op_names, oph->operation), osmo_scu_prim_type_name(oph->primitive)); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36989?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic353840a7b2e32c54c2732f58836776a5eddb220 Gerrit-Change-Number: 36989 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in osmo-bsc[master]: err log: output sigtran prim name instead of number

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36988?usp=email ) Change subject: err log: output sigtran prim name instead of number ...................................................................... err log: output sigtran prim name instead of number Change-Id: I14eb92a6c6d391873f0d6fc7d61205a13e635e6e --- M src/osmo-bsc/osmo_bsc_sigtran.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/36988/1 diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index a4d0f2d..a1aaaaf 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -364,8 +364,8 @@ break; default: - LOGP(DMSC, LOGL_ERROR, "Unhandled SIGTRAN operation %s on primitive %u\n", - get_value_string(osmo_prim_op_names, oph->operation), oph->primitive); + LOGP(DMSC, LOGL_ERROR, "Unhandled SIGTRAN operation %s on primitive %s\n", + get_value_string(osmo_prim_op_names, oph->operation), osmo_scu_prim_type_name(oph->primitive)); break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36988?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I14eb92a6c6d391873f0d6fc7d61205a13e635e6e Gerrit-Change-Number: 36988 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in osmo-ci[master]: jobs/{gerrit,master}: osmo-epdg: build manuals too

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36986?usp=email ) Change subject: jobs/{gerrit,master}: osmo-epdg: build manuals too ...................................................................... jobs/{gerrit,master}: osmo-epdg: build manuals too Related: OS#6332 Change-Id: I540c7cff982f6b0242b4b40985a80d0426c903d6 --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 32 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 1a5d656..61d90cc 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -194,8 +194,18 @@ - osmo-epdg: repos_url: '{gerrit_url}/erlang/{repos}' gerrit_project: 'erlang/{repos}' - cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' pipeline_binpkgs: "debian:12" + a2_name: JOB_TYPE + a2: !!python/tuple ["build", "manuals"] + cmd: | + case "$JOB_TYPE" in + build) + {docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh + ;; + manuals) + {docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins_manuals.sh + ;; + esac - osmo-e1-hardware: a2_name: JOB_TYPE diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index a902be8..d0ad169 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -278,7 +278,17 @@ - osmo-epdg: repos_url: '{gerrit_url}/erlang/{repos}' - cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' + a2_name: JOB_TYPE + a2: !!python/tuple ["build", "manuals"] + cmd: | + case "$JOB_TYPE" in + build) + {docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh + ;; + manuals) + {docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins_manuals.sh + ;; + esac - osmo-e1-hardware: a2_name: JOB_TYPE -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36986?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I540c7cff982f6b0242b4b40985a80d0426c903d6 Gerrit-Change-Number: 36986 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

[S] Change in osmo-ci[master]: jobs/{gerrit,master}: osmo-epdg: build manuals too

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36986?usp=email ) Change subject: jobs/{gerrit,master}: osmo-epdg: build manuals too ...................................................................... Patch Set 1: (1 comment) File jobs/master-builds.yml: https://gerrit.osmocom.org/c/osmo-ci/+/36986/comment/9bec5bdc_8e380dcc PS1, Line 282: a2: !!python/tuple ["build", "manuals"] > As alternative you could add an (optional) argument to the jenkins. […] Yes, that would work too - but I'll leave it as-is. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36986?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I540c7cff982f6b0242b4b40985a80d0426c903d6 Gerrit-Change-Number: 36986 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 03 Jun 2024 14:20:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in ...osmo-epdg[master]: gitignore: add manuals related

by osmith

Attention is currently required from: lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36985?usp=email ) Change subject: gitignore: add manuals related ...................................................................... Patch Set 1: (1 comment) File .gitignore: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36985/comment/22dfea27_11f1… PS1, Line 12: / ah indeed, I didn't realize it was equal as long as there is a slash in the middle: > If there is a separator at the beginning or middle (or both) of the pattern, then > the pattern is relative to the directory level of the particular .gitignore file > itself. Otherwise the pattern may also match at any level below the .gitignore > level. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I3e0924fb2e6120de5c8bf700d1db667345231bb5 Gerrit-Change-Number: 36985 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 03 Jun 2024 14:18:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in ...osmo-epdg[master]: gitignore: add manuals related

by osmith

Attention is currently required from: lynxis lazus, osmith. Hello Jenkins Builder, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36985?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by lynxis lazus, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: gitignore: add manuals related ...................................................................... gitignore: add manuals related Related: OS#6332 Change-Id: I3e0924fb2e6120de5c8bf700d1db667345231bb5 --- M .gitignore 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/85/36985/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I3e0924fb2e6120de5c8bf700d1db667345231bb5 Gerrit-Change-Number: 36985 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 year

1
0
0 0

[S] Change in ...osmo-epdg[master]: debian: add oemo-epdg-doc subpackage

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36987?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: debian: add oemo-epdg-doc subpackage ...................................................................... debian: add oemo-epdg-doc subpackage Related: OS#6332 Change-Id: I6e39c0cbdd8ea24f8f69a28194a4a13f9bb7a33b --- M debian/control A debian/osmo-epdg-doc.install M debian/rules 3 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/87/36987/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36987?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I6e39c0cbdd8ea24f8f69a28194a4a13f9bb7a33b Gerrit-Change-Number: 36987 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year

1
0
0 0

[S] Change in ...osmo-epdg[master]: contrib/jenkins_manuals: new file

by osmith

Attention is currently required from: lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36984?usp=email ) Change subject: contrib/jenkins_manuals: new file ...................................................................... Patch Set 1: (1 comment) File contrib/jenkins_manuals.sh: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36984/comment/f72f1469_0f41… PS1, Line 7: make publish > Where do you defined the `publish` target in the Makefile? Did I missed the commit? it is in the included Makefile from here: https://gitea.osmocom.org/cellular-infrastructure/osmo-gsm-manuals/src/comm… -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I10f8490e37fd0e332e670b6d461997024588a00c Gerrit-Change-Number: 36984 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 03 Jun 2024 14:16:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmo-ci[master]: jobs/{gerrit,master}: osmo-epdg: build manuals too

by lynxis lazus

Attention is currently required from: osmith. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36986?usp=email ) Change subject: jobs/{gerrit,master}: osmo-epdg: build manuals too ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Patchset: PS1: See my comment. File jobs/master-builds.yml: https://gerrit.osmocom.org/c/osmo-ci/+/36986/comment/e41496af_0f25e934 PS1, Line 282: a2: !!python/tuple ["build", "manuals"] As alternative you could add an (optional) argument to the jenkins.sh and only the manual job has it set. Just a note, not a change request. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36986?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I540c7cff982f6b0242b4b40985a80d0426c903d6 Gerrit-Change-Number: 36986 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Jun 2024 14:11:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in ...osmo-epdg[master]: contrib/jenkins_manuals: new file

by lynxis lazus

Attention is currently required from: osmith. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36984?usp=email ) Change subject: contrib/jenkins_manuals: new file ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File contrib/jenkins_manuals.sh: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36984/comment/ed20cd8e_c7da… PS1, Line 7: make publish Where do you defined the `publish` target in the Makefile? Did I missed the commit? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I10f8490e37fd0e332e670b6d461997024588a00c Gerrit-Change-Number: 36984 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Jun 2024 14:09:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2024