Attention is currently required from: osmith.
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36985?usp=email )
Change subject: gitignore: add manuals related
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File .gitignore:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36985/comment/3617d0cf_c398…
PS1, Line 12: /
I find the first slash weird. but should work.
as far I understand, `/docs/manuals/build` `docs/manuals/build` are equal.
(https://git-scm.com/docs/gitignore)
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36985?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I3e0924fb2e6120de5c8bf700d1db667345231bb5
Gerrit-Change-Number: 36985
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 03 Jun 2024 14:07:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36984?usp=email )
Change subject: contrib/jenkins_manuals: new file
......................................................................
contrib/jenkins_manuals: new file
Add a separate jenkins script to build and publish the manuals. This
will use the debian-bookworm-build container, which has all dependencies
for the manuals. The other script contrib/jenkins.sh uses the
debian-bookworm-erlang container.
Related: OS#6332
Change-Id: I10f8490e37fd0e332e670b6d461997024588a00c
---
A contrib/jenkins_manuals.sh
1 file changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/84/36984/1
diff --git a/contrib/jenkins_manuals.sh b/contrib/jenkins_manuals.sh
new file mode 100755
index 0000000..3dd3d0b
--- /dev/null
+++ b/contrib/jenkins_manuals.sh
@@ -0,0 +1,8 @@
+#!/bin/sh -ex
+
+cd docs/manuals
+make
+
+if [ "$PUBLISH" = "1" ]; then
+ make publish
+fi
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36984?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I10f8490e37fd0e332e670b6d461997024588a00c
Gerrit-Change-Number: 36984
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email
to look at the new patch set (#5).
Change subject: firmware: allow to change the sim presence pin polarity
......................................................................
firmware: allow to change the sim presence pin polarity
The sim presence pin allows the simtrace2 to inform the modem
about the presence of the simcard. On a generic simcard slot a
button is pressed by the simcard which generate a high or low voltage level.
Even there are specifications of minipcie or ngff defining this signal, certain
modems behave different.
Certain modems require different signals from the specification.
Extend the usb protocol to set the behaviour at runtime.
Related: SYS#6946
Change-Id: I77118114ba873fdf0778137402888b40f2442456
---
M TODO-RELEASE
M firmware/libcommon/include/simtrace.h
M firmware/libcommon/include/simtrace_prot.h
M firmware/libcommon/source/card_emu.c
M firmware/libcommon/source/mode_cardemu.c
M firmware/test/Makefile
M firmware/test/card_emu_tests.c
7 files changed, 83 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/81/36981/5
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I77118114ba873fdf0778137402888b40f2442456
Gerrit-Change-Number: 36981
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: lynxis lazus.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email )
Change subject: firmware: allow to change the sim presence pin polarity
......................................................................
Patch Set 4:
(1 comment)
File firmware/test/card_emu_tests.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16393):
https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/06a619c8_8d691a66
PS4, Line 99: }
void function return statements are not generally useful
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I77118114ba873fdf0778137402888b40f2442456
Gerrit-Change-Number: 36981
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 03 Jun 2024 12:39:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: firmware: allow to change the sim presence pin polarity
......................................................................
firmware: allow to change the sim presence pin polarity
The sim presence pin allows the simtrace2 to inform the modem
about the presence of the simcard. On a generic simcard slot a
button is pressed by the simcard which generate a high or low voltage level.
Even there are specifications of minipcie or ngff defining this signal, certain
modems behave different.
Certain modems require different signals from the specification.
Extend the usb protocol to set the behaviour at runtime.
Related: SYS#6946
Change-Id: I77118114ba873fdf0778137402888b40f2442456
---
M TODO-RELEASE
M firmware/libcommon/include/simtrace.h
M firmware/libcommon/include/simtrace_prot.h
M firmware/libcommon/source/card_emu.c
M firmware/libcommon/source/mode_cardemu.c
M firmware/test/Makefile
M firmware/test/card_emu_tests.c
7 files changed, 84 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/81/36981/4
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I77118114ba873fdf0778137402888b40f2442456
Gerrit-Change-Number: 36981
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-remsim/+/36983?usp=email
to look at the new patch set (#2).
Change subject: remsim_client: add support to set sim presence pin polarity
......................................................................
remsim_client: add support to set sim presence pin polarity
The sim presence pin allows the simtrace2 to inform the modem
about the presence of the simcard. On a generic simcard slot a
button is pressed by the simcard which generate a high or low voltage level.
Even there are specifications of minipcie or ngff defining this signal, certain
modems don't follow the specification and require a different signal level.
Related: SYS#6946
Depends-on: Iacde63e667472a85a5f18cb4ca99dcfa1a84dd59 (simtrace2)
Change-Id: Iaa61967d2e8cd5c2269b73f4e65b42072e0ec513
---
M TODO-RELEASE
M configure.ac
M src/client/Makefile.am
M src/client/client.h
M src/client/remsim_client_main.c
M src/client/user_simtrace2.c
6 files changed, 46 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/83/36983/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36983?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Iaa61967d2e8cd5c2269b73f4e65b42072e0ec513
Gerrit-Change-Number: 36983
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset