Attention is currently required from: laforge.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36960?usp=email )
Change subject: esim.saip: Implement ProfileElement.header_name for more PE types
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36960?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I37951a0441fe53fce7a329066aebd973389cb743
Gerrit-Change-Number: 36960
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 03 Jun 2024 08:14:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36959?usp=email )
Change subject: pySim.esim.saip.validation: Ensure unique PE identification value
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36959?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I37b9eb4cfb74de79b0493986d976c8a5f8ccd8ea
Gerrit-Change-Number: 36959
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 03 Jun 2024 08:13:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36969?usp=email )
Change subject: utils: Introduce BER-TLV parsers that return raw tag or even raw TLV
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36969?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I1e68a4003b833e86e9282c77325afa86ce144b98
Gerrit-Change-Number: 36969
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 03 Jun 2024 08:03:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email )
Change subject: build config: add --disable-ortp option
......................................................................
build config: add --disable-ortp option
Having ortp as a mandatory dependency for Osmocom CNI suite is
very burdensome for users of OS distributions that don't provide
zero-effort readily installable packages for every piece of software
under the sun. Furthermore, the actual usage of this dependency
in Osmocom is quite minimal: in a complete Osmocom 2G network,
only OsmoBTS uses the osmo_ortp layer provided by libosmo-abis,
and even that dependency may become optional in the future if we
implement an alternative jitter buffer mechanism natively in Osmocom.
Add --disable-ortp option to libosmo-abis configure that does what
it says, similar to the numerous --disable-* options in libosmocore.
When libosmo-abis is built with this option, osmo_ortp module is
excluded from libosmotrau, and <osmocom/trau/osmo_ortp.h> is omitted
from the installation. Packages that require osmo_ortp will then
fail to build, but other Osmocom CNI components that require
libosmoabis and/or libosmotrau (but not osmo_ortp) will build
and work with ortp dependency eliminated.
Related: OS#6474
Change-Id: I554260483b94d812ac3a957c969a902870f53883
---
M configure.ac
M include/Makefile.am
M src/Makefile.am
3 files changed, 52 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/75/36975/1
diff --git a/configure.ac b/configure.ac
index 085bb83..da80a1e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -70,7 +70,20 @@
PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.9.0)
PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.9.0)
PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec >= 1.9.0)
-PKG_CHECK_MODULES(ORTP, ortp >= 0.22.0)
+
+AC_ARG_ENABLE([ortp], [AS_HELP_STRING([--disable-ortp], [Build without ortp support])],
+ [
+ ENABLE_ORTP=$enableval
+ ],
+ [
+ ENABLE_ORTP="yes"
+ ])
+AS_IF([test "x$ENABLE_ORTP" = "xyes"], [
+ PKG_CHECK_MODULES(ORTP, ortp >= 0.22.0)
+ AC_DEFINE([HAVE_ORTP],[1],[Build with ortp support])
+])
+AM_CONDITIONAL(ENABLE_ORTP, test "x$ENABLE_ORTP" = "xyes")
+AC_SUBST(ENABLE_ORTP)
AC_ARG_ENABLE([dahdi],
AC_HELP_STRING([--disable-dahdi],
diff --git a/include/Makefile.am b/include/Makefile.am
index a167ef2..88d66dc 100644
--- a/include/Makefile.am
+++ b/include/Makefile.am
@@ -3,9 +3,12 @@
nobase_include_HEADERS = osmocom/abis/ipa.h osmocom/abis/trau_frame.h \
osmocom/abis/ipa_proxy.h osmocom/abis/ipaccess.h osmocom/abis/abis.h \
osmocom/abis/subchan_demux.h osmocom/abis/e1_input.h \
- osmocom/abis/lapd.h osmocom/abis/lapd_pcap.h osmocom/trau/osmo_ortp.h \
- osmocom/abis/unixsocket_proto.h \
+ osmocom/abis/lapd.h osmocom/abis/lapd_pcap.h osmocom/abis/unixsocket_proto.h \
osmocom/trau/trau_frame.h \
osmocom/trau/trau_sync.h \
osmocom/trau/trau_pcu_ericsson.h \
osmocom/trau/trau_rtp.h
+
+if ENABLE_ORTP
+nobase_include_HEADERS += osmocom/trau/osmo_ortp.h
+endif
diff --git a/src/Makefile.am b/src/Makefile.am
index 927d63f..d72601b 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -41,10 +41,13 @@
-no-undefined \
$(NULL)
libosmotrau_la_LIBADD = $(COMMONLIBS) $(LIBOSMOCODEC_LIBS) $(ORTP_LIBS)
-libosmotrau_la_SOURCES = trau/osmo_ortp.c \
- trau/trau_frame.c \
+libosmotrau_la_SOURCES = trau/trau_frame.c \
trau/trau_pcu_ericsson.c \
trau/trau_sync.c \
trau/trau_rtp_conv.c
+if ENABLE_ORTP
+libosmotrau_la_SOURCES += trau/osmo_ortp.c
+endif
+
noinst_HEADERS = trau/ubit_buf.h
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I554260483b94d812ac3a957c969a902870f53883
Gerrit-Change-Number: 36975
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-MessageType: newchange
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36971?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: [cosmetic] fix typos in comments
......................................................................
[cosmetic] fix typos in comments
Change-Id: I549ef7002e6ebef3f13af620cad8d03c7f4d891a
---
M osmo-smdpp.py
M pySim/esim/rsp.py
2 files changed, 11 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
lynxis lazus: Looks good to me, approved
diff --git a/osmo-smdpp.py b/osmo-smdpp.py
index d7fc872..9551396 100755
--- a/osmo-smdpp.py
+++ b/osmo-smdpp.py
@@ -444,7 +444,7 @@
ss.host_id = b'mahlzeit'
- # Generate Session Keys using the CRT, opPK.eUICC.ECKA and otSK.DP.ECKA according to annex G
+ # Generate Session Keys using the CRT, otPK.eUICC.ECKA and otSK.DP.ECKA according to annex G
euicc_public_key = ec.EllipticCurvePublicKey.from_encoded_point(ss.smdp_ot.curve, ss.euicc_otpk)
ss.shared_secret = ss.smdp_ot.exchange(ec.ECDH(), euicc_public_key)
print("shared_secret: %s" % b2h(ss.shared_secret))
diff --git a/pySim/esim/rsp.py b/pySim/esim/rsp.py
index a032031..85dacee 100644
--- a/pySim/esim/rsp.py
+++ b/pySim/esim/rsp.py
@@ -37,7 +37,7 @@
def __init__(self, transactionId: str, serverChallenge: bytes, ci_cert_id: bytes):
self.transactionId = transactionId
self.serverChallenge = serverChallenge
- # used at a later point between API calsl
+ # used at a later point between API calls
self.ci_cert_id = ci_cert_id
self.euicc_cert: Optional[x509.Certificate] = None
self.eum_cert: Optional[x509.Certificate] = None
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36971?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I549ef7002e6ebef3f13af620cad8d03c7f4d891a
Gerrit-Change-Number: 36971
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: merged
