May 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-sip-connector[master]: debian/postinst: add checks, be verbose

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/36809?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/36809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I2b01a7625cf66fbb7d203f939ddcc1cbab43cf33 Gerrit-Change-Number: 36809 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 May 2024 14:26:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-upf[master]: debian/postinst: add checks, be verbose

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/36811?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/36811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I8994759df644d6edd8f937051b95690537b749be Gerrit-Change-Number: 36811 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 May 2024 14:26:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ci[master]: OBS: gerrit_binpkgs: add hint where to find pkgs

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36813?usp=email ) Change subject: OBS: gerrit_binpkgs: add hint where to find pkgs ...................................................................... OBS: gerrit_binpkgs: add hint where to find pkgs Change-Id: If58081b17f96283620cd945f3521cf0edb4f7913 --- M scripts/obs/gerrit_binpkgs.sh 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/obs/gerrit_binpkgs.sh b/scripts/obs/gerrit_binpkgs.sh index 636be89..4e3b0f3 100755 --- a/scripts/obs/gerrit_binpkgs.sh +++ b/scripts/obs/gerrit_binpkgs.sh @@ -39,3 +39,5 @@ "$SCRIPTS_OBS_DIR"/build_binpkg.py \ --docker "$DISTRO" \ "$PROJECT_NAME" + +echo ":: Find binary packages in: $SCRIPTS_OBS_DIR/_temp/binpkgs" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If58081b17f96283620cd945f3521cf0edb4f7913 Gerrit-Change-Number: 36813 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-ci[master]: OBS: gerrit_binpkgs: use --no-meta

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36812?usp=email ) Change subject: OBS: gerrit_binpkgs: use --no-meta ...................................................................... OBS: gerrit_binpkgs: use --no-meta Don't let packages built with gerrit_binpkgs.sh depend on an osmocom-master meta package. This makes it easier to install and test the built packages locally. Change-Id: Ie225ed9d0a3b822752d902eaf1e74f54fb5f5d63 --- M scripts/obs/gerrit_binpkgs.sh 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/scripts/obs/gerrit_binpkgs.sh b/scripts/obs/gerrit_binpkgs.sh index 1e4ae26..636be89 100755 --- a/scripts/obs/gerrit_binpkgs.sh +++ b/scripts/obs/gerrit_binpkgs.sh @@ -32,6 +32,7 @@ --feed master \ --git-skip-fetch \ --git-skip-checkout \ + --no-meta \ "$PROJECT_NAME" echo ":: Building the binary packages" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie225ed9d0a3b822752d902eaf1e74f54fb5f5d63 Gerrit-Change-Number: 36812 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-ci[master]: OBS: gerrit_binpkgs: add hint where to find pkgs

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36813?usp=email ) Change subject: OBS: gerrit_binpkgs: add hint where to find pkgs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If58081b17f96283620cd945f3521cf0edb4f7913 Gerrit-Change-Number: 36813 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 May 2024 14:26:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ci[master]: OBS: gerrit_binpkgs: use --no-meta

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36812?usp=email ) Change subject: OBS: gerrit_binpkgs: use --no-meta ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie225ed9d0a3b822752d902eaf1e74f54fb5f5d63 Gerrit-Change-Number: 36812 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 May 2024 14:26:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-mgw[master]: contrib/systemd: run as osmocom user

by lynxis lazus

Attention is currently required from: fixeria, laforge, msuraev, osmith. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30094?usp=email ) Change subject: contrib/systemd: run as osmocom user ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/30094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibb83c231231b39dc6732c0f375aeb3b21f3938ef Gerrit-Change-Number: 30094 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 May 2024 14:24:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Always set Content-Length

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36814?usp=email ) Change subject: SIP_Templates: Always set Content-Length ...................................................................... SIP_Templates: Always set Content-Length According to RFC3261 7.4.2, 7.5, 20.14 Content-Length SHOULD be set over any transport, and MUST be set over TCP. Hence, make sure we set it in all cases. This allows Asterisk being able to decode SIP messages sent to it over a TCP connection, since it uses the Content-Length field to look up for message boundaries over the TCP stream. Change-Id: I26e444fe466b4742d74ef5a6e371ce8488a5afcf --- M library/SIP_Templates.ttcn 1 file changed, 68 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/36814/1 diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index 1c684c1..ab566d0 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -215,6 +215,16 @@ } +// [20.14] +template (value) ContentLength ts_ContentLength(template (value) integer len := 0) := { + fieldName := CONTENT_LENGTH_E, + len := len +} +template (present) ContentLength tr_ContentLength(template (present) integer len := ?) := { + fieldName := CONTENT_LENGTH_E, + len := len +} + // [20.19] template (value) Expires ts_Expires(template (value) DeltaSec deltaSec := "7200") := { fieldName := EXPIRES_E, @@ -433,6 +443,16 @@ return ct; } +private function f_ContentLength(template (omit) charstring body) +return template (value) ContentLength { + /* rfc3261 20.14: "If no body is present in a message, then the + * Content-Length header field value MUST be set to zero." */ + if (istemplatekind(body, "omit")) { + return ts_ContentLength(0); + } + return ts_ContentLength(lengthof(body)); +} + template (value) ContentType ts_CT_SDP := { fieldName := CONTENT_TYPE_E, mediaType := "application/sdp" @@ -553,6 +573,7 @@ template (value) charstring method, template (value) integer seq_nr, template (value) Via via, + template (omit) ContentLength content_length := ts_ContentLength(0), template (omit) ContentType content_type := omit, template (omit)Authorization authorization := omit, template (omit) Allow allow := ts_Allow(c_SIP_defaultMethods), @@ -572,6 +593,7 @@ callid := call_id }, contact := contact, + contentLength := content_length, contentType := content_type, cSeq := { fieldName := CSEQ_E, @@ -606,8 +628,9 @@ template Contact contact, template (present) Via via := tr_Via_from(?), template charstring method, - template ContentType content_type := *, template integer seq_nr := ?, + template ContentLength content_length := *, + template ContentType content_type := *, template Allow allow := *, template Expires expires := *, template Require require := *, @@ -624,6 +647,7 @@ callid := call_id }, contact := contact, + contentLength := content_length, contentType := content_type, cSeq := { fieldName := CSEQ_E, @@ -669,7 +693,8 @@ requestLine := ts_SIP_ReqLine(REGISTER_E, sip_url_host_port), msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, contact, "REGISTER", seq_nr, via, - f_ContentTypeOrOmit(ts_CT_SDP, body), + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body), authorization := authorization, expires := expires, require := require, @@ -693,7 +718,7 @@ template charstring body := *) := { requestLine := tr_SIP_ReqLine(REGISTER_E, sip_url_host_port), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, contact, - via, "REGISTER", *, seq_nr, + via, "REGISTER", seq_nr, expires := expires, require := require, security_client := security_client, @@ -714,7 +739,8 @@ msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, contact, "INVITE", seq_nr, via, - f_ContentTypeOrOmit(ts_CT_SDP, body)), + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body)), messageBody := body, payload := omit } @@ -728,7 +754,7 @@ template charstring body) := { requestLine := tr_SIP_ReqLine(INVITE_E, uri), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, ?, - via, "INVITE", *, seq_nr), + via, "INVITE", seq_nr), messageBody := body, payload := omit } @@ -742,7 +768,9 @@ template (omit) charstring body) := { requestLine := ts_SIP_ReqLine(BYE_E, to_addr.addr.nameAddr.addrSpec), msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, omit, "BYE", seq_nr, - via, f_ContentTypeOrOmit(ts_CT_SDP, body)), + via, + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body)), messageBody := body, payload := omit } @@ -757,7 +785,7 @@ template charstring body := *) := { requestLine := tr_SIP_ReqLine(BYE_E, uri), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, omit, - via, "BYE", *, seq_nr), + via, "BYE", seq_nr), messageBody := body, payload := omit } @@ -775,7 +803,8 @@ ts_Contact_SipAddr(from_addr), "ACK", seq_nr, via, - f_ContentTypeOrOmit(ts_CT_SDP, body)), + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body)), messageBody := body, payload := omit } @@ -790,7 +819,7 @@ requestLine := tr_SIP_ReqLine(ACK_E, uri), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, *, via, - "ACK", *, seq_nr), + "ACK", seq_nr), messageBody := body, payload := omit } @@ -806,7 +835,7 @@ requestLine := tr_SIP_ReqLine(CANCEL_E, uri), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, *, via, - "CANCEL", *, seq_nr), + "CANCEL", seq_nr), messageBody := body, payload := omit } @@ -823,7 +852,9 @@ template (omit) charstring body := omit) := { statusLine := ts_SIP_StatusLine(status_code, reason), msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, omit, method, seq_nr, - via, f_ContentTypeOrOmit(ts_CT_SDP, body)), + via, + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body)), messageBody := body, payload := omit } @@ -839,7 +870,9 @@ template (omit) charstring body := omit) := { statusLine := ts_SIP_StatusLine(100, "Trying"), msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, omit, method, seq_nr, - via, f_ContentTypeOrOmit(ts_CT_SDP, body)), + via, + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body)), messageBody := body, payload := omit } @@ -855,7 +888,9 @@ template (omit) charstring body := omit) := { statusLine := ts_SIP_StatusLine(180, "Ringing"), msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, omit, method, seq_nr, - via, f_ContentTypeOrOmit(ts_CT_SDP, body)), + via, + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body)), messageBody := body, payload := omit } @@ -874,7 +909,7 @@ statusLine := tr_SIP_StatusLine(status_code, reason), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, contact, via, - method, *, seq_nr), + method, seq_nr), messageBody := body, payload := omit } @@ -896,7 +931,7 @@ statusLine := tr_SIP_StatusLine(status_code, reason), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, contact, via, - method, *, seq_nr, + method, seq_nr, wwwAuthenticate := wwwAuthenticate), messageBody := body, payload := omit @@ -917,7 +952,7 @@ statusLine := tr_SIP_StatusLine(status_code, reason), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, omit, via, - method, *, seq_nr), + method, seq_nr), messageBody := body, payload := omit } @@ -937,7 +972,7 @@ statusLine := tr_SIP_StatusLine(status_code, reason), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, *, via, - method, *, seq_nr), + method, seq_nr), messageBody := body, payload := omit } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36814?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26e444fe466b4742d74ef5a6e371ce8488a5afcf Gerrit-Change-Number: 36814 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in simtrace2[master]: cardemu: add support for inverted sim presence pins

by lynxis lazus

Attention is currently required from: laforge, osmith. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/36441?usp=email ) Change subject: cardemu: add support for inverted sim presence pins ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Patchset: PS2: Will do another approach using bootloader default configuration. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36441?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I33325f763b56b297762a3fb6fe6baa7b0354de3c Gerrit-Change-Number: 36441 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: mschramm <mschramm(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 14 May 2024 14:22:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-hnbgw[master]: KPI: Add initial set of DTAP message type rate counters

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36788?usp=email ) Change subject: KPI: Add initial set of DTAP message type rate counters ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36788?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3e1ad7a2aa71674a22a27c31512600f2de139032 Gerrit-Change-Number: 36788 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 May 2024 14:22:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024