dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36851?usp=email )
Change subject: IPA_Tests: fix matching of tr_provideEimPackageResult_ePRAndNotif
......................................................................
IPA_Tests: fix matching of tr_provideEimPackageResult_ePRAndNotif
The template tr_provideEimPackageResult_ePRAndNotif got extended and
has now default parameters that break TC_proc_euicc_pkg_dwnld_exec_rollback,
so we must set euiccPackageResult to "?" to restore the original conditions
of the testcase.
Related: SYS#6563
Change-Id: I1e8c83a317619673cd091da585e44af1a6d8c866
---
M ipad/IPAd_Tests.ttcn
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/51/36851/1
diff --git a/ipad/IPAd_Tests.ttcn b/ipad/IPAd_Tests.ttcn
index 024c502..c5ee412 100644
--- a/ipad/IPAd_Tests.ttcn
+++ b/ipad/IPAd_Tests.ttcn
@@ -598,7 +598,7 @@
/* Step #10-14 */
esipa_res := valueof(ts_provideEimPackageResultResponse_eimAck(eimAcknowledgements := {1,2,3,4}));
esipa_req := f_esipa_transceive(esipa_res);
- if (not match(esipa_req, tr_provideEimPackageResult_ePRAndNotif)) {
+ if (not match(esipa_req, tr_provideEimPackageResult_ePRAndNotif(euiccPackageResult := ?))) {
setverdict(fail, "unexpected message from IPAd");
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36851?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1e8c83a317619673cd091da585e44af1a6d8c866
Gerrit-Change-Number: 36851
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36821?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: SGP32Definitions_Templates: add new template
......................................................................
SGP32Definitions_Templates: add new template
We do not have a template for the EsipaMessageFromIpaToEim message
that contains the HandleNotification field with the
profileInstallationResult, so lets add one.
Related: SYS#6824
Change-Id: Ic5d1b2ea1d3d7de20fbcb029b36e9f9daa27cce0
---
M library/euicc/SGP32Definitions_Templates.ttcn
1 file changed, 38 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/36821/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36821?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic5d1b2ea1d3d7de20fbcb029b36e9f9daa27cce0
Gerrit-Change-Number: 36821
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36819?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: SGP32Definitions_Templates: add new template
......................................................................
SGP32Definitions_Templates: add new template
We do not have a template for the GetBoundProfilePackageRequestEsipa,
so lets add one.
Change-Id: I90b699de01c0476262f0e25c196a147e0ccd44aa
Related: SYS#6824
---
M library/euicc/SGP32Definitions_Templates.ttcn
1 file changed, 33 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/36819/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36819?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I90b699de01c0476262f0e25c196a147e0ccd44aa
Gerrit-Change-Number: 36819
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36815?usp=email )
Change subject: IPAd_Tests: expect TERMINAL CAPABILITIES
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36815/comment/e8a431f2_77b1…
PS1, Line 317: f_vpcd_exp(tr_VPCD_DATA('80AA000005A903830107'O));
> it would be great if we could at least pust these hexstring into constants so they get a meaningful […]
Since we use the constant only once and since there is a comment and a spec reference that explains what it is, I think no extra constant is needed.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36815?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie0627685a300a478c39858abe1b5bb0f97f6d3fe
Gerrit-Change-Number: 36815
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 16 May 2024 14:28:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email )
Change subject: sgsn: add TC_attach_rau_invalid_old_rai
......................................................................
Patch Set 2:
(1 comment)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625/comment/182434c6_2256…
PS2, Line 2758: private function f_TC_attach_rau_invalid_old_rai(charstring id) runs on BSSGP_ConnHdlr {
> Probably a short comment explaining here what the test specific aim is may be good for other readers […]
+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I006adabdad26c0c48e1ebe99421bcab7295dc147
Gerrit-Change-Number: 36625
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 16 May 2024 14:03:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment