April 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: pcu: Update component diagram

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email ) Change subject: pcu: Update component diagram ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: https://dreampuf.github.io/GraphvizOnline/?compressed=CYSw5gTghgDgFgAgOIIN4… -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 Gerrit-Change-Number: 36556 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 19:19:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Update component diagram

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email ) Change subject: pcu: Update component diagram ...................................................................... pcu: Update component diagram The component architecture in PCU_Tests is quite complex to follow. Update the diagram in order to make it easier for people to gasp the big picture. Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 --- M pcu/PCU_Tests.ttcn M pcu/README.md 2 files changed, 100 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/36556/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 442d617..cab70e8 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -157,7 +157,7 @@ var StatsD_Checker_CT vc_STATSD; /* Connection to the PCUIF component */ - port RAW_PCU_MSG_PT PCUIF; + //port RAW_PCU_MSG_PT PCUIF; /* VTY connection to the PCU */ port TELNETasp_PT PCUVTY; @@ -282,7 +282,7 @@ /* Init PCU interface component */ vc_PCUIF := RAW_PCUIF_CT.create("PCUIF") alive; - connect(vc_PCUIF:MTC, self:PCUIF); + //connect(vc_PCUIF:MTC, self:PCUIF); map(vc_PCUIF:PCU, system:PCU); /* Create one BTS component (we may want more some day) */ diff --git a/pcu/README.md b/pcu/README.md index a2e439a..2a32f21 100644 --- a/pcu/README.md +++ b/pcu/README.md @@ -2,17 +2,94 @@ * external interfaces * Gb (emulates SGSN side NS/BSSGP) - * unix pcu socket (emulates BTS) + * PCUIF: unix pcu socket (emulates BTS) * VTY + * CTRL + * StatsD -{% dot msc_tests.svg +{% dot pcu_tests.svg digraph G { - rankdir=LR; - PCU [label="IUT\nosmo-pcu",shape="box"]; - ATS [label="ATS\nPCU_Tests.ttcn"]; + PCU [label="IUT\nosmo-pcu",shape="box", color=red]; - PCU -> ATS [label="Gb"]; - PCU -> ATS [label="pcu_sock"]; - ATS -> PCU [label="VTY"]; + subgraph cluster_ats { + label = "ATS\n(TTCN-3)"; + + system_PCU_PT [label="port system:PCU"]; + + subgraph cluster_RAW_PCU_Test_CT { + label = "RAW_PCU_Test_CT\n(PCU_Tests.ttcn)"; + + RAW_PCU_MSG_PT_PCUIF_A [label="port RAW_PCU_MSG_PT PCUIF\n(unused)"] + PCUVTY [label="PCUVTY"]; + StatsD_ConnHdlr [label="StatsD_ConnHdlr"]; + CTRL_Adapter_CT [label="CTRL_Adapter_CT"]; + + test [label="testcasename()\n(PCU_Tests.ttcn)", color=red]; + + subgraph cluster_bssgp_CT { + label="bssgp_CT\nSGSN_Components.ttcn"; + subgraph cluster_BSSGP_Client_CT { + label="BSSGP_Client_CT\nBSSGP_Emulation.ttcnpp"; + BSSGP_PT [label="port BSSGP_PT BSSGP"]; + } + } + + subgraph cluster_MS_BTS_IFACE_CT { + label = "MS_BTS_IFACE_CT\n(GPRS_Components.ttcn)"; + + RAW_PCU_MSG_PT_BTS_IFACE [label="port RAW_PCU_MSG_PT BTS"]; + + subgraph cluster_RAW_PCU_BTS_CT { + label = "RAW_PCU_BTS_CT\n(PCUIF_Components.ttcn)"; + + RAW_PCU_MSG_PT_CLCK_A [label="port RAW_PCU_MSG_PT CLCK"]; + RAW_PCU_MSG_PT_PCUIF_B [label="port RAW_PCU_MSG_PT PCUIF"]; + RAW_PCU_MSG_PT_TC [label="port RAW_PCU_MSG_PT TC"]; + + subgraph cluster_RAW_PCU_ClckGen_CT { + label = "RAW_PCU_ClckGen_CT\n(PCUIF_Components.ttcn)"; + + RAW_PCU_MSG_PT_CLCK_B [label="port RAW_PCU_MSG_PT CLCK", color=purple]; + } + + RAW_PCU_MSG_PT_CLCK_A -> RAW_PCU_MSG_PT_CLCK_B [dir=back]; + RAW_PCU_MSG_PT_PCUIF_B -> RAW_PCU_MSG_PT_TC [dir=none]; + } + } + + RAW_PCU_MSG_PT_TC -> RAW_PCU_MSG_PT_BTS_IFACE [dir=none]; + + } + + subgraph cluster_RAW_PCUIF_CT { + label = "RAW_PCUIF_CT\n(PCUIF_Components.ttcn)"; + + PCUIF_CODEC_PT_PCU [label="port PCUIF_CODEC_PT PCU"]; + RAW_PCU_MSG_PT_BTS [label="port RAW_PCU_MSG_PT BTS"]; + RAW_PCU_MSG_PT_MTC [label="port RAW_PCU_MSG_PT MTC"]; + + PCUIF_CODEC_PT_PCU -> RAW_PCU_MSG_PT_BTS [dir=none]; + PCUIF_CODEC_PT_PCU -> RAW_PCU_MSG_PT_MTC [dir=none]; + + } + + RAW_PCU_MSG_PT_MTC -> RAW_PCU_MSG_PT_PCUIF_A [dir=none]; + RAW_PCU_MSG_PT_PCUIF_B -> RAW_PCU_MSG_PT_BTS [dir=none]; + + PCUIF_CODEC_PT_PCU -> system_PCU_PT [dir=none]; + + test -> RAW_PCU_MSG_PT_BTS_IFACE [dir=none]; + //test -> RAW_PCU_MSG_PT_PCUIF_A [label="(unused)", dir=none]; + test -> BSSGP_PT; + test -> PCUVTY; + test -> StatsD_ConnHdlr; + test -> CTRL_Adapter_CT; + } + + PCU -> BSSGP_PT [label="Gb"]; + PCU -> StatsD_ConnHdlr [label="statsd"]; + system_PCU_PT -> PCU [label="PCUIF"]; + PCUVTY -> PCU [label="VTY"]; + CTRL_Adapter_CT -> PCU [label="CTRL"]; } %} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 Gerrit-Change-Number: 36556 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: README.md: Remove 'multi-slot ul tbf' line from 'Current Limitations'

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36551?usp=email ) Change subject: README.md: Remove 'multi-slot ul tbf' line from 'Current Limitations' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9abe54f280ab4e62c0c5220d010575b912c8c141 Gerrit-Change-Number: 36551 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 17:01:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf_ul.h: Mark empty param list as void

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36554?usp=email ) Change subject: tbf_ul.h: Mark empty param list as void ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a9213a9fdbe0f4b70d820c449dbb71539a733ce Gerrit-Change-Number: 36554 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 17:01:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf.h: Fix wrong type declaration of field dl_ass_fsm

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36553?usp=email ) Change subject: tbf.h: Fix wrong type declaration of field dl_ass_fsm ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibbc59a0584ee0cd83de0e04eebdcca2aebe3e970 Gerrit-Change-Number: 36553 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 17:01:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: bts: Drop no-longer existing GprsMsStorage reference

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36552?usp=email ) Change subject: bts: Drop no-longer existing GprsMsStorage reference ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2047588b1c187c842007fcb1eab0e8e4b7d7ed10 Gerrit-Change-Number: 36552 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 17:01:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: README.md: Remove 'multi-slot ul tbf' line from 'Current Limitations'

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36551?usp=email ) Change subject: README.md: Remove 'multi-slot ul tbf' line from 'Current Limitations' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9abe54f280ab4e62c0c5220d010575b912c8c141 Gerrit-Change-Number: 36551 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 17:00:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[M] Change in osmo-pcu[master]: doc: Introduce code architecture section with main class diagram

by pespin

Attention is currently required from: fixeria, jolly, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email ) Change subject: doc: Introduce code architecture section with main class diagram ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I created this diagram for my upcoming talk about Pcu past, present & future. I think it totally makes sense to have it in the project documentation. We already have something similar for osmo-trx. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d Gerrit-Change-Number: 36555 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 15:58:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[M] Change in osmo-pcu[master]: doc: Introduce code architecture section with main class diagram

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email ) Change subject: doc: Introduce code architecture section with main class diagram ...................................................................... doc: Introduce code architecture section with main class diagram This is useful to understand the data model in a quick gasp. Change-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d --- A doc/manuals/chapters/code-architecture.adoc M doc/manuals/osmopcu-usermanual.adoc 2 files changed, 84 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/55/36555/1 diff --git a/doc/manuals/chapters/code-architecture.adoc b/doc/manuals/chapters/code-architecture.adoc new file mode 100644 index 0000000..c3c0c70 --- /dev/null +++ b/doc/manuals/chapters/code-architecture.adoc @@ -0,0 +1,71 @@ +[[code_architecture]] +== Code Architecture + +[[fig-code-architecture-general]] +.General overview of main OsmoTRX components +[graphviz] +---- +digraph hierarchy { +node[shape=record,style=filled,fillcolor=gray95] +edge[dir=back, arrowtail=empty] + +PCU[label = "{gprs_pcu|+ pcu_sock_state\l+ bssgp\l+ bts_list[]\l}"] +BTS[label = "{gprs_rlcmac_bts|+ gsm_sysinfo\l+ trx_list[]\l+ ms_list[]\l}"] +TRX[label = "{gprs_rlcmac_bts_trx|+ul_tbfs[]\l+dl_tbfs[]\l}"] +PDCH[label = "{gprs_rlcmac_pdch|+ is_enabled\l+ pdch_ulc\l+ assigned_usf_mask\l+ assigned_tfi_mask_(dl,ul)\l+ tbfs_dl[]\l+ tbfs_ul[]\l+ pagings[]\l}"] +ULC[label = "{pdch_ulc|+ registered_polls[]\l}"] +ULC_NODE[label = "{pdch_ulc_node|+ fn\l+ type\l}"] +ULC_NODE_TBF_USF[label = "{pdch_ulc_node_tbf_usf|+ ul_tbf\l}"] +ULC_NODE_TBF_POLL[label = "{pdch_ulc_node_tbf_poll|+ poll_tbf (UL/DL)\l+ reason\l}"] +ULC_NODE_SBA[label = "{pdch_ulc_node_sba|+ sba\l}"] +MS[label = "{GprsMs|+ imsi, tlli, ta...\l+ refcount\l+ current_trx\l+ first_common_ts\l+ llc_queue\l}"] +TBF[label = "{gprs_rlcmac_tbf|+ tfi\l+ egprs_enabled\l+ control_ts\l+ pdch[]\l+ ul_ass_fsm\l+ dl_ass_fsm\l+ window\l+ llc_frame\l+ rlc_blocks\l}"] +UL_TBF[label = "{gprs_rlcmac_ul_tbf|+ state_fsm\l+ ul_ack_fsm\l+ usf[]\l}"] +DL_TBF[label = "{gprs_rlcmac_dl_tbf|+ state_fsm\l}"] +SBA[label = "{gprs_rlcmac_sba|+ pdch\l+ fn\l+ ta\l}"] +RLC_WINDOW[label = "{gprs_rlcmac_window|+ sns\l+ ws\l}"] +RLC_WINDOW_UL[label = "{gprs_rlcmac_window_ul|+ v_r\l+ v_q\l+ v_n[]\l}"] +RLC_WINDOW_DL[label = "{gprs_rlcmac_window_dl|+ v_s\l+ v_a\l+ v_b[]\l}"] +LLC_QUEUE[label = "{gprs_llc_queue|+ prio_queues[]\l}"] +LLC_PRIO_QUEUE[label = "{gprs_llc_prio_queue|+ codel_state\l+ priority\l+ frames[]\l}"] +LLC_FRAME[label = "{gprs_llc_frame|+ payload[]\l+ priority\l}"] +RLC_BLOCK[label = "{gprs_rlcmac_rlc_block|...}"] + +PCU -> BTS [headlabel="*", taillabel="1"] +BTS -> TRX [headlabel="0..8", taillabel="1"] +BTS -> MS [headlabel="*", taillabel="1"] +TRX -> PDCH [headlabel="0..8", taillabel="1"] + +PDCH -> ULC [headlabel="1", taillabel="0..1"] +ULC -> ULC_NODE [headlabel="*", taillabel="1"] +ULC_NODE -> ULC_NODE_TBF_USF [arrowtail=odiamond] +ULC_NODE -> ULC_NODE_TBF_POLL [arrowtail=odiamond] +ULC_NODE -> ULC_NODE_SBA [arrowtail=odiamond] +ULC_NODE_SBA -> SBA[headlabel="1", taillabel="1"] + +TBF -> UL_TBF [arrowtail=odiamond] +TBF -> DL_TBF [arrowtail=odiamond] + +RLC_WINDOW -> RLC_WINDOW_UL [arrowtail=odiamond] +RLC_WINDOW -> RLC_WINDOW_DL [arrowtail=odiamond] + +MS -> TBF [headlabel="*", taillabel="1"] + +MS -> LLC_QUEUE [headlabel="1", taillabel="1"] +LLC_QUEUE -> LLC_PRIO_QUEUE [headlabel="*", taillabel="1"] +LLC_PRIO_QUEUE -> LLC_FRAME [headlabel="*", taillabel="1"] + +TBF -> RLC_WINDOW [headlabel="*", taillabel="1"] +TBF -> LLC_FRAME [headlabel="0..1", taillabel="1"] +TBF -> RLC_BLOCK [headlabel="*", taillabel="1"] + +TRX -> MS [headlabel="*", taillabel="1", style=dashed, arrowtail=none, label="assigned"] +TBF -> PDCH [headlabel="0..8", taillabel="1", style=dashed, arrowtail=none, label="assigned"] + +UL_TBF -> ULC_NODE_TBF_USF [style=dashed, arrowtail=none, label="registered"] +TBF -> ULC_NODE_TBF_POLL [style=dashed, arrowtail=none, label="registered"] + +TRX -> UL_TBF [headlabel="*", taillabel="1", style=dashed, label="assigned"] +TRX -> DL_TBF [headlabel="*", taillabel="1", style=dashed, label="assigned"] +} +---- diff --git a/doc/manuals/osmopcu-usermanual.adoc b/doc/manuals/osmopcu-usermanual.adoc index 0fae72a..8c16668 100644 --- a/doc/manuals/osmopcu-usermanual.adoc +++ b/doc/manuals/osmopcu-usermanual.adoc @@ -17,6 +17,8 @@ include::{srcdir}/chapters/configuration.adoc[] +include::./common/chapters/code-architecture.adoc[] + include::{srcdir}/chapters/counters.adoc[] include::./common/chapters/gb.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d Gerrit-Change-Number: 36555 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf_ul.h: Mark empty param list as void

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36554?usp=email ) Change subject: tbf_ul.h: Mark empty param list as void ...................................................................... tbf_ul.h: Mark empty param list as void While at it, fix wrong whitespace indentation in one of the lines. Change-Id: I2a9213a9fdbe0f4b70d820c449dbb71539a733ce --- M src/tbf_ul.h 1 file changed, 19 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/54/36554/1 diff --git a/src/tbf_ul.h b/src/tbf_ul.h index 4ec0f6f..7a4c70c 100644 --- a/src/tbf_ul.h +++ b/src/tbf_ul.h @@ -59,8 +59,8 @@ struct gprs_rlcmac_ul_tbf : public gprs_rlcmac_tbf { gprs_rlcmac_ul_tbf(struct gprs_rlcmac_bts *bts, GprsMs *ms); - ~gprs_rlcmac_ul_tbf(); - gprs_rlc_window *window(); + ~gprs_rlcmac_ul_tbf(void); + gprs_rlc_window *window(void); void apply_allocated_resources(const struct alloc_resources_res *res); /* blocks were acked */ int rcv_data_block_acknowledged( @@ -70,7 +70,7 @@ /* TODO: extract LLC class? */ int assemble_forward_llc(const gprs_rlc_data *data); - int snd_ul_ud(); + int snd_ul_ud(void); egprs_rlc_ul_reseg_bsn_state handle_egprs_ul_spb( const struct gprs_rlc_data_info *rlc, @@ -87,12 +87,12 @@ struct gprs_rlc_data *block, uint8_t *data, const uint8_t block_idx); - uint16_t window_size() const; - void set_window_size(); + uint16_t window_size(void) const; + void set_window_size(void); void update_coding_scheme_counter_ul(enum CodingScheme cs); - void usf_timeout(); - void contention_resolution_start(); - void contention_resolution_success(); + void usf_timeout(void); + void contention_resolution_start(void); + void contention_resolution_success(void); /* Please note that all variables here will be reset when changing * from WAIT RELEASE back to FLOW state (re-use of TBF). -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a9213a9fdbe0f4b70d820c449dbb71539a733ce Gerrit-Change-Number: 36554 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2024