April 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: msc: f_expect_paging(): fix by_tmsi arg

by neels

Attention is currently required from: fixeria, laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455?usp=email ) Change subject: msc: f_expect_paging(): fix by_tmsi arg ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455/comment/2d5f24d7_0be1… PS2, Line 1360: function f_expect_paging(template OCT4 tmsi := *) oh, i expected that it would need to adjust lots of callers... Not blocking; But this patch breaks one paradigm of this function: see below how we use g_pars.imsi. Now this is not using g_pars.tmsi as would be logical, but the caller is passing a TMSI explicitly. This is the reason why i all the time and still and always will think a boolean is semantically the right choice. To fix it, you'd also have to make the imsi an argument that is passed in and not taken from g_pars. But since someone spent time to submit the patch and it's good enough, I'll not make their life harder with my fringe opinion on the far corner of a ttcn3 test's helper function's type of an arg, and will accept the patch despite not matching my opinion. I'd like to see more of that, please, very large wink. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9434745b7faeb738caafed8080b9f7b1a6a8079a Gerrit-Change-Number: 36455 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 22:29:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: ran-emu: allow receiving Paging without a TMSI

by neels

Attention is currently required from: fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36454?usp=email ) Change subject: ran-emu: allow receiving Paging without a TMSI ...................................................................... Patch Set 2: (1 comment) File library/RAN_Emulation.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36454/comment/1f09c370_a18e… PS1, Line 507: var template OCT4 tmsi := omit; > That's like asking "this non-const pointer works, why change it?" let's focus on technical reasoning. IOW, there seems to be no difference between with and without "(omit)"? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36454?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1bdf3488be0f8d4f0905665c4ba642f9468b9777 Gerrit-Change-Number: 36454 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 22:16:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf_ul.h: Mark empty param list as void

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36554?usp=email ) Change subject: tbf_ul.h: Mark empty param list as void ...................................................................... tbf_ul.h: Mark empty param list as void While at it, fix wrong whitespace indentation in one of the lines. Change-Id: I2a9213a9fdbe0f4b70d820c449dbb71539a733ce --- M src/tbf_ul.h 1 file changed, 19 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/tbf_ul.h b/src/tbf_ul.h index 4ec0f6f..7a4c70c 100644 --- a/src/tbf_ul.h +++ b/src/tbf_ul.h @@ -59,8 +59,8 @@ struct gprs_rlcmac_ul_tbf : public gprs_rlcmac_tbf { gprs_rlcmac_ul_tbf(struct gprs_rlcmac_bts *bts, GprsMs *ms); - ~gprs_rlcmac_ul_tbf(); - gprs_rlc_window *window(); + ~gprs_rlcmac_ul_tbf(void); + gprs_rlc_window *window(void); void apply_allocated_resources(const struct alloc_resources_res *res); /* blocks were acked */ int rcv_data_block_acknowledged( @@ -70,7 +70,7 @@ /* TODO: extract LLC class? */ int assemble_forward_llc(const gprs_rlc_data *data); - int snd_ul_ud(); + int snd_ul_ud(void); egprs_rlc_ul_reseg_bsn_state handle_egprs_ul_spb( const struct gprs_rlc_data_info *rlc, @@ -87,12 +87,12 @@ struct gprs_rlc_data *block, uint8_t *data, const uint8_t block_idx); - uint16_t window_size() const; - void set_window_size(); + uint16_t window_size(void) const; + void set_window_size(void); void update_coding_scheme_counter_ul(enum CodingScheme cs); - void usf_timeout(); - void contention_resolution_start(); - void contention_resolution_success(); + void usf_timeout(void); + void contention_resolution_start(void); + void contention_resolution_success(void); /* Please note that all variables here will be reset when changing * from WAIT RELEASE back to FLOW state (re-use of TBF). -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a9213a9fdbe0f4b70d820c449dbb71539a733ce Gerrit-Change-Number: 36554 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: bts: Drop no-longer existing GprsMsStorage reference

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36552?usp=email ) Change subject: bts: Drop no-longer existing GprsMsStorage reference ...................................................................... bts: Drop no-longer existing GprsMsStorage reference This struct was removed (merged into gprs_rlcmac_bts) in commit eb0a0527e0a720fa9b0e351b5b38a8e46cb286e5. Change-Id: I2047588b1c187c842007fcb1eab0e8e4b7d7ed10 --- M src/bts.h 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bts.h b/src/bts.h index 380c47c..ab3907f 100644 --- a/src/bts.h +++ b/src/bts.h @@ -208,7 +208,6 @@ bool single_block; }; -struct GprsMsStorage; struct pcu_l1_meas; /** -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2047588b1c187c842007fcb1eab0e8e4b7d7ed10 Gerrit-Change-Number: 36552 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf.h: Fix wrong type declaration of field dl_ass_fsm

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36553?usp=email ) Change subject: tbf.h: Fix wrong type declaration of field dl_ass_fsm ...................................................................... tbf.h: Fix wrong type declaration of field dl_ass_fsm The typo was harmless since as of now the two structs where identical. Change-Id: Ibbc59a0584ee0cd83de0e04eebdcca2aebe3e970 --- M src/tbf.h 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/tbf.h b/src/tbf.h index 97f5562..4170ca1 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -245,7 +245,7 @@ struct rate_ctr_group *m_ctrs; struct osmo_fsm_inst *state_fi; struct tbf_ul_ass_fsm_ctx ul_ass_fsm; - struct tbf_ul_ass_fsm_ctx dl_ass_fsm; + struct tbf_dl_ass_fsm_ctx dl_ass_fsm; struct llist_item m_ms_list; struct llist_item m_trx_list; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibbc59a0584ee0cd83de0e04eebdcca2aebe3e970 Gerrit-Change-Number: 36553 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: README.md: Remove 'multi-slot ul tbf' line from 'Current Limitations'

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36551?usp=email ) Change subject: README.md: Remove 'multi-slot ul tbf' line from 'Current Limitations' ...................................................................... README.md: Remove 'multi-slot ul tbf' line from 'Current Limitations' This feature was implemented in commit ed2afa3bed4c1b7a2bffae6be7df881de4f976e7, ~3 years ago. Change-Id: I9abe54f280ab4e62c0c5220d010575b912c8c141 --- M README.md 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/README.md b/README.md index 3d11a78..8467c50 100644 --- a/README.md +++ b/README.md @@ -78,7 +78,6 @@ * No fixed allocation support (was removed from 3GPP Rel >= 5 anyway) * No extended dynamic allocation support * No unacknowledged mode operation - * Only single slot assignment on uplink direction * No half-duplex class support (only semi-duplex) * No TA loop * No power loop -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9abe54f280ab4e62c0c5220d010575b912c8c141 Gerrit-Change-Number: 36551 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[M] Change in osmo-pcu[master]: doc: Introduce code architecture section with main class diagram

by pespin

Attention is currently required from: fixeria, jolly, osmith, pespin. Hello Jenkins Builder, fixeria, jolly, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: doc: Introduce code architecture section with main class diagram ...................................................................... doc: Introduce code architecture section with main class diagram This is useful to understand the data model in a quick gasp. Change-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d --- A doc/manuals/chapters/code-architecture.adoc M doc/manuals/osmopcu-usermanual.adoc 2 files changed, 84 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/55/36555/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d Gerrit-Change-Number: 36555 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Update component diagram

by pespin

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pcu: Update component diagram ...................................................................... pcu: Update component diagram The component architecture in PCU_Tests is quite complex to follow. Update the diagram in order to make it easier for people to gasp the big picture. Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 --- M pcu/PCU_Tests.ttcn M pcu/README.md 2 files changed, 100 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/36556/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 Gerrit-Change-Number: 36556 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Update component diagram

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email ) Change subject: pcu: Update component diagram ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I finally decided to rework a bit differently the graph, simply copy the graphviz code to the webpage I shared above if you want to see the result. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 Gerrit-Change-Number: 36556 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 19:30:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Update component diagram

by pespin

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pcu: Update component diagram ...................................................................... pcu: Update component diagram The component architecture in PCU_Tests is quite complex to follow. Update the diagram in order to make it easier for people to gasp the big picture. Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 --- M pcu/PCU_Tests.ttcn M pcu/README.md 2 files changed, 100 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/36556/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 Gerrit-Change-Number: 36556 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2024