April 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-pcu[master]: doc: Introduce code architecture section with main class diagram

by pespin

Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email ) Change subject: doc: Introduce code architecture section with main class diagram ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d Gerrit-Change-Number: 36555 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 08:56:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Update component diagram

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email ) Change subject: pcu: Update component diagram ...................................................................... pcu: Update component diagram The component architecture in PCU_Tests is quite complex to follow. Update the diagram in order to make it easier for people to gasp the big picture. Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 --- M pcu/PCU_Tests.ttcn M pcu/README.md 2 files changed, 100 insertions(+), 10 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 442d617..cab70e8 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -157,7 +157,7 @@ var StatsD_Checker_CT vc_STATSD; /* Connection to the PCUIF component */ - port RAW_PCU_MSG_PT PCUIF; + //port RAW_PCU_MSG_PT PCUIF; /* VTY connection to the PCU */ port TELNETasp_PT PCUVTY; @@ -282,7 +282,7 @@ /* Init PCU interface component */ vc_PCUIF := RAW_PCUIF_CT.create("PCUIF") alive; - connect(vc_PCUIF:MTC, self:PCUIF); + //connect(vc_PCUIF:MTC, self:PCUIF); map(vc_PCUIF:PCU, system:PCU); /* Create one BTS component (we may want more some day) */ diff --git a/pcu/README.md b/pcu/README.md index a2e439a..0a1d31f 100644 --- a/pcu/README.md +++ b/pcu/README.md @@ -2,17 +2,94 @@ * external interfaces * Gb (emulates SGSN side NS/BSSGP) - * unix pcu socket (emulates BTS) + * PCUIF: unix pcu socket (emulates BTS) * VTY + * CTRL + * StatsD -{% dot msc_tests.svg +{% dot pcu_tests.svg digraph G { - rankdir=LR; - PCU [label="IUT\nosmo-pcu",shape="box"]; - ATS [label="ATS\nPCU_Tests.ttcn"]; + PCU [label="IUT\nosmo-pcu",shape="box", color=red]; - PCU -> ATS [label="Gb"]; - PCU -> ATS [label="pcu_sock"]; - ATS -> PCU [label="VTY"]; + subgraph cluster_ats { + label = "ATS\n(TTCN-3)"; + + system_PCU_PT [label="port system:PCU"]; + + subgraph cluster_RAW_PCU_Test_CT { + label = "RAW_PCU_Test_CT\n(PCU_Tests.ttcn)"; + + RAW_PCU_MSG_PT_PCUIF_A [label="port RAW_PCU_MSG_PT PCUIF\n(unused)"] + PCUVTY [label="PCUVTY"]; + StatsD_ConnHdlr [label="StatsD_ConnHdlr"]; + CTRL_Adapter_CT [label="CTRL_Adapter_CT"]; + + test [label="testcasename()\n(PCU_Tests.ttcn)", color=red]; + + subgraph cluster_bssgp_CT { + label="bssgp_CT\nSGSN_Components.ttcn"; + subgraph cluster_BSSGP_Client_CT { + label="BSSGP_Client_CT\nBSSGP_Emulation.ttcnpp"; + BSSGP_PT [label="port BSSGP_PT BSSGP"]; + } + } + + subgraph cluster_MS_BTS_IFACE_CT { + label = "MS_BTS_IFACE_CT\n(GPRS_Components.ttcn)"; + + RAW_PCU_MSG_PT_BTS_IFACE [label="port RAW_PCU_MSG_PT BTS"]; + } + + } + + subgraph cluster_RAW_PCUIF_CT { + label = "RAW_PCUIF_CT\n(PCUIF_Components.ttcn)"; + + PCUIF_CODEC_PT_PCU [label="port PCUIF_CODEC_PT PCU"]; + RAW_PCU_MSG_PT_BTS [label="port RAW_PCU_MSG_PT BTS"]; + RAW_PCU_MSG_PT_MTC [label="port RAW_PCU_MSG_PT MTC"]; + + PCUIF_CODEC_PT_PCU -> RAW_PCU_MSG_PT_BTS [dir=none]; + PCUIF_CODEC_PT_PCU -> RAW_PCU_MSG_PT_MTC [dir=none]; + + } + + subgraph cluster_RAW_PCU_BTS_CT { + label = "RAW_PCU_BTS_CT\n(PCUIF_Components.ttcn)"; + + RAW_PCU_MSG_PT_CLCK_A [label="port RAW_PCU_MSG_PT CLCK"]; + RAW_PCU_MSG_PT_PCUIF_B [label="port RAW_PCU_MSG_PT PCUIF"]; + RAW_PCU_MSG_PT_TC [label="port RAW_PCU_MSG_PT TC"]; + + subgraph cluster_RAW_PCU_ClckGen_CT { + label = "RAW_PCU_ClckGen_CT\n(PCUIF_Components.ttcn)"; + + RAW_PCU_MSG_PT_CLCK_B [label="port RAW_PCU_MSG_PT CLCK", color=purple]; + } + + RAW_PCU_MSG_PT_CLCK_A -> RAW_PCU_MSG_PT_CLCK_B [dir=back]; + RAW_PCU_MSG_PT_PCUIF_B -> RAW_PCU_MSG_PT_TC [dir=none]; + } + + + RAW_PCU_MSG_PT_TC -> RAW_PCU_MSG_PT_BTS_IFACE [dir=none]; + RAW_PCU_MSG_PT_PCUIF_A -> RAW_PCU_MSG_PT_MTC [dir=none]; + RAW_PCU_MSG_PT_PCUIF_B -> RAW_PCU_MSG_PT_BTS [dir=none]; + + PCUIF_CODEC_PT_PCU -> system_PCU_PT [dir=none]; + + test -> RAW_PCU_MSG_PT_BTS_IFACE [dir=none]; + test -> RAW_PCU_MSG_PT_PCUIF_A [label="(unused)", dir=none]; + test -> BSSGP_PT; + test -> PCUVTY; + test -> StatsD_ConnHdlr; + test -> CTRL_Adapter_CT; + } + + PCU -> BSSGP_PT [label="Gb"]; + PCU -> StatsD_ConnHdlr [label="statsd"]; + system_PCU_PT -> PCU [label="PCUIF"]; + PCUVTY -> PCU [label="VTY"]; + CTRL_Adapter_CT -> PCU [label="CTRL"]; } %} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 Gerrit-Change-Number: 36556 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Update component diagram

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email ) Change subject: pcu: Update component diagram ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: > The graph looks good. […] This is more like a generic problem for all README.md files in osmo-ttcn3-hacks.git, not specific to this one, and hence not really tight to this patch. For now simply copy the graphviz code to some editor (like the online one I shared). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 Gerrit-Change-Number: 36556 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 08:55:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: derive altsteps from f_expect_paging() and use them

by pespin

Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36558?usp=email ) Change subject: msc: derive altsteps from f_expect_paging() and use them ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36558/comment/b8e1859c_eb7a… PS1, Line 2596: [] as_paging() { this is now less clear than having the as_paging_tmsi(g_pars.tmsi) or whatever, since one needs to look up what is expected there. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36558/comment/0fcf2e1d_eea1… PS1, Line 3582: [] as_paging() { setverdict(pass); } same here, it's difficult for reader to figure out the difference between as_paging and as_paging_any. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia0e787fc376acec09e8985a63862872eb89b53a4 Gerrit-Change-Number: 36558 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 08:53:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: f_expect_paging(): fix by_tmsi arg

by pespin

Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455?usp=email ) Change subject: msc: f_expect_paging(): fix by_tmsi arg ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9434745b7faeb738caafed8080b9f7b1a6a8079a Gerrit-Change-Number: 36455 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 08:50:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: expect TC_attached_imsi_lu_unknown_tmsi to pass

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36559?usp=email ) Change subject: msc: expect TC_attached_imsi_lu_unknown_tmsi to pass ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36559?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57a277fa7e6e0d10ff38e23f416ace87472e6602 Gerrit-Change-Number: 36559 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 08:49:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: rework f_expect_paging(): handle mismatch and timeout

by pespin

Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36456?usp=email ) Change subject: msc: rework f_expect_paging(): handle mismatch and timeout ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36456?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I30273e3882e348a2ded88b7b96a5ec1473a56913 Gerrit-Change-Number: 36456 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 08:48:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: expand TC_lu_tmsi_noauth_notmsi

by pespin

Attention is currently required from: fixeria, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36460?usp=email ) Change subject: msc: expand TC_lu_tmsi_noauth_notmsi ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36460?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5e596597add7d585efd27c850067b8d7ba34ecc0 Gerrit-Change-Number: 36460 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 08:45:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/osmocom-obs-sync: remove Ubuntu 20.04

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36560?usp=email ) Change subject: jobs/osmocom-obs-sync: remove Ubuntu 20.04 ...................................................................... jobs/osmocom-obs-sync: remove Ubuntu 20.04 We build binary packages for the last 2 LTS versions of Ubuntu, so remove 20.04. Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Linux_Distributio… Change-Id: Ia93b272447032eb5224d8e14a75801dda8a596a8 --- M jobs/osmocom-obs-sync.yml 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/60/36560/1 diff --git a/jobs/osmocom-obs-sync.yml b/jobs/osmocom-obs-sync.yml index 8858524..a57f968 100644 --- a/jobs/osmocom-obs-sync.yml +++ b/jobs/osmocom-obs-sync.yml @@ -36,7 +36,6 @@ Raspbian:10 Raspbian:11 Raspbian:12 - Ubuntu:20.04 Ubuntu:22.04 Ubuntu:23.10 Ubuntu:24.04 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia93b272447032eb5224d8e14a75801dda8a596a8 Gerrit-Change-Number: 36560 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

[M] Change in osmo-pcu[master]: doc: Introduce code architecture section with main class diagram

by osmith

Attention is currently required from: fixeria, jolly, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email ) Change subject: doc: Introduce code architecture section with main class diagram ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d Gerrit-Change-Number: 36555 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 07:52:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2024