April 2024 - gerrit-log - lists.osmocom.org

[L] Change in osmo-hnbgw[master]: per-HNB GTP-U traffic counters via nft

by pespin

Attention is currently required from: laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36385?usp=email ) Change subject: per-HNB GTP-U traffic counters via nft ...................................................................... Patch Set 17: (1 comment) Patchset: PS3: > Kindly state your reason for this statement, it seems unqualified to me. I already mentioned it in several places, even before you started writing any related code (Yes, I took the time to do so before you started coding by providing links to osmo_itq several times because I thought it would be helpful). The main loop should not be blocked. Running the nft command in blocking mode inside the main loop thread is not nice. So having this merged means we end up with code blocking the main loop in current master, which is not desirable. > every so often your CR uses stylistic means of downplaying a submitted patch without a sound base for it. In line with the lately "it's bikeshed" and "it's your opinion" comments, even if I'm not the only one stating it. I'll let others take care of this then, to avoid continuing with the "downplaying". -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36385?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I35b7e97fd039e36633dfde1317170527c82f9f68 Gerrit-Change-Number: 36385 Gerrit-PatchSet: 17 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 15 Apr 2024 16:30:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[M] Change in osmo-hnbgw[master]: nft_kpi: retrieve counters in a separate thread

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36540?usp=email ) Change subject: nft_kpi: retrieve counters in a separate thread ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > This is a very generalised statement that seems to be an opinion, and not a hard fact. Let's stay here in this patch. This may be an opinion to you, but to me it's a hard fact when using production-grade code using a main loop handling hundreds of peers and thousands of subscribers. TBH, since most of my comments seem to be discarded with "it's bikeshed" or "it's an opinion" from you, I'm really fed up and considering stopping what you consider "bikesheding" and let others review your patches until you get your +2, so at least I don't end up losing my time again and again providing feedback. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36540?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9dc54e6bc94c553f45adfa71ae8ad70be4afbc8f Gerrit-Change-Number: 36540 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 16:18:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[M] Change in osmo-hnbgw[master]: nft_kpi: retrieve counters in a separate thread

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36540?usp=email ) Change subject: nft_kpi: retrieve counters in a separate thread ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Responding to CR posted on an earlier patch: Your point seems to be that it_q is simpler than the implementation that is using mutexes. I considered this at length and decided against it. Reasons are code complexity as well as performance. Possibly the exact same reasons that osmo-trx has. > Regarding own thread vs multithread: Anything running under the main loop which blocks the main loop for long periods of time while waiting for some procedure to finish is broken by design, be it 300ms, 500ms, 1s, 3s, 50000s." This is a very generalised statement that seems to be an opinion, and not a hard fact. Let's stay here in this patch. There is a profound difference between blocking 3 ms, 30 ms, 300 ms or 3 s. 300 ms is too much for blocking all traffic on high volume infrastructure, but we do not know whether it is maybe closer to 3 ms yet. And blocking for 300 ms maybe once per day is not a problem that requires immediate action. There is also a difference between real-time phy code and a core network entity that is designed for high latency. IMHO your reasoning lacks these very important qualifications. A productive discussion could be based on "I do not agree with rarely blocking on HNBAP HNB Register events". My response to that is that we need empirical metrics to decide for or against it, and if it turns out bad, I will add the it_q. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36540?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9dc54e6bc94c553f45adfa71ae8ad70be4afbc8f Gerrit-Change-Number: 36540 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 15:40:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[L] Change in osmo-hnbgw[master]: per-HNB GTP-U traffic counters via nft

by neels

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36385?usp=email ) Change subject: per-HNB GTP-U traffic counters via nft ...................................................................... Patch Set 17: (1 comment) Patchset: PS3: Pau, every so often your CR uses stylistic means of downplaying a submitted patch without a sound base for it. Wording like these come to mind: - "playing around with" belittles a technically sound implementation. - "all this foo" is too general and diffuse, CR needs to be on point. - "everything ends up broken" without anything broken being present. > Fine if you want to keep it in 2 patches, but I wouldn't merge this one until the other one is ready and can be merged together. Kindly state your reason for this statement, it seems unqualified to me. And kindly state your reason directly at the start of a CR discussion, next time. I would appreciate that very much. I am not playing around, I know what I am doing, and decided things for sound reasons. I need you to acknowledge that. If you disagree, then let's stay with the sound arguments against it. Thanks! Also let's discuss in the proper place. CR is bringing up threading details in CR on patches without any threading. This patch here is not multi threaded. For threading, let's discuss at the patch introducing the nft thread. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36385?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I35b7e97fd039e36633dfde1317170527c82f9f68 Gerrit-Change-Number: 36385 Gerrit-PatchSet: 17 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 15:39:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: allow f_verify_vty_lac_ci() to pass for CompL3 by TMSI MI

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36457?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: msc: allow f_verify_vty_lac_ci() to pass for CompL3 by TMSI MI ...................................................................... msc: allow f_verify_vty_lac_ci() to pass for CompL3 by TMSI MI Obviously, when only a TMSI has been used, searching for an IMSI will return no subscriber. Don't fail in that case when testing for verify_vlr := false. Prepares TC_lu_tmsi_noauth_notmsi in If10b9987395670b084ff8ad6d1f033ff46896d75 Related: SYS#6860 OS#4721 Change-Id: I4d719928f04e5a47d415c38f835451b1f10c713d --- M msc/BSC_ConnectionHandler.ttcn 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index a979953..072f38d 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -827,7 +827,9 @@ } if (not verify_vlr and not connection_present) { - setverdict(fail, "f_verify_vty_lac_ci(verify_vlr := false) called, which requires an active connection, but there is no 'Connection:' part to verify in ", result); + /* If the Compl L3 was done by TMSI, the VLR has no IMSI until the ID Request / Response for IMSI has + * been answered. So if verify_vlr == false, a "missing" connection is one of the expected scenarios. */ + setverdict(pass); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36457?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4d719928f04e5a47d415c38f835451b1f10c713d Gerrit-Change-Number: 36457 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: add mi arg to f_perform_lu()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36458?usp=email ) Change subject: msc: add mi arg to f_perform_lu() ...................................................................... msc: add mi arg to f_perform_lu() Allow testing Location Updating by TMSI MI. Prepares for TC_lu_tmsi_noauth_notmsi in If10b9987395670b084ff8ad6d1f033ff46896d75 Change-Id: I31aad8eb751528f7237a892702e87ee5855cabbb --- M msc/BSC_ConnectionHandler.ttcn 1 file changed, 22 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 072f38d..658923e 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -833,9 +833,15 @@ } } -function f_perform_lu() +function f_perform_lu(template (omit) MobileIdentityLV use_mi := omit) runs on BSC_ConnHdlr { - var PDU_ML3_MS_NW l3_lu := f_build_lu_imsi(g_pars.imsi) + var MobileIdentityLV mi; + if (istemplatekind(use_mi, "omit")) { + mi := valueof(ts_MI_IMSI_LV(g_pars.imsi)); + } else { + mi := valueof(use_mi); + } + var PDU_ML3_MS_NW l3_lu := f_build_lu(mi); var PDU_DTAP_MT dtap_mt; /* tell GSUP dispatcher to send this IMSI to us */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36458?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I31aad8eb751528f7237a892702e87ee5855cabbb Gerrit-Change-Number: 36458 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: add TC_lu_tmsi_noauth_notmsi

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36459?usp=email ) Change subject: msc: add TC_lu_tmsi_noauth_notmsi ...................................................................... msc: add TC_lu_tmsi_noauth_notmsi Add test case for handling a LU by TMSI MI when 'no assign-tmsi' is configured. This test will pass from osmo-msc patch I583682d1a35a70b008d7bb2d89ba7c3109a60b21 on Depends: osmo-msc I583682d1a35a70b008d7bb2d89ba7c3109a60b21 Related: SYS#6860 OS#4721 Change-Id: If10b9987395670b084ff8ad6d1f033ff46896d75 --- M msc/MSC_Tests.ttcn M msc/expected-results.xml 2 files changed, 60 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 3effd52..2923a62 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -7289,10 +7289,52 @@ vc_conn.done; } +/* MSC <-> BSC: ID req/rsp for IMSI */ +private altstep as_id_req_imsi() +runs on BSC_ConnHdlr { + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req(CM_ID_TYPE_IMSI))) { + var MobileIdentityLV mi := valueof(ts_MI_IMSI_LV(g_pars.imsi)); + BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_MM_ID_Rsp(mi))); + repeat; + } +} + +/* MSC is configured to not assign a TMSI; MS sends LU Request with a TMSI MI (from another cell), and MSC shall not use + * that TMSI. */ +private function f_tc_lu_tmsi_noauth_notmsi(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + f_init_handler(pars, t_guard := 20.0); + + /* Perform Location Updating using an unknown TMSI MI. Expect an ID Request to come from the MSC and answer + * that with as_id_req_imsi(). */ + activate(as_id_req_imsi()); + f_perform_lu(use_mi := ts_MI_TMSI_LV(pars.tmsi)); + + f_sleep(1.0); + + /* Attached by invalid TMSI, and the MSC has asked for the IMSI. Initiate Paging and make sure the MSC doesn't + * use the invalid TMSI for it. */ + f_ran_register_imsi(g_pars.imsi, omit); + f_vty_transceive(MSCVTY, "subscriber imsi " & hex2str(g_pars.imsi) & " paging"); + f_expect_paging_tmsi(omit); +} +testcase TC_lu_tmsi_noauth_notmsi() runs on MTC_CT { + var BSC_ConnHdlrPars pars; + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "msc", "no assign-tmsi"); + pars := f_init_pars(101); + pars.net.expect_tmsi := false; + pars.tmsi := '0badbad0'O; + pars.mm_info := false; + vc_conn := f_start_handler_with_pars(refers(f_tc_lu_tmsi_noauth_notmsi), pars); + vc_conn.done; +} + control { execute( TC_cr_before_reset() ); execute( TC_lu_imsi_noauth_tmsi() ); execute( TC_lu_imsi_noauth_notmsi() ); + execute( TC_lu_tmsi_noauth_notmsi() ); execute( TC_lu_imsi_reject() ); execute( TC_lu_imsi_timeout_gsup() ); execute( TC_lu_imsi_auth_tmsi() ); diff --git a/msc/expected-results.xml b/msc/expected-results.xml index f8fa0ec..b6e0bb2 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -3,6 +3,7 @@ <testcase classname='MSC_Tests' name='TC_cr_before_reset' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_imsi_noauth_tmsi' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_imsi_noauth_notmsi' time='MASKED'/> + <testcase classname='MSC_Tests' name='TC_lu_tmsi_noauth_notmsi' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_imsi_reject' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_imsi_timeout_gsup' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36459?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If10b9987395670b084ff8ad6d1f033ff46896d75 Gerrit-Change-Number: 36459 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: expand TC_lu_tmsi_noauth_notmsi

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36460?usp=email ) Change subject: msc: expand TC_lu_tmsi_noauth_notmsi ...................................................................... msc: expand TC_lu_tmsi_noauth_notmsi From running this test repeatedly, I noticed that osmo-msc's new patch to avoid storing a TMSI may also trigger more evil twin situations in the VLR as described in OS#4721. Always run this test twice, to probe for the evil twin problem. This test will pass from osmo-msc patch Ifdabe0b65bffafbf7b8e5cc10e2d225d1ed1cecd on. Depends: osmo-msc Ifdabe0b65bffafbf7b8e5cc10e2d225d1ed1cecd Related: SYS#6860 OS#4721 Change-Id: I5e596597add7d585efd27c850067b8d7ba34ecc0 --- M msc/MSC_Tests.ttcn 1 file changed, 44 insertions(+), 0 deletions(-) Approvals: neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 2923a62..09004e8 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -7316,6 +7316,17 @@ f_ran_register_imsi(g_pars.imsi, omit); f_vty_transceive(MSCVTY, "subscriber imsi " & hex2str(g_pars.imsi) & " paging"); f_expect_paging_tmsi(omit); + + /* Respond to paging, to clean up internal paging state for this subscriber, so we can get a clean second run + * out of this test code. Don't use the TMSI in the paging response. */ + f_cl3_or_initial_ue(valueof(ts_PAG_RESP(ts_MI_IMSI_LV(pars.imsi)))); + f_mm_common(); + /* The paging was by VTY, so nothing happens, just a release. */ + f_expect_clear(); + + /* Clean up ttcn state for the second test run to work out. */ + f_unregister_gsup_imsi(hex2str(pars.imsi)); + f_ran_unregister_imsi(pars.imsi); } testcase TC_lu_tmsi_noauth_notmsi() runs on MTC_CT { var BSC_ConnHdlrPars pars; @@ -7328,6 +7339,19 @@ pars.mm_info := false; vc_conn := f_start_handler_with_pars(refers(f_tc_lu_tmsi_noauth_notmsi), pars); vc_conn.done; + + /* Now run the same test *again*, to test against an evil twin VLR entry: + * A vlr_subscr with the correct IMSI is now present in the VLR. + * We again ask for a LU with the 0x0bad TMSI. The VLR will initially create another vlr_subsrc(TMSI=0x0bad). + * When it learns the IMSI via ID Request, it needs to realize that this IMSI is already present on the first + * vsub, and sort out the VLR record so that only one entry for this IMSI exists. + */ + pars := f_init_pars(101); + pars.net.expect_tmsi := false; + pars.tmsi := '0badbad0'O; + pars.mm_info := false; + vc_conn := f_start_handler_with_pars(refers(f_tc_lu_tmsi_noauth_notmsi), pars); + vc_conn.done; } control { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36460?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5e596597add7d585efd27c850067b8d7ba34ecc0 Gerrit-Change-Number: 36460 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: expect TC_attached_imsi_lu_unknown_tmsi to pass

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36559?usp=email ) Change subject: msc: expect TC_attached_imsi_lu_unknown_tmsi to pass ...................................................................... msc: expect TC_attached_imsi_lu_unknown_tmsi to pass The "VLR evil twin" problem has been fixed in osmo-msc.git: https://gerrit.osmocom.org/c/osmo-msc/+/36452 https://cgit.osmocom.org/osmo-msc/commit/?id=2fd69e15d36d5a8e87029741ad6663… And the testcase is finally passing now. Change-Id: I57a277fa7e6e0d10ff38e23f416ace87472e6602 Related: OS#4721 --- M msc/expected-results.xml 1 file changed, 18 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/msc/expected-results.xml b/msc/expected-results.xml index b6e0bb2..aad96a7 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -27,12 +27,7 @@ <testcase classname='MSC_Tests' name='TC_lu_disconnect' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_by_imei' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_by_tmsi_noauth_unknown' time='MASKED'/> - <testcase classname='MSC_Tests' name='TC_attached_imsi_lu_unknown_tmsi' time='MASKED'> - <failure type='fail-verdict'>Expected LU ACK, but received REJ - MSC_Tests.ttcn:MASKED MSC_Tests control part - MSC_Tests.ttcn:MASKED TC_attached_imsi_lu_unknown_tmsi testcase - </failure> - </testcase> + <testcase classname='MSC_Tests' name='TC_attached_imsi_lu_unknown_tmsi' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_imsi_detach_by_imsi' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_imsi_detach_by_tmsi' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_imsi_detach_by_imei' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36559?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57a277fa7e6e0d10ff38e23f416ace87472e6602 Gerrit-Change-Number: 36559 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: f_expect_paging(): fix by_tmsi arg

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455?usp=email ) Change subject: msc: f_expect_paging(): fix by_tmsi arg ...................................................................... msc: f_expect_paging(): fix by_tmsi arg The by_tmsi argument so far had no effect. But I actually need exactly this in upcoming MSC_Tests.TC_lu_tmsi_noauth_notmsi(): expect a Paging with explicitly no TMSI included. Related: SYS#6860 OS#4721 Change-Id: I9434745b7faeb738caafed8080b9f7b1a6a8079a --- M msc/BSC_ConnectionHandler.ttcn 1 file changed, 21 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 6f8078b..75eb892 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -1357,15 +1357,20 @@ log("f_mt_call_complete DONE"); } -function f_expect_paging(boolean by_tmsi := true) +function f_expect_paging_tmsi(template OCT4 tmsi := *) runs on BSC_ConnHdlr { if (g_pars.ran_is_geran) { - BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi)); + BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi, tmsi)); } else { BSSAP.receive(tr_RANAP_Paging(cs_domain, imsi_hex2oct(g_pars.imsi))); } } +function f_expect_paging() +runs on BSC_ConnHdlr { + f_expect_paging_tmsi(g_pars.tmsi); +} + function f_mt_call_establish(inout CallParameters cpars) runs on BSC_ConnHdlr { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9434745b7faeb738caafed8080b9f7b1a6a8079a Gerrit-Change-Number: 36455 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2024