November 2024 - gerrit-log - lists.osmocom.org

[S] Change in upf-benchmark[master]: testsuites: Fix eupf run scripts

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38738?usp=email ) Change subject: testsuites: Fix eupf run scripts ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38738?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: If8e4f00154383a66c02b49e6a358911a9a9908d6 Gerrit-Change-Number: 38738 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Nov 2024 17:01:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[XS] Change in upf-benchmark[master]: testsuites: Document manual route setup required

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38732?usp=email ) Change subject: testsuites: Document manual route setup required ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38732?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: Ia946c65d9de3af00c438f0178acd0e644fe95b5e Gerrit-Change-Number: 38732 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Nov 2024 17:00:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: make it pass 'ruff check' linter

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38778?usp=email ) Change subject: testenv: make it pass 'ruff check' linter ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3e5cd05ce0aa241509d77391c5ed64e618f385ba Gerrit-Change-Number: 38778 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Nov 2024 16:37:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: mgw: fix RTP packets received while RX disabled

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38777?usp=email ) Change subject: mgw: fix RTP packets received while RX disabled ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38777?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieaf5440a693448cdeeaac7f47e6110cb480bff5f Gerrit-Change-Number: 38777 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Nov 2024 16:36:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: make it pass 'ruff check' linter

by osmith

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38778?usp=email to look at the new patch set (#2). Change subject: testenv: make it pass 'ruff check' linter ...................................................................... testenv: make it pass 'ruff check' linter I've added 'ruff check' to my pre-commit script. Make it pass initially, so it can detect future bugs. The missing f-string is a bug that causes ggsn testsuites with a custom kernel path to not work. Change-Id: I3e5cd05ce0aa241509d77391c5ed64e618f385ba --- M _testenv/testenv/podman.py M _testenv/testenv/testsuite.py 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/38778/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3e5cd05ce0aa241509d77391c5ed64e618f385ba Gerrit-Change-Number: 38778 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: testenv: add run --until-nok

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38776?usp=email ) Change subject: testenv: add run --until-nok ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17e1ebcc5d6ff1b6a087c4d4c9405a02798212f1 Gerrit-Change-Number: 38776 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Nov 2024 16:34:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: gsm_utils: add gprs_tlli2tmsi()

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email ) Change subject: gsm_utils: add gprs_tlli2tmsi() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: lgtm - aside from the obvious linter issues -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d3464922c89383099a5f3cdd1458c0ecc28ee18 Gerrit-Change-Number: 38764 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 14 Nov 2024 16:33:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bts[master]: l1sap: l1sap_tch_rts_ind(): fix NULL ptr dereference

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/38749?usp=email ) Change subject: l1sap: l1sap_tch_rts_ind(): fix NULL ptr dereference ...................................................................... l1sap: l1sap_tch_rts_ind(): fix NULL ptr dereference The 'resp_msg' will be NULL if msgb_dequeue_count() returns NULL, i.e. in the case of Downlink queue underrun. We need to handle this gracefully and check 'resp_msg' before dereferencing it. Change-Id: I4e1ea1d1ded2ffb3a07cc06f8b9b5dd922d32ec6 Fixes: 0a34af153 ("CSD NT modes: transmit properly aligned RLP frames on DL") --- M src/common/l1sap.c 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve falconia: Looks good to me, approved diff --git a/src/common/l1sap.c b/src/common/l1sap.c index dc83e77..18d7d93 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1789,8 +1789,11 @@ tchf96_nt_dl_alignment(lchan, resp_msg, fn); break; case GSM48_CMODE_DATA_14k5: - gsmtap_csd_rlp_dl(lchan, fn, msgb_l2(resp_msg), - msgb_l2len(resp_msg)); + if (resp_msg != NULL) { + gsmtap_csd_rlp_dl(lchan, fn, + msgb_l2(resp_msg), + msgb_l2len(resp_msg)); + } break; default: LOGPLCGT(lchan, &g_time, DL1P, LOGL_ERROR, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38749?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4e1ea1d1ded2ffb3a07cc06f8b9b5dd922d32ec6 Gerrit-Change-Number: 38749 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: csd_v110: use osmo_csd_ra2_* API from libosmotrau

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/38750?usp=email ) Change subject: csd_v110: use osmo_csd_ra2_* API from libosmotrau ...................................................................... csd_v110: use osmo_csd_ra2_* API from libosmotrau Change-Id: I0be44b15a812397377fe7772b988724dd205737c Depends: libosmo-abis.git I7b98b958651b3fc1a814d119d1b8644c91f98676 Related: OS#6167 --- M TODO-RELEASE M src/common/csd_v110.c 2 files changed, 10 insertions(+), 25 deletions(-) Approvals: Jenkins Builder: Verified falconia: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..81aa834 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmotrau >1.6.0 osmo_csd_ra2_{16k,8k}_{pack,unpack}() API diff --git a/src/common/csd_v110.c b/src/common/csd_v110.c index e307a6e..f60624f 100644 --- a/src/common/csd_v110.c +++ b/src/common/csd_v110.c @@ -29,6 +29,7 @@ #include <osmocom/gsm/gsm_utils.h> #include <osmocom/gsm/protocol/gsm_04_08.h> #include <osmocom/isdn/v110.h> +#include <osmocom/trau/csd_ra2.h> #include <osmo-bts/csd_v110.h> #include <osmo-bts/lchan.h> @@ -133,20 +134,10 @@ ra1_ra2: /* RA1/RA2: convert from an intermediate rate to 64 kbit/s */ - if (desc->ra2_ir == 16) { - /* 4 * 80 bits (16 kbit/s) => 2 bits per octet */ - for (unsigned int i = 0, j = 0; i < RFC4040_RTP_PLEN; i++) { - rtp[i] = (0xff >> 2); - rtp[i] |= (ra_bits[j++] << 7); - rtp[i] |= (ra_bits[j++] << 6); - } - } else { - /* 2 * 80 bits (8 kbit/s) => 1 bit per octet */ - for (unsigned int i = 0; i < RFC4040_RTP_PLEN; i++) { - rtp[i] = (0xff >> 1); - rtp[i] |= (ra_bits[i] << 7); - } - } + if (desc->ra2_ir == 16) + osmo_csd_ra2_16k_pack(&rtp[0], &ra_bits[0], RFC4040_RTP_PLEN); + else /* desc->ra2_ir == 8 */ + osmo_csd_ra2_8k_pack(&rtp[0], &ra_bits[0], RFC4040_RTP_PLEN); return RFC4040_RTP_PLEN; } @@ -181,17 +172,10 @@ return -EINVAL; /* RA1/RA2: convert from 64 kbit/s to an intermediate rate */ - if (desc->ra2_ir == 16) { - /* 4 * 80 bits (16 kbit/s) => 2 bits per octet */ - for (unsigned int i = 0, j = 0; i < RFC4040_RTP_PLEN; i++) { - ra_bits[j++] = (rtp[i] >> 7); - ra_bits[j++] = (rtp[i] >> 6) & 0x01; - } - } else { - /* 2 * 80 bits (8 kbit/s) => 1 bit per octet */ - for (unsigned int i = 0; i < RFC4040_RTP_PLEN; i++) - ra_bits[i] = (rtp[i] >> 7); - } + if (desc->ra2_ir == 16) + osmo_csd_ra2_16k_unpack(&ra_bits[0], &rtp[0], RFC4040_RTP_PLEN); + else /* desc->ra2_ir == 8 */ + osmo_csd_ra2_8k_unpack(&ra_bits[0], &rtp[0], RFC4040_RTP_PLEN); /* RA1'/RA1: convert from an intermediate rate to radio rate */ for (unsigned int i = 0; i < desc->num_blocks; i++) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38750?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0be44b15a812397377fe7772b988724dd205737c Gerrit-Change-Number: 38750 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: make it pass 'ruff check' linter

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38778?usp=email ) Change subject: testenv: make it pass 'ruff check' linter ...................................................................... testenv: make it pass 'ruff check' linter I've added 'ruff check' to my pre-commit script. Make it pass initially, so it can detect future bugs. The missing f-string is a bug that may causes ggsn testsuites with a custom kernel path to not work. Change-Id: I3e5cd05ce0aa241509d77391c5ed64e618f385ba --- M _testenv/testenv/podman.py M _testenv/testenv/testsuite.py 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/38778/1 diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py index 16db400..1281b3b 100644 --- a/_testenv/testenv/podman.py +++ b/_testenv/testenv/podman.py @@ -254,7 +254,7 @@ cmd += ["--volume", "/dev/kvm:/dev/kvm"] if os.path.islink(testenv.custom_kernel_path): dest = os.readlink(testenv.custom_kernel_path) - cmd += ["--volume", "{dest}:{dest}:ro"] + cmd += ["--volume", f"{dest}:{dest}:ro"] cmd += [ "--volume", diff --git a/_testenv/testenv/testsuite.py b/_testenv/testenv/testsuite.py index 0fa42ab..9b28668 100644 --- a/_testenv/testenv/testsuite.py +++ b/_testenv/testenv/testsuite.py @@ -225,7 +225,7 @@ try: with open(path, "r") as h: return h.readline().rstrip() - except: + except: # noqa # File may not exist, e.g. if test was stopped return None -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3e5cd05ce0aa241509d77391c5ed64e618f385ba Gerrit-Change-Number: 38778 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024